jasonmolenda wrote:
as cool as this idea is, I do worry that it will make the code less readable,
where instead of saying "BehavesLikeFrameZero / HasAllRegisters", we now need
to ask "can the frame below supply register x", I don't know. it's just
something I have running around my head today
@@ -719,6 +776,10 @@ class ValueObject {
ClearUserVisibleData(eClearUserVisibleDataItemsSummary);
}
+ void SetDerefValobj(ValueObject *deref) { m_deref_valobj = deref; }
cmtice wrote:
I use the synthetic child providers way of getting the deref ValueOb
https://github.com/rafaelauler approved this pull request.
Could you elaborate a bit better on why do we need a deleted block to be
present in the table? My memory fails me, aren't we using the translation table
just to map samples collected on the bolted binary? Where do the deleted blocks
be
royitaqi wrote:
Thanks to @antmox and @labath for fixing this. My apologies for breaking the
build.
https://github.com/llvm/llvm-project/pull/92870
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
royitaqi wrote:
Hi @antmox,
I'm sorry that it broke the lldb-aarch64-windows build. My bad. Your fix makes
sense, though I do have the same comment as @labath had, i.e. to move that
typedef outside platform-specific region. From the latest comments in that PR
it seems it's already got moved.
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 0bc710f7c19910817ccff254c43496602635bbc9
8a6202f8ae92a62ce577271ec580379f1424f9e3 --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
This change is a general improvement of the internal API. My motivation is to
use this in the Swift typesystem plugin.
---
Full diff: https://github.com/llvm/llvm-project/pull/92979.diff
10 Files Aff
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/92979
This change is a general improvement of the internal API. My motivation is to
use this in the Swift typesystem plugin.
>From 8a6202f8ae92a62ce577271ec580379f1424f9e3 Mon Sep 17 00:00:00 2001
From: Adrian P
jasonmolenda wrote:
(with the caveat that a register location of IsSame for a volatile aka
non-callee-spilled register would be treated as "did not have a location")
https://github.com/llvm/llvm-project/pull/92503
___
lldb-commits mailing list
lldb-co
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/92953
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
We are almost done with configuring the buildbot for cross lldb (Windows x86_64
host and Linux Aarch64 target). We are trying to get it green with minimal
local patches.
https://github.com/llvm/llvm-project/pull/90580
___
lldb-commits
jasonmolenda wrote:
We should be able to work correctly with a trap handler that has full eh_frame
without knowing the function name. And we shouldn't treat a sigtramp missing
eh_frame as having all registers.
https://github.com/llvm/llvm-project/pull/92503
___
jasonmolenda wrote:
btw @labath I was thinking about "sigtramp routines" and fault / trap /
interrupt handlers in general, and how lldb has this list of function names
that it treats as fault handlers (`target.trap-handler-names`). And in the
unwinder we have the same idea of "the frame above
https://github.com/aeubanks approved this pull request.
awesome, thanks!
https://github.com/llvm/llvm-project/pull/92953
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/92953
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/92843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/92843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/92843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -362,6 +363,36 @@ llvm::json::Value DebuggerStats::ReportStatistics(
global_stats.try_emplace("modules", std::move(json_modules));
global_stats.try_emplace("memory", std::move(json_memory));
global_stats.try_emplace("commands", std::move(cmd_stats));
+
+// Wh
@@ -0,0 +1,65 @@
+//===-- SBAddressRange.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,91 @@
+//===-- SBAddressRangeList.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/92014
>From bcca8420736283bf564cf86e1442f023ba63b9e9 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 10 May 2024 12:42:03 -0700
Subject: [PATCH] Add AddressRange to SB API
Summary:
This adds new SB API calls and c
https://github.com/MaskRay approved this pull request.
Great 👍
https://github.com/llvm/llvm-project/pull/92953
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Endilll wrote:
Here are CE links with the set of minimum required compilers that should cover
almost all the changes I made:
https://godbolt.org/z/j98xzhrGa
https://godbolt.org/z/errv4WhfP
https://godbolt.org/z/vnoh8YqEP
Windows-targeted flags were tested both on MSVC on CE, and on clang-cl 5.0
@@ -0,0 +1,91 @@
+//===-- SBAddressRangeList.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
Endilll wrote:
On my setup, this patch improves CMake configuration times (from a clean state)
from 51 seconds down to 46 seconds (average of 3 measurements).
My setup: ancient x86 hardware, Debian Sid, nightly Clang, build directory on a
RAM disk. CMake invocation:
`cmake -DLLVM_ENABLE_PROJEC
llvmbot wrote:
@llvm/pr-subscribers-lldb
@llvm/pr-subscribers-clang
Author: Vlad Serebrennikov (Endilll)
Changes
This patch remove 36 checks for compiler flags that are done via invoking the
compiler across LLVM, Clang, and LLDB. It's was made possible by raising the
bar for supported co
@@ -0,0 +1,54 @@
+//===-- SBAddressRangeList.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/92953
This patch remove 36 checks for compiler flags that are done via invoking the
compiler across LLVM, Clang, and LLDB. It's was made possible by raising the
bar for supported compilers that has been happening over
@@ -0,0 +1,28 @@
+%extend lldb::SBAddressRangeList {
+#ifdef SWIGPYTHON
+%pythoncode%{
+def __len__(self):
+ '''Return the number of address ranges in a lldb.SBAddressRangeList
object.'''
+ return self.GetSize()
+
+def __iter__(self):
+ '''Iterate over
@@ -0,0 +1,28 @@
+%extend lldb::SBAddressRangeList {
+#ifdef SWIGPYTHON
+%pythoncode%{
+def __len__(self):
+ '''Return the number of address ranges in a lldb.SBAddressRangeList
object.'''
+ return self.GetSize()
+
+def __iter__(self):
+ '''Iterate over
@@ -0,0 +1,11 @@
+%extend lldb::SBAddressRange {
+#ifdef SWIGPYTHON
+%pythoncode%{
+ def __repr__(self):
+import lldb
mbucko wrote:
it's not, produces the following error:
`NameError: name 'lldb' is not defined`
https://github.com/llvm/llvm-proj
@@ -0,0 +1,91 @@
+//===-- SBAddressRangeList.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,103 @@
+//===-- SBAddressRange.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,91 @@
+//===-- SBAddressRangeList.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,54 @@
+//===-- SBAddressRangeList.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,65 @@
+//===-- SBAddressRange.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,91 @@
+//===-- SBAddressRangeList.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,91 @@
+//===-- SBAddressRangeList.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,11 @@
+%extend lldb::SBAddressRange {
+#ifdef SWIGPYTHON
+%pythoncode%{
+ def __repr__(self):
+import lldb
bulbazord wrote:
Why does this import lldb? Shouldn't it already be imported?
https://github.com/llvm/llvm-project/pull/92014
_
@@ -0,0 +1,28 @@
+%extend lldb::SBAddressRangeList {
+#ifdef SWIGPYTHON
+%pythoncode%{
+def __len__(self):
+ '''Return the number of address ranges in a lldb.SBAddressRangeList
object.'''
+ return self.GetSize()
+
+def __iter__(self):
+ '''Iterate over
@@ -0,0 +1,28 @@
+%extend lldb::SBAddressRangeList {
+#ifdef SWIGPYTHON
+%pythoncode%{
+def __len__(self):
+ '''Return the number of address ranges in a lldb.SBAddressRangeList
object.'''
+ return self.GetSize()
+
+def __iter__(self):
+ '''Iterate over
@@ -2306,6 +2345,11 @@ bool DWARFASTParserClang::CompleteTypeFromDWARF(const
DWARFDIE &die,
if (!die)
return false;
+ ParsedDWARFTypeAttributes attrs(die);
ZequanWu wrote:
> The reason why this crash does not happen when attempting to complete a type
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 3074060d6a1d7d2e74cb767876bd9e5192d12007
29b55fcba7a7f7b7ab0581f7804b9ad70863b0ff --
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
3074060d6a1d7d2e74cb767876bd9e5192d12007...29b55fcba7a7f7b7ab0581f7804b9ad70863b0ff
lldb
https://github.com/augusto2112 approved this pull request.
https://github.com/llvm/llvm-project/pull/92565
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/89110
>From e0316188d22605c670079e37855d3d8b5c944cee Mon Sep 17 00:00:00 2001
From: Jacob John Lalonde
Date: Wed, 10 Apr 2024 14:33:40 -0700
Subject: [PATCH 1/5] Fix bug where an sbvalue containing a std::string create
@@ -2306,6 +2345,11 @@ bool DWARFASTParserClang::CompleteTypeFromDWARF(const
DWARFDIE &die,
if (!die)
return false;
+ ParsedDWARFTypeAttributes attrs(die);
labath wrote:
> > Why don't those cases lead to a crash? For example, what would happen if
> >
JDevlieghere wrote:
No objections in the context of LLDB. We don't use terminfo directly (although
I think editline does, but that isn't affected by this) and if we want the TUI
we depend on curses anyway.
https://github.com/llvm/llvm-project/pull/92865
__
Author: Dave Lee
Date: 2024-05-21T10:16:51-07:00
New Revision: 98f105a1304e8d3fd0a0234d1d488ed513833df8
URL:
https://github.com/llvm/llvm-project/commit/98f105a1304e8d3fd0a0234d1d488ed513833df8
DIFF:
https://github.com/llvm/llvm-project/commit/98f105a1304e8d3fd0a0234d1d488ed513833df8.diff
LOG:
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/92618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
keith wrote:
looks like the .bazelrc still has mentions of this
https://github.com/llvm/llvm-project/pull/92865
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> > I was not able to produce a DW_IDX_parent_entries referring to any kind of
> > class type
>
> When I compile the following with `clang++ test.cpp -c -gdwarf-5 -O0 -o - |
> dwarfdump --debug-names -`, I get the right parent chain. Is this not true
> when you try it?
I do get
felipepiovezan wrote:
> I think #77696 is justification enough to add this check, but I don't think
> we should be implicating DW_IDX_parent_entries until we know how those came
> about.
This is pretty much my point, the workaround is fine, but I don't think the
source-code comment in this P
@@ -2306,6 +2345,11 @@ bool DWARFASTParserClang::CompleteTypeFromDWARF(const
DWARFDIE &die,
if (!die)
return false;
+ ParsedDWARFTypeAttributes attrs(die);
ZequanWu wrote:
> Why don't those cases lead to a crash? For example, what would happen if the
royitaqi wrote:
cc @clayborg and @jeffreytan81
https://github.com/llvm/llvm-project/pull/92843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jeffreytan81 wrote:
@jimingham, I have revised the PR, let me know when you can review again.
Thanks.
https://github.com/llvm/llvm-project/pull/90930
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
DWARFDebugInfo doesn't know how to resolve the "file_index" component of a
DIERef. This patch removes GetUnit (in favor of existing
GetUnitContainingDIEOffset) and changes GetDIE to take only the components it
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/92894
DWARFDebugInfo doesn't know how to resolve the "file_index" component of a
DIERef. This patch removes GetUnit (in favor of existing
GetUnitContainingDIEOffset) and changes GetDIE to take only the components it
a
Author: Pavel Labath
Date: 2024-05-21T10:48:39Z
New Revision: 45a5d8d6dba6156c24825b3a04378e999f8af82d
URL:
https://github.com/llvm/llvm-project/commit/45a5d8d6dba6156c24825b3a04378e999f8af82d
DIFF:
https://github.com/llvm/llvm-project/commit/45a5d8d6dba6156c24825b3a04378e999f8af82d.diff
LOG:
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/92745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-05-21T12:45:59+02:00
New Revision: 9677e8171c19f1a15c0234724f083bc9473c545a
URL:
https://github.com/llvm/llvm-project/commit/9677e8171c19f1a15c0234724f083bc9473c545a
DIFF:
https://github.com/llvm/llvm-project/commit/9677e8171c19f1a15c0234724f083bc9473c545a.diff
@@ -9,7 +9,7 @@
#include "Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.h"
#include "Plugins/SymbolFile/DWARF/DWARFDebugInfo.h"
#include "Plugins/SymbolFile/DWARF/DWARFDeclContext.h"
-#include "Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.h"
+#include "Plugins/SymbolFile/DWARF/L
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/92745
>From ae72d530c723a8d0fb2eac38224e8cf74cc43e70 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 20 May 2024 12:30:46 +
Subject: [PATCH 1/2] [lldb/dwarf] Fix DW_IDX_parent processing for split dwarf
DWAR
labath wrote:
> What is "nameless index entry"? I don't quite understand from the spec.
```
It is possible that an indexed debugging information entry has a parent that is
not indexed (for example, if its parent does not have a name attribute). In
such a
case, a parent attribute may point to a
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/91808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
I think #77696 is justification enough to add this check, but I don't think we
should be implicating DW_IDX_parent_entries until we know how those came about.
Both me and David have tried to produce entries like you describe and failed
(in fact I was not ab
@@ -83,6 +83,10 @@ bool DebugNamesDWARFIndex::ProcessEntry(
DWARFDIE die = dwarf.GetDIE(*ref);
if (!die)
return true;
+ // Watch out for forward declarations that appear in the .debug_names tables
+ // only due to being there for a DW_IDX_parent.
laba
antmox wrote:
fixed elsewhere
https://github.com/llvm/llvm-project/pull/92870
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/antmox closed https://github.com/llvm/llvm-project/pull/92870
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
Moving the typedef out of platform-specific code would be a better, as this is
not in any way platform-specific. I just pushed something along those lines.
https://github.com/llvm/llvm-project/pull/92870
___
lldb-commits mailing list
lld
Author: Pavel Labath
Date: 2024-05-21T09:37:38Z
New Revision: a098beaff7670e5986b790b6ba93999fa21c6b48
URL:
https://github.com/llvm/llvm-project/commit/a098beaff7670e5986b790b6ba93999fa21c6b48
DIFF:
https://github.com/llvm/llvm-project/commit/a098beaff7670e5986b790b6ba93999fa21c6b48.diff
LOG:
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/92503
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-05-21T10:56:26+02:00
New Revision: bbd54e08b08f5ccd38c4665178e65c58f7b14459
URL:
https://github.com/llvm/llvm-project/commit/bbd54e08b08f5ccd38c4665178e65c58f7b14459
DIFF:
https://github.com/llvm/llvm-project/commit/bbd54e08b08f5ccd38c4665178e65c58f7b14459.diff
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/92503
>From 47858edddfbccf989213d61f3761fcdb04814839 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Fri, 17 May 2024 06:34:08 +
Subject: [PATCH 1/2] Reapply "[lldb/aarch64] Fix unwinding when signal
interrupts a
labath wrote:
> Yes, originally lldb's unwinder was recursive for any register propagation
> and it was easy to hit the problem of lldb blowing out its own stack on a
> recursive inferior that had crashed. I changed most of the propagation to a
> loop to solve this (years and years ago) but it
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/92726
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-05-21T10:37:41+02:00
New Revision: af8f1554b8e7844304ce61b49b06e5b7946e9c47
URL:
https://github.com/llvm/llvm-project/commit/af8f1554b8e7844304ce61b49b06e5b7946e9c47
DIFF:
https://github.com/llvm/llvm-project/commit/af8f1554b8e7844304ce61b49b06e5b7946e9c47.diff
mstorsjo wrote:
+1, this fixes my build errors for Windows targets as well:
https://github.com/mstorsjo/llvm-mingw/actions/runs/9167001362/job/25206642195
https://github.com/llvm/llvm-project/pull/92870
___
lldb-commits mailing list
lldb-commits@lists
antmox wrote:
@royitaqi @clayborg I proposed a fix here :
https://github.com/llvm/llvm-project/pull/92870
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: antoine moynault (antmox)
Changes
fix lldb-aarch64-windows bot failure introduced by #89868
https://lab.llvm.org/buildbot/#/builders/219/builds/11583
---
Full diff: https://github.com/llvm/llvm-project/pull/92870.diff
1 Files Affected:
https://github.com/antmox created
https://github.com/llvm/llvm-project/pull/92870
fix lldb-aarch64-windows bot failure introduced by #89868
https://lab.llvm.org/buildbot/#/builders/219/builds/11583
>From 83ac7ff11a694795dccf3fa09c82ddab5d0096f3 Mon Sep 17 00:00:00 2001
From: Antoine Moynault
82 matches
Mail list logo
