https://github.com/Michael137 approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/90657
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg requested changes to this pull request.
You will need to hook this up so it actually works, and then add a test case to
verify this works as expected.
https://github.com/llvm/llvm-project/pull/90703
___
lldb-commits mailing
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/90703
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/90703
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/90703
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (royitaqi)
Changes
# Motivation
Currently, the user can already get the "transcript" (for "what is the
transcript", see `CommandInterpreter::SaveTranscript()`). However, the only way
to obtain the transcript data as a user is to firs
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/royitaqi created
https://github.com/llvm/llvm-project/pull/90703
# Motivation
Currently, the user can already get the "transcript" (for "what is the
transcript", see `CommandInterpreter::SaveTranscript()`). However, the only way
to obtain the transcript data as a user is to
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 4cd11c986f78e19f53b3f3c92143b7b7c1ce54b1
9510a08995da26d0c3c1ea8d13f6c3f8fab772c2 --
adrian-prantl wrote:
I had to replace the GLOB with a hardcoded file name because the GLOB gets
evaluated at CMake configure time, when the file doesn't exist yet.
https://github.com/llvm/llvm-project/pull/90666
___
lldb-commits mailing list
lldb-comm
@@ -8,6 +8,12 @@ set(LLDB_INCLUDE_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/include")
set(LLDB_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
set(LLDB_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})
+if (LLDB_BUILT_STANDALONE)
+ set(LLDB_OBJ_DIR ${CMAKE_CURRENT_BINARY_DIR})
+else()
+ set(LLDB_OBJ_
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/90666
>From 9510a08995da26d0c3c1ea8d13f6c3f8fab772c2 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 30 Apr 2024 13:59:39 -0700
Subject: [PATCH] Install generated API headers into LLDB.framework
---
lld
@@ -287,8 +292,49 @@ bool
lldb_private::formatters::LibStdcppStringSummaryProvider(
} else
return true;
} break;
-case eAddressTypeHost:
- break;
+case eAddressTypeHost: {
+
+ DataExtractor data;
+ Status error;
+ valobj.GetData(da
@@ -287,8 +292,49 @@ bool
lldb_private::formatters::LibStdcppStringSummaryProvider(
} else
return true;
} break;
-case eAddressTypeHost:
- break;
+case eAddressTypeHost: {
+
+ DataExtractor data;
+ Status error;
+ valobj.GetData(da
@@ -8,6 +8,12 @@ set(LLDB_INCLUDE_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/include")
set(LLDB_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
set(LLDB_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})
+if (LLDB_BUILT_STANDALONE)
+ set(LLDB_OBJ_DIR ${CMAKE_CURRENT_BINARY_DIR})
+else()
+ set(LLDB_OBJ_
@@ -8,6 +8,12 @@ set(LLDB_INCLUDE_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/include")
set(LLDB_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
set(LLDB_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})
+if (LLDB_BUILT_STANDALONE)
+ set(LLDB_OBJ_DIR ${CMAKE_CURRENT_BINARY_DIR})
+else()
+ set(LLDB_OBJ_
https://github.com/JDevlieghere requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/90666
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/90666
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
Looks fine to me. Thanks for fixing this!
https://github.com/llvm/llvm-project/pull/90666
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
bulbazord wrote:
I think you've laid out the events that happen nicely but I came to the
opposite conclusion. I still don't think this is the right fix. We have
buildbots running on x86_64 and it works there too. I don't think this test
working on AArch64 machines is related. The platform arch
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/90666
>From 6950a36e2619f032f2dd41f258f171b876274bd5 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 30 Apr 2024 13:59:39 -0700
Subject: [PATCH] Install generated API headers into LLDB.framework
---
lld
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/90580
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kastiglione wrote:
revert: 0f628fdb1aa8be97a5d86c3259b8caaa997790ec
apologies, thanks for reporting @aaupov.
https://github.com/llvm/llvm-project/pull/81196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
Author: Dave Lee
Date: 2024-04-30T16:15:19-07:00
New Revision: 0f628fdb1aa8be97a5d86c3259b8caaa997790ec
URL:
https://github.com/llvm/llvm-project/commit/0f628fdb1aa8be97a5d86c3259b8caaa997790ec
DIFF:
https://github.com/llvm/llvm-project/commit/0f628fdb1aa8be97a5d86c3259b8caaa997790ec.diff
LOG:
slydiman wrote:
> `SBDebugger::CreateTarget` takes a `platform_name` argument which we're
> already setting to "remote-linux".
Probably it works on buildbots because the host architecture is `Aarch64`. I'm
trying to get it working on Windows `x86_64`.
`target1 = self.dbg.CreateTarget(exe, Non
@@ -71,6 +71,7 @@ endif()
# At configuration time, collect headers for the framework bundle and copy them
# into a staging directory. Later we can copy over the entire folder.
file(GLOB public_headers ${LLDB_SOURCE_DIR}/include/lldb/API/*.h)
+file(GLOB built_public_headers
${L
aaupov wrote:
This diff broke buildbot:
https://lab.llvm.org/buildbot/#/builders/68/builds/73367
https://github.com/llvm/llvm-project/pull/81196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
@@ -71,6 +71,7 @@ endif()
# At configuration time, collect headers for the framework bundle and copy them
# into a staging directory. Later we can copy over the entire folder.
file(GLOB public_headers ${LLDB_SOURCE_DIR}/include/lldb/API/*.h)
+file(GLOB built_public_headers
${L
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/90666.diff
1 Files Affected:
- (modified) lldb/cmake/modules/LLDBFramework.cmake (+2)
``diff
diff --git a/lldb/cmake/modules/LLDBF
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/90666
None
>From 628576baf4dbf11efa56a079dde9759ccc7e988d Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 30 Apr 2024 13:59:39 -0700
Subject: [PATCH] Install generated API headers into LLDB.framework
--
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff cf49d077fd75278abc405c8c125f40a975c830b4
4e83099b593e66f12dc21be5fbac5279e03e --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Zequan Wu (ZequanWu)
Changes
This is the implementation for
https://discourse.llvm.org/t/rfc-delay-definition-die-searching-when-parse-a-declaration-die-for-record-type/78526.
Motivation
Currently, lldb eagerly searches for definition
https://github.com/ZequanWu ready_for_review
https://github.com/llvm/llvm-project/pull/90663
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/90663
This is the implementation for
https://discourse.llvm.org/t/rfc-delay-definition-die-searching-when-parse-a-declaration-die-for-record-type/78526.
Motivation
Currently, lldb eagerly searches for definition
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
The high level goal is to have 1 way of converting a DW_TAG value into a
human-readable string.
There are 3 ways this change accomplishes that:
1.) Changing DW_TAG_value_to_name to not create custom error
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/90657
The high level goal is to have 1 way of converting a DW_TAG value into a
human-readable string.
There are 3 ways this change accomplishes that:
1.) Changing DW_TAG_value_to_name to not create custom error stri
Author: Kazu Hirata
Date: 2024-04-30T12:10:54-07:00
New Revision: 5f88f0c63fa75169665732a3377f5bb3fef6256d
URL:
https://github.com/llvm/llvm-project/commit/5f88f0c63fa75169665732a3377f5bb3fef6256d
DIFF:
https://github.com/llvm/llvm-project/commit/5f88f0c63fa75169665732a3377f5bb3fef6256d.diff
L
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/90223
>From bb166a95bafc74860d78da0dedb5760c579cae48 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 26 Apr 2024 08:17:26 -0700
Subject: [PATCH] [lldb-dap] Fix test_exit_status_message_sigterm test.
Summary:
'test
https://github.com/jeffreytan81 approved this pull request.
Quick accept to unblock the build break. Feel free to follow-up in future
patches for better solution.
https://github.com/llvm/llvm-project/pull/90223
___
lldb-commits mailing list
lldb-commi
JDevlieghere wrote:
> Thanks for the explanation! What kind of tool reads this file?
One such tool is SWIG, which happens to support macro expansion, but we have
other tools downstream that don't.
> It's still weird to use tblgen to process non-td files imho. We have a bunch
> of places that
bulbazord wrote:
This doesn't actually copy `SBLanguages.h` into the framework, so this breaks
the framework.
These tests now fail:
```
Unresolved Tests (5):
lldb-api :: api/check_public_api_headers/TestPublicAPIHeaders.py
lldb-api :: api/multiple-de
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/81196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dave Lee
Date: 2024-04-30T10:45:10-07:00
New Revision: 7a8d15e919dde70118dbfa34e927be1705ded67d
URL:
https://github.com/llvm/llvm-project/commit/7a8d15e919dde70118dbfa34e927be1705ded67d
DIFF:
https://github.com/llvm/llvm-project/commit/7a8d15e919dde70118dbfa34e927be1705ded67d.diff
LOG:
https://github.com/JDevlieghere approved this pull request.
Looks good to me as well.
https://github.com/llvm/llvm-project/pull/90099
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
JDevlieghere wrote:
> > Always refer to lldb as lldb not LLDB, to match what the user sees on the
> > command line.
>
> If this were any other doc I'd say it should always be LLDB and GDB as that's
> the projects' branding. In this doc I think it's better to imagine the user
> is looking at s
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/81196
>From 81a2034ff2b41e30a1f5b82c86b4d5d4c429ed52 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Thu, 8 Feb 2024 13:59:12 -0800
Subject: [PATCH 1/9] [lldb] Support custom printf formatting for variables
---
lld
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/81196
>From 81a2034ff2b41e30a1f5b82c86b4d5d4c429ed52 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Thu, 8 Feb 2024 13:59:12 -0800
Subject: [PATCH 1/8] [lldb] Support custom printf formatting for variables
---
lld
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/90099
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
LLDB changes look fine.
https://github.com/llvm/llvm-project/pull/90391
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/81196
>From 81a2034ff2b41e30a1f5b82c86b4d5d4c429ed52 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Thu, 8 Feb 2024 13:59:12 -0800
Subject: [PATCH 1/7] [lldb] Support custom printf formatting for variables
---
lld
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/90584
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord requested changes to this pull request.
I don't think this is the right thing to do. `SBDebugger::CreateTarget` takes a
`platform_name` argument which we're already setting to "remote-linux". If
`target1.GetPlatform()` doesn't return the SBPlatform for `remote-linux
https://github.com/bulbazord commented:
lgtm
https://github.com/llvm/llvm-project/pull/90572
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-04-30T09:53:13-07:00
New Revision: 4cd11c986f78e19f53b3f3c92143b7b7c1ce54b1
URL:
https://github.com/llvm/llvm-project/commit/4cd11c986f78e19f53b3f3c92143b7b7c1ce54b1
DIFF:
https://github.com/llvm/llvm-project/commit/4cd11c986f78e19f53b3f3c92143b7b7c1ce54b1.diff
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kevin Frei (kevinfrei)
Changes
I'm taking yet another swing at getting these tests going, on the hypothesis
that the problems with buildbots & whatnot are because they're not
configured with CURL support, which I've confirmed would cause t
https://github.com/kevinfrei ready_for_review
https://github.com/llvm/llvm-project/pull/90622
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/90594
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
LGTM!
https://github.com/llvm/llvm-project/pull/90594
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jayfoad wrote:
AMDGPU changes are fine.
https://github.com/llvm/llvm-project/pull/90391
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/89110
>From e0316188d22605c670079e37855d3d8b5c944cee Mon Sep 17 00:00:00 2001
From: Jacob John Lalonde
Date: Wed, 10 Apr 2024 14:33:40 -0700
Subject: [PATCH 1/4] Fix bug where an sbvalue containing a std::string create
nico wrote:
Thanks for the explanation! What kind of tool reads this file?
It's still weird to use tblgen to process non-td files imho. We have a bunch of
places that run python scripts as part of the build
(clang/utils/bundle_resources.py,
clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py,
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/90622
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/90622
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/90622
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/90622
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/90622
>From dfa1acd8e51b04b4a37cde4fc064ab294ed7a02e Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Mon, 25 Mar 2024 08:23:47 -0700
Subject: [PATCH 1/8] Trying to deal with Linux AArch64 test failures :/
---
.../S
luolent wrote:
Hi @bulbazord , @lntue ,
thanks for your helpful comments, first time contributing here :)
I have updated the PR.
https://github.com/llvm/llvm-project/pull/90391
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
https://github.com/luolent edited
https://github.com/llvm/llvm-project/pull/90391
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/luolent edited
https://github.com/llvm/llvm-project/pull/90391
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
8d28e5861f8b117a547850ffbb9a332aa6e91459...735822efd188c677337f84e472cf7be6edb42feb
lldb/
https://github.com/kevinfrei created
https://github.com/llvm/llvm-project/pull/90622
I'm taking another swing at getting these tests going, on the hypothesis that
the problems with buildbots & whatnot are because they're not configured with
CURL support, which I've confirmed would cause the pr
adrian-prantl wrote:
Btw. github doesn't let you see older revisions, but the code snippet you
posted that includes a .def file was exactly my first version of this patch.
You can still find @JDevlieghere's comment asking me to change it though :-)
Another thing worth noting is that the public
adrian-prantl wrote:
That's also why it's a `.h` file and not a `.inc`.
https://github.com/llvm/llvm-project/pull/89981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
> Why does this use tablegen to parse a .def file?
>
> Can't you get the same behavior without tablegen, using normal xmacro
> techniques, something like
>
> ```c++
> enum SBSourceLanguageName : uint16_t {
>
> #define HANDLE_DW_LNAME(ID, NAME, DESC, LOWER_BOUND) \
> eLa
https://github.com/al45tair updated
https://github.com/llvm/llvm-project/pull/90099
>From ce54a7fb339a00029da266c9f518e344aac5d19e Mon Sep 17 00:00:00 2001
From: Alastair Houghton
Date: Thu, 25 Apr 2024 11:35:55 +0100
Subject: [PATCH 1/5] [LLDB][ELF] Fix section unification to not just use
nam
al45tair wrote:
@labath @JDevlieghere Are we happy with this PR now? If so, I'll cherry pick it
to the various Apple forks; I need it in order to merge
https://github.com/apple/swift/pull/72061, which we need for both my fully
statically linked Swift SDK work and for Amazon Linux 2023 support
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/90609
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-04-30T15:15:14+01:00
New Revision: c106abfe9f3d3ed78a946009f7625088f28e9065
URL:
https://github.com/llvm/llvm-project/commit/c106abfe9f3d3ed78a946009f7625088f28e9065
DIFF:
https://github.com/llvm/llvm-project/commit/c106abfe9f3d3ed78a946009f7625088f28e9065.dif
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/90609
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
nico wrote:
I left another comment on the commit that doesn't show up here
(https://github.com/llvm/llvm-project/commit/975eca0e6a3459e59e96b0df33ea0cfbd157c597).
If you do want to keep the generated file: All other tablegen invocations use
".inc" for tablegen output. Maybe this could match th
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/90607
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-04-30T14:38:46+01:00
New Revision: 7ae32bf7581e03d92c78346a72ea20798520b978
URL:
https://github.com/llvm/llvm-project/commit/7ae32bf7581e03d92c78346a72ea20798520b978
DIFF:
https://github.com/llvm/llvm-project/commit/7ae32bf7581e03d92c78346a72ea20798520b978.dif
https://github.com/DavidSpickett approved this pull request.
Thanks for the fix!
https://github.com/llvm/llvm-project/pull/90607
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/90609.diff
1 Files Affected:
- (modified) lldb/packages/Python/lldbsuite/test/lldbtest.py (+1-1)
``diff
diff --git a/lldb/packages/Py
nico wrote:
Why does this use tablegen to parse a .def file?
Can't you get the same behavior without tablegen, using normal xmacro
techniques, something like
```c++
enum SBSourceLanguageName : uint16_t {
#define HANDLE_DW_LNAME(ID, NAME, DESC, LOWER_BOUND) \
eLanguageName ## NAME = ID,
#i
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/90609
None
>From 697ee70d089642107514329c4611b766372c9bad Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Tue, 30 Apr 2024 17:36:24 +0400
Subject: [PATCH] [lldb] Fixed SyntaxWarning invalid escape sequence '\l'
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/90607.diff
1 Files Affected:
- (modified) lldb/packages/Python/lldbsuite/test/decorators.py (+1-1)
``diff
diff --git a/lldb/packages/
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/90607
None
>From f64ab848420b18dbf7d7d6f2fb269ebab6075bec Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Tue, 30 Apr 2024 17:30:38 +0400
Subject: [PATCH] [lldb] Fixed SyntaxWarning invalid escape sequence '\s'
sdkrystian wrote:
@tmatheson-arm This breaks builds without the `AArch64` target enabled (e.g.
`LLVM_TARGETS_TO_BUILD=X86` )
https://github.com/llvm/llvm-project/pull/90320
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
DavidSpickett wrote:
On the face of it
> When we have an unset high memory address mask, and we are told to set low-
> and high-memory to the same new address mask, maintain the high memory mask
> as unset in Process. The same thing is done with the
> SBProcess::SetAddressMask API when the us
@@ -1465,6 +1465,20 @@ class Process : public
std::enable_shared_from_this,
/// platforms where there is a difference (only Arm Thumb at this time).
lldb::addr_t FixAnyAddress(lldb::addr_t pc);
+ /// Retrieve the actual address masks for high memory code/data,
+ /// wit
DavidSpickett wrote:
> Always refer to lldb as lldb not LLDB, to match what the user sees on the
> command line.
If this were any other doc I'd say it should always be LLDB and GDB as that's
the projects' branding. In this doc I think it's better to imagine the user is
looking at side by side
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
* Replace "we" with either "you" (when talking to the reader) or "lldb" (when
talking about the project).
* Always refer to lldb as lldb not LLDB, to match what the user sees on the
command line.
* Re
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/90594
* Replace "we" with either "you" (when talking to the reader) or "lldb" (when
talking about the project).
* Always refer to lldb as lldb not LLDB, to match what the user sees on the
command line.
* Remove
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
This was last modified in 4fd3347d6e4b0c873c789528e1c9a1b55990d1b6 in 2021 and
was made obsolete by the RST version that
edb874b2310dc6eeaa27330ca1b1c013da7bdd65 added in 2019.
There are some differe
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/90585
This was last modified in 4fd3347d6e4b0c873c789528e1c9a1b55990d1b6 in 2021 and
was made obsolete by the RST version that
edb874b2310dc6eeaa27330ca1b1c013da7bdd65 added in 2019.
There are some differences
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
For the platform and extension doc.
Also add links in the extension doc to the GDB specs we're extending.
---
Patch is 170.36 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
It is necessary to select the expected platform at the beginning. In case of
`Windows` host platform1.GetName() returned `host`. platform2.GetName()
returned `remote-linux`, but platform2.GetWorkingDirect
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/90580
It is necessary to select the expected platform at the beginning. In case of
`Windows` host platform1.GetName() returned `host`. platform2.GetName()
returned `remote-linux`, but platform2.GetWorkingDirectory()
1 - 100 of 110 matches
Mail list logo
