https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/85892
Same change as #85468 but broken down into two commits as discussed in the
original PR.
>From 0914ecdf582831ec4da776e26ae5ebd2cf9f984f Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 19 Mar 20
Author: Jonas Devlieghere
Date: 2024-03-19T20:49:56-07:00
New Revision: 92b2b49994eb804253db1deeb7e9f63904cd96d1
URL:
https://github.com/llvm/llvm-project/commit/92b2b49994eb804253db1deeb7e9f63904cd96d1
DIFF:
https://github.com/llvm/llvm-project/commit/92b2b49994eb804253db1deeb7e9f63904cd96d1.d
JDevlieghere wrote:
@slackito @dwblaikie I'm really puzzled, I've audited every change in this
patch and I can't figure out where things could be going wrong.
My first guess was that we're not updating the FileSpec. There's only 3 places
that explicitly modify the file in the line entry: 2 in
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e2fa90fa0a4b7950dd0d7fae6933e89c075d0af0
719069e6b7e191e338bbb17e9e18b7974b5acef0 --
JDevlieghere wrote:
I reverted the change as this was meant to be RFC and ostensibly it's not. I'll
read through this to see if I can spot where this might behave differently.
https://github.com/llvm/llvm-project/pull/85468
___
lldb-commits mailing l
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Reverts llvm/llvm-project#85468 because @slackito reports this
broke stepping in one of their tests [1] and this patch was meant to be NFC.
[1]
https://github.com/llvm/llvm-project/commit/d5a277d3
Author: Jonas Devlieghere
Date: 2024-03-19T17:48:46-07:00
New Revision: a289f66efd638c2af14cdb88968e4eaeea0c0605
URL:
https://github.com/llvm/llvm-project/commit/a289f66efd638c2af14cdb88968e4eaeea0c0605
DIFF:
https://github.com/llvm/llvm-project/commit/a289f66efd638c2af14cdb88968e4eaeea0c0605.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/85885
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/85885
Reverts llvm/llvm-project#85468 because @slackito reports this broke stepping
in one of their tests [1] and this patch was meant to be NFC.
[1]
https://github.com/llvm/llvm-project/commit/d5a277d309e92b1d
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/85883
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Med Ismail Bennani
Date: 2024-03-20T00:42:59Z
New Revision: e2fa90fa0a4b7950dd0d7fae6933e89c075d0af0
URL:
https://github.com/llvm/llvm-project/commit/e2fa90fa0a4b7950dd0d7fae6933e89c075d0af0
DIFF:
https://github.com/llvm/llvm-project/commit/e2fa90fa0a4b7950dd0d7fae6933e89c075d0af0.diff
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/85883
>From 2d6450747584c99a0b40706e04cb7feee9297ad0 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 20 Mar 2024 00:39:47 +
Subject: [PATCH] [lldb/API] Add missing `eBroadcastBitSymbolsChanged` to
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 22ac5f743811ae1e5004fdd43be556ebbd0496d1
f3c88d52cb72082d070a68822f0d1aad94ce306a --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This patch exposes the missing `eBroadcastBitSymbolsChanged` event bit in
`SBTarget`.
---
Full diff: https://github.com/llvm/llvm-project/pull/85883.diff
1 Files Affected:
- (modified) lldb/incl
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/85883
This patch exposes the missing `eBroadcastBitSymbolsChanged` event bit in
`SBTarget`.
>From f3c88d52cb72082d070a68822f0d1aad94ce306a Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 20 Mar 2024
dwblaikie wrote:
(because we don't have a good sense of where feedback should be provided...
crosslinking here from some feedback on the commit:
https://github.com/llvm/llvm-project/commit/d5a277d309e92b1d3e493da6036cffdf815105b1#commitcomment-139991120
)
https://github.com/llvm/llvm-project/
kastiglione wrote:
@jimingham now that I've switched to llvm format, I'll loop back and follow up
on your comments.
https://github.com/llvm/llvm-project/pull/81196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
kastiglione wrote:
I've updated this PR to use llvm formatting instead of printf. For the
following reasons:
1. For printf, users would have to know the system's size of the value, eg `%d`
vs `%ld` etc
2. Users would have to provide different values for different systems, which
limits the use
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/85861
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/81196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/85861
>From c24630bbccd3d53079314f7dc6393ffa27ea192f Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Tue, 19 Mar 2024 13:18:23 -0700
Subject: [PATCH 1/2] [lldb] Remove process restart prompt from
TestSourceManage
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/81196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/81196
>From 81a2034ff2b41e30a1f5b82c86b4d5d4c429ed52 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Thu, 8 Feb 2024 13:59:12 -0800
Subject: [PATCH 1/5] [lldb] Support custom printf formatting for variables
---
lld
@@ -323,13 +323,13 @@ def test_artificial_source_location(self):
)
self.expect(
-"run",
-RUN_SUCCEEDED,
+"thread info", substrs=[f"{src_file}:0", "stop reason =
breakpoint"]
+)
+self.expect(
+"fra
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/85861
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
In TestSourceManager, test_artificial_source_location will give the process
restart prompt if you run the test individually. The reason is that we run the
process twice: first using a convenience function
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/85861
In TestSourceManager, test_artificial_source_location will give the process
restart prompt if you run the test individually. The reason is that we run the
process twice: first using a convenience function to r
https://github.com/jasonmolenda approved this pull request.
Thanks for fixing this, I hadn't been paying attention to the separation when I
added this method.
https://github.com/llvm/llvm-project/pull/85858
___
lldb-commits mailing list
lldb-commits@l
@@ -50,6 +50,11 @@ static constexpr OptionDefinition g_variable_options[] = {
"Specify a summary string to use to format the variable output."},
};
+static constexpr auto g_num_frame_options = 4;
felipepiovezan wrote:
Sadly it seems we need to hand-maint
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
AddressableBits is in the Utility module of LLDB. It currently directly refers
to Process, which is from the Target LLDB module. This is a layering violation
which concretely means that it is impossible to
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/85858
AddressableBits is in the Utility module of LLDB. It currently directly refers
to Process, which is from the Target LLDB module. This is a layering violation
which concretely means that it is impossible to lin
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/85855
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/85855
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -50,6 +50,11 @@ static constexpr OptionDefinition g_variable_options[] = {
"Specify a summary string to use to format the variable output."},
};
+static constexpr auto g_num_frame_options = 4;
bulbazord wrote:
Is this number computable? Or does it nee
https://github.com/bulbazord commented:
Big fan of centralizing the options here. I had one question about automating
another portion of this, but otherwise LGTM.
https://github.com/llvm/llvm-project/pull/85855
___
lldb-commits mailing list
lldb-commi
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
This option doesn't exist. It is currently displayed by `help target var` due
to a bug introduced by 41ae8e7445 in 2018.
Some code for `target var` and `frame var` is shared, and some har
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/85855
This option doesn't exist. It is currently displayed by `help target var` due
to a bug introduced by 41ae8e7445 in 2018.
Some code for `target var` and `frame var` is shared, and some hard-code
constants
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/85492
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/85693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/85693
>From 9713607cd4839ad355c7fd2e786ae7eb5a96f637 Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Fri, 15 Mar 2024 08:54:04 -0700
Subject: [PATCH 1/5] Tests (w/fixes) for initial DebugInfoD LLDB integration
Summa
@@ -4377,26 +4377,40 @@ const std::shared_ptr
&SymbolFileDWARF::GetDwpSymbolFile() {
FileSpecList search_paths = Target::GetDefaultDebugFileSearchPaths();
ModuleSpec module_spec;
module_spec.GetFileSpec() = m_objfile_sp->GetFileSpec();
+FileSpec dwp_filespec;
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/85763
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2024-03-19T11:26:43Z
New Revision: 7edfbf2af2253297f48ff8adaba99373f67e8dca
URL:
https://github.com/llvm/llvm-project/commit/7edfbf2af2253297f48ff8adaba99373f67e8dca
DIFF:
https://github.com/llvm/llvm-project/commit/7edfbf2af2253297f48ff8adaba99373f67e8dca.diff
LOG:
https://github.com/mordante approved this pull request.
I wasn't aware LLDB's print accepts `%zu`, thanks for the fix!
https://github.com/llvm/llvm-project/pull/85763
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This caused following warnings in an LLDB build:
```
[237/1072] Building CXX object tools/l...lusLanguage.dir/LibCxxSliceArray.cpp.o
/Volumes/Data/llvm-project/lldb/source/Plugins/Language/CPlusPlus/LibCxxSl
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/85763
This caused following warnings in an LLDB build:
```
[237/1072] Building CXX object tools/l...lusLanguage.dir/LibCxxSliceArray.cpp.o
/Volumes/Data/llvm-project/lldb/source/Plugins/Language/CPlusPlus/LibCxxSlice
46 matches
Mail list logo
