llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
Walter Erquinigo added optional instruction annotations for x86 instructions in
2022 for the `thread trace dump instruction` command, and code to
DisassemblerLLVMC to add annotations for instructions th
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/84607
Walter Erquinigo added optional instruction annotations for x86 instructions in
2022 for the `thread trace dump instruction` command, and code to
DisassemblerLLVMC to add annotations for instructions that c
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/84583
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
> @jimingham, thanks for the review and feedback on how to improve the code.
> Are you okay with us addressing this in a follow-up?
>
> > do you know why it was done this way?
>
> I don't think we do. I think we just copied what was done in the old ASan
> plugin. My guess for
jimingham wrote:
I have no problem with doing this in stages, what needs doing right now and
cleanups to follow.
https://github.com/llvm/llvm-project/pull/84583
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
adrian-prantl wrote:
Found two more tests that were (positively) affected by this change!
https://github.com/llvm/llvm-project/pull/84265
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/84265
>From 78866b8977b655109d85bd1c231b1659c5c90c8a Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Fri, 8 Mar 2024 14:46:13 -0800
Subject: [PATCH] Report back errors in GetNumChildren()
This is a proof-of-c
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 9405d5af65853ac548cce2656497195010db1d86
e85c0108f3508537b4d2d9fe9120dd07ebd00361 --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
The ValueObjectConstResult classes that back expression result variables play a
complicated game with where the data for their values is stored. They try to
make it appear as though they are still tied to the memo
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/84588
The ValueObjectConstResult classes that back expression result variables play a
complicated game with where the data for their values is stored. They try to
make it appear as though they are still tied to the
yln wrote:
@jimingham, thanks for the review and feedback on how to improve the code. Are
you okay with us addressing this in a follow-up?
> do you know why it was done this way?
I don't think we do. I think we just copied what was done in the old ASan
plugin.
> survives rebuilds
I think
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/84265
>From 9b02d004a3aec681047d47cb481a269637bdd9fc Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Fri, 8 Mar 2024 14:46:13 -0800
Subject: [PATCH] Report back errors in GetNumChildren()
This is a proof-of-c
jimingham wrote:
ReportRetriever::SetupBreakpoint is a weird way to set a breakpoint. This is
somewhat off topic, but do you know why it was done this way? You could set it
by symbol & module and then you'd have something that survives rebuilds of the
module, or you could set it by Address,
https://github.com/yln approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/84583
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-03-08T16:03:04-08:00
New Revision: 624ea68cbc3ce422b3ee110c0c0af839eec2e278
URL:
https://github.com/llvm/llvm-project/commit/624ea68cbc3ce422b3ee110c0c0af839eec2e278
DIFF:
https://github.com/llvm/llvm-project/commit/624ea68cbc3ce422b3ee110c0c0af839eec2e278.diff
https://github.com/usama54321 updated
https://github.com/llvm/llvm-project/pull/84583
>From fbe08446991972f1fde90206d0281c506d668d6b Mon Sep 17 00:00:00 2001
From: usama
Date: Fri, 8 Mar 2024 15:55:25 -0800
Subject: [PATCH] [LLDB] ASanLibsanitizers Use `sanitizers_address_on_report`
breakpoint
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff cb6ff746e0c7b9218b6f5c11db44162cacd623a4
aa8f732f4d6d2cdae5b32462b7be8f3afda512fc --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Usama Hameed (usama54321)
Changes
symbol
This patch puts the default breakpoint on the
sanitizers_address_on_report symbol, and uses the old symbol as a backup if the
default case is not found
rdar://123911522
---
Full diff: https://gith
https://github.com/usama54321 created
https://github.com/llvm/llvm-project/pull/84583
symbol
This patch puts the default breakpoint on the
sanitizers_address_on_report symbol, and uses the old symbol as a backup if the
default case is not found
rdar://123911522
>From aa8f732f4d6d2cdae5b32462
adrian-prantl wrote:
Or rather, I didn't build with all LLVM targets.
https://github.com/llvm/llvm-project/pull/84219
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
Apologies, I made a last-minute rebase without rebuilding. Thanks for reverting!
https://github.com/llvm/llvm-project/pull/84219
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/84265
>From 934ad65f660a43917ec66861127230c68c697743 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Fri, 8 Mar 2024 14:46:13 -0800
Subject: [PATCH] Report back errors in GetNumChildren()
This is a proof-of-c
Author: Florian Mayer
Date: 2024-03-08T12:14:22-08:00
New Revision: 300a39bdad4593fdc2618eb28f6e838df735619a
URL:
https://github.com/llvm/llvm-project/commit/300a39bdad4593fdc2618eb28f6e838df735619a
DIFF:
https://github.com/llvm/llvm-project/commit/300a39bdad4593fdc2618eb28f6e838df735619a.diff
fmayer wrote:
I think this broke the build completely?
```
/usr/local/google/home/fmayer/large/llvm-project/lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc64.cpp:771:14:
error: no viable conversion from 'llvm::Expected' (aka
'Expected') to 'uint32_t' (aka 'unsigned int')
uint32_t n = m_type.Ge
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/84265
>From 76d65446227d18f4f3c4675b1aa12678037dff8c Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 6 Mar 2024 16:21:14 -0800
Subject: [PATCH] Report back errors in GetNumChildren()
This is a proof-of-c
Author: Adrian Prantl
Date: 2024-03-08T10:39:34-08:00
New Revision: 99118c809367d518ffe4de60c16da953744b68b9
URL:
https://github.com/llvm/llvm-project/commit/99118c809367d518ffe4de60c16da953744b68b9
DIFF:
https://github.com/llvm/llvm-project/commit/99118c809367d518ffe4de60c16da953744b68b9.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/84219
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/84219
>From 0504cd6b50df6fafe36bade310fe1b729a3d9cea Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 7 Mar 2024 13:03:14 -0800
Subject: [PATCH] Change GetNumChildren()/CalculateNumChildren() to return
ll
https://github.com/jimingham approved this pull request.
LGTM. The "IgnoringErrors" makes this construct easier to spot, and also
should give anyone a bad feeling if they are tempted to use it...
https://github.com/llvm/llvm-project/pull/84219
___
ll
adrian-prantl wrote:
Rebased
https://github.com/llvm/llvm-project/pull/84265
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
> From looking at the code, it seems like there are two clear classes of users,
> those that need to check the error, and those that, in the error case, 0 is
> just as good as the error. The latter appears not infrequently as:
>
> `llvm::expectedToStdOptional(value_sp->Get
adrian-prantl wrote:
@walter-erquinigo @jimingham I updated the patch to implement Jim's suggestion
of adding an explicit `GetNumChilrdrenIgnoringErrors()` API that also ticks off
the "big red warning flag" @JDevlieghere was pushing for.
https://github.com/llvm/llvm-project/pull/84219
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/84219
>From 97a80ffa93d9fd648f0aa995b51981f0ad949530 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 7 Mar 2024 13:03:14 -0800
Subject: [PATCH] Let GetNumChildren()/CalculateNumChildren() return
llvm::Ex
@@ -48,20 +48,38 @@ static Status EnsureFDFlags(int fd, int flags) {
return error;
}
+static Status CanTrace() {
+ int proc_debug, ret;
+ size_t len = sizeof(proc_debug);
+ ret = ::sysctlbyname("security.bsd.unprivileged_proc_debug", &proc_debug,
+ &
Author: David Spickett
Date: 2024-03-08T17:15:11Z
New Revision: 73b2d672c1c8318cd16a02812c39ae3997b9dbcd
URL:
https://github.com/llvm/llvm-project/commit/73b2d672c1c8318cd16a02812c39ae3997b9dbcd
DIFF:
https://github.com/llvm/llvm-project/commit/73b2d672c1c8318cd16a02812c39ae3997b9dbcd.diff
LOG
@@ -339,6 +339,15 @@ class Language : public PluginInterface {
virtual llvm::StringRef GetInstanceVariableName() { return {}; }
+ /// Returns true if this SymbolContext should be ignored when setting
+ /// breakpoints by line (number or regex). This is useful for language
Author: David Spickett
Date: 2024-03-08T11:33:17Z
New Revision: 235332150d52d11b340a10be1bb88432d2cf4179
URL:
https://github.com/llvm/llvm-project/commit/235332150d52d11b340a10be1bb88432d2cf4179
DIFF:
https://github.com/llvm/llvm-project/commit/235332150d52d11b340a10be1bb88432d2cf4179.diff
LOG
Author: David Spickett
Date: 2024-03-08T10:43:17Z
New Revision: 0f8cb6818d788c34d70d586f701469a5adabfce1
URL:
https://github.com/llvm/llvm-project/commit/0f8cb6818d788c34d70d586f701469a5adabfce1
DIFF:
https://github.com/llvm/llvm-project/commit/0f8cb6818d788c34d70d586f701469a5adabfce1.diff
LOG
38 matches
Mail list logo
