[Lldb-commits] [lldb] e52650c - Fix LLDB build after renaming the base class for ThreadPool to ThreadPoolInterface

2024-03-02 Thread Mehdi Amini via lldb-commits
Author: Mehdi Amini Date: 2024-03-02T19:30:33-08:00 New Revision: e52650cfc3aa5d134186c5a8fd6701a6fd0a1051 URL: https://github.com/llvm/llvm-project/commit/e52650cfc3aa5d134186c5a8fd6701a6fd0a1051 DIFF: https://github.com/llvm/llvm-project/commit/e52650cfc3aa5d134186c5a8fd6701a6fd0a1051.diff L

[Lldb-commits] [lld] [lldb] [llvm] [mlir] Rename ThreadPool->DefaultThreadPool and ThreadPoolInterface->ThreadPool (NFC) (PR #83702)

2024-03-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-mlir @llvm/pr-subscribers-debuginfo Author: Mehdi Amini (joker-eph) Changes This is a breaking change: clients who use to create a ThreadPool must now create a DefaultThreadPool. --- Patch is 38.32 KiB, truncated to 20.00 KiB below, full version: htt

[Lldb-commits] [lld] [lldb] [llvm] [mlir] Rename ThreadPool->DefaultThreadPool and ThreadPoolInterface->ThreadPool (NFC) (PR #83702)

2024-03-02 Thread Mehdi Amini via lldb-commits
https://github.com/joker-eph created https://github.com/llvm/llvm-project/pull/83702 This is a breaking change: clients who use to create a ThreadPool must now create a DefaultThreadPool. >From aec355378bcb453adc4d697b02c69af30eb5f0ae Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Tue, 27 F

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

2024-03-02 Thread Mehdi Amini via lldb-commits
https://github.com/joker-eph closed https://github.com/llvm/llvm-project/pull/82094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

2024-03-02 Thread Mehdi Amini via lldb-commits
https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From 5f47d05b0310ffe5b20b972c507bce09399aec77 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an im

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

2024-03-02 Thread Mehdi Amini via lldb-commits
https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From 375add7f2ea7c8aa805c022936e7b65fdefe80b6 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an im

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

2024-03-02 Thread Mehdi Amini via lldb-commits
https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From 6864303679435f51ce899e348e49bfd11eb4146f Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an im

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

2024-03-02 Thread Mehdi Amini via lldb-commits
https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From d39dfe51ee866a9f45337b015e09d307b0ea994e Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an im

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

2024-03-02 Thread Mehdi Amini via lldb-commits
https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From 41404ed9b7038d712d18b0e16896fae66a954f87 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an im

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

2024-03-02 Thread Mehdi Amini via lldb-commits
https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From 5851f2980e699f7265bf556ea1889a63f080dc4d Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an im

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

2024-03-02 Thread Mehdi Amini via lldb-commits
https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From eb630caf1bb9689f23c1f7dfe62a80f4c276da0d Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an im

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

2024-03-02 Thread via lldb-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/82094 >From eb630caf1bb9689f23c1f7dfe62a80f4c276da0d Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an imp

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

2024-03-02 Thread Mehdi Amini via lldb-commits
@@ -92,30 +104,32 @@ class ThreadPool { &Group); } - /// Blocking wait for all the threads to complete and the queue to be empty. - /// It is an error to try to add new tasks while blocking on this call. - /// Calling wait() from a task would deadlock

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

2024-03-02 Thread Mehdi Amini via lldb-commits
@@ -140,54 +142,74 @@ class ThreadPool { }, std::move(F)}; } +}; + +/// A ThreadPool implementation using std::threads. +/// +/// The pool keeps a vector of threads alive, waiting on a condition variable +/// for some work to become available. +class S

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

2024-03-02 Thread Alexandre Ganea via lldb-commits
https://github.com/aganea approved this pull request. Look good, thank you again for making all these changes! https://github.com/llvm/llvm-project/pull/82094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [lldb] [lldb][X86] Fix setting target features in ClangExpressionParser (PR #82364)

2024-03-02 Thread Daniil Kovalev via lldb-commits
https://github.com/kovdan01 closed https://github.com/llvm/llvm-project/pull/82364 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b14220e - [lldb][X86] Fix setting target features in ClangExpressionParser (#82364)

2024-03-02 Thread via lldb-commits
Author: Daniil Kovalev Date: 2024-03-02T13:09:47+03:00 New Revision: b14220e075fe47f4d61632e80a6d0a4a955a7c97 URL: https://github.com/llvm/llvm-project/commit/b14220e075fe47f4d61632e80a6d0a4a955a7c97 DIFF: https://github.com/llvm/llvm-project/commit/b14220e075fe47f4d61632e80a6d0a4a955a7c97.diff

[Lldb-commits] [lldb] [lldb][X86] Fix setting target features in ClangExpressionParser (PR #82364)

2024-03-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. Using `FeaturesAsWritten` makes sense here, thanks! We really should change this logic to derive all the compiler options using the driver, but that's a bigger change for the future https://github.com/llvm/llvm-project/pull/82364 __

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

2024-03-02 Thread Mehdi Amini via lldb-commits
https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From 75c17b79beeb117dbfc407051bb9a7660b69ee62 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an im