[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2024-01-02 Thread Greg Clayton via lldb-commits
clayborg wrote: So I traced down why things used to work and why they don't work now. The issue is we are being too accurate with our type lookups now. For my reduced example I had this code: ``` struct A { struct B { static int f; }; }; ``` What would happen when you type "p A::B::f" w

[Lldb-commits] [clang-tools-extra] [polly] [libc] [flang] [openmp] [compiler-rt] [clang] [libcxxabi] [llvm] [mlir] [libcxx] [lldb] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-02 Thread Rik Huijzer via lldb-commits
@@ -897,7 +921,8 @@ struct TransferOpConversion : public VectorToSCFPattern { } else { // It's safe to assume the mask buffer can be unpacked if the data // buffer was unpacked. -auto castedMaskType = *unpackOneDim(maskBufferType); +auto m

[Lldb-commits] [clang-tools-extra] [polly] [libc] [flang] [openmp] [compiler-rt] [clang] [libcxxabi] [llvm] [mlir] [libcxx] [lldb] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-02 Thread Rik Huijzer via lldb-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/76292 >From 0ff5a0ec09f7c26824bd90e6c7656222ee2448ae Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Sat, 23 Dec 2023 16:32:27 +0100 Subject: [PATCH 1/3] [mlir][vector] Fix invalid `LoadOp` indices being created -

[Lldb-commits] [libcxx] [flang] [clang] [compiler-rt] [llvm] [lldb] [clang-tools-extra] [libc] [lld] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

2024-01-02 Thread A. Jiang via lldb-commits
https://github.com/frederick-vs-ja edited https://github.com/llvm/llvm-project/pull/76447 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [flang] [clang] [compiler-rt] [llvm] [lldb] [clang-tools-extra] [libc] [lld] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

2024-01-02 Thread A. Jiang via lldb-commits
@@ -1273,6 +1293,22 @@ public: __impl_.__swap(__that.__impl_); } +# if _LIBCPP_STD_VER >= 26 + // [variant.visit], visitation + + template frederick-vs-ja wrote: Would it be better to use a special tag type like this ```C++ struct __variant_visit_ba

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

2024-01-02 Thread Greg Clayton via lldb-commits
clayborg wrote: > > Can this be tested? > > I took a look at existing tests, but I'm not sure how to best test this. I > think we would need to create a breakpoint in a module by address and make > sure the resolver correctly serializes the name (in `statistics dump` or > otherwise). Does tha

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2024-01-02 Thread Greg Clayton via lldb-commits
clayborg wrote: I am also not saying this patch hasn't made this issue happen more often, so I will check out my APIs to see how they are being called from the expression parser. https://github.com/llvm/llvm-project/pull/74786 ___ lldb-commits mailin

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2024-01-02 Thread Greg Clayton via lldb-commits
clayborg wrote: > absl::cord_internal::RefcountAndFlags::Flags::kNumFlags I have a small repro case from the code pointer you gave. I will look into this and report back what I find. Are you guys using the expression parser in your pretty printer? As Michael pointed out, you can get the enum

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

2024-01-02 Thread Alex Langford via lldb-commits
bulbazord wrote: > Can this be tested? I took a look at existing tests, but I'm not sure how to best test this. I think we would need to create a breakpoint in a module by address and make sure the resolver correctly serializes the name (in `statistics dump` or otherwise). Does that sound app

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

2024-01-02 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: Can this be tested? https://github.com/llvm/llvm-project/pull/76766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

2024-01-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes BreakpointResolverAddress optionally can include the module name related to the address that gets resolved. Currently this will never work because it sets the name to itself (which is empty). --- Full dif

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

2024-01-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/76766 BreakpointResolverAddress optionally can include the module name related to the address that gets resolved. Currently this will never work because it sets the name to itself (which is empty). >From 519f2db688

[Lldb-commits] [lld] [lldb] [polly] [compiler-rt] [libc] [clang] [libcxx] [mlir] [llvm] [libcxxabi] [clang-tools-extra] [flang] Make clang report invalid target versions. (PR #75373)

2024-01-02 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/75373 >From 74f256d8a77ee2ba8e0d5bbb6519aa2729cf94d5 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Wed, 13 Dec 2023 20:07:45 + Subject: [PATCH 01/11] Make clang report garbage target versions. Clang always s

[Lldb-commits] [clang-tools-extra] [lld] [mlir] [libcxx] [lldb] [compiler-rt] [libc] [flang] [llvm] [libcxxabi] [clang] [polly] Make clang report invalid target versions. (PR #75373)

2024-01-02 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/75373 >From 74f256d8a77ee2ba8e0d5bbb6519aa2729cf94d5 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Wed, 13 Dec 2023 20:07:45 + Subject: [PATCH 01/11] Make clang report garbage target versions. Clang always s

[Lldb-commits] [llvm] [libcxxabi] [lldb] [libcxx] [polly] [openmp] [compiler-rt] [flang] [libc] [mlir] [clang-tools-extra] [clang] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-02 Thread Mehdi Amini via lldb-commits
@@ -897,7 +921,8 @@ struct TransferOpConversion : public VectorToSCFPattern { } else { // It's safe to assume the mask buffer can be unpacked if the data // buffer was unpacked. -auto castedMaskType = *unpackOneDim(maskBufferType); +auto m

[Lldb-commits] [compiler-rt] [polly] [clang-tools-extra] [llvm] [libc] [mlir] [clang] [lldb] [libcxxabi] [lld] [libcxx] [flang] Make clang report invalid target versions. (PR #75373)

2024-01-02 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/75373 >From 74f256d8a77ee2ba8e0d5bbb6519aa2729cf94d5 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Wed, 13 Dec 2023 20:07:45 + Subject: [PATCH 01/11] Make clang report garbage target versions. Clang always s

[Lldb-commits] [compiler-rt] [polly] [clang-tools-extra] [llvm] [libc] [mlir] [clang] [lldb] [libcxxabi] [lld] [libcxx] [flang] Make clang report invalid target versions. (PR #75373)

2024-01-02 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/75373 >From 74f256d8a77ee2ba8e0d5bbb6519aa2729cf94d5 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Wed, 13 Dec 2023 20:07:45 + Subject: [PATCH 01/10] Make clang report garbage target versions. Clang always s

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2024-01-02 Thread Michael Buch via lldb-commits
Michael137 wrote: > FWIW, we're seeing this breaking a pretty printer in google - previously a > lookup was able to find > `absl::cord_internal::RefcountAndFlags::Flags::kNumFlags` ( > https://github.com/abseil/abseil-cpp/blob/8184f16e898fcb13b310b40430e13ba40679cf0e/absl/strings/internal/cord

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2024-01-02 Thread David Blaikie via lldb-commits
dwblaikie wrote: @clayborg any thoughts on this ^ ? https://github.com/llvm/llvm-project/pull/74786 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [openmp] [lldb] [flang] [clang-tools-extra] [compiler-rt] [mlir] [llvm] [polly] [libc] [libcxxabi] [libcxx] [clang] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-02 Thread Rik Huijzer via lldb-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/76292 >From 0ff5a0ec09f7c26824bd90e6c7656222ee2448ae Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Sat, 23 Dec 2023 16:32:27 +0100 Subject: [PATCH 1/2] [mlir][vector] Fix invalid `LoadOp` indices being created -

[Lldb-commits] [libcxx] [flang] [libc] [clang-tools-extra] [lldb] [lld] [compiler-rt] [clang] [llvm] [AMDGPU] Use alias scope to relax waitcounts for LDS DMA (PR #75974)

2024-01-02 Thread Stanislav Mekhanoshin via lldb-commits
rampitec wrote: Ping https://github.com/llvm/llvm-project/pull/75974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [clang] [flang] [clang-tools-extra] [llvm] [lldb] [libc] [compiler-rt] [libcxx] [AMDGPU] Use alias info to relax waitcounts for LDS DMA (PR #74537)

2024-01-02 Thread Stanislav Mekhanoshin via lldb-commits
rampitec wrote: Ping https://github.com/llvm/llvm-project/pull/74537 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 0d19a89 - Fix builtbot

2024-01-02 Thread walter erquinigo via lldb-commits
Author: walter erquinigo Date: 2024-01-02T13:30:44-05:00 New Revision: 0d19a8983c05de321d8ab592995e7a36bca448ee URL: https://github.com/llvm/llvm-project/commit/0d19a8983c05de321d8ab592995e7a36bca448ee DIFF: https://github.com/llvm/llvm-project/commit/0d19a8983c05de321d8ab592995e7a36bca448ee.di

[Lldb-commits] [lldb] [lldb-dap] Emit more structured info along with variables (PR #75244)

2024-01-02 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/75244 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ffd173b - [lldb-dap] Emit more structured info along with variables (#75244)

2024-01-02 Thread via lldb-commits
Author: Walter Erquinigo Date: 2024-01-02T13:06:13-05:00 New Revision: ffd173ba0b4a6d84f45308e78cea4af611bec10e URL: https://github.com/llvm/llvm-project/commit/ffd173ba0b4a6d84f45308e78cea4af611bec10e DIFF: https://github.com/llvm/llvm-project/commit/ffd173ba0b4a6d84f45308e78cea4af611bec10e.di

[Lldb-commits] [clang] [compiler-rt] [clang-tools-extra] [libc] [mlir] [lldb] [libcxx] [flang] [llvm] [openmp] [OpenMP] atomic compare fail : Codegen support (PR #75709)

2024-01-02 Thread Sandeep Kosuri via lldb-commits
https://github.com/sandeepkosuri closed https://github.com/llvm/llvm-project/pull/75709 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [DO NOT MERGE][DebugInfo] Implement debug_names's IDX_parent attribute (PR #75365)

2024-01-02 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/75365 >From 1fafdee241e98c469a3a06e29d4a375bd8af1ca0 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Mon, 11 Dec 2023 12:42:40 -0300 Subject: [PATCH 1/9] [lldb][[DWARFDeclContext] Add function to

[Lldb-commits] [openmp] [clang] [libc] [mlir] [lldb] [flang] [llvm] [AMDGPU] GFX12 global_atomic_ordered_add_b64 instruction and intrinsic (PR #76149)

2024-01-02 Thread Jay Foad via lldb-commits
https://github.com/jayfoad closed https://github.com/llvm/llvm-project/pull/76149 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libc] [clang] [lldb] [llvm] [openmp] [mlir] [flang] [AMDGPU] GFX12 global_atomic_ordered_add_b64 instruction and intrinsic (PR #76149)

2024-01-02 Thread Matt Arsenault via lldb-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/76149 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [openmp] [flang] [lldb] [libc] [mlir] [llvm] [AMDGPU] GFX12 global_atomic_ordered_add_b64 instruction and intrinsic (PR #76149)

2024-01-02 Thread Jay Foad via lldb-commits
jayfoad wrote: Ping! https://github.com/llvm/llvm-project/pull/76149 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [compiler-rt] [libc] [clang] [libcxx] [clang-tools-extra] [llvm] [mlir] [openmp] [flang] [OpenMP] atomic compare fail : Codegen support (PR #75709)

2024-01-02 Thread via lldb-commits
https://github.com/SunilKuravinakop updated https://github.com/llvm/llvm-project/pull/75709 >From fe931d64741f427629407bca3e68a61bec6f2b67 Mon Sep 17 00:00:00 2001 From: Sunil Kuravinakop Date: Sat, 16 Dec 2023 11:43:35 -0600 Subject: [PATCH 1/3] Adding parameter to fail clause (i.e. memory ord