[Lldb-commits] [mlir] [compiler-rt] [libc] [clang] [flang] [llvm] [openmp] [lldb] [hwasan] Respect strip_path_prefix printing locals (PR #76132)

2023-12-21 Thread antoine moynault via lldb-commits
antmox wrote: Hello, this patch broke several aarch64 bots: https://lab.llvm.org/buildbot/#/builders/198/builds/7522 https://lab.llvm.org/buildbot/#/builders/176/builds/7521 https://lab.llvm.org/buildbot/#/builders/197/builds/11545 https://lab.llvm.org/buildbot/#/builders/184/builds/8762 https://

[Lldb-commits] [libc] [clang] [openmp] [flang] [libcxx] [llvm] [compiler-rt] [lldb] [mlir] [hwasan] Classify stack overflow, and use after scope (PR #76133)

2023-12-21 Thread Vitaly Buka via lldb-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/76133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libc] [clang] [openmp] [flang] [libcxx] [llvm] [compiler-rt] [lldb] [mlir] [hwasan] Classify stack overflow, and use after scope (PR #76133)

2023-12-21 Thread Florian Mayer via lldb-commits
https://github.com/fmayer approved this pull request. https://github.com/llvm/llvm-project/pull/76133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [mlir] [openmp] [libcxx] [compiler-rt] [llvm] [lldb] [libc] [clang] [flang] [hwasan] Classify stack overflow, and use after scope (PR #76133)

2023-12-21 Thread Vitaly Buka via lldb-commits
vitalybuka wrote: > Remove this comment? > > Line 780 > > ``` > // TODO(fmayer): figure out how to distinguish use-after-return and > // stack-buffer-overflow. > ``` done https://github.com/llvm/llvm-project/pull/76133 ___ lldb-commits maili

[Lldb-commits] [mlir] [openmp] [libcxx] [compiler-rt] [llvm] [lldb] [libc] [clang] [flang] [hwasan] Classify stack overflow, and use after scope (PR #76133)

2023-12-21 Thread Vitaly Buka via lldb-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/76133 >From 89636904337efe75ef6e0743e4f098f0d5b5ab56 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 20 Dec 2023 23:58:05 -0800 Subject: [PATCH 1/4] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?= =?U

[Lldb-commits] [mlir] [openmp] [libcxx] [compiler-rt] [llvm] [lldb] [libc] [clang] [flang] [hwasan] Classify stack overflow, and use after scope (PR #76133)

2023-12-21 Thread Vitaly Buka via lldb-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/76133 >From 89636904337efe75ef6e0743e4f098f0d5b5ab56 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 20 Dec 2023 23:58:05 -0800 Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?= =?U

[Lldb-commits] [llvm] [openmp] [libc] [compiler-rt] [lldb] [mlir] [flang] [libcxx] [clang] [hwasan] Classify stack overflow, and use after scope (PR #76133)

2023-12-21 Thread Florian Mayer via lldb-commits
https://github.com/fmayer commented: Remove this comment? Line 780 ``` // TODO(fmayer): figure out how to distinguish use-after-return and // stack-buffer-overflow. ``` https://github.com/llvm/llvm-project/pull/76133 ___ lldb-commits mailing

[Lldb-commits] [llvm] [libc] [compiler-rt] [clang-tools-extra] [lldb] [flang] [libcxx] [clang] [RegAllocFast] Refactor dominates algorithm for large basic block (PR #72250)

2023-12-21 Thread via lldb-commits
https://github.com/HaohaiWen updated https://github.com/llvm/llvm-project/pull/72250 >From 581b28b6827855643bd5bdbca0cf9ccef0de2584 Mon Sep 17 00:00:00 2001 From: Haohai Wen Date: Tue, 14 Nov 2023 20:20:29 +0800 Subject: [PATCH 1/2] [RegAllocFast] Refactor dominates algorithm for large basic b

[Lldb-commits] [llvm] [openmp] [libc] [compiler-rt] [lldb] [mlir] [flang] [libcxx] [clang] [hwasan] Classify stack overflow, and use after scope (PR #76133)

2023-12-21 Thread Florian Mayer via lldb-commits
@@ -221,29 +221,55 @@ static void PrintStackAllocations(const StackAllocationsRingBuffer *sa, for (LocalInfo &local : frame.locals) { if (!local.has_frame_offset || !local.has_size || !local.has_tag_offset) continue; +if (!(local.name && intern

[Lldb-commits] [clang] [llvm] [libcxx] [lldb] [flang] [openmp] [mlir] [libc] [compiler-rt] [hwasan] Classify stack overflow, and use after scope (PR #76133)

2023-12-21 Thread Florian Mayer via lldb-commits
@@ -221,29 +221,55 @@ static void PrintStackAllocations(const StackAllocationsRingBuffer *sa, for (LocalInfo &local : frame.locals) { if (!local.has_frame_offset || !local.has_size || !local.has_tag_offset) continue; +if (!(local.name && intern

[Lldb-commits] [llvm] [clang-tools-extra] [libcxx] [compiler-rt] [flang] [libc] [lldb] [clang] [RegAllocFast] Refactor dominates algorithm for large basic block (PR #72250)

2023-12-21 Thread via lldb-commits
https://github.com/HaohaiWen updated https://github.com/llvm/llvm-project/pull/72250 >From 581b28b6827855643bd5bdbca0cf9ccef0de2584 Mon Sep 17 00:00:00 2001 From: Haohai Wen Date: Tue, 14 Nov 2023 20:20:29 +0800 Subject: [PATCH 1/2] [RegAllocFast] Refactor dominates algorithm for large basic b

[Lldb-commits] [flang] [clang] [mlir] [llvm] [libcxx] [compiler-rt] [libc] [lldb] [openmp] [hwasan] Classify stack overflow, and use after scope (PR #76133)

2023-12-21 Thread Vitaly Buka via lldb-commits
@@ -0,0 +1,25 @@ +// RUN: %clang_hwasan -g %s -o %t && not %run %t 2>&1 | FileCheck %s + +// Stack histories currently are not recorded on x86. +// XFAIL: target=x86_64{{.*}} + +__attribute((noinline)) void buggy() { + char c[64]; + char *volatile p = c; + p[-2] = 0; +} + +int

[Lldb-commits] [flang] [clang] [mlir] [llvm] [libcxx] [compiler-rt] [libc] [lldb] [openmp] [hwasan] Classify stack overflow, and use after scope (PR #76133)

2023-12-21 Thread Vitaly Buka via lldb-commits
@@ -221,29 +221,55 @@ static void PrintStackAllocations(const StackAllocationsRingBuffer *sa, for (LocalInfo &local : frame.locals) { if (!local.has_frame_offset || !local.has_size || !local.has_tag_offset) continue; +if (!(local.name && intern

[Lldb-commits] [flang] [clang] [mlir] [llvm] [libcxx] [compiler-rt] [libc] [lldb] [openmp] [hwasan] Classify stack overflow, and use after scope (PR #76133)

2023-12-21 Thread Vitaly Buka via lldb-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/76133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [flang] [llvm] [libc] [openmp] [clang] [lldb] [mlir] [hwasan] Respect strip_path_prefix printing locals (PR #76132)

2023-12-21 Thread Vitaly Buka via lldb-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/76132 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [flang] [llvm] [libc] [openmp] [clang] [lldb] [mlir] [hwasan] Respect strip_path_prefix printing locals (PR #76132)

2023-12-21 Thread Vitaly Buka via lldb-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/76132 >From 8c5b5de0d4fda16cfa1c8c4281601b61a9ca774d Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 20 Dec 2023 23:58:01 -0800 Subject: [PATCH 1/4] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?= =?U

[Lldb-commits] [llvm] [lldb] [mlir] [libc] [compiler-rt] [flang] [clang] [openmp] [hwasan] Respect strip_path_prefix printing locals (PR #76132)

2023-12-21 Thread Florian Mayer via lldb-commits
https://github.com/fmayer approved this pull request. Lgtm thanks https://github.com/llvm/llvm-project/pull/76132 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [llvm] [lldb] [mlir] [libc] [compiler-rt] [flang] [clang] [openmp] [hwasan] Respect strip_path_prefix printing locals (PR #76132)

2023-12-21 Thread Vitaly Buka via lldb-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/76132 >From 8c5b5de0d4fda16cfa1c8c4281601b61a9ca774d Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 20 Dec 2023 23:58:01 -0800 Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?= =?U

[Lldb-commits] [llvm] [lldb] [mlir] [libc] [compiler-rt] [flang] [clang] [openmp] [hwasan] Respect strip_path_prefix printing locals (PR #76132)

2023-12-21 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9d0e3a77eee290592620cf017c433bd7a751952d 9e2f17c3a3624b8dbaff499612339210d66ff975 --

[Lldb-commits] [llvm] [compiler-rt] [lldb] [mlir] [clang] [openmp] [flang] [libc] [hwasan] Respect strip_path_prefix printing locals (PR #76132)

2023-12-21 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9d0e3a77eee290592620cf017c433bd7a751952d 9e2f17c3a3624b8dbaff499612339210d66ff975 --

[Lldb-commits] [llvm] [compiler-rt] [lldb] [mlir] [clang] [openmp] [flang] [libc] [hwasan] Respect strip_path_prefix printing locals (PR #76132)

2023-12-21 Thread Vitaly Buka via lldb-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/76132 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Define _BSD_SOURCE globally, to get optreset available in mingw's getopt.h (PR #76137)

2023-12-21 Thread Martin Storsjö via lldb-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/76137 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f70b229 - [LLDB] Define _BSD_SOURCE globally, to get optreset available in mingw's getopt.h (#76137)

2023-12-21 Thread via lldb-commits
Author: Martin Storsjö Date: 2023-12-22T00:40:12+02:00 New Revision: f70b229e9643ddb895d491b62a5ec0655917f6f8 URL: https://github.com/llvm/llvm-project/commit/f70b229e9643ddb895d491b62a5ec0655917f6f8 DIFF: https://github.com/llvm/llvm-project/commit/f70b229e9643ddb895d491b62a5ec0655917f6f8.diff

[Lldb-commits] [lldb] [lldb] Remove redundant severity substring within a diagnostic message. (PR #76111)

2023-12-21 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/76111 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove redundant severity substring within a diagnostic message. (PR #76111)

2023-12-21 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -48,8 +48,17 @@ std::string DiagnosticManager::GetString(char separator) { std::string ret; for (const auto &diagnostic : Diagnostics()) { -ret.append(StringForSeverity(diagnostic->GetSeverity())); -ret.append(std::string(diagnostic->GetMessage())); +std::st

[Lldb-commits] [lldb] [lldb] Remove redundant severity substring within a diagnostic message. (PR #76111)

2023-12-21 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -48,8 +48,17 @@ std::string DiagnosticManager::GetString(char separator) { std::string ret; for (const auto &diagnostic : Diagnostics()) { -ret.append(StringForSeverity(diagnostic->GetSeverity())); -ret.append(std::string(diagnostic->GetMessage())); +std::st

[Lldb-commits] [lldb] [lldb] Remove redundant severity substring within a diagnostic message. (PR #76111)

2023-12-21 Thread Pete Lawrence via lldb-commits
@@ -48,8 +48,17 @@ std::string DiagnosticManager::GetString(char separator) { std::string ret; for (const auto &diagnostic : Diagnostics()) { -ret.append(StringForSeverity(diagnostic->GetSeverity())); -ret.append(std::string(diagnostic->GetMessage())); +std::st

[Lldb-commits] [lldb] [LLDB] Define _BSD_SOURCE globally, to get optreset available in mingw's getopt.h (PR #76137)

2023-12-21 Thread Martin Storsjö via lldb-commits
@@ -44,6 +44,10 @@ endif() if (WIN32) add_definitions(-D_ENABLE_EXTENDED_ALIGNED_STORAGE) + if (NOT MSVC) mstorsjo wrote: This was never defined for clang-cl/MSVC builds before. Note that the existing define I'm removing is within this context: ``` #if !

[Lldb-commits] [lldb] [lldb] Remove redundant severity substring within a diagnostic message. (PR #76111)

2023-12-21 Thread Pete Lawrence via lldb-commits
@@ -48,8 +48,17 @@ std::string DiagnosticManager::GetString(char separator) { std::string ret; for (const auto &diagnostic : Diagnostics()) { -ret.append(StringForSeverity(diagnostic->GetSeverity())); -ret.append(std::string(diagnostic->GetMessage())); +std::st

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-21 Thread David Blaikie via lldb-commits
dwblaikie wrote: FWIW, we're seeing this breaking a pretty printer in google - previously a lookup was able to find `absl::cord_internal::RefcountAndFlags::Flags::kNumFlags` ( https://github.com/abseil/abseil-cpp/blob/8184f16e898fcb13b310b40430e13ba40679cf0e/absl/strings/internal/cord_internal

[Lldb-commits] [lldb] [LLDB] Fix write permission error in TestGlobalModuleCache.py (PR #76171)

2023-12-21 Thread via lldb-commits
https://github.com/cmtice closed https://github.com/llvm/llvm-project/pull/76171 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1830fad - [LLDB] Fix write permission error in TestGlobalModuleCache.py (#76171)

2023-12-21 Thread via lldb-commits
Author: cmtice Date: 2023-12-21T12:05:36-08:00 New Revision: 1830fadb78be9993cfeeaa7fb6867c3df1a53a8b URL: https://github.com/llvm/llvm-project/commit/1830fadb78be9993cfeeaa7fb6867c3df1a53a8b DIFF: https://github.com/llvm/llvm-project/commit/1830fadb78be9993cfeeaa7fb6867c3df1a53a8b.diff LOG: [

[Lldb-commits] [lldb] [LLDB] Fix write permission error in TestGlobalModuleCache.py (PR #76171)

2023-12-21 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/76171 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [libc] [llvm] [compiler-rt] [clang] [flang] [libcxx] [clang-tools-extra] [openmp] [lld] [mlir] [libunwind] [OpenMP] Improve omp offload profiler (PR #68016)

2023-12-21 Thread Johannes Doerfert via lldb-commits
https://github.com/jdoerfert approved this pull request. LG. Please rebase and merge. https://github.com/llvm/llvm-project/pull/68016 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix write permission error in TestGlobalModuleCache.py (PR #76171)

2023-12-21 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: IIUC, the issue is that even though we are working in the build directory, which is writeable, we are copying a file from the source tree, which may be readonly, and those readonly permission bits persist when they're copied to the build directory. https://github.com/llvm/llv

[Lldb-commits] [lldb] [LLDB] Fix write permission error in TestGlobalModuleCache.py (PR #76171)

2023-12-21 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/76171 >From 74ac76e175917e0354d998b3b3fdc2b30bf9251b Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Thu, 21 Dec 2023 09:10:35 -0800 Subject: [PATCH 1/4] [LLDB] Fix write permission error in TestGlobalModuleCache.py

[Lldb-commits] [lldb] [LLDB] Fix write permission error in TestGlobalModuleCache.py (PR #76171)

2023-12-21 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/76171 >From 74ac76e175917e0354d998b3b3fdc2b30bf9251b Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Thu, 21 Dec 2023 09:10:35 -0800 Subject: [PATCH 1/3] [LLDB] Fix write permission error in TestGlobalModuleCache.py

[Lldb-commits] [lldb] [LLDB] Fix write permission error in TestGlobalModuleCache.py (PR #76171)

2023-12-21 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/76171 >From 74ac76e175917e0354d998b3b3fdc2b30bf9251b Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Thu, 21 Dec 2023 09:10:35 -0800 Subject: [PATCH 1/2] [LLDB] Fix write permission error in TestGlobalModuleCache.py

[Lldb-commits] [lldb] [LLDB] Fix write permission error in TestGlobalModuleCache.py (PR #76171)

2023-12-21 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 11140cc238b8c4124e6f9efacb1601f81da096a0...74ac76e175917e0354d998b3b3fdc2b30bf9251b lldb/

[Lldb-commits] [lldb] [LLDB] Fix write permission error in TestGlobalModuleCache.py (PR #76171)

2023-12-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (cmtice) Changes TestGlobalModuleCache.py, a recently added test, tries to update a source file in the build directory, but it assumes the file is writable. In our distributed build and test system, this is not always true, so the tes

[Lldb-commits] [lldb] [LLDB] Fix write permission error in TestGlobalModuleCache.py (PR #76171)

2023-12-21 Thread via lldb-commits
https://github.com/cmtice created https://github.com/llvm/llvm-project/pull/76171 TestGlobalModuleCache.py, a recently added test, tries to update a source file in the build directory, but it assumes the file is writable. In our distributed build and test system, this is not always true, so th

[Lldb-commits] [clang-tools-extra] [openmp] [libcxx] [llvm] [mlir] [flang] [clang] [lldb] [compiler-rt] [libc] [OpenMP] atomic compare fail : Codegen support (PR #75709)

2023-12-21 Thread via lldb-commits
https://github.com/SunilKuravinakop updated https://github.com/llvm/llvm-project/pull/75709 >From fe931d64741f427629407bca3e68a61bec6f2b67 Mon Sep 17 00:00:00 2001 From: Sunil Kuravinakop Date: Sat, 16 Dec 2023 11:43:35 -0600 Subject: [PATCH 1/3] Adding parameter to fail clause (i.e. memory ord

[Lldb-commits] [lldb] [lldb] enhance colorize process for image lookup command (PR #76112)

2023-12-21 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: DavidSpickett wrote: Drive by comments since I am low on time, also I will be away until early January from today. A general comment, please keep each PR to one thing. So I'd say mak

[Lldb-commits] [lldb] [lldb] enhance colorize process for image lookup command (PR #76112)

2023-12-21 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -72,23 +72,21 @@ size_t Stream::PutCString(llvm::StringRef str) { return bytes_written; } -void Stream::PutCStringColorHighlighted(llvm::StringRef text, -

[Lldb-commits] [lldb] [lldb] enhance colorize process for image lookup command (PR #76112)

2023-12-21 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -23,6 +23,16 @@ namespace lldb_private { +struct Information { DavidSpickett wrote: This should be within the Stream class. Also the name is

[Lldb-commits] [lldb] [lldb] enhance colorize process for image lookup command (PR #76112)

2023-12-21 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -1609,6 +1612,11 @@ static uint32_t LookupSymbolInModule(CommandInterpreter &interpreter, } if (num_matches > 0) { +llvm::StringRef ansi_prefix = +

[Lldb-commits] [lldb] [lldb] enhance colorize process for image lookup command (PR #76112)

2023-12-21 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -72,23 +72,21 @@ size_t Stream::PutCString(llvm::StringRef str) { return bytes_written; } -void Stream::PutCStringColorHighlighted(llvm::StringRef text, -

[Lldb-commits] [lldb] [lldb] enhance colorize process for image lookup command (PR #76112)

2023-12-21 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -262,14 +263,12 @@ void Symbol::GetDescription(Stream *s, lldb::DescriptionLevel level, } if (ConstString demangled = m_mangled.GetDemangledName()) { s->

[Lldb-commits] [lldb] [llvm] [mlir] [openmp] [libc] [flang] [clang] [AMDGPU] GFX12 global_atomic_ordered_add_b64 instruction and intrinsic (PR #76149)

2023-12-21 Thread Jay Foad via lldb-commits
https://github.com/jayfoad updated https://github.com/llvm/llvm-project/pull/76149 >From b14a554a15e4de88c9afc428f9c6898090e6eb23 Mon Sep 17 00:00:00 2001 From: Jay Foad Date: Thu, 21 Dec 2023 12:00:26 + Subject: [PATCH] [AMDGPU] GFX12 global_atomic_ordered_add_b64 instruction and intrinsi

[Lldb-commits] [lldb] [LLDB] Define _BSD_SOURCE globally, to get optreset available in mingw's getopt.h (PR #76137)

2023-12-21 Thread David Spickett via lldb-commits
@@ -44,6 +44,10 @@ endif() if (WIN32) add_definitions(-D_ENABLE_EXTENDED_ALIGNED_STORAGE) + if (NOT MSVC) DavidSpickett wrote: Defining `_BSD_SOURCE` is probably not changing anything on our existing clang-cl Windows on Arm build then. This will just remo

[Lldb-commits] [lldb] f54249e - [lldb][test] Link to PlatformWindows in thread tests

2023-12-21 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-12-21T14:07:27Z New Revision: f54249e79a507f4bfeaa9ce3f693dbe01c9af915 URL: https://github.com/llvm/llvm-project/commit/f54249e79a507f4bfeaa9ce3f693dbe01c9af915 DIFF: https://github.com/llvm/llvm-project/commit/f54249e79a507f4bfeaa9ce3f693dbe01c9af915.diff LOG

[Lldb-commits] [lldb] 55985db - [lldb][test] Remove non-existent Windows lib from thread tests

2023-12-21 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-12-21T14:05:08Z New Revision: 55985db5fe82705234370848c47575db7a16437e URL: https://github.com/llvm/llvm-project/commit/55985db5fe82705234370848c47575db7a16437e DIFF: https://github.com/llvm/llvm-project/commit/55985db5fe82705234370848c47575db7a16437e.diff LOG

[Lldb-commits] [lldb] [LLDB] Define _BSD_SOURCE globally, to get optreset available in mingw's getopt.h (PR #76137)

2023-12-21 Thread Saleem Abdulrasool via lldb-commits
@@ -44,6 +44,10 @@ endif() if (WIN32) add_definitions(-D_ENABLE_EXTENDED_ALIGNED_STORAGE) + if (NOT MSVC) compnerd wrote: clang-cl should be detected as MSVC. The define should be generally safe, but it is nice to be more precise and add it when needed.

[Lldb-commits] [clang] [compiler-rt] [clang-tools-extra] [mlir] [libunwind] [libcxxabi] [llvm] [lldb] [libcxx] [flang] [lld] [libc] [asan] Install `pthread_atfork` (PR #75290)

2023-12-21 Thread Rainer Orth via lldb-commits
rorth wrote: > I'll give such a patch a try... That would be something like ``` int internal_fork(void) { // Call syscall directly to avoid pthread_atfork handler processing. // // This is highly unportable on Solaris since syscalls are an implementation // detail subject to change. re

[Lldb-commits] [lldb] [lldb] add support for thread names on Windows (PR #74731)

2023-12-21 Thread David Spickett via lldb-commits
DavidSpickett wrote: Everything passed on Windows (https://lab.llvm.org/buildbot/#/builders/219/builds/7700) and the rest of the lldb specific bots are green. You may get a few more messages as other builders get to it (the Mac ones mainly), if it's a link error with `lldbPluginProcessWindows

[Lldb-commits] [lldb] [LLDB] Define _BSD_SOURCE globally, to get optreset available in mingw's getopt.h (PR #76137)

2023-12-21 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM, bot might fail but only one way to find out. https://github.com/llvm/llvm-project/pull/76137 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [lldb] [LLDB] Define _BSD_SOURCE globally, to get optreset available in mingw's getopt.h (PR #76137)

2023-12-21 Thread David Spickett via lldb-commits
@@ -44,6 +44,10 @@ endif() if (WIN32) add_definitions(-D_ENABLE_EXTENDED_ALIGNED_STORAGE) + if (NOT MSVC) DavidSpickett wrote: Do we want this msvc check? Our Windows on Arm buildbot is using clang-cl, not sure if it'll hit this path. No harm in landing

[Lldb-commits] [lldb] [lldb] add support for thread names on Windows (PR #74731)

2023-12-21 Thread via lldb-commits
oltolm wrote: Thank you David, I didn't see a button for merging the PR. https://github.com/llvm/llvm-project/pull/74731 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] dddb9d1 - [lldb][test] Fix missing-braces warnings in unit tests

2023-12-21 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-12-21T13:36:04Z New Revision: dddb9d1ee3e283133ce1abb50b7c7a3715317b9d URL: https://github.com/llvm/llvm-project/commit/dddb9d1ee3e283133ce1abb50b7c7a3715317b9d DIFF: https://github.com/llvm/llvm-project/commit/dddb9d1ee3e283133ce1abb50b7c7a3715317b9d.diff LOG

[Lldb-commits] [lldb] [lldb] add support for thread names on Windows (PR #74731)

2023-12-21 Thread David Spickett via lldb-commits
DavidSpickett wrote: You'll have email from at least one Linux builder. I believe I've fixed that link error with: https://github.com/llvm/llvm-project/commit/513c2151cd0cddd90af91a6614b15b74b538963e https://github.com/llvm/llvm-project/pull/74731 __

[Lldb-commits] [lldb] 513c215 - [lldb][test] Only link Windows libraries on Windows

2023-12-21 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-12-21T13:11:34Z New Revision: 513c2151cd0cddd90af91a6614b15b74b538963e URL: https://github.com/llvm/llvm-project/commit/513c2151cd0cddd90af91a6614b15b74b538963e DIFF: https://github.com/llvm/llvm-project/commit/513c2151cd0cddd90af91a6614b15b74b538963e.diff LOG

[Lldb-commits] [libcxx] [llvm] [clang] [flang] [mlir] [lld] [clang-tools-extra] [libc] [lldb] [compiler-rt] Don't emit relax relocs like R_X86_64_REX_GOTPCRELX on X86 target for OPENMP internal vars.

2023-12-21 Thread via lldb-commits
https://github.com/UmeshKalappa0 updated https://github.com/llvm/llvm-project/pull/75564 >From 4125e4a709c594562fa6c52f045ba7442e3cb523 Mon Sep 17 00:00:00 2001 From: Umesh Kalappa Date: Fri, 15 Dec 2023 11:52:52 +0530 Subject: [PATCH 1/4] Problem :For Kernel Modules ,emitting the relocs like

[Lldb-commits] [lldb] [lldb] add support for thread names on Windows (PR #74731)

2023-12-21 Thread David Spickett via lldb-commits
DavidSpickett wrote: If you have permissions, once a PR is approved you can click "squash and merge" to land it. I've gone ahead and done that for you in this time. https://github.com/llvm/llvm-project/pull/74731 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [lldb] [lldb] add support for thread names on Windows (PR #74731)

2023-12-21 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/74731 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 95e5839 - [lldb] add support for thread names on Windows (#74731)

2023-12-21 Thread via lldb-commits
Author: oltolm Date: 2023-12-21T12:42:22Z New Revision: 95e5839e06fdffd278499257c6e7679bba3d6868 URL: https://github.com/llvm/llvm-project/commit/95e5839e06fdffd278499257c6e7679bba3d6868 DIFF: https://github.com/llvm/llvm-project/commit/95e5839e06fdffd278499257c6e7679bba3d6868.diff LOG: [lldb]

[Lldb-commits] [lldb] [lldb] add support for thread names on Windows (PR #74731)

2023-12-21 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/74731 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove redundant severity substring within a diagnostic message. (PR #76111)

2023-12-21 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan commented: I'll leave the approval to others, but I left a coding suggestion. It would be a lot nicer if we could tell the producer of those messages to not include the severity, but I think this is way out of scope here. The "severity" inside the message

[Lldb-commits] [lldb] [lldb] Remove redundant severity substring within a diagnostic message. (PR #76111)

2023-12-21 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -48,8 +48,17 @@ std::string DiagnosticManager::GetString(char separator) { std::string ret; for (const auto &diagnostic : Diagnostics()) { -ret.append(StringForSeverity(diagnostic->GetSeverity())); -ret.append(std::string(diagnostic->GetMessage())); +std::st

[Lldb-commits] [lldb] [lldb] Remove redundant severity substring within a diagnostic message. (PR #76111)

2023-12-21 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/76111 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang-tools-extra] [lldb] [compiler-rt] [llvm] [libcxx] [flang] [libc] [clang] [flang] FDATE extension implementation: get date and time in ctime format (PR #71222)

2023-12-21 Thread Yi Wu via lldb-commits
https://github.com/yi-wu-arm updated https://github.com/llvm/llvm-project/pull/71222 >From e0d99fb5baa4231ab351f7fd5abf0a1ffe589547 Mon Sep 17 00:00:00 2001 From: Yi Wu Date: Mon, 6 Nov 2023 19:55:06 + Subject: [PATCH 01/14] FDATE extension implementation: get date and time in ctime format

[Lldb-commits] [lldb] [compiler-rt] [llvm] [libc] [clang] [flang] [libcxx] [clang-tools-extra] [flang] FDATE extension implementation: get date and time in ctime format (PR #71222)

2023-12-21 Thread Yi Wu via lldb-commits
https://github.com/yi-wu-arm updated https://github.com/llvm/llvm-project/pull/71222 >From e0d99fb5baa4231ab351f7fd5abf0a1ffe589547 Mon Sep 17 00:00:00 2001 From: Yi Wu Date: Mon, 6 Nov 2023 19:55:06 + Subject: [PATCH 01/13] FDATE extension implementation: get date and time in ctime format

[Lldb-commits] [openmp] [clang-tools-extra] [libc] [compiler-rt] [clang] [flang] [mlir] [lldb] [libcxx] [llvm] [OpenMP] atomic compare fail : Codegen support (PR #75709)

2023-12-21 Thread via lldb-commits
https://github.com/SunilKuravinakop updated https://github.com/llvm/llvm-project/pull/75709 >From fe931d64741f427629407bca3e68a61bec6f2b67 Mon Sep 17 00:00:00 2001 From: Sunil Kuravinakop Date: Sat, 16 Dec 2023 11:43:35 -0600 Subject: [PATCH 1/3] Adding parameter to fail clause (i.e. memory ord

[Lldb-commits] [clang-tools-extra] [libc] [compiler-rt] [clang] [flang] [mlir] [lldb] [libcxx] [lld] [llvm] Don't emit relax relocs like R_X86_64_REX_GOTPCRELX on X86 target for OPENMP internal vars.

2023-12-21 Thread via lldb-commits
https://github.com/UmeshKalappa0 updated https://github.com/llvm/llvm-project/pull/75564 >From 4125e4a709c594562fa6c52f045ba7442e3cb523 Mon Sep 17 00:00:00 2001 From: Umesh Kalappa Date: Fri, 15 Dec 2023 11:52:52 +0530 Subject: [PATCH 1/4] Problem :For Kernel Modules ,emitting the relocs like

[Lldb-commits] [lldb] [lldb] Add actionable feedback when overwriting a command fails (PR #76030)

2023-12-21 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/76030 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] cf0be7b - [lldb] Add actionable feedback when overwriting a command fails (#76030)

2023-12-21 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2023-12-21T09:04:24-03:00 New Revision: cf0be7b4920cec762639a1f39e8ccf1868e44c40 URL: https://github.com/llvm/llvm-project/commit/cf0be7b4920cec762639a1f39e8ccf1868e44c40 DIFF: https://github.com/llvm/llvm-project/commit/cf0be7b4920cec762639a1f39e8ccf186

[Lldb-commits] [lldb] [compiler-rt] [llvm] [libc] [clang] [flang] [libcxx] [clang-tools-extra] [flang] FDATE extension implementation: get date and time in ctime format (PR #71222)

2023-12-21 Thread Yi Wu via lldb-commits
https://github.com/yi-wu-arm updated https://github.com/llvm/llvm-project/pull/71222 >From e0d99fb5baa4231ab351f7fd5abf0a1ffe589547 Mon Sep 17 00:00:00 2001 From: Yi Wu Date: Mon, 6 Nov 2023 19:55:06 + Subject: [PATCH 01/12] FDATE extension implementation: get date and time in ctime format

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-21 Thread via lldb-commits
oltolm wrote: What happens next with my PR? https://github.com/llvm/llvm-project/pull/74731 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Define _BSD_SOURCE globally, to get optreset available in mingw's getopt.h (PR #76137)

2023-12-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Martin Storsjö (mstorsjo) Changes We previously were defining _BSD_SOURCE right before including getopt.h. However, on mingw-w64, getopt.h is also transitively included by unistd.h, and unistd.h can be transitively included by many headers

[Lldb-commits] [lldb] [LLDB] Define _BSD_SOURCE globally, to get optreset available in mingw's getopt.h (PR #76137)

2023-12-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-platform-windows Author: Martin Storsjö (mstorsjo) Changes We previously were defining _BSD_SOURCE right before including getopt.h. However, on mingw-w64, getopt.h is also transitively included by unistd.h, and unistd.h can be transitively included by

[Lldb-commits] [lldb] [LLDB] Define _BSD_SOURCE globally, to get optreset available in mingw's getopt.h (PR #76137)

2023-12-21 Thread Martin Storsjö via lldb-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/76137 We previously were defining _BSD_SOURCE right before including getopt.h. However, on mingw-w64, getopt.h is also transitively included by unistd.h, and unistd.h can be transitively included by many headers (rec

[Lldb-commits] [lldb] [lldb] Fix MaxSummaryLength target property type (PR #72233)

2023-12-21 Thread Michael Buch via lldb-commits
Michael137 wrote: @dancing-leaves are you still planning to add tests for this so we can land this? Would be great to get this in https://github.com/llvm/llvm-project/pull/72233 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l