Author: Kazu Hirata
Date: 2023-12-16T15:02:15-08:00
New Revision: ee667db4b83eb6171bbceca1010cddd0da6f17ca
URL:
https://github.com/llvm/llvm-project/commit/ee667db4b83eb6171bbceca1010cddd0da6f17ca
DIFF:
https://github.com/llvm/llvm-project/commit/ee667db4b83eb6171bbceca1010cddd0da6f17ca.diff
L
Author: Kazu Hirata
Date: 2023-12-16T14:39:37-08:00
New Revision: 744f38913fa380580431df0ae89ef5fb3df30240
URL:
https://github.com/llvm/llvm-project/commit/744f38913fa380580431df0ae89ef5fb3df30240
DIFF:
https://github.com/llvm/llvm-project/commit/744f38913fa380580431df0ae89ef5fb3df30240.diff
L
H-G-Hristov wrote:
Thank you for noticing. Somehow what should have been ignored snuck in back
again.
https://github.com/llvm/llvm-project/pull/74994
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
https://github.com/H-G-Hristov updated
https://github.com/llvm/llvm-project/pull/74994
>From 6e26ca239c49e1b7d9ab72217db7339e92df163f Mon Sep 17 00:00:00 2001
From: Zingam
Date: Sun, 10 Dec 2023 14:16:02 +0200
Subject: [PATCH 01/14] [libc++][span] P2821R5: span.at()
---
libcxx/include/span
antoniofrighetto wrote:
Could you kindly squash everything into one commit and provide a meaningful git
commit title and git message description? For example:
```
[clang][Parse] `TryAnnotateCXXScopeToken` to be called only when parsing C++
Assume `TryAnnotateCXXScopeToken` to be parsing C++ cod
@@ -0,0 +1,145 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/mordante edited
https://github.com/llvm/llvm-project/pull/66963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mordante commented:
Thanks for your patch!
I mainly glossed over the patch, and left some comments.
https://github.com/llvm/llvm-project/pull/66963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
@@ -0,0 +1,145 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
mordante wrote:
What is this submodule? I assume it's not intended to be here.
https://github.com/llvm/llvm-project/pull/74994
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/mordante edited
https://github.com/llvm/llvm-project/pull/74994
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mordante requested changes to this pull request.
Mostly looks good, a few comments.
https://github.com/llvm/llvm-project/pull/74994
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
@@ -0,0 +1,170 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -343,6 +347,15 @@ public:
return __data_[__idx];
}
+# if _LIBCPP_STD_VER >= 26
+_LIBCPP_HIDE_FROM_ABI constexpr reference at(size_type __idx) const {
mordante wrote:
Nevermind this only applies to non-member functions and classes themselve
ChipsSpectre wrote:
@cor3ntin could you please give your review?
@shafik or would you have time to do this?
The fix is ready to be merged, and all review comments are addressed.
https://github.com/llvm/llvm-project/pull/74926
___
lldb-commits mailing
15 matches
Mail list logo