[Lldb-commits] [lldb] [clang] fixing issue #64441 (PR #74814)

2023-12-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 58bdef2be75263a9b6bf93faf3baccc76e31e082 c137cd0ba81f82dbca2feb01bb8d088e42f0c524 --

[Lldb-commits] [lldb] [clang] fixing issue #64441 (PR #74814)

2023-12-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-lldb Author: Jeevan Ghimire (jeevanghimire) Changes removing using namespace std; and assigning the fully qualified name for better naming in codebase --- Full diff: https://github.com/llvm/llvm-project/pull/74814.diff 2 F

[Lldb-commits] [lldb] [clang] fixing issue #64441 (PR #74814)

2023-12-07 Thread Jeevan Ghimire via lldb-commits
https://github.com/jeevanghimire created https://github.com/llvm/llvm-project/pull/74814 removing using namespace std; and assigning the fully qualified name for better naming in codebase >From c137cd0ba81f82dbca2feb01bb8d088e42f0c524 Mon Sep 17 00:00:00 2001 From: Jeevan Ghimire Date: Fri,

[Lldb-commits] [lldb] [lldb][Symbol] Make sure we decrement PC before checking location list (PR #74772)

2023-12-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/74772 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 58bdef2 - [lldb][Symbol] Make sure we decrement PC before checking location list (#74772)

2023-12-07 Thread via lldb-commits
Author: Michael Buch Date: 2023-12-08T07:32:23Z New Revision: 58bdef2be75263a9b6bf93faf3baccc76e31e082 URL: https://github.com/llvm/llvm-project/commit/58bdef2be75263a9b6bf93faf3baccc76e31e082 DIFF: https://github.com/llvm/llvm-project/commit/58bdef2be75263a9b6bf93faf3baccc76e31e082.diff LOG:

[Lldb-commits] [lldb] [lldb-dap] Implement quiet commands (PR #74808)

2023-12-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Erquinigo (walter-erquinigo) Changes This adds support for optionally prefixing any command with `?`, which effectively prevents the output of these commands to be printed to the console unless they fail. This comes handy when progr

[Lldb-commits] [lldb] [lldb-dap] Implement quiet commands (PR #74808)

2023-12-07 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/74808 This adds support for optionally prefixing any command with `?`, which effectively prevents the output of these commands to be printed to the console unless they fail. This comes handy when programmatic

[Lldb-commits] [lldb] [lldb-dap] Introduce the new privateConfiguration setting (PR #74748)

2023-12-07 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/74748 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Introduce the new privateConfiguration setting (PR #74748)

2023-12-07 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: Closing this because I'm going to change my approach after talking to Greg. https://github.com/llvm/llvm-project/pull/74748 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [llvm] [libcxxabi] [lldb] [compiler-rt] [clang-tools-extra] [clang] [openmp] [flang] [mlir] [libcxx] [MachineCopyPropagation] When the source of PreviousCopy is undef, we cannot replace

2023-12-07 Thread via lldb-commits
DianQK wrote: > Hello. I think that if you removed undef from the first instruction the > result would still be incorrect. With: > > ``` > $x8 = ORRXrs $xzr, $x0, 0, implicit $w0 > $w8 = ORRWrs $wzr, $w0, 0, implicit-def $x8 > ``` I'm also curious about it, but this transformation has been aro

[Lldb-commits] [lldb] [lldb] Return index of element in ValueObject path instead of the element's value (PR #74413)

2023-12-07 Thread Pete Lawrence via lldb-commits
https://github.com/PortalPete updated https://github.com/llvm/llvm-project/pull/74413 >From 5731517e6453f9fc72577531bc3e2f745a8b9ca3 Mon Sep 17 00:00:00 2001 From: Pete Lawrence Date: Mon, 4 Dec 2023 18:29:37 -1000 Subject: [PATCH] [lldb] Return index of element in ValueObject path instead of

[Lldb-commits] [lldb] [lldb] Return index of element in ValueObject path instead of the element's value (PR #74413)

2023-12-07 Thread Pete Lawrence via lldb-commits
@@ -414,13 +417,17 @@ lldb::ValueObjectSP ValueObject::GetChildAtIndexPath( if (idxs.size() == 0) return GetSP(); ValueObjectSP root(GetSP()); + + size_t current_index = 0; for (std::pair idx : idxs) { root = root->GetChildAtIndex(idx.first, idx.second); i

[Lldb-commits] [lldb] [lldb] Return index of element in ValueObject path instead of the element's value (PR #74413)

2023-12-07 Thread Pete Lawrence via lldb-commits
PortalPete wrote: > I can see why the mistake was made, we have an index into a list of different > indexes? Anyway, please add a test for this. I'm not really sure there's a good way to test this there doesn't appear to be anything that calls these methods, let alone an SB API. CC @adrian-pr

[Lldb-commits] [lldb] [lldb][NFC] Simplify DWARRFDeclContext::GetQualifiedName (PR #74788)

2023-12-07 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/74788 >From c10c3f03383cf8015ce014330f40d9089ff64fcf Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Thu, 7 Dec 2023 15:45:05 -0800 Subject: [PATCH] [lldb][NFC] Simplify DWARRFDeclContext::GetQua

[Lldb-commits] [lldb] [lldb][progress] Add discrete boolean flag to progress reports (PR #69516)

2023-12-07 Thread Chelsea Cassanova via lldb-commits
@@ -2225,7 +2225,8 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) { const char *file_name = file.GetFilename().AsCString(""); LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name); LLDB_LOG(log, "Parsing symbol table for {0}", file_name); - P

[Lldb-commits] [flang] [openmp] [compiler-rt] [libc] [lld] [lldb] [clang-tools-extra] [libcxx] [clang] [mlir] [llvm] [libcxxabi] [libc++] Fix `take_view::__sentinel`'s `operator==` (PR #74655)

2023-12-07 Thread Jakub Mazurkiewicz via lldb-commits
https://github.com/JMazurkiewicz updated https://github.com/llvm/llvm-project/pull/74655 >From b3de573887cdd86fd6ce168bdcc6d729d73b13b2 Mon Sep 17 00:00:00 2001 From: Jakub Mazurkiewicz Date: Wed, 6 Dec 2023 14:03:51 +0100 Subject: [PATCH 01/11] [libc++] Fix `take_view::__sentinel`'s `operator=

[Lldb-commits] [lldb] [lldb][NFC] Simplify DWARRFDeclContext::GetQualifiedName (PR #74788)

2023-12-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7003e255d3f1fbff3b2ef3052d478b65ec555963 89c88d156170e5c8287d8a8236cfaf3e1ec2d1cf --

[Lldb-commits] [lldb] [lldb][NFC] Simplify DWARRFDeclContext::GetQualifiedName (PR #74788)

2023-12-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes This commit factors out the logic building each component of a qualified name into its own function so that it may be reused by a future commit, while also simplifying the logic of assemb

[Lldb-commits] [lldb] [lldb][NFC] Simplify DWARRFDeclContext::GetQualifiedName (PR #74788)

2023-12-07 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/74788 This commit factors out the logic building each component of a qualified name into its own function so that it may be reused by a future commit, while also simplifying the logic of assembling these pieces

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 42bba97fc24f045f593fc26f998bac9b08633255...5adebf6f6068ef1eb8e5a4dbb02a52d8c21b1b3c lldb/

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-07 Thread Greg Clayton via lldb-commits
clayborg wrote: @adrian-prantl This patch is exactly the same as it was back when you accepted it in Phabricator with two things added: - fixes for -gsimple-template-names - updated the new `SBType::FindDirectNestedType(...)` All tests pass on macOS. https://github.com/llvm/llvm-project/pull/7

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Greg Clayton (clayborg) Changes This patch revives the effort to get this Phabricator patch into upstream: https://reviews.llvm.org/D137900 This patch was accepted before in Phabricator but I found some -gsimple-template-names issues that

[Lldb-commits] [lldb] [lldb][Symbol] Make sure we decrement PC before checking location list (PR #74772)

2023-12-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/74772 >From 2352f67789c04f86c8a0f7ad8940d782288750b8 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 7 Dec 2023 21:35:41 + Subject: [PATCH 1/4] [lldb][Symbol] Make sure we decrement PC before checking lo

[Lldb-commits] [lldb] [lldb][Symbol] Make sure we decrement PC before checking location list (PR #74772)

2023-12-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/74772 >From 2352f67789c04f86c8a0f7ad8940d782288750b8 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 7 Dec 2023 21:35:41 + Subject: [PATCH 1/3] [lldb][Symbol] Make sure we decrement PC before checking lo

[Lldb-commits] [lldb] [lldb][Symbol] Make sure we decrement PC before checking location list (PR #74772)

2023-12-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/74772 >From 2352f67789c04f86c8a0f7ad8940d782288750b8 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 7 Dec 2023 21:35:41 + Subject: [PATCH 1/2] [lldb][Symbol] Make sure we decrement PC before checking lo

[Lldb-commits] [lldb] [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (PR #74773)

2023-12-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/74773 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Symbol] Make sure we decrement PC before checking location list (PR #74772)

2023-12-07 Thread Michael Buch via lldb-commits
Michael137 wrote: > This looks good to me. Do you think we take the frame variable test in > API/functionalities/location-list-lookup/TestLocationListLookup.py and add it > to your test? They're testing the same thing, and getting there the same way > so I'm not sure there's value to having th

[Lldb-commits] [lldb] [lldb][Symbol] Make sure we decrement PC before checking location list (PR #74772)

2023-12-07 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. This looks good to me. Do you think we take the frame variable test in API/functionalities/location-list-lookup/TestLocationListLookup.py and add it to your test? They're testing the same thing, and getting there the same way so I'm

[Lldb-commits] [lldb] [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (PR #74773)

2023-12-07 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/74773 >From 9f38564875620a44a982a50492d87ee431baffcd Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Thu, 7 Dec 2023 13:41:44 -0800 Subject: [PATCH 1/2] [SymbolFileDWARF][NFC] Remove duplicated c

[Lldb-commits] [lldb] Fix a stall in running `quit` while a live process is running (PR #74687)

2023-12-07 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/74687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9d3aec5 - Fix a stall in running `quit` while a live process is running (#74687)

2023-12-07 Thread via lldb-commits
Author: jimingham Date: 2023-12-07T14:36:27-08:00 New Revision: 9d3aec5535adfdeb10a400e92cecc1cc0a5e26a6 URL: https://github.com/llvm/llvm-project/commit/9d3aec5535adfdeb10a400e92cecc1cc0a5e26a6 DIFF: https://github.com/llvm/llvm-project/commit/9d3aec5535adfdeb10a400e92cecc1cc0a5e26a6.diff LOG

[Lldb-commits] [lldb] Fix a stall in running `quit` while a live process is running (PR #74687)

2023-12-07 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/74687 >From 64505f573341c16a62eda786c4710d3a7233cecc Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Wed, 6 Dec 2023 17:01:06 -0800 Subject: [PATCH 1/3] We need to generate events when finalizing, or we won't know t

[Lldb-commits] [libcxx] [llvm] [lldb] [lld] [clang-tools-extra] [flang] [compiler-rt] [libcxxabi] [clang] [mlir] [libc] [openmp] [libc++] Fix `take_view::__sentinel`'s `operator==` (PR #74655)

2023-12-07 Thread Jakub Mazurkiewicz via lldb-commits
@@ -183,7 +183,7 @@ class take_view<_View>::__sentinel { template requires sentinel_for, iterator_t<__maybe_const<_OtherConst, _View>>> _LIBCPP_HIDE_FROM_ABI - friend constexpr bool operator==(const _Iter<_Const>& __lhs, const __sentinel& __rhs) { + friend constexpr

[Lldb-commits] [lldb] [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (PR #74773)

2023-12-07 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -2947,29 +2951,18 @@ TypeSP SymbolFileDWARF::FindCompleteObjCDefinitionTypeForDIE( m_index->GetCompleteObjCClass( type_name, must_be_implementation, [&](DWARFDIE type_die) { -bool try_resolving_type = false; - // Don't try and resolve the DIE we ar

[Lldb-commits] [lldb] [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (PR #74773)

2023-12-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/74773 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (PR #74773)

2023-12-07 Thread Michael Buch via lldb-commits
@@ -2947,29 +2951,18 @@ TypeSP SymbolFileDWARF::FindCompleteObjCDefinitionTypeForDIE( m_index->GetCompleteObjCClass( type_name, must_be_implementation, [&](DWARFDIE type_die) { -bool try_resolving_type = false; - // Don't try and resolve the DIE we ar

[Lldb-commits] [lldb] [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (PR #74773)

2023-12-07 Thread Michael Buch via lldb-commits
@@ -3128,36 +3121,11 @@ SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(const DWARFDIE &die) { if (type_system && !type_system->SupportsLanguage(GetLanguage(*type_die.GetCU( return true; - bool try_resolving_type = false; - // Don

[Lldb-commits] [lldb] [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (PR #74773)

2023-12-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes There was duplicated (and complex) code querying whether tags were type-like tags (i.e. class or struct); this has been factored out into a helper function. There was also a comment about

[Lldb-commits] [lldb] [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (PR #74773)

2023-12-07 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/74773 There was duplicated (and complex) code querying whether tags were type-like tags (i.e. class or struct); this has been factored out into a helper function. There was also a comment about not comparing id

[Lldb-commits] [lldb] [lldb][Symbol] Make sure we decrement PC before checking location list (PR #74772)

2023-12-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/74772 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Symbol] Make sure we decrement PC before checking location list (PR #74772)

2023-12-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/74772 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Symbol] Make sure we decrement PC before checking location list (PR #74772)

2023-12-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes In optimized code we can end up with return address being the next instruction in a different block. If we are dealing with location lists, we want to decrement the PC value so it's within the calling bloc

[Lldb-commits] [lldb] [lldb][Symbol] Make sure we decrement PC before checking location list (PR #74772)

2023-12-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/74772 In optimized code we can end up with return address being the next instruction in a different block. If we are dealing with location lists, we want to decrement the PC value so it's within the calling block r

[Lldb-commits] [lldb] [lldb][progress] Add discrete boolean flag to progress reports (PR #69516)

2023-12-07 Thread Chelsea Cassanova via lldb-commits
@@ -2225,7 +2225,8 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) { const char *file_name = file.GetFilename().AsCString(""); LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name); LLDB_LOG(log, "Parsing symbol table for {0}", file_name); - P

[Lldb-commits] [mlir] [lldb] [libc] [clang-tools-extra] [flang] [llvm] [libcxxabi] [openmp] [lld] [compiler-rt] [libcxx] [clang] [libc++] Fix `take_view::__sentinel`'s `operator==` (PR #74655)

2023-12-07 Thread via lldb-commits
https://github.com/huixie90 edited https://github.com/llvm/llvm-project/pull/74655 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [llvm] [compiler-rt] [mlir] [lld] [clang-tools-extra] [openmp] [flang] [libcxxabi] [libcxx] [libc] [clang] [lldb] [libc++] Fix `take_view::__sentinel`'s `operator==` (PR #74655)

2023-12-07 Thread via lldb-commits
https://github.com/huixie90 edited https://github.com/llvm/llvm-project/pull/74655 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [clang-tools-extra] [libcxxabi] [openmp] [libc] [mlir] [flang] [lldb] [compiler-rt] [libcxx] [clang] [llvm] [libc++] Fix `take_view::__sentinel`'s `operator==` (PR #74655)

2023-12-07 Thread via lldb-commits
@@ -183,7 +183,7 @@ class take_view<_View>::__sentinel { template requires sentinel_for, iterator_t<__maybe_const<_OtherConst, _View>>> _LIBCPP_HIDE_FROM_ABI - friend constexpr bool operator==(const _Iter<_Const>& __lhs, const __sentinel& __rhs) { + friend constexpr

[Lldb-commits] [lldb] [compiler-rt] [lld] [libcxxabi] [clang-tools-extra] [llvm] [libc] [libcxx] [flang] [mlir] [clang] [openmp] [libc++] Fix `take_view::__sentinel`'s `operator==` (PR #74655)

2023-12-07 Thread via lldb-commits
https://github.com/huixie90 approved this pull request. LGTM with green CI https://github.com/llvm/llvm-project/pull/74655 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Introduce the new privateConfiguration setting (PR #74748)

2023-12-07 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: @clayborg , the main issue is to allow users to use the regular initCommands and at the same time have another way for the vscode extension to issue their own initCommands and control the output of these specific commands without interfering with the initCommands provid

[Lldb-commits] [lldb] Fix a stall in running `quit` while a live process is running (PR #74687)

2023-12-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: The change itself LGTM, but I'd like to either have an inline comment (e.g. `Finalize(/*destructing=*/false)) `or use an enum value to convey the meaning of those values. https://github.com/llvm/llvm-project/pull/74687

[Lldb-commits] [lldb] Fix a stall in running `quit` while a live process is running (PR #74687)

2023-12-07 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/74687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [clang] [flang] [compiler-rt] [llvm] [clang-tools-extra] [libcxxabi] [lldb] [mlir] [openmp] [MachineCopyPropagation] When the source of PreviousCopy is undef, we cannot replace

2023-12-07 Thread David Green via lldb-commits
davemgreen wrote: Hello. I think that if you removed undef from the first instruction the result would still be incorrect. With: ``` $x8 = ORRXrs $xzr, $x0, 0, implicit $w0 $w8 = ORRWrs $wzr, $w0, 0, implicit-def $x8 ``` The second instruction will zero-extend the w0 register to x8. It would be

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-07 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: Sounds like there is good reason for linking in the kernel32.dll, so code looks good to me. A windows only test that creates a thread with a known name would be great to add where we verify the name is correct. https://github.com/llvm/llvm-project/pull/74

[Lldb-commits] [llvm] [lldb] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-12-07 Thread Kevin Frei via lldb-commits
kevinfrei wrote: > Sounds like some configs don't create `LLVMDebuginfod` target possibly > because it isn't enabled. Is there a cmake option to disable `LLVMDebuginfod` > or some magic in the Cmake config file for this target? Nothing that I could find. The library is written such that if the

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-07 Thread via lldb-commits
https://github.com/Fulgen301 edited https://github.com/llvm/llvm-project/pull/74731 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-07 Thread via lldb-commits
@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() { return Status(); } + +const char *TargetThreadWindows::GetName() { + Log *log = GetLog(LLDBLog::Thread); + HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll"); + if (hModule) { +auto GetThreadDescription = +

[Lldb-commits] [llvm] [lldb] [lldb] Rename lldb-vscode to lldb-dap (PR #69264)

2023-12-07 Thread Greg Clayton via lldb-commits
clayborg wrote: > > @JDevlieghere Can you delete the `llvm-project/lldb/tools/lldb-vscode` > > directory from git after this commit to clean up our codebase? There are > > still two copies of the `lldb-dap` code in the sources: > > ``` > > lldb/tools/lldb-dap > > lldb/tools/lldb-vscode > > ```

[Lldb-commits] [lldb] [lldb-dap] Introduce the new privateConfiguration setting (PR #74748)

2023-12-07 Thread Greg Clayton via lldb-commits
clayborg wrote: Another idea would be to add a command that allows users to specify the console to log LLDB commands from `*Commands` settings by allowing them to specify a console. From the DAP spec we have: ``` /** * The output category. If not specified or if the category is not *

[Lldb-commits] [libcxxabi] [libc] [clang] [clang-tools-extra] [lld] [openmp] [compiler-rt] [libcxx] [flang] [lldb] [mlir] [llvm] [libc++] Fix `take_view::__sentinel`'s `operator==` (PR #74655)

2023-12-07 Thread Jakub Mazurkiewicz via lldb-commits
https://github.com/JMazurkiewicz updated https://github.com/llvm/llvm-project/pull/74655 >From b3de573887cdd86fd6ce168bdcc6d729d73b13b2 Mon Sep 17 00:00:00 2001 From: Jakub Mazurkiewicz Date: Wed, 6 Dec 2023 14:03:51 +0100 Subject: [PATCH 01/10] [libc++] Fix `take_view::__sentinel`'s `operator=

[Lldb-commits] [lldb] [lldb-dap] Introduce the new privateConfiguration setting (PR #74748)

2023-12-07 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: I am not a fan of making a whole extra duplication of "initCommands" just to make these commands not show up in the debug console. Wouldn't a setting like: ``` "showCommandsInDebugConsole": ["always", "error-only", "never"] ``` Would this achieve the sam

[Lldb-commits] [llvm] [clang-tools-extra] [mlir] [lldb] [clang] [libcxx] [compiler-rt] [flang] [libc] [openmp] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

2023-12-07 Thread via lldb-commits
@@ -0,0 +1,21 @@ +.. title:: clang-tidy - performance-move-smart-pointer-contents + +performance-move-smart-pointer-contents +=== + +Recommends avoiding moving out of a smart pointer when moving the pointer is +cheaper. + +Given a smart pointer

[Lldb-commits] [openmp] [clang-tools-extra] [libc] [llvm] [libcxx] [lldb] [flang] [clang] [compiler-rt] [mlir] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

2023-12-07 Thread via lldb-commits
@@ -0,0 +1,21 @@ +.. title:: clang-tidy - performance-move-smart-pointer-contents + +performance-move-smart-pointer-contents +=== + +Recommends avoiding moving out of a smart pointer when moving the pointer is EugeneZelenko wrot

[Lldb-commits] [clang-tools-extra] [llvm] [libcxx] [lldb] [flang] [clang] [compiler-rt] [libcxxabi] [lld] [AMDGPU] GFX12: select @llvm.prefetch intrinsic (PR #74576)

2023-12-07 Thread Stanislav Mekhanoshin via lldb-commits
@@ -959,6 +967,32 @@ def : GCNPat < } } // let OtherPredicates = [HasShaderCyclesRegister] +def SIMM24bitPtr : ImmLeaf (Imm);}] +>; + +multiclass SMPrefetchPat { + def : GCNPat < +(smrd_prefetch (SMRDImm i64:$sbase, i32:$offset), timm, timm, (i32 cache_type)), +(!cas

[Lldb-commits] [llvm] [lldb] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-12-07 Thread Greg Clayton via lldb-commits
clayborg wrote: Sounds like some configs don't create `LLVMDebuginfod` target possibly because it isn't enabled. Is there a cmake option to disable `LLVMDebuginfod` or some magic in the Cmake config file for this target? https://github.com/llvm/llvm-project/pull/70996 _

[Lldb-commits] [lldb] [lldb-dap] Introduce the new privateConfiguration setting (PR #74748)

2023-12-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Erquinigo (walter-erquinigo) Changes There are some typescript vscode extensions that are effectively wrappers of lldb-dap, and they commonly configure the debug adapter in particular ways using initCommands, among other settings. A

[Lldb-commits] [compiler-rt] [libcxx] [libc] [flang] [llvm] [clang-tools-extra] [lldb] [mlir] [clang] [openmp] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

2023-12-07 Thread via lldb-commits
pizzud wrote: I've been kind of leaving this in limbo while we sort out the shared_ptr one and I agree it probably makes more sense to make bugprone-unique-pointer-move as a parallel to shared-pointer in [PR #67467](https://github.com/llvm/llvm-project/pull/67467) and consider performance-hea

[Lldb-commits] [llvm] [clang-tools-extra] [mlir] [lldb] [clang] [libcxx] [compiler-rt] [flang] [libc] [openmp] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

2023-12-07 Thread via lldb-commits
https://github.com/pizzud closed https://github.com/llvm/llvm-project/pull/66139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Introduce the new privateConfiguration setting (PR #74748)

2023-12-07 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/74748 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Introduce the new privateConfiguration setting (PR #74748)

2023-12-07 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/74748 >From 07bd16ac9bbc4f9868d1b541e003aa95bf6ae8be Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Wed, 29 Nov 2023 18:12:54 -0500 Subject: [PATCH] [lldb-dap] Introduce the new privateConfiguration set

[Lldb-commits] [llvm] [libcxxabi] [clang-tools-extra] [lldb] [clang] [lld] [compiler-rt] [flang] [libcxx] [AMDGPU] GFX12: select @llvm.prefetch intrinsic (PR #74576)

2023-12-07 Thread Jay Foad via lldb-commits
@@ -959,6 +967,32 @@ def : GCNPat < } } // let OtherPredicates = [HasShaderCyclesRegister] +def SIMM24bitPtr : ImmLeaf (Imm);}] +>; + +multiclass SMPrefetchPat { + def : GCNPat < +(smrd_prefetch (SMRDImm i64:$sbase, i32:$offset), timm, timm, (i32 cache_type)), +(!cas

[Lldb-commits] [lldb] [lldb-dap] Introduce the new privateConfiguration setting (PR #74748)

2023-12-07 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/74748 There are some typescript vscode extensions that are effectively wrappers of lldb-dap, and they commonly configure the debug adapter in particular ways using initCommands, among other settings. An unfor

[Lldb-commits] [llvm] [lldb] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-12-07 Thread Kevin Frei via lldb-commits
kevinfrei wrote: > > This change broke building against LLVM dylib: > > ``` > > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: > > cannot find -lLLVMDebuginfod: No such file or directory > > collect2: error: ld returned 1 exit status > > samu: subcommand failed > > `

[Lldb-commits] [llvm] [lldb] [lldb] Rename lldb-vscode to lldb-dap (PR #69264)

2023-12-07 Thread Alex Langford via lldb-commits
bulbazord wrote: > @JDevlieghere Can you delete the `llvm-project/lldb/tools/lldb-vscode` > directory from git after this commit to clean up our codebase? There are > still two copies of the `lldb-dap` code in the sources: > > ``` > lldb/tools/lldb-dap > lldb/tools/lldb-vscode > ``` > > I wor

[Lldb-commits] [lldb] Fix a stall in running `quit` while a live process is running (PR #74687)

2023-12-07 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/74687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a stall in running `quit` while a live process is running (PR #74687)

2023-12-07 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/74687 >From 64505f573341c16a62eda786c4710d3a7233cecc Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Wed, 6 Dec 2023 17:01:06 -0800 Subject: [PATCH 1/2] We need to generate events when finalizing, or we won't know t

[Lldb-commits] [compiler-rt] [libcxxabi] [libcxx] [lld] [flang] [llvm] [clang-tools-extra] [lldb] [clang] [AMDGPU] GFX12: select @llvm.prefetch intrinsic (PR #74576)

2023-12-07 Thread Stanislav Mekhanoshin via lldb-commits
@@ -959,6 +967,32 @@ def : GCNPat < } } // let OtherPredicates = [HasShaderCyclesRegister] +def SIMM24bitPtr : ImmLeaf (Imm);}] +>; + +multiclass SMPrefetchPat { + def : GCNPat < +(smrd_prefetch (SMRDImm i64:$sbase, i32:$offset), timm, timm, (i32 cache_type)), +(!cas

[Lldb-commits] [llvm] [lldb] [lldb] Rename lldb-vscode to lldb-dap (PR #69264)

2023-12-07 Thread Greg Clayton via lldb-commits
clayborg wrote: @JDevlieghere Can you delete the `llvm-project/lldb/tools/lldb-vscode` directory from git after this commit to clean up our codebase? There are still two copies of the `lldb-dap` code in the sources: ``` lldb/tools/lldb-dap lldb/tools/lldb-vscode ``` I worry someone might make P

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: The implementation looks fine to me. Can you write a test? https://github.com/llvm/llvm-project/pull/74731 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-07 Thread Greg Clayton via lldb-commits
@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() { return Status(); } + +const char *TargetThreadWindows::GetName() { + Log *log = GetLog(LLDBLog::Thread); + HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll"); + if (hModule) { +auto GetThreadDescription = +

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-07 Thread Greg Clayton via lldb-commits
@@ -33,6 +34,9 @@ using namespace lldb; using namespace lldb_private; +using GetThreadDescriptionFunctionPtr = HRESULT +WINAPI (*)(HANDLE hThread, PWSTR *ppszThreadDescription); + clayborg wrote: Can we just `#include ` and avoid manually declaring a functio

[Lldb-commits] [lldb] Fix a stall in running `quit` while a live process is running (PR #74687)

2023-12-07 Thread Alex Langford via lldb-commits
@@ -558,7 +558,10 @@ class Process : public std::enable_shared_from_this, /// /// Subclasses that override this method should always call this superclass /// method. - virtual void Finalize(); + /// If you are running Finalize in your Process subclass Destructor, pass

[Lldb-commits] [lldb] Fix a stall in running `quit` while a live process is running (PR #74687)

2023-12-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM, small typo https://github.com/llvm/llvm-project/pull/74687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a stall in running `quit` while a live process is running (PR #74687)

2023-12-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/74687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libc] [openmp] [lldb] [llvm] [flang] [compiler-rt] [lld] [mlir] [libcxx] [clang] [clang-tools-extra] [libcxxabi] [libc++] Fix `take_view::__sentinel`'s `operator==` (PR #74655)

2023-12-07 Thread Jakub Mazurkiewicz via lldb-commits
https://github.com/JMazurkiewicz updated https://github.com/llvm/llvm-project/pull/74655 >From b3de573887cdd86fd6ce168bdcc6d729d73b13b2 Mon Sep 17 00:00:00 2001 From: Jakub Mazurkiewicz Date: Wed, 6 Dec 2023 14:03:51 +0100 Subject: [PATCH 01/10] [libc++] Fix `take_view::__sentinel`'s `operator=

[Lldb-commits] [compiler-rt] [lldb] [libcxx] [clang-tools-extra] [clang] [flang] [llvm] [libc] [flang] FDATE extension implementation: get date and time in ctime format (PR #71222)

2023-12-07 Thread Yi Wu via lldb-commits
https://github.com/yi-wu-arm updated https://github.com/llvm/llvm-project/pull/71222 >From e0d99fb5baa4231ab351f7fd5abf0a1ffe589547 Mon Sep 17 00:00:00 2001 From: Yi Wu Date: Mon, 6 Nov 2023 19:55:06 + Subject: [PATCH 01/11] FDATE extension implementation: get date and time in ctime format

[Lldb-commits] [libc] [clang-tools-extra] [flang] [libcxx] [llvm] [clang] [lldb] [compiler-rt] [flang] FDATE extension implementation: get date and time in ctime format (PR #71222)

2023-12-07 Thread Yi Wu via lldb-commits
https://github.com/yi-wu-arm updated https://github.com/llvm/llvm-project/pull/71222 >From e0d99fb5baa4231ab351f7fd5abf0a1ffe589547 Mon Sep 17 00:00:00 2001 From: Yi Wu Date: Mon, 6 Nov 2023 19:55:06 + Subject: [PATCH 01/10] FDATE extension implementation: get date and time in ctime format

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup with a regex pattern (PR #69422)

2023-12-07 Thread Jonas Devlieghere via lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>, =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?=

[Lldb-commits] [lld] [libc] [mlir] [openmp] [llvm] [libcxxabi] [flang] [lldb] [libcxx] [clang-tools-extra] [clang] [compiler-rt] [libc++] Fix `take_view::__sentinel`'s `operator==` (PR #74655)

2023-12-07 Thread Jakub Mazurkiewicz via lldb-commits
https://github.com/JMazurkiewicz updated https://github.com/llvm/llvm-project/pull/74655 >From b3de573887cdd86fd6ce168bdcc6d729d73b13b2 Mon Sep 17 00:00:00 2001 From: Jakub Mazurkiewicz Date: Wed, 6 Dec 2023 14:03:51 +0100 Subject: [PATCH 1/9] [libc++] Fix `take_view::__sentinel`'s `operator==`

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup with a regex pattern (PR #69422)

2023-12-07 Thread José Lira Junior via lldb-commits
junior-jl wrote: > > I tried this now and I guess it's not correct. For example, if I have a > > prefix (red color) and no suffix, the text does not go back to normal and > > will be forever red. Or am I doing something wrong? > > This is expected. We don't expect many people to do this but if

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup with a regex pattern (PR #69422)

2023-12-07 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl updated https://github.com/llvm/llvm-project/pull/69422 From c416443a93f7113a7f57d337682ec4862438522d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?= Date: Tue, 7 Nov 2023 16:57:18 -0300 Subject: [PATCH 01/10] [lldb] colorize symbols in image lo

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-07 Thread via lldb-commits
https://github.com/oltolm updated https://github.com/llvm/llvm-project/pull/74731 >From 9383b8b92849c71a96b4b4e7e55f615d8f2efedb Mon Sep 17 00:00:00 2001 From: oltolm Date: Fri, 1 Dec 2023 16:49:13 +0100 Subject: [PATCH] lldb: add support for thread names on Windows --- .../Windows/Common/Tar

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff dfd36aa70ec1cff0529272b00f6c6a81bf0cc49c b9accfb579b6d2718ad12ee55dacf38257693d56 --

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: oltolm (oltolm) Changes This PR adds support for thread names in lldb on Windows. ``` (lldb) thr list Process 2960 stopped thread #53: tid = 0x03a0, 0x7ff84582db34 ntdll.dll`NtWaitForMultipleObjects + 20 thread #29: tid = 0x04ec, 0

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-07 Thread via lldb-commits
https://github.com/oltolm created https://github.com/llvm/llvm-project/pull/74731 This PR adds support for thread names in lldb on Windows. ``` (lldb) thr list Process 2960 stopped thread #53: tid = 0x03a0, 0x7ff84582db34 ntdll.dll`NtWaitForMultipleObjects + 20 thread #29: tid = 0x04ec

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-12-07 Thread via lldb-commits
cmtice wrote: I've removed the Smart pointer functions from this PR. Are there any other changes that I need to make? If not, could someone approve this? https://github.com/llvm/llvm-project/pull/73472 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup with a regex pattern (PR #69422)

2023-12-07 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>, =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Re

[Lldb-commits] [libcxx] [llvm] [flang] [compiler-rt] [clang-tools-extra] [openmp] [libcxxabi] [lldb] [clang] [mlir] [MachineCopyPropagation] When the source of PreviousCopy is undef, we cannot replace

2023-12-07 Thread via lldb-commits
https://github.com/DianQK updated https://github.com/llvm/llvm-project/pull/74682 >From 5a5ade3a10fef4d50bb73de5a42a07011fbdba63 Mon Sep 17 00:00:00 2001 From: DianQK Date: Thu, 7 Dec 2023 22:57:12 +0800 Subject: [PATCH 1/2] [MachineCopyPropagation] Pre-commit test case --- .../test/CodeGen/A

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup with a regex pattern (PR #69422)

2023-12-07 Thread José Lira Junior via lldb-commits
junior-jl wrote: > I tried this now and I guess it's not correct. For example, if I have a > prefix (red color) and no suffix, the text does not go back to normal and > will be forever red. Or am I doing something wrong? ![image](https://github.com/llvm/llvm-project/assets/69206952/2ed63ec4-6f

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup with a regex pattern (PR #69422)

2023-12-07 Thread José Lira Junior via lldb-commits
junior-jl wrote: > If the prefix and suffix are empty. Not prefix or suffix is empty. I tried this now and I guess it's not correct. For example, if I have a prefix (red color) and no suffix, the text does not go back to normal and will be forever red. Or am I doing something wrong? > Or rath

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup with a regex pattern (PR #69422)

2023-12-07 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>, =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Re

  1   2   >