[Lldb-commits] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-10 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I built and tested this on arm64 macos and aarch64 linux. The native process plugins/register contexts are tracking the watchpoint/breakpoint hardware indexes of course, for maintaining the registers, but I think I have everything correct. I might find I missed one when I

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

2023-11-10 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/71828 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 309596f - [LLDB] Ensure the data of apple accelerator tables is kept around (#71828)

2023-11-10 Thread via lldb-commits
Author: Walter Erquinigo Date: 2023-11-10T21:53:58-05:00 New Revision: 309596f2497755b371bacff9d72d094a2c942042 URL: https://github.com/llvm/llvm-project/commit/309596f2497755b371bacff9d72d094a2c942042 DIFF: https://github.com/llvm/llvm-project/commit/309596f2497755b371bacff9d72d094a2c942042.di

[Lldb-commits] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-10 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I started making this change while working a larger "NFC" change in https://github.com/llvm/llvm-project/pull/68845 which has grown quite a lot in its scope and Jonas admonished me to not sneak functional changes into an NFC, so I broke it out into a separate one. https:/

[Lldb-commits] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes The Watchpoint and Breakpoint objects try to track the hardware index that was used for them, if they are hardware wp/bp's. The majority of our debugging goes over the gdb remote serial protocol, and wh

[Lldb-commits] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-10 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/72012 The Watchpoint and Breakpoint objects try to track the hardware index that was used for them, if they are hardware wp/bp's. The majority of our debugging goes over the gdb remote serial protocol, and when w

[Lldb-commits] [lldb] [mlir] [flang] [llvm] [libc] [libcxx] [openmp] [clang-tools-extra] [clang] GlobalISel: Guide return in llvm::getIConstantSplatVal (PR #71989)

2023-11-10 Thread Changpeng Fang via lldb-commits
changpeng wrote: > Any tests? Encountered this issue during a downstream branch testing. No test for trunk yet but think the issue should be here. https://github.com/llvm/llvm-project/pull/71989 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [lldb] Fix a little thinko in sending events to secondary listeners. (PR #71997)

2023-11-10 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/71997 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 0f8d3e6 - Fix a little thinko in sending events to secondary listeners. (#71997)

2023-11-10 Thread via lldb-commits
Author: jimingham Date: 2023-11-10T16:12:51-08:00 New Revision: 0f8d3e62d3fe3db905ac94e5d11fee87553c7794 URL: https://github.com/llvm/llvm-project/commit/0f8d3e62d3fe3db905ac94e5d11fee87553c7794 DIFF: https://github.com/llvm/llvm-project/commit/0f8d3e62d3fe3db905ac94e5d11fee87553c7794.diff LOG

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

2023-11-10 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. LGTM. I'm ok postponing the lifetime change to a separate task https://github.com/llvm/llvm-project/pull/71828 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] Fix a little thinko in sending events to secondary listeners. (PR #71997)

2023-11-10 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. LGTM! I will keep an eye on the bots once we merge this to make sure we don't see the test failure anymore https://github.com/llvm/llvm-project/pull/71997 ___ lldb-commits mailing list lldb

[Lldb-commits] [lldb] [clang] Reland "[clang][DebugInfo] Emit global variable definitions for static data members with constant initializers" (PR #71780)

2023-11-10 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/71780 >From e5bc858c35b479d29174c9945c6c67f4d2dc085b Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Nov 2023 01:13:21 + Subject: [PATCH 1/4] Reland "[clang][DebugInfo] Emit global variable definitions

[Lldb-commits] [clang-tools-extra] [mlir] [libcxx] [llvm] [libc] [flang] [openmp] [clang] [lldb] GlobalISel: Guide return in llvm::getIConstantSplatVal (PR #71989)

2023-11-10 Thread Stanislav Mekhanoshin via lldb-commits
rampitec wrote: Any tests? https://github.com/llvm/llvm-project/pull/71989 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a little thinko in sending events to secondary listeners. (PR #71997)

2023-11-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 64f62de96609dc3ea9a8a914a9e9445b7f4d625d d76a7dec707e484e501b45a32066f852cba8de95 --

[Lldb-commits] [lldb] Fix a little thinko in sending events to secondary listeners. (PR #71997)

2023-11-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes If `unique` is true, I was redoing the uniqueness check for the secondary listeners, which is racy since a "duplicate" event could come in between deciding to send the event to the main listener and checking for th

[Lldb-commits] [lldb] Fix a little thinko in sending events to secondary listeners. (PR #71997)

2023-11-10 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/71997 If `unique` is true, I was redoing the uniqueness check for the secondary listeners, which is racy since a "duplicate" event could come in between deciding to send the event to the main listener and checking f

[Lldb-commits] [lldb] [lldb] Remove StructuredData::Array::GetItemAtIndexAsArray (PR #71994)

2023-11-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/71994 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 64f62de - [lldb] Read Checksum from DWARF line tables (#71458)

2023-11-10 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2023-11-10T14:43:47-08:00 New Revision: 64f62de96609dc3ea9a8a914a9e9445b7f4d625d URL: https://github.com/llvm/llvm-project/commit/64f62de96609dc3ea9a8a914a9e9445b7f4d625d DIFF: https://github.com/llvm/llvm-project/commit/64f62de96609dc3ea9a8a914a9e9445b7f4d625d.d

[Lldb-commits] [lldb] [lldb] Remove StructuredData::Array::GetItemAtIndexAsArray (PR #71994)

2023-11-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes This method is completely unused. --- Full diff: https://github.com/llvm/llvm-project/pull/71994.diff 1 Files Affected: - (modified) lldb/include/lldb/Utility/StructuredData.h (-10) ``diff dif

[Lldb-commits] [lldb] [lldb] Remove StructuredData::Array::GetItemAtIndexAsArray (PR #71994)

2023-11-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/71994 This method is completely unused. >From 96d7701aa01312e1decdf43c1c1287c9a4e3da91 Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Fri, 10 Nov 2023 14:40:21 -0800 Subject: [PATCH] [lldb] Remove StructuredData

[Lldb-commits] [lldb] [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsInteger (PR #71993)

2023-11-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes This is a follow-up to (#71613) and (#71961). --- Full diff: https://github.com/llvm/llvm-project/pull/71993.diff 4 Files Affected: - (modified) lldb/include/lldb/Utility/StructuredData.h (+7-21) - (mod

[Lldb-commits] [lldb] [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsInteger (PR #71993)

2023-11-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/71993 This is a follow-up to (#71613) and (#71961). >From c6b3f622c32634db628cb76eaca556ae3d8ad6f4 Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Fri, 10 Nov 2023 14:06:48 -0800 Subject: [PATCH] [lldb] Change in

[Lldb-commits] [lldb] [mlir] [flang] [libc] [openmp] [llvm] [clang] [libcxx] [clang-tools-extra] GlobalISel: Guide return in llvm::getIConstantSplatVal (PR #71989)

2023-11-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0448a1c0dc131835301a59db7138d504b836a591 23d34569183f405fdae0a8a665be8b7772addebe --

[Lldb-commits] [lldb] [lldb] Fix a off-by-one error in ParseSupportFilesFromPrologue (PR #71984)

2023-11-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/71984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fa7e07e - [lldb] Fix a off-by-one error in ParseSupportFilesFromPrologue (#71984)

2023-11-10 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2023-11-10T14:03:29-08:00 New Revision: fa7e07ed9995637d84f40b3d29e0449154e73dd5 URL: https://github.com/llvm/llvm-project/commit/fa7e07ed9995637d84f40b3d29e0449154e73dd5 DIFF: https://github.com/llvm/llvm-project/commit/fa7e07ed9995637d84f40b3d29e0449154e73dd5.d

[Lldb-commits] [openmp] [clang-tools-extra] [libcxx] [libc] [mlir] [lldb] [llvm] [flang] [clang] GlobalISel: Guide return in llvm::getIConstantSplatVal (PR #71989)

2023-11-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-globalisel Author: Changpeng Fang (changpeng) Changes getIConstantVRegValWithLookThrough could return NULL. --- Full diff: https://github.com/llvm/llvm-project/pull/71989.diff 1 Files Affected: - (modified) llvm/lib/CodeGen/GlobalISel/Utils.cpp

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

2023-11-10 Thread Walter Erquinigo via lldb-commits
@@ -57,7 +57,9 @@ std::unique_ptr AppleDWARFIndex::Create( return std::make_unique( walter-erquinigo wrote: Sure, I've just changed it to assert https://github.com/llvm/llvm-project/pull/71828 ___ lldb-commits mai

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

2023-11-10 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/71828 >From b7fadbbe01d626fbffe2523c601b2e7ea727b591 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 9 Nov 2023 11:40:23 -0500 Subject: [PATCH] [LLDB] Ensure the data of apple accelerator tables is

[Lldb-commits] [lldb] [lldb] Fix a off-by-one error in ParseSupportFilesFromPrologue (PR #71984)

2023-11-10 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. LGTM! really like the `_idx` suffix of the new induction variable and its bounds https://github.com/llvm/llvm-project/pull/71984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

2023-11-10 Thread Jonas Devlieghere via lldb-commits
@@ -57,7 +57,9 @@ std::unique_ptr AppleDWARFIndex::Create( return std::make_unique( JDevlieghere wrote: This checks internal consistency so an `assert` is totally appropriate imho. https://github.com/llvm/llvm-project/pull/71828 ___

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

2023-11-10 Thread Walter Erquinigo via lldb-commits
@@ -57,7 +57,9 @@ std::unique_ptr AppleDWARFIndex::Create( return std::make_unique( walter-erquinigo wrote: @JDevlieghere , what do you suggest in this case? Plain assert or better not to put anything? I'd rather follow the guidelines https://github.com/ll

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

2023-11-10 Thread Jonas Devlieghere via lldb-commits
@@ -57,7 +57,9 @@ std::unique_ptr AppleDWARFIndex::Create( return std::make_unique( JDevlieghere wrote: Without expressing an opinion, the [contributing guidelines](https://lldb.llvm.org/resources/contributing.html) say not to add new `lldbasserts`. This i

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

2023-11-10 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/71828 >From 48ba23b4c0ef9c698b26d06e5b8b337a774563b8 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 9 Nov 2023 11:40:23 -0500 Subject: [PATCH] [LLDB] Ensure the data of apple accelerator tables is

[Lldb-commits] [lldb] [lldb] Fix a off-by-one error in ParseSupportFilesFromPrologue (PR #71984)

2023-11-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/71984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix a off-by-one error in ParseSupportFilesFromPrologue (PR #71984)

2023-11-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This fixes a subtle and previously harmless off-by-one bug in ParseSupportFilesFromPrologue. The function accounts for the start index being one-based for DWARF v4 and earlier and zero-based for DWA

[Lldb-commits] [lldb] [lldb] Fix a off-by-one error in ParseSupportFilesFromPrologue (PR #71984)

2023-11-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/71984 This fixes a subtle and previously harmless off-by-one bug in ParseSupportFilesFromPrologue. The function accounts for the start index being one-based for DWARF v4 and earlier and zero-based for DWARF v5 an

[Lldb-commits] [clang-tools-extra] [libcxx] [lldb] [flang] [lld] [llvm] [libc] [clang] [compiler-rt] [asan] Report executable/DSO name for report_globals=2 and odr-violation checking (PR #71879)

2023-11-10 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/71879 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Emit DIE's size in bits when size is not a multiple of 8 (PR #69741)

2023-11-10 Thread Michael Buch via lldb-commits
@@ -2866,8 +2879,12 @@ void DWARFASTParserClang::ParseSingleMember( // Get the parent byte size so we can verify any members will fit const uint64_t parent_byte_size = parent_die.GetAttributeValueAsUnsigned(DW_AT_byte_size, UINT64_MAX); - const uint64_t parent_bit_si

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-10 Thread Jonas Devlieghere via lldb-commits
@@ -41,7 +41,10 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process) : LanguageRuntime(process) {} bool CPPLanguageRuntime::IsAllowedRuntimeValue(ConstString name) { - return name == g_this; + return name == g_this || + // Artificial coroutine-related vari

[Lldb-commits] [lldb] [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsDictionary (PR #71961)

2023-11-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/71961 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 133bcac - [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsDictionary (#71961)

2023-11-10 Thread via lldb-commits
Author: Alex Langford Date: 2023-11-10T12:47:43-08:00 New Revision: 133bcacecfb70e8b1692f9c2c0a44ec640a0422a URL: https://github.com/llvm/llvm-project/commit/133bcacecfb70e8b1692f9c2c0a44ec640a0422a DIFF: https://github.com/llvm/llvm-project/commit/133bcacecfb70e8b1692f9c2c0a44ec640a0422a.diff

[Lldb-commits] [lldb] [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsDictionary (PR #71961)

2023-11-10 Thread Alex Langford via lldb-commits
bulbazord wrote: > A great future patch would be to have StructuredData backed by the llvm::json > stuff instead of our own custom version of this a JSON style object hiearchy I think that I agree. Unfortunately I don't have time to drive that right now and it might appear to not make sense wh

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

2023-11-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r d0da3d8393939790bb1a6b3b5a36daeeef000c9b..50e81f16a6c09d19af53e64818d3b67ebb8dbfd0 lldb/

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

2023-11-10 Thread Haojian Wu via lldb-commits
hokein wrote: @Caslyn , I added the `# REQUIRES: gcc` to the test in https://github.com/llvm/llvm-project/commit/81a76902ae0fc08138e37212239c5c704eec2f26 https://github.com/llvm/llvm-project/pull/70779 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [lldb] 81a7690 - [lldb] Only run ignored_artificial_fields.test when gcc is available.

2023-11-10 Thread Haojian Wu via lldb-commits
Author: Haojian Wu Date: 2023-11-10T20:56:27+01:00 New Revision: 81a76902ae0fc08138e37212239c5c704eec2f26 URL: https://github.com/llvm/llvm-project/commit/81a76902ae0fc08138e37212239c5c704eec2f26 DIFF: https://github.com/llvm/llvm-project/commit/81a76902ae0fc08138e37212239c5c704eec2f26.diff LO

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

2023-11-10 Thread Greg Clayton via lldb-commits
https://github.com/clayborg updated https://github.com/llvm/llvm-project/pull/71772 >From feea395f4ef165dfc057dfdc0649c6948895eeb3 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Wed, 8 Nov 2023 21:14:49 -0800 Subject: [PATCH 1/2] Centralize the code that figures out which memory ranges to s

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

2023-11-10 Thread Greg Clayton via lldb-commits
@@ -57,7 +57,9 @@ std::unique_ptr AppleDWARFIndex::Create( return std::make_unique( clayborg wrote: > These asserts might not always pass? I don't know if it's guaranteed that if > one of those sections is present, then the rest of them are as well. You ca

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

2023-11-10 Thread Greg Clayton via lldb-commits
@@ -57,7 +57,9 @@ std::unique_ptr AppleDWARFIndex::Create( return std::make_unique( clayborg wrote: Fine with me! https://github.com/llvm/llvm-project/pull/71828 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

2023-11-10 Thread Caslyn Tonelli via lldb-commits
Caslyn wrote: Hi @hokein - ignored_artificial_fields.test breaks if gcc is unavailable. For ex we purposely exclude gcc on our downstream bots so as not to implicitly depend on it. Maybe all that is needed is adding `# REQUIRES: gcc`. Would you be able to revert the test and/or patch it to onl

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

2023-11-10 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/71828 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

2023-11-10 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -57,7 +57,9 @@ std::unique_ptr AppleDWARFIndex::Create( return std::make_unique( felipepiovezan wrote: @clayborg what do you think about moving ownership of the data to inside the AppleAcceleratorTable class? https://github.com/llvm/llvm-project/pull/71

[Lldb-commits] [lldb] [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsDictionary (PR #71961)

2023-11-10 Thread Greg Clayton via lldb-commits
clayborg wrote: A great future patch would be to have StructuredData backed by the llvm::json stuff instead of our own custom version of this a JSON style object hiearchy https://github.com/llvm/llvm-project/pull/71961 ___ lldb-commits mailing list ll

[Lldb-commits] [libc] [lldb] [compiler-rt] [clang-tools-extra] [flang] [lld] [libcxx] [llvm] [clang] [asan] Report executable/DSO name for report_globals=2 and odr-violation checking (PR #71879)

2023-11-10 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/71879 >From 573a5c0ea74284f572cb1cff7e8d3e2d9cac210b Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Thu, 9 Nov 2023 15:17:25 -0800 Subject: [PATCH 1/3] [asan] Report executable/DSO name for report_globals=2 and odr

[Lldb-commits] [llvm] [lldb] Emit DIE's size in bits when size is not a multiple of 8 (PR #69741)

2023-11-10 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 edited https://github.com/llvm/llvm-project/pull/69741 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [llvm] [lldb] Fix size in bytes of type DIEs when size in bits is not a multiple of 8 (PR #69741)

2023-11-10 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/69741 >From 997da625fda1efebde43ec965c23c1a8ef9c0132 Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Fri, 10 Nov 2023 10:40:05 -0800 Subject: [PATCH] Emit DIE's size in bits when size is not a multiple of 8 T

[Lldb-commits] [lldb] [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsDictionary (PR #71961)

2023-11-10 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/71961 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [llvm] [lldb] Fix size in bytes of type DIEs when size in bits is not a multiple of 8 (PR #69741)

2023-11-10 Thread Augusto Noronha via lldb-commits
@@ -2866,8 +2879,12 @@ void DWARFASTParserClang::ParseSingleMember( // Get the parent byte size so we can verify any members will fit const uint64_t parent_byte_size = parent_die.GetAttributeValueAsUnsigned(DW_AT_byte_size, UINT64_MAX); - const uint64_t parent_bit_si

[Lldb-commits] [llvm] [lldb] Fix size in bytes of type DIEs when size in bits is not a multiple of 8 (PR #69741)

2023-11-10 Thread Augusto Noronha via lldb-commits
@@ -2210,9 +2216,16 @@ bool DWARFASTParserClang::CompleteRecordType(const DWARFDIE &die, !layout_info.vbase_offsets.empty()) { if (type) layout_info.bit_size = type->GetByteSize(nullptr).value_or(0) * 8; -if (layout_info.bit_size == 0) - layout_info.bi

[Lldb-commits] [compiler-rt] [clang-tools-extra] [llvm] [flang] [mlir] [clang] [lldb] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-11-10 Thread Zequan Wu via lldb-commits
ZequanWu wrote: There are some discussions about this outside the PR: https://github.com/llvm/llvm-project/pull/70856#issuecomment-1791465183 https://discourse.llvm.org/t/rfc-add-binary-profile-correlation-to-not-load-profile-metadata-sections-into-memory-at-runtime/74565/8 Some further discussi

[Lldb-commits] [lldb] [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsDictionary (PR #71961)

2023-11-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/71961 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsDictionary (PR #71961)

2023-11-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes Similar to my previous patch (#71613) where I changed `GetItemAtIndexAsString`, this patch makes the same change to `GetItemAtIndexAsDictionary`. `GetItemAtIndexAsDictionary` now returns a std::optional t

[Lldb-commits] [lldb] [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsDictionary (PR #71961)

2023-11-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/71961 Similar to my previous patch (#71613) where I changed `GetItemAtIndexAsString`, this patch makes the same change to `GetItemAtIndexAsDictionary`. `GetItemAtIndexAsDictionary` now returns a std::optional that i

[Lldb-commits] [lldb] [llvm] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-11-10 Thread Kevin Frei via lldb-commits
@@ -0,0 +1,154 @@ +//===-- SymbolLocatorDebuginfod.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [llvm] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-11-10 Thread Kevin Frei via lldb-commits
@@ -0,0 +1,154 @@ +//===-- SymbolLocatorDebuginfod.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [clang] Reland "[clang][DebugInfo] Emit global variable definitions for static data members with constant initializers" (PR #71780)

2023-11-10 Thread Michael Buch via lldb-commits
@@ -5800,6 +5827,18 @@ void CGDebugInfo::setDwoId(uint64_t Signature) { } void CGDebugInfo::finalize() { + for (auto const *VD : StaticDataMemberDefinitionsToEmit) { +assert(VD->isStaticDataMember()); + +if (DeclCache.contains(VD)) + continue; + +if (!VD->has

[Lldb-commits] [clang] [lldb] Reland "[clang][DebugInfo] Emit global variable definitions for static data members with constant initializers" (PR #71780)

2023-11-10 Thread Michael Buch via lldb-commits
@@ -5596,6 +5587,42 @@ void CGDebugInfo::EmitGlobalVariable(const ValueDecl *VD, const APValue &Init) { TemplateParameters, Align)); } +void CGDebugInfo::EmitGlobalVariable(const VarDecl *VD) { + assert(VD->hasInit()); + assert(CGM.getCodeGenOpts().hasReducedDebugInfo

[Lldb-commits] [lldb] [clang] Reland "[clang][DebugInfo] Emit global variable definitions for static data members with constant initializers" (PR #71780)

2023-11-10 Thread Adrian Prantl via lldb-commits
@@ -5800,6 +5827,18 @@ void CGDebugInfo::setDwoId(uint64_t Signature) { } void CGDebugInfo::finalize() { + for (auto const *VD : StaticDataMemberDefinitionsToEmit) { +assert(VD->isStaticDataMember()); + +if (DeclCache.contains(VD)) + continue; + +if (!VD->has

[Lldb-commits] [clang] [lldb] Reland "[clang][DebugInfo] Emit global variable definitions for static data members with constant initializers" (PR #71780)

2023-11-10 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. Minor comments inside. https://github.com/llvm/llvm-project/pull/71780 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] Reland "[clang][DebugInfo] Emit global variable definitions for static data members with constant initializers" (PR #71780)

2023-11-10 Thread Adrian Prantl via lldb-commits
@@ -5596,6 +5587,42 @@ void CGDebugInfo::EmitGlobalVariable(const ValueDecl *VD, const APValue &Init) { TemplateParameters, Align)); } +void CGDebugInfo::EmitGlobalVariable(const VarDecl *VD) { + assert(VD->hasInit()); + assert(CGM.getCodeGenOpts().hasReducedDebugInfo

[Lldb-commits] [clang] [lldb] Reland "[clang][DebugInfo] Emit global variable definitions for static data members with constant initializers" (PR #71780)

2023-11-10 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/71780 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb][DWARFASTParserClang] Fetch constant value from variable defintion if available" (PR #71800)

2023-11-10 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/71800 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

2023-11-10 Thread David Spickett via lldb-commits
DavidSpickett wrote: All fixed now. https://github.com/llvm/llvm-project/pull/70779 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-10 Thread Haojian Wu via lldb-commits
hokein wrote: > Did you configure your build with `LLDB_INCLUDE_TESTS=ON` and > `LLDB_INCLUDE_PYTHON=ON`? Those CMake variables are necessary to get the API > tests to run Thanks! I was able to run the test locally now with `-DLLDB_INCLUDE_TESTS=On`, `-DLLDB_ENABLE_PYTHON=On`, and all deps i

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-10 Thread Haojian Wu via lldb-commits
@@ -41,7 +41,11 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process) : LanguageRuntime(process) {} bool CPPLanguageRuntime::IsAllowedRuntimeValue(ConstString name) { - return name == g_this; + // FIXME: use a list when the list grows more. hokein

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-10 Thread Haojian Wu via lldb-commits
https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/71928 >From 1ac7e612bf6917af4e347407fb98affa9bb296c6 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Fri, 10 Nov 2023 12:35:10 +0100 Subject: [PATCH 1/2] [LLDB] Display artificial __promise and __coro_frame variables.

[Lldb-commits] [lldb] d96ea27 - Revert "[lldb] Remove the newly-added test in 66acd1e4dc1080015fe6b234226f1d30d6577f04"

2023-11-10 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-11-10T13:47:41Z New Revision: d96ea279734fd9105a0ed7bad898ed84d79ed308 URL: https://github.com/llvm/llvm-project/commit/d96ea279734fd9105a0ed7bad898ed84d79ed308 DIFF: https://github.com/llvm/llvm-project/commit/d96ea279734fd9105a0ed7bad898ed84d79ed308.diff LOG

[Lldb-commits] [lldb] 6b4ac76 - Reland "[lldb][test] Only add -m(64|32) for GCC on non Arm/AArch64 platforms"

2023-11-10 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-11-10T13:36:23Z New Revision: 6b4ac76504d120d44023618ef8240d4f907d08ca URL: https://github.com/llvm/llvm-project/commit/6b4ac76504d120d44023618ef8240d4f907d08ca DIFF: https://github.com/llvm/llvm-project/commit/6b4ac76504d120d44023618ef8240d4f907d08ca.diff LOG

[Lldb-commits] [lldb] fd5206c - Revert "[lldb][test] Only add -m(64|32) for GCC on non Arm/AArch64 platforms"

2023-11-10 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-11-10T13:17:01Z New Revision: fd5206cc55c820598d5145d799b18d66cc193356 URL: https://github.com/llvm/llvm-project/commit/fd5206cc55c820598d5145d799b18d66cc193356 DIFF: https://github.com/llvm/llvm-project/commit/fd5206cc55c820598d5145d799b18d66cc193356.diff LOG

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

2023-11-10 Thread Haojian Wu via lldb-commits
hokein wrote: Thank you very much for the fix! https://github.com/llvm/llvm-project/pull/70779 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

2023-11-10 Thread David Spickett via lldb-commits
DavidSpickett wrote: I just pushed a fix for the build script, I'll put the test case back once I know the script change is good. https://github.com/llvm/llvm-project/pull/70779 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] 7c3603e - [lldb][test] Only add -m(64|32) for GCC on non Arm/AArch64 platforms

2023-11-10 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-11-10T12:52:36Z New Revision: 7c3603e1c162382b5c038b99e482e0689e1505aa URL: https://github.com/llvm/llvm-project/commit/7c3603e1c162382b5c038b99e482e0689e1505aa DIFF: https://github.com/llvm/llvm-project/commit/7c3603e1c162382b5c038b99e482e0689e1505aa.diff LOG

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

2023-11-10 Thread Haojian Wu via lldb-commits
hokein wrote: > I think I have a fix for this, will commit it soon. Ah, I just saw your new message. If you can fix that, that would be fantastic (I don't know too much about lldb). https://github.com/llvm/llvm-project/pull/70779 ___ lldb-commits mai

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

2023-11-10 Thread Haojian Wu via lldb-commits
hokein wrote: > Hi, this is failing on Linaro's Linux LLDB bots: > https://lab.llvm.org/buildbot/#/builders/96/builds/48277 > Looks like the -m64 (or -m32) is being passed to an AArch64 (or ARM) g++, and > those are X86 only flags. Sorry for the breakage. I removed this test temporarily in 3

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

2023-11-10 Thread David Spickett via lldb-commits
DavidSpickett wrote: I think I have a fix for this, will commit it soon. https://github.com/llvm/llvm-project/pull/70779 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 343eb4b - [lldb] Remove the newly-added test in 66acd1e4dc1080015fe6b234226f1d30d6577f04

2023-11-10 Thread Haojian Wu via lldb-commits
Author: Haojian Wu Date: 2023-11-10T13:46:36+01:00 New Revision: 343eb4b4253fea31767f6a98e1cf77a7d69c856a URL: https://github.com/llvm/llvm-project/commit/343eb4b4253fea31767f6a98e1cf77a7d69c856a DIFF: https://github.com/llvm/llvm-project/commit/343eb4b4253fea31767f6a98e1cf77a7d69c856a.diff LO

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

2023-11-10 Thread David Spickett via lldb-commits
DavidSpickett wrote: Hi, this is failing on Linaro's Linux LLDB bots: https://lab.llvm.org/buildbot/#/builders/96/builds/48277 Looks like the `-m64` (or `-m32`) is being passed to an AArch64 (or ARM) g++, and those are X86 only flags. https://github.com/llvm/llvm-project/pull/70779 __

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-10 Thread Michael Buch via lldb-commits
@@ -41,7 +41,11 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process) : LanguageRuntime(process) {} bool CPPLanguageRuntime::IsAllowedRuntimeValue(ConstString name) { - return name == g_this; + // FIXME: use a list when the list grows more. Michael

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-10 Thread Michael Buch via lldb-commits
Michael137 wrote: > Is there a way to run the tests under `lldb/test/API/` directory? `ninja > check-lldb` doesn't seem to run these tests on my linux machine. > > ``` > ./bin/llvm-lit -sv > /lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/ > >

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff bd611264993f64decbce178d460caf1d1cb05f59 1ac7e612bf6917af4e347407fb98affa9bb296c6 --

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r bd611264993f64decbce178d460caf1d1cb05f59..1ac7e612bf6917af4e347407fb98affa9bb296c6 lldb/

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Haojian Wu (hokein) Changes See the discussion in #69309. --- Full diff: https://github.com/llvm/llvm-project/pull/71928.diff 3 Files Affected: - (modified) lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp (+5-1) -

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-10 Thread Haojian Wu via lldb-commits
https://github.com/hokein ready_for_review https://github.com/llvm/llvm-project/pull/71928 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-10 Thread Haojian Wu via lldb-commits
hokein wrote: Is there a way to run the tests under `lldb/test/API/` directory? `ninja check-lldb` doesn't seem to run these tests on my linux machine. ``` ./bin/llvm-lit -sv /lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/ Testing Time: 0.02s

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-10 Thread Haojian Wu via lldb-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/71928 See the discussion in #69309. >From 1ac7e612bf6917af4e347407fb98affa9bb296c6 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Fri, 10 Nov 2023 12:35:10 +0100 Subject: [PATCH] [LLDB] Display artificial __promise an

[Lldb-commits] [lldb] bd61126 - [lldb][docs] Update Discord invite link

2023-11-10 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-11-10T11:18:30Z New Revision: bd611264993f64decbce178d460caf1d1cb05f59 URL: https://github.com/llvm/llvm-project/commit/bd611264993f64decbce178d460caf1d1cb05f59 DIFF: https://github.com/llvm/llvm-project/commit/bd611264993f64decbce178d460caf1d1cb05f59.diff LOG

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Make MemberAttributes const when parsing member DIEs (PR #71921)

2023-11-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch removes the Objective-C accessibility workaround added in https://github.com/llvm/llvm-project/commit/5a477cfd90a8a12510518973fa450ae67372f199 (rdar://8492646). This allows us to make the local

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Make MemberAttributes const when parsing member DIEs (PR #71921)

2023-11-10 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/71921 This patch removes the Objective-C accessibility workaround added in https://github.com/llvm/llvm-project/commit/5a477cfd90a8a12510518973fa450ae67372f199 (rdar://8492646). This allows us to make the local `Me

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

2023-11-10 Thread Haojian Wu via lldb-commits
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/70779 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 66acd1e - [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (#70779)

2023-11-10 Thread via lldb-commits
Author: Haojian Wu Date: 2023-11-10T10:53:03+01:00 New Revision: 66acd1e4dc1080015fe6b234226f1d30d6577f04 URL: https://github.com/llvm/llvm-project/commit/66acd1e4dc1080015fe6b234226f1d30d6577f04 DIFF: https://github.com/llvm/llvm-project/commit/66acd1e4dc1080015fe6b234226f1d30d6577f04.diff LO

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

2023-11-10 Thread Haojian Wu via lldb-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/70779 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >