rampitec wrote:
> I suppose left shift of negative values is undefined because if you shift out
> the sign bit you can overflow and get a positive value.
Sounds like BS. It is defined. Unexpected maybe.
https://github.com/llvm/llvm-project/pull/68740
___
mikaelholmen wrote:
I suppose left shift of negative values is undefined because if you shift out
the sign bit you can overflow and get a positive value.
https://github.com/llvm/llvm-project/pull/68740
___
lldb-commits mailing list
lldb-commits@lists.
mikaelholmen wrote:
Hi @rampitec
With UBSan built binaries the
MC/AMDGPU/literals.s
testcase fails and triggers UB like
```
07:33:04 ../lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:2246:59: runtime
error: left shift of negative value -54321
07:33:04 SUMMARY: UndefinedBehaviorSanitizer: und
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/68705
>From ca4d1bbdeb4ea541199e3db3518b35eb2d5a8cad Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Tue, 10 Oct 2023 15:07:56 +0300
Subject: [PATCH 01/12] [lldb] Add SBType::FindNestedType() function
---
lld
medismailben wrote:
> Ok, I put the 2 new tests into a single, new file, which makes the file
> naming a bit simpler and set up for future FixIt tests specific to C++.
This is exactly what I had in mind :)
https://github.com/llvm/llvm-project/pull/68755
___
@@ -169,19 +169,42 @@ static lldb::Format GetItemFormatForFormat(lldb::Format
format,
}
}
+/// \brief Returns the number of elements of 'container_type'
+/// as if its elements had type 'element_type'.
+///
+/// For example, a container of type
+/// `uint8_t __attribute__((
@@ -169,19 +169,42 @@ static lldb::Format GetItemFormatForFormat(lldb::Format
format,
}
}
+/// \brief Returns the number of elements of 'container_type'
+/// as if its elements had type 'element_type'.
+///
+/// For example, a container of type
+/// `uint8_t __attribute__((
https://github.com/PeimingLiu approved this pull request.
https://github.com/llvm/llvm-project/pull/68951
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/aartbik created
https://github.com/llvm/llvm-project/pull/68951
None
>From 64011a22c3e9b97515e34139d0fbb03e0b1fe330 Mon Sep 17 00:00:00 2001
From: Aart Bik
Date: Thu, 12 Oct 2023 21:24:05 -0700
Subject: [PATCH] [mlir][sparse] remove unused sparse tensor iterator
---
.../ml
https://github.com/aartbik closed
https://github.com/llvm/llvm-project/pull/68939
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -642,18 +642,8 @@ get_sanitizer_flags(SANITIZER_FLAGS
"${LLVM_USE_SANITIZER}")
# Link system libraries ===
function(cxx_link_system_libraries target)
-
-# In order to remove just libc++ from the link step
-# we need to us
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/68832
>From 9ca88d1a30ec1bcaa9c3c943c32649c36ad136d0 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 11 Oct 2023 12:21:39 -0700
Subject: [PATCH 1/3] [libc++] Use -nostdlib++ on GCC unconditionally
We support GC
walter-erquinigo wrote:
@jimingham , thanks! I reverted the changes to that method and left a tiny
comment mentioning that it's used by swift.
https://github.com/llvm/llvm-project/pull/68927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68927
>From fa598fac03c2be067cf3adc7c2b161b403ebf4de Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 12 Oct 2023 16:58:08 -0400
Subject: [PATCH] [LLDB][NFC] Remove dead code
I found this type/types
https://github.com/NatashaKnk created
https://github.com/llvm/llvm-project/pull/68945
None
>From e431cc466e5609e19757481604dad47558219166 Mon Sep 17 00:00:00 2001
From: Natasha Kononenko
Date: Fri, 13 Oct 2023 00:48:17 +
Subject: [PATCH 1/2] Add ContractionOpInterface utility functions for
https://github.com/PeimingLiu approved this pull request.
https://github.com/llvm/llvm-project/pull/68939
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/65148
>From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 31 Aug 2023 20:08:32 +
Subject: [PATCH 01/12] [libc++] Implement ranges::contains
Differential Revision
jimingham wrote:
Swift uses the `IsRuntimeGeneratedType` API, so it would be nice if you could
leave that in to reduce diffs. All the others are not used in the swift
support.
https://github.com/llvm/llvm-project/pull/68927
___
lldb-commits mailing
@@ -183,8 +181,6 @@ class CompilerType {
bool IsPointerToScalarType() const;
- bool IsRuntimeGeneratedType() const;
jimingham wrote:
Swift uses this one.
https://github.com/llvm/llvm-project/pull/68927
___
lldb
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Tom Yang (zhyty)
Changes
Follow up to #66035.
@kazutakahirata noticed
([comment](https://github.com/llvm/llvm-project/commit/64d78d8b3cd09dff32c97fbefa56bcfc8b676406#r129848406))
that I was reading structured data in assert statements whi
https://github.com/zhyty created https://github.com/llvm/llvm-project/pull/68940
Follow up to #66035.
@kazutakahirata noticed
([comment](https://github.com/llvm/llvm-project/commit/64d78d8b3cd09dff32c97fbefa56bcfc8b676406#r129848406))
that I was reading structured data in assert statements whi
https://github.com/clayborg commented:
Looks fine to me, but anyone at Apple might need to comment to make sure it
doesn't take away something needed for Swift.
https://github.com/llvm/llvm-project/pull/68927
___
lldb-commits mailing list
lldb-commits
Author: Tom Yang
Date: 2023-10-12T16:28:56-07:00
New Revision: cd0d478e7cfa4ecf44c6fa97c796678cea5e4256
URL:
https://github.com/llvm/llvm-project/commit/cd0d478e7cfa4ecf44c6fa97c796678cea5e4256
DIFF:
https://github.com/llvm/llvm-project/commit/cd0d478e7cfa4ecf44c6fa97c796678cea5e4256.diff
LOG:
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68927
>From fd9b54296757e86b3798e6782513a11356c56622 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 12 Oct 2023 16:58:08 -0400
Subject: [PATCH] [LLDB][NFC] Remove dead code
I found this type/types
jasonmolenda wrote:
I started on the next step of updating ProcessGDBRemote to identify the
WatchpointResource that was hit by a watchpoint stop, and evaluate all of its
Watchpoints, when I looked at BreakpointSite and BreakpointSiteList and realize
I should have started by coping their design
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/68927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68927
>From de55d41ed7c3bed798953b69e401cfeb403304e0 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 12 Oct 2023 16:58:08 -0400
Subject: [PATCH] [LLDB][NFC] Remove dead code
I found this type/types
https://github.com/rampitec closed
https://github.com/llvm/llvm-project/pull/68740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -384,13 +384,15 @@ class TypeSystem : public PluginInterface,
dump(lldb::opaque_compiler_type_t type) const = 0;
#endif
- virtual void DumpValue(lldb::opaque_compiler_type_t type,
- ExecutionContext *exe_ctx, Stream &s,
- l
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68927
>From bf47938af6e80a02402a492ca7c61cf47391bd3c Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 12 Oct 2023 16:58:08 -0400
Subject: [PATCH] [LLDB][NFC] Remove dead code
I found this type/types
@@ -384,13 +384,15 @@ class TypeSystem : public PluginInterface,
dump(lldb::opaque_compiler_type_t type) const = 0;
#endif
- virtual void DumpValue(lldb::opaque_compiler_type_t type,
- ExecutionContext *exe_ctx, Stream &s,
- l
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68927
>From c6ca8497de2cfabf22d29b8210021f36263302c9 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 12 Oct 2023 16:58:08 -0400
Subject: [PATCH] [LLDB][NFC] Remove dead code
I found this type/types
@@ -384,13 +384,15 @@ class TypeSystem : public PluginInterface,
dump(lldb::opaque_compiler_type_t type) const = 0;
#endif
- virtual void DumpValue(lldb::opaque_compiler_type_t type,
- ExecutionContext *exe_ctx, Stream &s,
- l
@@ -384,13 +384,15 @@ class TypeSystem : public PluginInterface,
dump(lldb::opaque_compiler_type_t type) const = 0;
#endif
- virtual void DumpValue(lldb::opaque_compiler_type_t type,
- ExecutionContext *exe_ctx, Stream &s,
- l
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68927
>From 8671fd2bb1808322e24688feba75e7b6df1a302e Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 12 Oct 2023 16:58:08 -0400
Subject: [PATCH] [LLDB][NFC] Remove dead code
I found this type/types
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Walter Erquinigo (walter-erquinigo)
Changes
I found this type/typesystem code that is dead and seems to have been replaced
by the ValueObjectPrinter.
---
Patch is 25.20 KiB, truncated to 20.00 KiB below, full version:
https://github.com
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68927
>From ddea9112d479eddeaf95a30d5f3dd314cae6860b Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 12 Oct 2023 16:58:08 -0400
Subject: [PATCH] [LLDB][NFC] Remove dead code
I found this type/types
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/68927
I found this type/typesystem code that is dead and seems to have been replaced
by the ValueObjectPrinter.
>From 2e589d7e13959947bf7c81b089f164ccd8d22906 Mon Sep 17 00:00:00 2001
From: walter erquinigo
@@ -19,6 +19,21 @@ def getFormatted(self, format, expr):
self.assertTrue(result.Succeeded(), result.GetError())
return result.GetOutput()
+@no_debug_info_test
+@skipIfWindows
+def testAllPlatforms(self):
+self.build()
+lldbutil.run_t
@@ -19,6 +19,21 @@ def getFormatted(self, format, expr):
self.assertTrue(result.Succeeded(), result.GetError())
return result.GetOutput()
+@no_debug_info_test
+@skipIfWindows
+def testAllPlatforms(self):
+self.build()
+lldbutil.run_t
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68924
>From eaf314f813202fd71b884f3cd2e87db6cfd97e96 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 12 Oct 2023 15:58:19 -0400
Subject: [PATCH 1/3] [LLDB] Fix type formatting empty c-strings
The t
https://github.com/rampitec updated
https://github.com/llvm/llvm-project/pull/68740
>From cc9e065a9218eb36750a2c2a4a4d08fae3f329fa Mon Sep 17 00:00:00 2001
From: Stanislav Mekhanoshin
Date: Wed, 4 Oct 2023 13:36:25 -0700
Subject: [PATCH 1/6] [AMDGPU] Change the representation of double literals
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68924
>From eaf314f813202fd71b884f3cd2e87db6cfd97e96 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 12 Oct 2023 15:58:19 -0400
Subject: [PATCH 1/2] [LLDB] Fix type formatting empty c-strings
The t
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
220244b71ba2a0301bb13fb195d64a66418d1c70..eaf314f813202fd71b884f3cd2e87db6cfd97e96
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Walter Erquinigo (walter-erquinigo)
Changes
The type formatter code is effectively considering empty strings as read
errors, which is wrong. The fix is very simple. We should rely on the error
object and stop checking the size. I also adde
https://github.com/walter-erquinigo ready_for_review
https://github.com/llvm/llvm-project/pull/68924
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/68924
The type formatter code is effectively considering empty strings as read
errors, which is wrong. The fix is very simple. We should rely on the error
object and stop checking the size. I also added a tes
https://github.com/rampitec updated
https://github.com/llvm/llvm-project/pull/68740
>From cc9e065a9218eb36750a2c2a4a4d08fae3f329fa Mon Sep 17 00:00:00 2001
From: Stanislav Mekhanoshin
Date: Wed, 4 Oct 2023 13:36:25 -0700
Subject: [PATCH 1/6] [AMDGPU] Change the representation of double literals
@@ -313,6 +313,8 @@ class TypeImpl {
bool GetDescription(lldb_private::Stream &strm,
lldb::DescriptionLevel description_level);
+ CompilerType FindNestedType(ConstString name);
Endilll wrote:
@jimingham @Michael137 Any opinions?
http
@@ -186,6 +186,11 @@ std::optional
TypeSystem::ReportStatistics() {
return std::nullopt;
}
+CompilerDeclContext
Endilll wrote:
Both items are done!
https://github.com/llvm/llvm-project/pull/68705
___
lldb-commit
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/68705
>From ca4d1bbdeb4ea541199e3db3518b35eb2d5a8cad Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Tue, 10 Oct 2023 15:07:56 +0300
Subject: [PATCH 01/11] [lldb] Add SBType::FindNestedType() function
---
lld
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/68866
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -212,6 +212,21 @@ This loads the coredump file `/cores/123.core` associated
with the program
}
```
+### Connect to a Remote Debug Server
+
+This connects to a debug server (e.g. `lldb-server`, `gdbserver`) that is
+debugging the program `/tmp/a.out` and listening locally o
clayborg wrote:
> (aside: isn't the SBAPI meant to be the thing to use if you want to script
> stuff, rather than having formatted output/scraping that? - but sounds like
> the output has converged on a table rather than JSON anyway? So maybe a moot
> point)
The reason we use StructuredData i
https://github.com/zhyty closed https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Tom Yang
Date: 2023-10-12T11:21:53-07:00
New Revision: 64d78d8b3cd09dff32c97fbefa56bcfc8b676406
URL:
https://github.com/llvm/llvm-project/commit/64d78d8b3cd09dff32c97fbefa56bcfc8b676406
DIFF:
https://github.com/llvm/llvm-project/commit/64d78d8b3cd09dff32c97fbefa56bcfc8b676406.diff
LOG:
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty updated https://github.com/llvm/llvm-project/pull/66035
>From fe1f2874d91b6583759f43ba5a0ed28b44275ab6 Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH 1/3] Add `target modules dump separate-debug-info`
Summary:
Add a new co
https://github.com/zhyty updated https://github.com/llvm/llvm-project/pull/66035
>From 9a52ac5193af2a8ddca2a5d922684935b043d0ef Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH 1/2] Add `target modules dump separate-debug-info`
Summary:
Add a new co
jimingham wrote:
As long as it does (and will continue doing) what it says,
`FindDirectNestedType` is okay.
Part of me thinks: "later on somebody will want to add an N levels deep search
-requiring a depth parameter, and then we'll have to add another
`FindNestedTypeAtDepth` API where passi
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
05181a849b4c1ec14fdd6d667285d6f5ad34a5a2..ffc0f0ffa4164f9b426e4b30897c86577e2aa867
mlir/p
@@ -212,6 +212,21 @@ This loads the coredump file `/cores/123.core` associated
with the program
}
```
+### Connect to a Remote Debug Server
+
+This connects to a debug server (e.g. `lldb-server`, `gdbserver`) that is
+debugging the program `/tmp/a.out` and listening locally o
@@ -212,6 +212,21 @@ This loads the coredump file `/cores/123.core` associated
with the program
}
```
+### Connect to a Remote Debug Server
+
+This connects to a debug server (e.g. `lldb-server`, `gdbserver`) that is
+debugging the program `/tmp/a.out` and listening locally o
clayborg wrote:
> I am not a big fan of having a specialized name `separate-debug-info` to dump
> external debug info. Ideally, I would like a single/centralized command for
> end users to see/check symbols/debug info status for a target including all
> possible situations.
>
> How about we r
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/68907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/68907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/68907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/68907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/68907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
To get the number of children for a VectorType (i.e.,
a type declared with a `vector_size`/`ext_vector_type` attribute)
LLDB previously did following calculation:
1. Get byte-size of the vector container fro
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/68907
To get the number of children for a VectorType (i.e.,
a type declared with a `vector_size`/`ext_vector_type` attribute)
LLDB previously did following calculation:
1. Get byte-size of the vector container from C
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/68705
>From ca4d1bbdeb4ea541199e3db3518b35eb2d5a8cad Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Tue, 10 Oct 2023 15:07:56 +0300
Subject: [PATCH 1/8] [lldb] Add SBType::FindNestedType() function
---
lldb/
@@ -119,6 +119,15 @@ def test(self):
self.assertEqual(task_type, task_head_pointee_type)
+# Check whether we can find a nested type by name
+name_type = task_type.FindNestedType("name")
+self.assertTrue(name_type)
+self.DebugSBType(name
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/68705
>From ca4d1bbdeb4ea541199e3db3518b35eb2d5a8cad Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Tue, 10 Oct 2023 15:07:56 +0300
Subject: [PATCH 1/7] [lldb] Add SBType::FindNestedType() function
---
lldb/
@@ -1082,6 +1082,19 @@ bool TypeImpl::GetDescription(lldb_private::Stream &strm,
return true;
}
+CompilerType TypeImpl::FindNestedType(ConstString name) {
Endilll wrote:
Done!
https://github.com/llvm/llvm-project/pull/68705
@@ -119,6 +119,11 @@ def test(self):
self.assertEqual(task_type, task_head_pointee_type)
+# Check whether we can find a nested type by name
+name_type = task_type.FindNestedType("name")
Endilll wrote:
Done!
https://github.com/llvm/ll
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/68705
>From ca4d1bbdeb4ea541199e3db3518b35eb2d5a8cad Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Tue, 10 Oct 2023 15:07:56 +0300
Subject: [PATCH 1/6] [lldb] Add SBType::FindNestedType() function
---
lldb/
@@ -119,6 +119,15 @@ def test(self):
self.assertEqual(task_type, task_head_pointee_type)
+# Check whether we can find a nested type by name
+name_type = task_type.FindNestedType("name")
+self.assertTrue(name_type)
+self.DebugSBType(name
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/68705
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -119,6 +119,11 @@ def test(self):
self.assertEqual(task_type, task_head_pointee_type)
+# Check whether we can find a nested type by name
+name_type = task_type.FindNestedType("name")
Michael137 wrote:
Up to you, though it would be
@@ -1468,6 +1468,18 @@ LogicalResult CancellationPointOp::verify() {
return success();
}
+//===--===//
+// RegionOp
+//===--===//
+
+Logica
@@ -1987,4 +1987,40 @@ def ClauseRequiresAttr :
EnumAttr {
}
+
+def StructuredRegionOp : OpenMP_Op<"structured_region"> {
+ let summary = "Encapsulates a region in an OpenMP construct.";
+ let description = [{
+Encapsulates a region surrounded by an OpenMP Construct. T
@@ -119,6 +119,11 @@ def test(self):
self.assertEqual(task_type, task_head_pointee_type)
+# Check whether we can find a nested type by name
+name_type = task_type.FindNestedType("name")
Endilll wrote:
I can, but I'm not sure it would
@@ -186,6 +186,11 @@ std::optional
TypeSystem::ReportStatistics() {
return std::nullopt;
}
+CompilerDeclContext
Endilll wrote:
> Could add a brief oxygen docstring saying: "Returns the direct parent context
> of specified type".
I'd be happy to do that a
@@ -1082,6 +1082,19 @@ bool TypeImpl::GetDescription(lldb_private::Stream &strm,
return true;
}
+CompilerType TypeImpl::FindNestedType(ConstString name) {
Endilll wrote:
Makes sense.
IIRC it's possible to have multiple anonymous unions, so it's not going to
@@ -186,6 +186,11 @@ std::optional
TypeSystem::ReportStatistics() {
return std::nullopt;
}
+CompilerDeclContext
Michael137 wrote:
Could add a brief oxygen docstring saying: "Returns the direct parent context
of specified type". Also, what happens if no su
@@ -1082,6 +1082,19 @@ bool TypeImpl::GetDescription(lldb_private::Stream &strm,
return true;
}
+CompilerType TypeImpl::FindNestedType(ConstString name) {
Michael137 wrote:
fwiw, `name.IsValid()` would check for both nullptr and empty string
https://github
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/68705
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/68705
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -119,6 +119,11 @@ def test(self):
self.assertEqual(task_type, task_head_pointee_type)
+# Check whether we can find a nested type by name
+name_type = task_type.FindNestedType("name")
Michael137 wrote:
Should add tests for enums/uni
@@ -1082,6 +1082,19 @@ bool TypeImpl::GetDescription(lldb_private::Stream &strm,
return true;
}
+CompilerType TypeImpl::FindNestedType(ConstString name) {
Michael137 wrote:
Should an `empty` name require special treatment? Like we don't support that as
a v
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/68705
>From ca4d1bbdeb4ea541199e3db3518b35eb2d5a8cad Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Tue, 10 Oct 2023 15:07:56 +0300
Subject: [PATCH 1/4] [lldb] Add SBType::FindNestedType() function
---
lldb/
https://github.com/dtcxzyw closed
https://github.com/llvm/llvm-project/pull/67915
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
This can be used to have VS Code debug various emulators, remote systems,
hardware probes, etc.
In my case I was doing this for the Gameboy Advance,
https://github.com/stuij/gba-llvm-devkit/blob/main
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/68866
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/68866
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/68866
…ote gdbserver
This can be used to have VS Code debug various emulators, remote systems,
hardware probes, etc.
In my case I was doing this for the Gameboy Advance,
https://github.com/stuij/gba-llvm-devki
https://github.com/nikic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/67915
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Thanks for working on this! It's going to save me a lot of "b main" in the
future.
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
Michael137 wrote:
> It's not clear to me whether `TypeSystem::DeclContextIsContainedInLookup`
> provides such a guarantee. Implementation suggests that it's only interested
> in direct `DeclContext`, maybe ignoring transparent decl contexts like inline
> namespace it already handles. I hope re
100 matches
Mail list logo
