Author: Fangrui Song
Date: 2023-09-27T22:37:24-07:00
New Revision: 34ee53c9e390019d757b453ceba9cc3e47ab0df1
URL:
https://github.com/llvm/llvm-project/commit/34ee53c9e390019d757b453ceba9cc3e47ab0df1
DIFF:
https://github.com/llvm/llvm-project/commit/34ee53c9e390019d757b453ceba9cc3e47ab0df1.diff
@@ -0,0 +1,100 @@
+"""A tool for extracting a list of private lldb symbols to export for MSVC.
+
+When exporting symbols from a dll or exe we either need to mark the symbols in
+the source code as __declspec(dllexport) or supply a list of symbols to the
+linker. Private symbols in
@@ -0,0 +1,100 @@
+"""A tool for extracting a list of private lldb symbols to export for MSVC.
+
+When exporting symbols from a dll or exe we either need to mark the symbols in
+the source code as __declspec(dllexport) or supply a list of symbols to the
+linker. Private symbols in
https://github.com/walter-erquinigo approved this pull request.
Other than a few nits, this is awesome!
https://github.com/llvm/llvm-project/pull/67628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/67628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
I am implementing the fixes in the LanguageRuntime stuff. I have it working.
Stay tuned to updates to this patch.
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
https://github.com/shafik updated
https://github.com/llvm/llvm-project/pull/67514
>From e2e0e10e13748ba9369b73c7547c035ee75dfffa Mon Sep 17 00:00:00 2001
From: Shafik Yaghmour
Date: Tue, 26 Sep 2023 18:55:44 -0700
Subject: [PATCH] [Clang] Fix crash when visting a fold expression in a default
a
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
LLDB_EXPORT_ALL_SYMBOLS is useful when building out-of-tree plugins and
extensions that rely on LLDB's internal symbols. For example, this is how the
Mojo language provides its REPL and debugger support.
Supporting this on windows is kind
https://github.com/River707 updated
https://github.com/llvm/llvm-project/pull/67628
>From 5174dcdd77567cc4e0dd063f6e5b7fce18dd767b Mon Sep 17 00:00:00 2001
From: River Riddle
Date: Wed, 27 Sep 2023 18:59:53 -0700
Subject: [PATCH] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS
LLDB_EXPO
https://github.com/River707 created
https://github.com/llvm/llvm-project/pull/67628
LLDB_EXPORT_ALL_SYMBOLS is useful when building out-of-tree plugins and
extensions that rely on LLDB's internal symbols. For example, this is how the
Mojo language provides its REPL and debugger support.
Suppo
jimingham wrote:
I pushed this from the repro, going through the PR hoops was too much work just
for uglification...
https://github.com/llvm/llvm-project/pull/67621
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/67621
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jim Ingham
Date: 2023-09-27T17:20:48-07:00
New Revision: 0f339e6567bffb290e409ef5de272fb75ce70234
URL:
https://github.com/llvm/llvm-project/commit/0f339e6567bffb290e409ef5de272fb75ce70234
DIFF:
https://github.com/llvm/llvm-project/commit/0f339e6567bffb290e409ef5de272fb75ce70234.diff
LO
jimingham wrote:
> LGTM, thanks!
>
> Please fix the python formatting before landing.
Seriously, we're enforcing "" vrs. ''? This is silly.
https://github.com/llvm/llvm-project/pull/67621
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
https://github.com/bulbazord approved this pull request.
LGTM, thanks!
Please fix the python formatting before landing.
https://github.com/llvm/llvm-project/pull/67621
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
22433cc541ff706d9e845774ef1c8c959dc67799..fab5e1f67433a29a5d54198d83960d7e608dc480
lldb/t
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
We just forget to check for interrupt while waiting for the answer to the
prompt. But if we are in the interrupt state then the lower layers of the
EditLine code just eat all characters so we never get out of the query prompt.
You're prett
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/67621
We just forget to check for interrupt while waiting for the answer to the
prompt. But if we are in the interrupt state then the lower layers of the
EditLine code just eat all characters so we never get out of
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,65 @@
+//===-- ValueObjectVTable.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/bulbazord commented:
Overall I think this is fine, just a few comments here or there. I like the
idea a lot, thanks for working on this.
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@list
jimingham wrote:
> > This is an oft-requested feature so thanks for doing this!
> > My only real complaint is that the code that determines the C++ "dynamic
> > type" does much of the work that the ValueObjectVTable has to do to find
> > the vtable pointer, and it's enough code that it seems a
clayborg wrote:
> Looks good in general to me.
>
> Several scenarios to test:
>
> * Make sure command works when the vtable symbol can be found but the vtable
> exists in another binary which do not have any debug info (which we have seen
> failure from lldb before)
Good idea. I tried to tes
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
clayborg wrote:
> This is an oft-requested feature so thanks for doing this!
>
> My only real complaint is that the code that determines the C++ "dynamic
> type" does much of the work that the ValueObjectVTable has to do to find the
> vtable pointer, and it's enough code that it seems a shame
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/jimingham resolved
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -374,6 +374,34 @@ class LLDB_API SBValue {
lldb::SBWatchpoint WatchPointee(bool resolve_location, bool read, bool write,
SBError &error);
+ /// If this value represents a C++ class that has a vtable, return an value
+ /// that represent
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -1696,6 +1696,40 @@ TEST(Support, ReplacePathPrefix) {
EXPECT_EQ(Path, "C:\\old/foo\\bar");
}
+TEST(Support, FindProgramName) {
+ StringRef WindowsProgName =
+ path::program_name("C:\\Test\\foo.exe", path::Style::windows);
+ EXPECT_EQ(WindowsProgName, "foo");
+
+
jimingham wrote:
It might also be good to write a test that scribbles on the VTable and make
sure that we present that usefully. That is a significant use case for this
feature.
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailin
jimingham wrote:
This is an oft-requested feature so thanks for doing this!
My only real complaint is that the code that determines the C++ "dynamic type"
does much of the work that the ValueObjectVTable has to do to find the vtable
pointer, and it's enough code that it seems a shame to have t
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
jeffreytan81 wrote:
Looks good in general to me.
Several scenarios to test:
* Make sure command works when the vtable symbol can be found but the vtable
exists in another binary which do not have any symbols/debug info (which we
have seen failure from lldb before)
* Is vtable pointer guarante
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -374,6 +374,34 @@ class LLDB_API SBValue {
lldb::SBWatchpoint WatchPointee(bool resolve_location, bool read, bool write,
SBError &error);
+ /// If this value represents a C++ class that has a vtable, return an value
+ /// that represent
@@ -374,6 +374,34 @@ class LLDB_API SBValue {
lldb::SBWatchpoint WatchPointee(bool resolve_location, bool read, bool write,
SBError &error);
+ /// If this value represents a C++ class that has a vtable, return an value
+ /// that represent
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
Add the ability to get a C++ vtable ValueObject from another ValueObject.
This patch adds the ability to ask a ValueObject for a ValueObject that
represents the virtual function table for a C++ class. If the ValueObject is
not a C++ class
https://github.com/clayborg created
https://github.com/llvm/llvm-project/pull/67599
Add the ability to get a C++ vtable ValueObject from another ValueObject.
This patch adds the ability to ask a ValueObject for a ValueObject that
represents the virtual function table for a C++ class. If the Va
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
jimingham wrote:
We try to only add really frequently used aliases to the default lldb set. In
jimingham wrote:
First off, note that the case of std::strings is slightly orthogonal to what
you are doing here, because the thing that provides the "semantic" value for a
std::string is the std::string Summary Formatter. std::string doesn't actually
have a synthetic front end provider. So
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/67579
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
The LLVM implementation of DWARFDebugAbbrev does not have a way of listing all
the DW_FORM values that have been parsed but are unsupported or otherwise
unknown. AFAICT this functionality does not exist in LLVM at all. Since my
primary goa
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/67579
The LLVM implementation of DWARFDebugAbbrev does not have a way of listing all
the DW_FORM values that have been parsed but are unsupported or otherwise
unknown. AFAICT this functionality does not exist in LLV
aokblast wrote:
Thanks, maybe aokblast is more suitable. XD
https://github.com/llvm/llvm-project/pull/67106
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/67470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jeffreytan81
Date: 2023-09-27T09:14:40-07:00
New Revision: e8ea47602bdb74a88c707d289fc241f7670e1483
URL:
https://github.com/llvm/llvm-project/commit/e8ea47602bdb74a88c707d289fc241f7670e1483
DIFF:
https://github.com/llvm/llvm-project/commit/e8ea47602bdb74a88c707d289fc241f7670e1483.diff
emaste wrote:
> Excuse me. If the code works well now, I want to ask if I need to modify the
> commit message by myself so the message looks tidy, or let somebody landing
> this pull request modify the message?
This will be the first substantial change I'd land after LLVM moved to use pull
re
junior-jl wrote:
What are your thoughts on creating an alias for `process launch
--stop-at-user-entry` such as the intended `start` (or `begin`, or even `run
-m`).
Also, if I wanted to do that, the only change would be an `AddAlias` in
`CommandInterpreter.cpp`? Or there's something else?
ht
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -38,7 +39,36 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntry);
break;
-
+ case 'm': // Stop at user entry point
+ {
+TargetSP target_sp =
+execution_cont
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/67019
From 11270775865a8415e00b4d899703f84717344967 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Thu, 21 Sep 2023 11:12:58 -0300
Subject: [PATCH 1/7] [lldb] add command start
---
lldb/
aokblast wrote:
Excuse me. If the code works well now, I want to ask if I need to modify the
commit message by myself so the message looks tidy, or let somebody landing
this pull request modify the message?
https://github.com/llvm/llvm-project/pull/67106
___
https://github.com/aokblast resolved
https://github.com/llvm/llvm-project/pull/67106
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/aokblast updated
https://github.com/llvm/llvm-project/pull/67106
>From f8ed3ed64be0a451542a4ec71f254dc9038b2d19 Mon Sep 17 00:00:00 2001
From: aokblast
Date: Fri, 22 Sep 2023 18:11:07 +0800
Subject: [PATCH 1/5] feat: add DynamicLoaderFreeBSDKernel
---
.../Plugins/DynamicLoa
emaste wrote:
Needs to be adapted for f2d32ddcec82c20582c6aa32558b82ca7c3d3c50,
`lldb/source/{Core => Host/common}/StreamFile.cpp`
(I've applied the change locally for testing, and will just fold it into the
patch series if otherwise ready to go.)
https://github.com/llvm/llvm-project/pull/67
73 matches
Mail list logo
