https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/67055
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
How right you are.
I was thinking this was the ValueObject updated stuff, but it's the
SyntheticChildrenFrontEnd::Update. If I'm reading the code in
ValueObjectSyntheticFilter.cpp aright, the return for that actually means the
opposite of what you remembered. If you retur
jasonmolenda wrote:
re. TestStepOverWatchpoint.py this test case annoys me greatly. It wants to
test that we get a watchpoint trap when stepping over a function that accesses
the memory, and that we can stop on the watchpoint access when instruction
stepping. It wants to test this for read a
walter-erquinigo wrote:
@jimingham , IIRC from old experiments regarding the synthetic formatter code,
`true` is returned when you want to avoid caching the results of the `Update`,
which means that if you want to persist the success or the failure, you just
return `false`. I might be wrong bu
jimingham wrote:
Supposedly, Update returns true or false based on whether the update succeeds.
If we took that seriously, then it would be worrisome that you move one of the
possible failure modes from Update to GetChildAtIndex. But both these
functions return false no matter what happens,
Author: jeffreytan81
Date: 2023-09-21T15:45:42-07:00
New Revision: 9faf8b5117758cc6f117465fc6ce995a30864ae7
URL:
https://github.com/llvm/llvm-project/commit/9faf8b5117758cc6f117465fc6ce995a30864ae7
DIFF:
https://github.com/llvm/llvm-project/commit/9faf8b5117758cc6f117465fc6ce995a30864ae7.diff
https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/67069
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
Looks good to me. Anytime we can be more lazy the better.
https://github.com/llvm/llvm-project/pull/67069
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
yinghuitan abandoned this revision.
yinghuitan added a comment.
Abandon to use the github workflow
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159542/new/
https://reviews.llvm.org/D159542
___
lldb-comm
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
We noticed some performance issue while in lldb-vscode for grabing the name of
the SBValue. Profiling shows SBValue::GetName() can cause synthetic children
provider of shared/unique_ptr to deference underlying object and complete it
type.
https://github.com/jeffreytan81 created
https://github.com/llvm/llvm-project/pull/67069
We noticed some performance issue while in lldb-vscode for grabing the name of
the SBValue. Profiling shows SBValue::GetName() can cause synthetic children
provider of shared/unique_ptr to deference underly
yinghuitan created this revision.
yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere,
kusmour, GeorgeHuyubo.
Herald added a project: All.
yinghuitan requested review of this revision.
Herald added subscribers: lldb-commits, wangpc.
Herald added a project: LLDB.
We noti
jasonmolenda wrote:
@DavidSpickett pushed the fix for the `watch set expression` bug in
```
commit 35e3939cb06d19942a30fd39f1416f49a7b982a4
Author: Jason Molenda
Date: Thu Sep 21 14:48:19 2023 -0700
watch set expression's default type was wrong with new modify type
```
https://github.co
Author: Jason Molenda
Date: 2023-09-21T14:50:34-07:00
New Revision: 35e3939cb06d19942a30fd39f1416f49a7b982a4
URL:
https://github.com/llvm/llvm-project/commit/35e3939cb06d19942a30fd39f1416f49a7b982a4
DIFF:
https://github.com/llvm/llvm-project/commit/35e3939cb06d19942a30fd39f1416f49a7b982a4.diff
https://github.com/ZijunZhaoCCK ready_for_review
https://github.com/llvm/llvm-project/pull/66963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
Ah, I see the bug where `watch set expression` ends up marked as `rw`.
CommandObjectWatchpointSetExpression::DoExecute passes
`OptionGroupWatchpoint::eWatchModify` as the type to Target::CreateWatchpoint
(which takes that as a uint32_t). It passes that `uint32_t kind` to
jasonmolenda wrote:
FWIW I've found that `watch set expression -s ` will ignore the size
specified if there is a clang type of the expression, it seems. :(
https://github.com/llvm/llvm-project/pull/66308
___
lldb-commits mailing list
lldb-commits@lis
Author: Jim Ingham
Date: 2023-09-21T13:30:45-07:00
New Revision: b9e08cbf3037e03bdb2da700db3b02ed32e49b78
URL:
https://github.com/llvm/llvm-project/commit/b9e08cbf3037e03bdb2da700db3b02ed32e49b78
DIFF:
https://github.com/llvm/llvm-project/commit/b9e08cbf3037e03bdb2da700db3b02ed32e49b78.diff
LO
jasonmolenda wrote:
Thanks @DavidSpickett for looking into these. Let me looked into the tagged
ptr watchpoint issue right now, that sounds like a bug. One of the changes I
made in the second landing of my patch was to the TestStepOverWatchpoint C
file, which had three 1-byte globals, one wh
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
GetObjectPointer (and other related methods) do not need `ConstString`
parameters. The string parameter in these methods boil down to getting a
StringRef and calling `StackFrame::GetValueForVariableExpressionPath` which
takes a `StringRef`
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/67055
GetObjectPointer (and other related methods) do not need `ConstString`
parameters. The string parameter in these methods boil down to getting a
StringRef and calling `StackFrame::GetValueForVariableExpressionP
shafik added a comment.
Herald added a project: All.
Is this PR still relevant or can it be closed?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54053/new/
https://reviews.llvm.org/D54053
___
lldb-commits mailing list
lldb-commits@lists.llvm
jimingham wrote:
Even if this were enough behavior to warrant a new command, it would live under
the `process launch` node, not as a top level command. We try not to make lots
of top level commands so as to leave plenty of namespace in the easy access
commands for user customization.
https:/
https://github.com/jimingham requested changes to this pull request.
Half of this command is just `process launch --stop-at-entry`. If you wanted
to can the "break at main" part, then add a --stop-at-main to process launch.
And if you want a "start" command, the lldb way to do that would be t
ted added inline comments.
Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:133
+ABISysV_riscv::CreateInstance(ProcessSP process_sp, const ArchSpec &arch) {
+ if (process_sp) {
+process_sp->SetCanInterpretFunctionCalls(true);
DavidSpickett wrote:
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
## Description
This pull request adds a new `start` command to LLDB, allowing users to launch
a process and pause execution at either the `main` function or the first
instruction.
## Motivation
The `start` command provides a convenient way
https://github.com/junior-jl created
https://github.com/llvm/llvm-project/pull/67019
## Description
This pull request adds a new `start` command to LLDB, allowing users to launch
a process and pause execution at either the `main` function or the first
instruction.
## Motivation
The `start` co
Author: David Spickett
Date: 2023-09-21T15:04:15+01:00
New Revision: 2d69bb721386af419824c93fbeb92f79861f1add
URL:
https://github.com/llvm/llvm-project/commit/2d69bb721386af419824c93fbeb92f79861f1add
DIFF:
https://github.com/llvm/llvm-project/commit/2d69bb721386af419824c93fbeb92f79861f1add.diff
Author: David Spickett
Date: 2023-09-21T14:54:51+01:00
New Revision: 7e744460e7ef0c3c54191b4cd0d7e9749d6fc16c
URL:
https://github.com/llvm/llvm-project/commit/7e744460e7ef0c3c54191b4cd0d7e9749d6fc16c
DIFF:
https://github.com/llvm/llvm-project/commit/7e744460e7ef0c3c54191b4cd0d7e9749d6fc16c.diff
Author: David Spickett
Date: 2023-09-21T12:53:18Z
New Revision: 3fa503582315f23f187a019f026c5fce59b3f3d8
URL:
https://github.com/llvm/llvm-project/commit/3fa503582315f23f187a019f026c5fce59b3f3d8
DIFF:
https://github.com/llvm/llvm-project/commit/3fa503582315f23f187a019f026c5fce59b3f3d8.diff
LOG
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG43812c8c87b1: [lldb][AArch64] Linux corefile support for SME
(authored by DavidSpickett).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
Author: David Spickett
Date: 2023-09-21T13:24:34+01:00
New Revision: 43812c8c87b1c14bbcd160d613b7d8a60c21f260
URL:
https://github.com/llvm/llvm-project/commit/43812c8c87b1c14bbcd160d613b7d8a60c21f260
DIFF:
https://github.com/llvm/llvm-project/commit/43812c8c87b1c14bbcd160d613b7d8a60c21f260.diff
DavidSpickett updated this revision to Diff 557171.
DavidSpickett added a comment.
Remove redundant if.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158500/new/
https://reviews.llvm.org/D158500
Files:
lldb/source/Plugins/Process/Utility/Registe
DavidSpickett wrote:
Where the "commands" are:
```
watchpoint set expression -s 4 -- tagged_ptr
watchpoint set variable global_var
```
They default to different types.
https://github.com/llvm/llvm-project/pull/66308
___
lldb-commits mailing list
lldb-c
DavidSpickett wrote:
I've updated the tests and relanded but there is still some stuff to check. The
tagged address test is working fine but the default watchpoint type is
different between the 2 commands, which seems wrong at first glance.
For the other one see https://github.com/llvm/llvm-pr
Author: David Spickett
Date: 2023-09-21T10:35:15Z
New Revision: 75e862077834c06e574d34e8958dd2ee7cc1d334
URL:
https://github.com/llvm/llvm-project/commit/75e862077834c06e574d34e8958dd2ee7cc1d334
DIFF:
https://github.com/llvm/llvm-project/commit/75e862077834c06e574d34e8958dd2ee7cc1d334.diff
LOG
omjavaid accepted this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.
This looks good with just one nit above.
Comment at:
lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:74
- if (m_register_info_up->IsSVEEnabled
DavidSpickett wrote:
I've reverted this due to failures on Arm/AArch64 Linux, well, one test
failing, one passing unexpectedly. Likely they are expecting the watchpoint to
go off even when not modified. If I can fix them I'll do that and reland this.
https://github.com/llvm/llvm-project/pull/6
Author: David Spickett
Date: 2023-09-21T09:30:07Z
New Revision: a7b78cac9a77e3ef6bbbd8ab1a559891dc693401
URL:
https://github.com/llvm/llvm-project/commit/a7b78cac9a77e3ef6bbbd8ab1a559891dc693401
DIFF:
https://github.com/llvm/llvm-project/commit/a7b78cac9a77e3ef6bbbd8ab1a559891dc693401.diff
LOG
DavidSpickett wrote:
Thanks for looking into this. Well for now at least we know that users on Linux
will only see the bug 1 in N times :)
(the bots are still red but for unrelated reasons)
https://github.com/llvm/llvm-project/pull/65822
___
lldb-com
Endill abandoned this revision.
Endill added a comment.
Moved to GitHub: https://github.com/llvm/llvm-project/pull/66879
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156774/new/
https://reviews.llvm.org/D156774
___
dtcxzyw wrote:
> You might want to check whether this also fixes #66740 and if so add a test.
Confirmed. I have added a pre-commit test for 66733 in
1a73a6b80b54cd23ee8380c6fa3304847e5cb5d1.
https://github.com/llvm/llvm-project/pull/66740
___
lldb-co
https://github.com/dtcxzyw edited
https://github.com/llvm/llvm-project/pull/66740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dtcxzyw updated
https://github.com/llvm/llvm-project/pull/66740
>From 85f7911dfe0f1e9112881a9f503bcd68edfde580 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Tue, 19 Sep 2023 10:19:46 +0800
Subject: [PATCH 1/3] [InstCombine] Canonicalize `and(zext(A), B)` into `select
A,
https://github.com/dtcxzyw edited
https://github.com/llvm/llvm-project/pull/66740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
45 matches
Mail list logo
