zhyty wrote:
Added tests for the human-readable/table format.
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty updated https://github.com/llvm/llvm-project/pull/66035
>From 9a52ac5193af2a8ddca2a5d922684935b043d0ef Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH] Add `target modules dump separate-debug-info`
Summary:
Add a new comman
https://github.com/zhyty updated https://github.com/llvm/llvm-project/pull/66035
>From 5bf6c4a90bf578af56fb0da30586086fd777bd55 Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH] Add `target modules dump separate-debug-info`
Summary:
Add a new comman
Author: Jonas Devlieghere
Date: 2023-09-14T22:16:24-07:00
New Revision: 111bc6f1fe6536ac091d4490c112ce7242e00349
URL:
https://github.com/llvm/llvm-project/commit/111bc6f1fe6536ac091d4490c112ce7242e00349
DIFF:
https://github.com/llvm/llvm-project/commit/111bc6f1fe6536ac091d4490c112ce7242e00349.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/66447
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -57,6 +57,29 @@ def test_add_dsym_with_dSYM_bundle(self):
self.exe_name = "a.out"
self.do_add_dsym_with_dSYM_bundle(self.exe_name)
+@no_debug_info_test
+def test_report_symbol_load(self):
+"""Test that when adding a symbol file, the eBroadcas
@@ -661,27 +661,27 @@ static bool FixupInvocation(CompilerInvocation
&Invocation,
static unsigned getOptimizationLevel(ArgList &Args, InputKind IK,
DiagnosticsEngine &Diags) {
- unsigned DefaultOpt = llvm::CodeGenOpt::None;
+ unsigned De
clayborg wrote:
> You and Alex both preferred adding an Options class to pass in to this (and
> future WatchpointCreate API) so I'll write that up for my next revision of
> this PR, I didn't see your earlier message talking about your preference for
> that when I ping'ed Alex on their opinion.
jimingham wrote:
I'm not sure I see the benefit of the SBWatchpointSpec including the way the
watched region is specified. That's just moving the proliferation of API's
from SBTarget::WatchpointCreate*() to the SBWatchpointSpec constructor. We'd
have to have:
SBWatchpointSpec::SBWatchpointSp
@@ -11,6 +11,7 @@
#include "DIERef.h"
#include "lldb/Symbol/SymbolFile.h"
+#include "lldb/Utility/ConstString.h"
clayborg wrote:
Remove this now that we aren't returning a std::optional
https://github.com/llvm/llvm-project/pull/66035
https://github.com/clayborg requested changes to this pull request.
Just need tests for the non --json output for OSO and DWO. If you can also
attach the output of the 4 cases (OSO no errors, OSO with errors, DWO no errors
and DWO with errors), that might help people see what this output looks
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -661,27 +661,27 @@ static bool FixupInvocation(CompilerInvocation
&Invocation,
static unsigned getOptimizationLevel(ArgList &Args, InputKind IK,
DiagnosticsEngine &Diags) {
- unsigned DefaultOpt = llvm::CodeGenOpt::None;
+ unsigned De
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/66447:
>From 1d9a7f7302b57883d316205967904268e0e54e59 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 14 Sep 2023 16:47:49 -0700
Subject: [PATCH] [lldb] Add config and decorator for wide character supp
zhyty wrote:
Addressed @clayborg's comments: removed trailing whitespaces, simplify the
`SymbolFile` functions into one.
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2035,8 +2118,8 @@ class CommandObjectTargetModulesDumpSymtab
result.GetOutputStream().EOL();
result.GetOutputStream().EOL();
}
- if (INTERRUPT_REQUESTED(GetDebugger(),
zhyty wrote:
Done. Turns out
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty updated
https://github.com/llvm/llvm-project/pull/66035:
>From 2bb9a2a245d214bf4201d28037f498da5a94c78f Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH] Add `target modules dump separate-debug-info`
Summary:
Add a new comm
https://github.com/mysterymath approved this pull request.
https://github.com/llvm/llvm-project/pull/66447
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -781,6 +781,9 @@ SBStructuredData SBDebugger::GetBuildConfiguration() {
AddBoolConfigEntry(
*config_up, "editline", LLDB_ENABLE_LIBEDIT,
"A boolean value that indicates if editline support is enabled in LLDB");
+ AddBoolConfigEntry(
+ *config_up, "editlin
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
Add a configuration entry for whether LLDB was configured with wide character
support in Editline and use it in a decorator to guard the UTF-8 prompt test.
--
Full diff: https://github.com/llvm/llvm-project/pull/66447.diff
3 File
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66447
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
I added a configuration entry and corresponding decorator in #66447.
https://github.com/llvm/llvm-project/pull/66312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/66447:
Add a configuration entry for whether LLDB was configured with wide character
support in Editline and use it in a decorator to guard the UTF-8 prompt test.
>From 6e745a62dea1efd8cd614c7a206ddf715aefc867 Mo
https://github.com/JDevlieghere review_requested
https://github.com/llvm/llvm-project/pull/66447
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere review_requested
https://github.com/llvm/llvm-project/pull/66447
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere review_requested
https://github.com/llvm/llvm-project/pull/66447
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -71,7 +71,8 @@ void GPUToSPIRVPass::runOnOperation() {
std::unique_ptr target =
spirv::getMemorySpaceToStorageClassTarget(*context);
spirv::MemorySpaceToStorageClassMap memorySpaceMap =
- spirv::mapMemorySpaceToVulkanStorageClass;
+ th
dankm wrote:
Hm. I'm happy with this file, but I also discovered a bunch of other
`tool-name` tests that can be updated. I'll add those too.
https://github.com/llvm/llvm-project/pull/65812
___
lldb-commits mailing li
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/65812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/65812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/65812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
> > ```
> >SBWatchpoint SBTarget::WatchpointCreateByAddress(addr_t address, size_t
> > size, uint32_t access_flags, SBError &error);
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > with `eWatchpointAccess{Read,Write,Modify}` f
https://github.com/dankm updated
https://github.com/llvm/llvm-project/pull/65812:
>From 416d75e617cc87b6e497815ce6ad1da630eb14a1 Mon Sep 17 00:00:00 2001
From: Dan McGregor
Date: Mon, 14 Aug 2023 18:44:08 -0600
Subject: [PATCH 1/2] Support: hoist lld's executable name code to Path
Instead of u
jasonmolenda wrote:
> > > ```
> > >SBWatchpoint SBTarget::WatchpointCreateByAddress(addr_t address,
> > > size_t size, uint32_t access_flags, SBError &error);
> > > ```
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > with `eWat
clayborg wrote:
> > ```
> >SBWatchpoint SBTarget::WatchpointCreateByAddress(addr_t address, size_t
> > size, uint32_t access_flags, SBError &error);
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > with `eWatchpointAccess{Read,Write,Modify}` fl
@@ -2035,8 +2118,8 @@ class CommandObjectTargetModulesDumpSymtab
result.GetOutputStream().EOL();
result.GetOutputStream().EOL();
}
- if (INTERRUPT_REQUESTED(GetDebugger(),
clayborg wrote:
It would be
@@ -162,6 +163,21 @@ void SymbolFile::AssertModuleLock() {
SymbolFile::RegisterInfoResolver::~RegisterInfoResolver() = default;
+bool SymbolFile::ListSeparateDebugInfoFiles(StructuredData::Dictionary &d) {
+ StructuredData::Array array;
+ std::optional debug_info_type =
Ge
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -459,6 +470,14 @@ class SymbolFile : public PluginInterface {
virtual void GetCompileOptions(
std::unordered_map &args) {}
+ /// If separate debug info files are supported and this function succeeded,
+ /// return some string representing the type of debug info. E
mysterymath wrote:
I dug into this a little bit; it looks like the autodetection for
`LLDB_EDITLINE_USE_WCHAR` was broken on our build, so it was turned `OFF`, even
though our libedit supports the wchar API. I can fix this on our end, but more
generally, is there a way to condition this test o
https://github.com/aeubanks closed
https://github.com/llvm/llvm-project/pull/66295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
> ```
>SBWatchpoint SBTarget::WatchpointCreateByAddress(addr_t address, size_t
> size, uint32_t access_flags, SBError &error);
> ```
>
> with `eWatchpointAccess{Read,Write,Modify}` flags defined.
@bulbazord what do you think about this suggestion? Would you still pref
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/66144:
>From 8754d93a72bdff94f95f991d9bf1112e5f9fe692 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 12 Sep 2023 13:49:50 -0700
Subject: [PATCH 1/4] [lldb][Commands] Show symbol change bit in SB API
@@ -57,6 +57,29 @@ def test_add_dsym_with_dSYM_bundle(self):
self.exe_name = "a.out"
self.do_add_dsym_with_dSYM_bundle(self.exe_name)
+@no_debug_info_test
+def test_report_symbol_load(self):
+"""Test that when adding a symbol file, the eBroadcas
https://github.com/bnbarham closed
https://github.com/llvm/llvm-project/pull/66271
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bnbarham wrote:
Everything seems to work fine without it, so I'll put up that PR again without
that check and close this PR.
https://github.com/llvm/llvm-project/pull/66271
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
zhyty wrote:
Updated to show a more human-readable format @jimingham.
Also addressed comments by @DavidSpickett.
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
https://github.com/zhyty edited https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty updated
https://github.com/llvm/llvm-project/pull/66035:
>From 94b834f747fe66a50288e23fec2d00918f4fc8ef Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH] Add `target modules dump separate-debug-info`
Summary:
Add a new comm
https://github.com/zhyty updated
https://github.com/llvm/llvm-project/pull/66035:
>From d0538bc86ec02819ed9a24d06a2e7fc355447f4b Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH] Add `target modules dump separate-debug-info`
Summary:
Add a new comm
augusto2112 wrote:
> > @clayborg as Adrian said, this fixes a test failure downstream. I don't
> > there's any visible change in behavior to test in main, unfortunately.
>
> Gotcha. Let me guess: Swift? :-)
Exactly :)
https://github.com/llvm/llvm-project/pull/66286
___
clayborg wrote:
> @clayborg as Adrian said, this fixes a test failure downstream. I don't
> there's any visible change in behavior to test in main, unfortunately.
Gotcha. Let me guess: Swift? :-)
https://github.com/llvm/llvm-project/pull/66286
___
l
augusto2112 wrote:
@clayborg as Adrian said, this fixes a test failure downstream. I don't there's
any visible change in behavior to test in main, unfortunately.
https://github.com/llvm/llvm-project/pull/66286
___
lldb-commits mailing list
lldb-commit
clayborg wrote:
> > > Just to be clear, I need to find a solution for
> > > SBTarget::CreateWatchpoint before this PR is ready to land. I'm inclined
> > > towards adding a third bool parameter 'modify', but I'm not sure that's
> > > the best choice.
> >
> >
> > Anytime we keep adding more op
adrian-prantl wrote:
IIUC, this is an infrastructure change that fixes a test failure in swift
branch. Augusto can speak to whether it's testable on `main`.
https://github.com/llvm/llvm-project/pull/66286
___
lldb-commits mailing list
lldb-commits@lis
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa5a2a5a3eca0: [lldb][NFCI] Remove use of ConstString in
StructuredData (authored by bulbazord).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159313/new/
ht
Author: Alex Langford
Date: 2023-09-14T10:53:39-07:00
New Revision: a5a2a5a3eca06998d9f71186db2ce78ae2716022
URL:
https://github.com/llvm/llvm-project/commit/a5a2a5a3eca06998d9f71186db2ce78ae2716022
DIFF:
https://github.com/llvm/llvm-project/commit/a5a2a5a3eca06998d9f71186db2ce78ae2716022.diff
@@ -0,0 +1,23 @@
+.. title:: clang-tidy - performance-move-smart-pointer-contents
+
+performance-move-smart-pointer-contents
+===
+
+Given a smart pointer containing a movable type, such as a
+`std::unique_ptr`, it's possible to move the content
@@ -0,0 +1,23 @@
+.. title:: clang-tidy - performance-move-smart-pointer-contents
+
+performance-move-smart-pointer-contents
+===
+
+Given a smart pointer containing a movable type, such as a
EugeneZelenko wrote:
Please synchro
@@ -0,0 +1,23 @@
+.. title:: clang-tidy - performance-move-smart-pointer-contents
+
+performance-move-smart-pointer-contents
+===
+
+Given a smart pointer containing a movable type, such as a
+`std::unique_ptr`, it's possible to move the content
fdeazeve accepted this revision.
fdeazeve added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159313/new/
https://reviews.llvm.org/D159313
__
bulbazord updated this revision to Diff 556798.
bulbazord added a comment.
Remove unneeded lambda
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159313/new/
https://reviews.llvm.org/D159313
Files:
lldb/include/lldb/Utility/StructuredData.h
lldb
bulbazord added inline comments.
Comment at: lldb/source/Utility/StructuredData.cpp:249-251
+ llvm::sort(sorted_entries, [&](const Entry &lhs, const Entry &rhs) -> bool {
+return lhs.first < rhs.first;
+ });
Oh I can remove this lambda too -- Let me update.
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2f377c5bd713: [lldb][NFCI] Remove use of ConstString from
UnixSignals (authored by bulbazord).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
Author: Alex Langford
Date: 2023-09-14T10:19:53-07:00
New Revision: 2f377c5bd713e9ee72faa6a99088bb81358059e3
URL:
https://github.com/llvm/llvm-project/commit/2f377c5bd713e9ee72faa6a99088bb81358059e3
DIFF:
https://github.com/llvm/llvm-project/commit/2f377c5bd713e9ee72faa6a99088bb81358059e3.diff
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy
authoring and uploading a patch. LLDB differs from the LLVM Developer
Policy in the following respects.
- - **Test infrastructure**: Like LLVM it is important to submit tests with
your
- patches, but note that
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy
authoring and uploading a patch. LLDB differs from the LLVM Developer
Policy in the following respects.
- - **Test infrastructure**: Like LLVM it is important to submit tests with
your
- patches, but note that
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy
authoring and uploading a patch. LLDB differs from the LLVM Developer
Policy in the following respects.
- - **Test infrastructure**: Like LLVM it is important to submit tests with
your
- patches, but note that
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
None
--
Full diff: https://github.com/llvm/llvm-project/pull/66400.diff
3 Files Affected:
- (renamed) lldb/test/API/lang/objc/charstar_dyntype/Makefile (-3)
- (renamed) lldb/test/API/lang/objc/charstar_dyntype/TestCharStarDynTyp
Author: Adrian Prantl
Date: 2023-09-14T09:48:36-07:00
New Revision: 9dfc6d37da65b94208bf81b06908bb20d92de8fb
URL:
https://github.com/llvm/llvm-project/commit/9dfc6d37da65b94208bf81b06908bb20d92de8fb
DIFF:
https://github.com/llvm/llvm-project/commit/9dfc6d37da65b94208bf81b06908bb20d92de8fb.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/66400
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66400
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl review_requested
https://github.com/llvm/llvm-project/pull/66400
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl review_requested
https://github.com/llvm/llvm-project/pull/66400
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl review_requested
https://github.com/llvm/llvm-project/pull/66400
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/66400:
None
>From d14e5d08571ea206b1ee8dd0ffc66f896306d15e Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 14 Sep 2023 09:44:15 -0700
Subject: [PATCH] Clean up test case
---
.../Makefile
@@ -3109,14 +3109,15 @@ static GDBStoppointType GetGDBStoppointType(Watchpoint
*wp) {
assert(wp);
bool watch_read = wp->WatchpointRead();
bool watch_write = wp->WatchpointWrite();
+ bool watch_modify = wp->WatchpointModify();
- // watch_read and watch_write cannot bo
@@ -211,6 +212,35 @@ bool Watchpoint::CaptureWatchedValue(const
ExecutionContext &exe_ctx) {
return (m_new_value_sp && m_new_value_sp->GetError().Success());
}
+bool Watchpoint::WatchedValueReportable(const ExecutionContext &exe_ctx) {
+ if (!m_watch_modify)
+return tr
bulbazord wrote:
> @bulbazord This would be a good place to put your plugin dependency / const
> string guidance. Or tell me where it lives now and I'll link to it.
Oh, yes! I'd be happy to take care of that after this goes in, thanks for
pointing that out! :)
https://github.com/llvm/llvm-pro
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy
authoring and uploading a patch. LLDB differs from the LLVM Developer
Policy in the following respects.
- - **Test infrastructure**: Like LLVM it is important to submit tests with
your
- patches, but note that
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy
authoring and uploading a patch. LLDB differs from the LLVM Developer
Policy in the following respects.
- - **Test infrastructure**: Like LLVM it is important to submit tests with
your
- patches, but note that
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy
authoring and uploading a patch. LLDB differs from the LLVM Developer
Policy in the following respects.
- - **Test infrastructure**: Like LLVM it is important to submit tests with
your
- patches, but note that
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy
authoring and uploading a patch. LLDB differs from the LLVM Developer
Policy in the following respects.
- - **Test infrastructure**: Like LLVM it is important to submit tests with
your
- patches, but note that
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/66345
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord commented:
Excellent write up, thanks for taking care of that!
https://github.com/llvm/llvm-project/pull/66345
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
gulfemsavrun wrote:
We started seeing a test failure after this commit.
```
UNRESOLVED: lldb-api :: terminal/TestEditline.py (2430 of 2430)
TEST 'lldb-api :: terminal/TestEditline.py' FAILED
Script:
--
/b/s/w/ir/x/w/lldb_install/python3/bin/python3
/b/s
Valentin Clement =?utf-8?b?KOODkOODrOODsw==?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw==?=,Jonas Devlieghere
,Douglas Yung ,daisy202309
<144047963+daisy202...@users.noreply.github.com>,Jonas Devlieghere
,Mehdi Amini ,Siva Chandra
,Jonas Devlieghere ,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Jonas Devlieghere
,Douglas Yung ,daisy202309
<144047963+daisy202...@users.noreply.github.com>,Jonas Devlieghere
,Mehdi Amini ,Siva Chandra
,Jonas Devlieghere ,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Jonas Devlieghere
,Douglas Yung ,daisy202309
<144047963+daisy202...@users.noreply.github.com>,Jonas Devlieghere
,Mehdi Amini ,Siva Chandra
,Jonas Devlieghere ,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Jonas Devlieghere
,Douglas Yung ,daisy202309
<144047963+daisy202...@users.noreply.github.com>,Jonas Devlieghere
,Mehdi Amini ,Siva Chandra
,Jonas Devlieghere ,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=
1 - 100 of 146 matches
Mail list logo
