clayborg created this revision.
clayborg added reviewers: labath, JDevlieghere, GeorgeHuyubo, yinghuitan,
kusmour.
Herald added a project: All.
clayborg requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Our LLDB parser didn't correctly handl
Author: Kazu Hirata
Date: 2023-09-02T09:32:48-07:00
New Revision: 5dd956871785a5b04903d6da85109c9e1052a8a8
URL:
https://github.com/llvm/llvm-project/commit/5dd956871785a5b04903d6da85109c9e1052a8a8
DIFF:
https://github.com/llvm/llvm-project/commit/5dd956871785a5b04903d6da85109c9e1052a8a8.diff
L
kkcode0 added inline comments.
Comment at:
lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:186-193
-
-if (!SetRendezvousBreakpoint()) {
- // If we cannot establish rendezvous breakpoint right now we'll try again
- // at entry point.
- P
kkcode0 added inline comments.
Comment at:
lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:114-117
+ tp = LLDB_INVALID_ADDRESS;
+ Status error;
+ return error;
+}
labath wrote:
> Is this necessary, given that the function is already stubbed o
kkcode0 updated this revision to Diff 92.
kkcode0 marked an inline comment as done.
kkcode0 added a comment.
spacing
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143698/new/
https://reviews.llvm.org/D143698
Files:
lldb/include/lldb/Host/com
kkcode0 updated this revision to Diff 91.
kkcode0 marked 3 inline comments as done.
kkcode0 added a comment.
address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143698/new/
https://reviews.llvm.org/D143698
Files:
lldb/inclu
mib accepted this revision.
mib added a comment.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159387/new/
https://reviews.llvm.org/D159387
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
kkcode0 updated this revision to Diff 75.
kkcode0 added a comment.
formatting
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143698/new/
https://reviews.llvm.org/D143698
Files:
lldb/include/lldb/Host/common/NativeRegisterContext.h
lldb/incl
kkcode0 updated this revision to Diff 74.
kkcode0 marked an inline comment as done.
kkcode0 added a comment.
formatting
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143698/new/
https://reviews.llvm.org/D143698
Files:
lldb/include/lldb/Host/
kkcode0 updated this revision to Diff 73.
kkcode0 added a comment.
formatting
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143698/new/
https://reviews.llvm.org/D143698
Files:
lldb/include/lldb/Host/common/NativeRegisterContext.h
lldb/incl
kkcode0 updated this revision to Diff 72.
kkcode0 added a comment.
formatting
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143698/new/
https://reviews.llvm.org/D143698
Files:
lldb/include/lldb/Host/common/NativeRegisterContext.h
lldb/incl
11 matches
Mail list logo