[Lldb-commits] [PATCH] D158785: [lldb] Add a "thread extrainfo" LC_NOTE for Mach-O corefiles, to store the thread IDs of the threads

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:5682-5693 + for (uint32_t i = 0; i < m_header.ncmds; ++i) { +const uint32_t cmd_offset = offset; +llvm::MachO::load_command lc = {}; +if (m_data.GetU32(&offset,

[Lldb-commits] [PATCH] D158893: [lldb] Fix TestVSCode_completions on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7ca1175d0d4: [lldb] Fix & re-enable TestVSCode_completions on Darwin (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [lldb] a7ca117 - [lldb] Fix & re-enable TestVSCode_completions on Darwin

Author: Jonas Devlieghere Date: 2023-08-25T14:35:07-07:00 New Revision: a7ca1175d0d4f3ec8ed04cf2e2d380d007681f6e URL: https://github.com/llvm/llvm-project/commit/a7ca1175d0d4f3ec8ed04cf2e2d380d007681f6e DIFF: https://github.com/llvm/llvm-project/commit/a7ca1175d0d4f3ec8ed04cf2e2d380d007681f6e.d

[Lldb-commits] [PATCH] D158893: [lldb] Fix TestVSCode_completions on Darwin

JDevlieghere added a comment. In D158893#4618503 , @wallace wrote: > Awesome!! Thank you for the prompt reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158893/new/ https://reviews.llvm.org/D158893 __

[Lldb-commits] [PATCH] D158785: [lldb] Add a "thread extrainfo" LC_NOTE for Mach-O corefiles, to store the thread IDs of the threads

bulbazord added a comment. The idea itself looks good to me. It would be nice if we could maintain a schema for this format in documentation or elsewhere so future code spelunkers have an idea of what the parsing and saving code are doing while they read it. Comment at: lldb

[Lldb-commits] [PATCH] D158893: [lldb] Fix TestVSCode_completions on Darwin

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Awesome!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158893/new/ https://reviews.llvm.org/D158893 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D158893: [lldb] Fix TestVSCode_completions on Darwin

JDevlieghere created this revision. JDevlieghere added reviewers: wallace, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. The test was expecting `vector> &` while the test returned `vector &`. Since `verify_completions` doesn't support regex matching, side

[Lldb-commits] [PATCH] D158785: [lldb] Add a "thread extrainfo" LC_NOTE for Mach-O corefiles, to store the thread IDs of the threads

jasonmolenda added a comment. One interesting question about the basic design of this LC_NOTE. If I call it "thread extrainfo" and it is a JSON dictionary with a `threads` array -- how long before someone wants to stick some non-thread specific piece of data in here. Should it be a `proc meta

[Lldb-commits] [lldb] 6bdf485 - [lldb] Re-enable TestVSCode_launch on Darwin

Author: Jonas Devlieghere Date: 2023-08-25T13:52:45-07:00 New Revision: 6bdf485887e5a2d613c3bf23ce96c216a086dfca URL: https://github.com/llvm/llvm-project/commit/6bdf485887e5a2d613c3bf23ce96c216a086dfca DIFF: https://github.com/llvm/llvm-project/commit/6bdf485887e5a2d613c3bf23ce96c216a086dfca.d

[Lldb-commits] [lldb] 37086ca - [lldb] Use Popen.wait in TestVSCode_launch

Author: Jonas Devlieghere Date: 2023-08-25T12:59:52-07:00 New Revision: 37086cadb1aebb306e06a6a122c6a82305286c9d URL: https://github.com/llvm/llvm-project/commit/37086cadb1aebb306e06a6a122c6a82305286c9d DIFF: https://github.com/llvm/llvm-project/commit/37086cadb1aebb306e06a6a122c6a82305286c9d.d

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

wallace added a comment. In D158010#4617611 , @electriclilies wrote: > @wallace The type synthetic add command already disables itself if python is > not enabled (the check is at CommandObjectType::1564), so I think there > aren't any changes I need to

[Lldb-commits] [lldb] 1034688 - [lldb] Re-enable TestVSCode_disconnect on Darwin

Author: Jonas Devlieghere Date: 2023-08-25T11:02:38-07:00 New Revision: 1034688d58783779168d59b47d2b3e897ad869c6 URL: https://github.com/llvm/llvm-project/commit/1034688d58783779168d59b47d2b3e897ad869c6 DIFF: https://github.com/llvm/llvm-project/commit/1034688d58783779168d59b47d2b3e897ad869c6.d

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

electriclilies added a comment. @wallace The type synthetic add command already disables itself if python is not enabled (the check is at CommandObjectType::1564), so I think there aren't any changes I need to make Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [lldb] 50b1276 - [lldb] Qualify `auto` in the lldb driver (NFC)

Author: Jonas Devlieghere Date: 2023-08-25T07:40:37-07:00 New Revision: 50b127613abc1a3d52f4f0f98ef6cdff4f9d39c8 URL: https://github.com/llvm/llvm-project/commit/50b127613abc1a3d52f4f0f98ef6cdff4f9d39c8 DIFF: https://github.com/llvm/llvm-project/commit/50b127613abc1a3d52f4f0f98ef6cdff4f9d39c8.d

[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

mib created this revision. mib added reviewers: JDevlieghere, jingham, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. As we're consolidating and streamlining the various scripting affordances of ll