[Lldb-commits] [PATCH] D157137: [lldb/crashlog] Skip images with empty path and 0 UUID from loading

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157137/new/ https://reviews.llvm.org/D157137 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu added a comment. Thank you @jasonmolenda. If there are no further comments on llvm side, I will land this in a couple of days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156086/new/ https://reviews.llvm.org/D156086 __

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

wallace added a comment. Btw, the SBAPI expects the old behavior. // Set the timeout for the expression, 0 means wait forever. void SetTimeoutInMicroSeconds(uint32_t timeout = 0); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157764/new/ https

[Lldb-commits] [PATCH] D157137: [lldb/crashlog] Skip images with empty path and 0 UUID from loading

mib updated this revision to Diff 549560. mib added a comment. Address @bulbazord comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157137/new/ https://reviews.llvm.org/D157137 Files: lldb/examples/python/symbolication.py Index: lldb/examples/python/symbolication.py =

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

rriddle added a comment. This makes sense to me, but again will defer to area owners for what the expectation is here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157764/new/ https://reviews.llvm.org/D157764

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

augusto2112 updated this revision to Diff 549548. augusto2112 added a comment. Changed to regular mutex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157654/new/ https://reviews.llvm.org/D157654 Files: lldb/include/lldb/Host/posix/PipePosix.h

[Lldb-commits] [PATCH] D157759: [lldb] Remove use of __future__ in python

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Although we should make sure no one is still using Python 2 downstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157759/new/ https://reviews

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

JDevlieghere added a comment. In D157654#4581578 , @augusto2112 wrote: > @JDevlieghere I updated this to two shared mutexes because I'm assuming you > can have more than one concurrent read and more than one concurrent write. If > this is wrong I can g

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

augusto2112 added a comment. @JDevlieghere I updated this to two shared mutexes because I'm assuming you can have more than one concurrent read and more than one concurrent write. If this is wrong I can go back to two regular mutexes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

augusto2112 updated this revision to Diff 549539. augusto2112 added a comment. Update to two shared mutexes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157654/new/ https://reviews.llvm.org/D157654 Files: lldb/include/lldb/Host/posix/PipePosix.

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

wallace created this revision. wallace added a reviewer: bulbazord. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. https://github.com/llvm/llvm-project/commit/59237bb52c9483fce395428bfab5996eabe54ed0 c

[Lldb-commits] [PATCH] D157760: [lldb] Properly protect the Communication class with reader/writer lock

augusto2112 created this revision. augusto2112 added reviewers: JDevlieghere, bulbazord. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch picks up where https://reviews.llvm.org/D157159 lef

[Lldb-commits] [PATCH] D157759: [lldb] Remove use of __future__ in python

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, kastiglione, DavidSpickett. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These were useful primarily for the Python 2 t

[Lldb-commits] [PATCH] D157659: Have SBTarget::AddModule force a possibly-slow search for the binary, and if the Target has no arch, initialize it with the binary's arch

This revision was automatically updated to reflect the committed changes. Closed by commit rGebf249066ac5: [lldb] SBTarget::AddModule do all searches by UUID, set Target arch (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [lldb] ebf2490 - [lldb] SBTarget::AddModule do all searches by UUID, set Target arch

Author: Jason Molenda Date: 2023-08-11T14:20:38-07:00 New Revision: ebf249066ac5c7917064eb56a9e51c21000cdf93 URL: https://github.com/llvm/llvm-project/commit/ebf249066ac5c7917064eb56a9e51c21000cdf93 DIFF: https://github.com/llvm/llvm-project/commit/ebf249066ac5c7917064eb56a9e51c21000cdf93.diff

[Lldb-commits] [PATCH] D157756: Support corefiles that put the uuid of their binary in a fixed address in low memory; load that binary

jasonmolenda updated this revision to Diff 549516. jasonmolenda added a comment. Fix size check when making sure there's enough data. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157756/new/ https://reviews.llvm.org/D157756 Files: lldb/source/P

[Lldb-commits] [PATCH] D157756: Support corefiles that put the uuid of their binary in a fixed address in low memory; load that binary

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. There are some Mach-O coref

[Lldb-commits] [PATCH] D157667: Define qHostInfo and Mach-O LC_NOTE "addrable bits" methods to describe high and low memory addressing bits

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM. You may want to wait for Jonas to take a look before landing though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157667/new/ https

[Lldb-commits] [PATCH] D157659: Have SBTarget::AddModule force a possibly-slow search for the binary, and if the Target has no arch, initialize it with the binary's arch

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157659/new/ https://reviews.llvm.org/D157659 _

[Lldb-commits] [PATCH] D157659: Have SBTarget::AddModule force a possibly-slow search for the binary, and if the Target has no arch, initialize it with the binary's arch

bulbazord added inline comments. Comment at: lldb/test/API/python_api/target-arch-from-module/TestTargetArchFromModule.py:39 +dwarfdump_cmd_output = subprocess.check_output( +('/usr/bin/dwarfdump --uuid "%s"' % aout_exe), shell=True +).decode("utf-8")

[Lldb-commits] [PATCH] D157659: Have SBTarget::AddModule force a possibly-slow search for the binary, and if the Target has no arch, initialize it with the binary's arch

jasonmolenda updated this revision to Diff 549507. jasonmolenda added a comment. Incorporate Alex's suggestions, not sure about using llvm-dwarfdump yet tho. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157659/new/ https://reviews.llvm.org/D157659

[Lldb-commits] [PATCH] D157659: Have SBTarget::AddModule force a possibly-slow search for the binary, and if the Target has no arch, initialize it with the binary's arch

jasonmolenda marked 2 inline comments as done. jasonmolenda added inline comments. Comment at: lldb/test/API/python_api/target-arch-from-module/TestTargetArchFromModule.py:39 +dwarfdump_cmd_output = subprocess.check_output( +('/usr/bin/dwarfdump --uuid "%s"'

[Lldb-commits] [PATCH] D157667: Define qHostInfo and Mach-O LC_NOTE "addrable bits" methods to describe high and low memory addressing bits

jasonmolenda updated this revision to Diff 549504. jasonmolenda added a comment. Fix the problems Alex found on review, thanks Alex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157667/new/ https://reviews.llvm.org/D157667 Files: lldb/docs/lldb

[Lldb-commits] [PATCH] D157667: Define qHostInfo and Mach-O LC_NOTE "addrable bits" methods to describe high and low memory addressing bits

bulbazord added inline comments. Comment at: lldb/include/lldb/Symbol/ObjectFile.h:500-503 + /// /param[out] lowmem_mask + /// Address mask to be used for low memory addresses. + /// + /// /param[out] highmem_mask `/param` -> `\param` C

[Lldb-commits] [PATCH] D157659: Have SBTarget::AddModule force a possibly-slow search for the binary, and if the Target has no arch, initialize it with the binary's arch

bulbazord added a comment. The idea seems fine to me. A few nits and comments, otherwise LGTM. Comment at: lldb/source/API/SBTarget.cpp:1517 + if (Symbols::DownloadObjectAndSymbolFile(*module_spec.m_opaque_up, error, + true)) {

[Lldb-commits] [PATCH] D157640: [lldb] Improve error message when trying to debug a non-debuggable process

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe237b76da7e: [lldb] Improve error message when trying to debug a non-debuggable process (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D1576

[Lldb-commits] [lldb] be237b7 - [lldb] Improve error message when trying to debug a non-debuggable process

Author: Jonas Devlieghere Date: 2023-08-11T10:47:00-07:00 New Revision: be237b76da7e29debd9cf1e557235f945b92cead URL: https://github.com/llvm/llvm-project/commit/be237b76da7e29debd9cf1e557235f945b92cead DIFF: https://github.com/llvm/llvm-project/commit/be237b76da7e29debd9cf1e557235f945b92cead.d

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Shouldn't we have two murexes, one for the read FD and one for the write FD? The current approach is overly strict: it preventing concurrent reads and writes because `Rea

[Lldb-commits] [PATCH] D157640: [lldb] Improve error message when trying to debug a non-debuggable process

JDevlieghere added a comment. In D157640#4578198 , @jingham wrote: > In this function we have the path to the binary. We could spawn `codesign -d > -entitlements -` and then we would know whether it had that entitlement. > > Maybe that's more work than

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

augusto2112 updated this revision to Diff 549454. augusto2112 added a comment. Lock earlier in operator= Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157654/new/ https://reviews.llvm.org/D157654 Files: lldb/include/lldb/Host/posix/PipePosix.h

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

augusto2112 added inline comments. Comment at: lldb/source/Host/posix/PipePosix.cpp:69 PipeBase::operator=(std::move(pipe_posix)); - m_fds[READ] = pipe_posix.ReleaseReadFileDescriptor(); - m_fds[WRITE] = pipe_posix.ReleaseWriteFileDescriptor(); + std::lock_guard guard(m_loc

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. The lldb side looks good to me, and I think you've addressed the llvm parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156086/new

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu added a comment. I think I have addressed all the review feedback. Ok to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156086/new/ https://reviews.llvm.org/D156086 ___ lldb-commits mai