[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. LGTM outside of the PE header check. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:1035 + // llvm::object::COFFObjectFile::getSectionSize(). +

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

JDevlieghere updated this revision to Diff 547099. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Link to developer policy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156949/new/ https://reviews.llvm.org/D156949 Files: lldb/CODE_OWNERS.txt lldb/Code

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 added inline comments. Comment at: lld/ELF/Driver.h:28 OPT_INVALID = 0, -#define OPTION(_1, _2, ID, _4, _5, _6, _7, _8, _9, _10, _11, _12) OPT_##ID, +#define OPTION(...) LLVM_MAKE_OPT_ID(__VA_ARGS__), #include "Options.inc" MaskRay wrote: > lld/w

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 updated this revision to Diff 547090. jansvoboda11 added a comment. Herald added subscribers: pmatos, asb, aheejin, sbc100. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. Convert missed LLD parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

hjyamauchi updated this revision to Diff 547086. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157059/new/ https://reviews.llvm.org/D157059 Files: lldb/include/lldb/Symbol/ObjectFile.h lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp lldb/source/Plugins/ObjectFile/PECOFF/

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

MaskRay added inline comments. Comment at: lld/ELF/Driver.h:28 OPT_INVALID = 0, -#define OPTION(_1, _2, ID, _4, _5, _6, _7, _8, _9, _10, _11, _12) OPT_##ID, +#define OPTION(...) LLVM_MAKE_OPT_ID(__VA_ARGS__), #include "Options.inc" lld/wasm lld/COFF lld/MachO

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. In D157028#4558724 , @jansvoboda11 wrote: > Here's an example of a patch that changes the `OPTION` macro: D157029 >

[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

hjyamauchi created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. hjyamauchi requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. There can be zero padding bytes at a section end for file alig

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

augusto2112 marked 2 inline comments as done. augusto2112 added inline comments. Comment at: lldb/source/Interpreter/OptionValue.cpp:49 + std::lock_guard lock(m_mutex); if (GetType() == OptionValue::eTypeBoolean) return static_cast(this); kastiglione wro

[Lldb-commits] [PATCH] D156934: [lldb][NFCI] Add SBTraceCursor.h to swig headers file

This revision was automatically updated to reflect the committed changes. Closed by commit rG08dc847d55fb: [lldb][NFCI] Add SBTraceCursor.h to swig headers file (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156934/new/ https

[Lldb-commits] [lldb] 08dc847 - [lldb][NFCI] Add SBTraceCursor.h to swig headers file

Author: Alex Langford Date: 2023-08-03T16:41:17-07:00 New Revision: 08dc847d55fbdfa7ff6cb8034633139df0199562 URL: https://github.com/llvm/llvm-project/commit/08dc847d55fbdfa7ff6cb8034633139df0199562 DIFF: https://github.com/llvm/llvm-project/commit/08dc847d55fbdfa7ff6cb8034633139df0199562.diff

[Lldb-commits] [PATCH] D157022: Fix the NSIndexSet formatter for macOS Sonoma

jingham marked an inline comment as done. jingham added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:303 +return false; + count = llvm::popcount(bitfield); + break; bulbazord wrote: > This clobbers the pre

[Lldb-commits] [PATCH] D157022: Fix the NSIndexSet formatter for macOS Sonoma

jingham updated this revision to Diff 547048. jingham added a comment. Remove redundant code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157022/new/ https://reviews.llvm.org/D157022 Files: lldb/source/Plugins/Language/ObjC/Cocoa.cpp Index: l

[Lldb-commits] [PATCH] D157044: [lldb/crashlog] Fix sticky image parsing logic

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Python default parameter values strike again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157044/new/ https://reviews.llvm.org/D157044

[Lldb-commits] [PATCH] D157043: [lldb/crashlog] Make TextCrashLogParser more resilient to new lines

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Looks alright to me. I think it would be interesting to replace a lot of the index juggling code with python Iterators that can only iterate over the lines that are not empty, but that's

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

kastiglione added inline comments. Comment at: lldb/source/Interpreter/OptionValue.cpp:49 + std::lock_guard lock(m_mutex); if (GetType() == OptionValue::eTypeBoolean) return static_cast(this); do these GetAsX functions need to lock? Repository: rG LL

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

bulbazord added a comment. In D157041#4559255 , @augusto2112 wrote: >> Do all of these need to be protected with a mutex? In your description >> you're saying TSan is detecting data races. What piece of data are you >> observing the data race on? > > O

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

kastiglione added inline comments. Comment at: lldb/source/Interpreter/OptionValue.cpp:41 llvm::StringRef value) { + std::lock_guard lock(m_mutex); Status error; this one doesn't need a lock Comment at: lldb

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

augusto2112 added a comment. > Do all of these need to be protected with a mutex? In your description you're > saying TSan is detecting data races. What piece of data are you observing the > data race on? Only SetAsBoolean/GetAsBoolean are being caught when running our test suite at the moment

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

bulbazord added a comment. A few questions: - Do all of these need to be protected with a mutex? In your description you're saying TSan is detecting data races. What piece of data are you observing the data race on? - Do we need a recursive mutex? I assume that these operations might call into

[Lldb-commits] [PATCH] D157022: Fix the NSIndexSet formatter for macOS Sonoma

bulbazord added a comment. It would be nice if we could clean up what `mode` is. There's a lot of bit-wise operations and setting it to 1 and 2 and it's not clear what each one might mean in each case... Some kind of enum or semantic meaning for each number would be nice. Either way, I think I'

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 updated this revision to Diff 547018. jansvoboda11 added a comment. Herald added a reviewer: alexander-shaposhnikov. Consolidate all usages by extra `_WITH_ID_PREFIX` macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157028/new/ htt

[Lldb-commits] [PATCH] D157044: [lldb/crashlog] Fix sticky image parsing logic

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. Prior to this patch, when a user loaded multiple crash report in lldb, they could get in

[Lldb-commits] [PATCH] D157043: [lldb/crashlog] Make TextCrashLogParser more resilient to new lines

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch changes the parsing logic for the legacy crash report format to avoid interrup

[Lldb-commits] [PATCH] D156919: [lldb/crashlog] Make register output match lldb ordering in legacy mode

mib updated this revision to Diff 547010. mib marked an inline comment as done. mib added a comment. Address feedback & reformat CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156919/new/ https://reviews.llvm.org/D156919 Files: lldb/examples/python/crashlog.py Index: lldb/examples/py

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

augusto2112 created this revision. augusto2112 added reviewers: JDevlieghere, aprantl, jingham. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thread sanitizer is catching data races in OptionValue,

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156732/new/ https://reviews.llvm.org/D156732

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 added a comment. Here's an example of a patch that changes the `OPTION` macro: D157029 . I wonder if we could have counterparts to `LLVM_MAKE_OPT_ID` and `LLVM_CONSTRUCT_OPT_INFO` that allow overriding the default `OPT_` prefix. That would make D15

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

MaskRay added a comment. I'll be away for a few days but I took a quick glance. This change looks reasonable. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157028/new/ https://reviews.llvm.org/D157028 _

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 created this revision. jansvoboda11 added a reviewer: MaskRay. Herald added subscribers: jhenderson, ormris, ributzka, steven_wu, hiraditya, arichardson, emaste. Herald added a reviewer: JDevlieghere. Herald added a reviewer: jhenderson. Herald added a project: All. jansvoboda11 reque

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

zhyty updated this revision to Diff 546979. zhyty added a comment. remove a.out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156732/new/ https://reviews.llvm.org/D156732 Files: lldb/test/API/tools/lldb-vscode/stackTraceMissingFunctionName/Makef

[Lldb-commits] [PATCH] D156970: Fix crash in lldb-vscode when missing function name

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a3f0cd717f6: Fix crash in lldb-vscode when missing function name (authored by zhyty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156970/new/ https://rev

[Lldb-commits] [lldb] 9a3f0cd - Fix crash in lldb-vscode when missing function name

Author: Tom Yang Date: 2023-08-03T12:56:37-07:00 New Revision: 9a3f0cd717f68ccf9e348bce2d76a2372482f4f2 URL: https://github.com/llvm/llvm-project/commit/9a3f0cd717f68ccf9e348bce2d76a2372482f4f2 DIFF: https://github.com/llvm/llvm-project/commit/9a3f0cd717f68ccf9e348bce2d76a2372482f4f2.diff LOG:

[Lldb-commits] [PATCH] D157022: Fix the NSIndexSet formatter for macOS Sonoma

jingham added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:278 + && descriptor->GetTaggedPointerInfo(nullptr, nullptr, &payload)) { +count = __builtin_popcountll(payload); +break; bulbazord wrote: > I'm pretty

[Lldb-commits] [PATCH] D157022: Fix the NSIndexSet formatter for macOS Sonoma

jingham updated this revision to Diff 546976. jingham marked an inline comment as done. jingham added a comment. Use llvm::popcount instead of using the builtin directly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157022/new/ https://reviews.llv

[Lldb-commits] [PATCH] D157022: Fix the NSIndexSet formatter for macOS Sonoma

bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:278 + && descriptor->GetTaggedPointerInfo(nullptr, nullptr, &payload)) { +count = __builtin_popcountll(payload); +break; I'm pretty sure `__builtin_p

[Lldb-commits] [PATCH] D157022: Fix the NSIndexSet formatter for macOS Sonoma

mib added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:294 + // This is the bitfield case. The bitfield is a uint64_t: + count = process_sp->ReadUnsignedIntegerFromMemory( + valobj_addr + 2 * ptr_size, 8, 0, error);

[Lldb-commits] [PATCH] D157022: Fix the NSIndexSet formatter for macOS Sonoma

jingham created this revision. jingham added reviewers: JDevlieghere, bulbazord, mib. Herald added a subscriber: arphaman. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Just mutatis mutandis for the Fo

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

tonic added a comment. Comment at: lldb/CodeOwners.rst:7-8 +particular part of LLDB are reviewed, either by themself or by someone else. +They are also the gatekeepers for their part of LLDB, with the final word on +what goes in or not. + JDevlieghere wrote: >

[Lldb-commits] [PATCH] D156817: [lldb][windows] _wsopen_s does not accept bits other than `_S_IREAD | _S_IWRITE`

DavidSpickett accepted this revision. DavidSpickett added a comment. I think this could be tested with an lldb-server test, but it would likely go in `lldb/test/API/tools/lldb-server/TestGdbRemotePlatformFile.py` which has every test marked as skipped on Windows. For reasons lost to time. If yo

[Lldb-commits] [PATCH] D156997: [LLDB][CMake][NFC] Remove unused LLDB_LINKER_SUPPORTS_GROUPS variable

bulbazord accepted this revision. bulbazord added a comment. LGTM. I don't see any actual uses of this on llvm.org. If somebody needs it they can re-add it and add their use case or they can maintain a patch downstream. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D156270: [lldb][NFCI] Change logic to find clang resource dir in standalone builds

bulbazord added a comment. In D156270#4557902 , @mgorny wrote: > I'm not sure if it was really intended but the new API is kinda horrible, at > least for us in Gentoo. > > Our install prefix is `/usr/lib/llvm/NN`, whereas clang resource dir is > `/usr/l

[Lldb-commits] [PATCH] D156997: [LLDB][CMake][NFC] Remove unused LLDB_LINKER_SUPPORTS_GROUPS variable

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156997/new/ https://reviews.llvm.org/D156997 __

[Lldb-commits] [PATCH] D156817: [lldb][windows] _wsopen_s does not accept bits other than `_S_IREAD | _S_IWRITE`

yshui added a comment. In D156817#4553045 , @DavidSpickett wrote: > What exactly are the other bits in the mode here, are we losing something > important potentially? I guess it can't be that important if Windows rejects > them. I don't think so, grou

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

JDevlieghere added inline comments. Comment at: lldb/CodeOwners.rst:7-8 +particular part of LLDB are reviewed, either by themself or by someone else. +They are also the gatekeepers for their part of LLDB, with the final word on +what goes in or not. + DavidSpicke

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

JDevlieghere updated this revision to Diff 546897. JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. - Update wording - Remove double newline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156949/new/ https://reviews.llvm.org/D156949 Files: lldb/CODE_OWNERS.

[Lldb-commits] [PATCH] D156270: [lldb][NFCI] Change logic to find clang resource dir in standalone builds

mgorny added subscribers: paperchalice, tstellar, mgorny. mgorny added a comment. I'm not sure if it was really intended but the new API is kinda horrible, at least for us in Gentoo. Our install prefix is `/usr/lib/llvm/NN`, whereas clang resource dir is `/usr/lib/clang/NN`. If I don't overrid

[Lldb-commits] [PATCH] D156979: [lldb][lldb-vscode] Pretty print JSON to log files

This revision was automatically updated to reflect the committed changes. Closed by commit rG165f45a87774: [lldb][lldb-vscode] Pretty print JSON to log files (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156979/new/ http

[Lldb-commits] [lldb] 165f45a - [lldb][lldb-vscode] Pretty print JSON to log files

Author: David Spickett Date: 2023-08-03T15:09:12Z New Revision: 165f45a877742a74988d63f36aee635c8e0a47da URL: https://github.com/llvm/llvm-project/commit/165f45a877742a74988d63f36aee635c8e0a47da DIFF: https://github.com/llvm/llvm-project/commit/165f45a877742a74988d63f36aee635c8e0a47da.diff LOG

[Lldb-commits] [PATCH] D156977: [lldb][lldb-vscode] Fix nullptr dereference when JSON is not an object

This revision was automatically updated to reflect the committed changes. Closed by commit rGbdeb35bda438: [lldb][lldb-vscode] Fix nullptr dereference when JSON is not an object (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [lldb] bdeb35b - [lldb][lldb-vscode] Fix nullptr dereference when JSON is not an object

Author: David Spickett Date: 2023-08-03T14:56:24Z New Revision: bdeb35bda4381d3b416a92d797713b4b5a6a6c97 URL: https://github.com/llvm/llvm-project/commit/bdeb35bda4381d3b416a92d797713b4b5a6a6c97 DIFF: https://github.com/llvm/llvm-project/commit/bdeb35bda4381d3b416a92d797713b4b5a6a6c97.diff LOG

[Lldb-commits] [PATCH] D156979: [lldb][lldb-vscode] Pretty print JSON to log files

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. nice improvement for sure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156979/new/ https://reviews.llvm.org/D156979

[Lldb-commits] [PATCH] D156977: [lldb][lldb-vscode] Fix nullptr dereference when JSON is not an object

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156977/new/ https://reviews.llvm.org/D156977 ___

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

DavidSpickett added inline comments. Comment at: lldb/CodeOwners.rst:7-8 +particular part of LLDB are reviewed, either by themself or by someone else. +They are also the gatekeepers for their part of LLDB, with the final word on +what goes in or not. + JDevlieghe

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

JDevlieghere added inline comments. Comment at: lldb/CodeOwners.rst:7-8 +particular part of LLDB are reviewed, either by themself or by someone else. +They are also the gatekeepers for their part of LLDB, with the final word on +what goes in or not. + DavidSpicke

[Lldb-commits] [PATCH] D157000: [lldb][AArch64] Check SIMD save/restore in SVE SIMD test

DavidSpickett added a comment. MTE control needs a test too, I'm working on that as its own change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157000/new/ https://reviews.llvm.org/D157000 ___ lldb-com

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett added a comment. Oh, and fixed the FIXME now that the TLS fixes have landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156687/new/ https://reviews.llvm.org/D156687 ___ lldb-commits mail

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett updated this revision to Diff 546842. DavidSpickett added a comment. Use uint8_t for kind, fix some places doing sizeof uint32_t not of the kind type. Put back memcopy of fpr registers, which is now tested by the parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D157000: [lldb][AArch64] Check SIMD save/restore in SVE SIMD test

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. While doing some refactoring I forgot to carry over the copyi

[Lldb-commits] [PATCH] D156997: [LLDB][CMake][NFC] Remove unused LLDB_LINKER_SUPPORTS_GROUPS variable

jryans created this revision. jryans added a reviewer: JDevlieghere. Herald added a subscriber: ekilmer. Herald added a project: All. jryans added a project: LLDB. jryans published this revision for review. Herald added a subscriber: lldb-commits. The `LLDB_LINKER_SUPPORTS_GROUPS` CMake variable w

[Lldb-commits] [PATCH] D156512: [lldb][AArch64] Save/restore TLS registers around expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG6239227172cd: [lldb][AArch64] Save/restore TLS registers around expressions (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156512

[Lldb-commits] [lldb] 6239227 - [lldb][AArch64] Save/restore TLS registers around expressions

Author: David Spickett Date: 2023-08-03T12:33:49Z New Revision: 6239227172cdc92f3bb72131333f50f83a6439cf URL: https://github.com/llvm/llvm-project/commit/6239227172cdc92f3bb72131333f50f83a6439cf DIFF: https://github.com/llvm/llvm-project/commit/6239227172cdc92f3bb72131333f50f83a6439cf.diff LOG

[Lldb-commits] [PATCH] D156118: [lldb][AArch64] Add reading of TLS tpidr register from core files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43ad521f2fa9: [lldb][AArch64] Add reading of TLS tpidr register from core files (authored by DavidSpickett). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 43ad521 - [lldb][AArch64] Add reading of TLS tpidr register from core files

Author: David Spickett Date: 2023-08-03T12:06:06Z New Revision: 43ad521f2fa9a50e6b30425a3b9fb3025b42587a URL: https://github.com/llvm/llvm-project/commit/43ad521f2fa9a50e6b30425a3b9fb3025b42587a DIFF: https://github.com/llvm/llvm-project/commit/43ad521f2fa9a50e6b30425a3b9fb3025b42587a.diff LOG

[Lldb-commits] [PATCH] D156512: [lldb][AArch64] Save/restore TLS registers around expressions

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This looks good. Just a nit the summary seems to be using a lot pronouns. Could you kindly improve summary a little and add a one liner about expr_func and how it tests save/restore for fu

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM modulo nits found by others, thank you for this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156949/new/ https://reviews.llvm.org/D156949 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D156118: [lldb][AArch64] Add reading of TLS tpidr register from core files

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. Looks legit. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156118/new/ https://reviews.llvm.org/D156118

[Lldb-commits] [PATCH] D156512: [lldb][AArch64] Save/restore TLS registers around expressions

DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156512/new/ https://reviews.llvm.org/D156512 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D156118: [lldb][AArch64] Add reading of TLS tpidr register from core files

DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156118/new/ https://reviews.llvm.org/D156118 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D156979: [lldb][lldb-vscode] Pretty print JSON to log files

DavidSpickett added reviewers: ashgti, wallace. DavidSpickett added a comment. The one disadvantage here is that pretty printing adds more characters, so before you could copy paste the single JSON line and (I presume) it would have the same number of characters. If that's a required use case t

[Lldb-commits] [PATCH] D156979: [lldb][lldb-vscode] Pretty print JSON to log files

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This makes anlysing test failures much more easy. For SendJSON this is simple, just use llvm::format instead.

[Lldb-commits] [PATCH] D156977: [lldb][lldb-vscode] Fix nullptr dereference when JSON is not an object

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added subscribers: lldb-commits, wangpc. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D156977 Files: lldb/tools/lldb-vscode/

[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

DavidSpickett added a comment. > Also it would be very useful if the logs could be printed in a pretty form > like: And I'll have a patch for this shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156493/new/ https://reviews.llvm.org/D156493

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

DavidSpickett added inline comments. Comment at: lldb/include/lldb/API/SBProcess.h:433 + + /// Clear the non-addressable bits of an \a addr value and return a + /// virtual address in memory. "Clear bits from an addr value that are not used for addressing" is c

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

DavidSpickett added inline comments. Comment at: lldb/CodeOwners.rst:7-8 +particular part of LLDB are reviewed, either by themself or by someone else. +They are also the gatekeepers for their part of LLDB, with the final word on +what goes in or not. + This could

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

zhyty updated this revision to Diff 546738. zhyty added a comment. - added a test case - rebased this commit on top of D156970 , which fixes a crash preventing me from testing this feature - addressed other comments Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D156970: Fix crash in lldb-vscode when missing function name

zhyty created this revision. Herald added a project: All. zhyty requested review of this revision. Herald added subscribers: lldb-commits, wangpc. Herald added a project: LLDB. In cases where the PC has no function name, lldb-vscode crashes. `lldb::SBFrame::GetDisplayFunctionName()` returns a `nu

[Lldb-commits] [PATCH] D156804: [lldb] Bump SWIG minimum version to 4

DavidSpickett added a comment. We are on 4.01 (AArch64), 4.02 (Arm) and 4.1.1 (Windows on Arm), so we have no issues with this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156804/new/ https://reviews.llvm.org/D156804 ___ lldb-commits maili

[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

DavidSpickett added a comment. It's failing the test, but actually it looks like a cleanup step is failing. Whether that is also the timeout I don't know. I will restart the machine to rule out any lingering processes and get back to you. Repository: rG LLVM Github Monorepo CHANGES SINCE LA