[Lldb-commits] [PATCH] D154907: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (2nd attempt)

jasonmolenda added a comment. Herald added subscribers: Michael137, JDevlieghere. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154907/new/ https://reviews.llvm.org/D154907 ___ lldb-commits maili

[Lldb-commits] [PATCH] D154907: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (2nd attempt)

This revision was automatically updated to reflect the committed changes. Closed by commit rG3885ceafa934: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (authored by cmtice). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Mono

[Lldb-commits] [lldb] 3885cea - [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate

Author: Caroline Tice Date: 2023-07-10T19:47:38-07:00 New Revision: 3885ceafa9347dd729eba5cf872091a689b63d98 URL: https://github.com/llvm/llvm-project/commit/3885ceafa9347dd729eba5cf872091a689b63d98 DIFF: https://github.com/llvm/llvm-project/commit/3885ceafa9347dd729eba5cf872091a689b63d98.diff

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

wallace added a comment. Could you split the changes to the selected thread out of this? I'm seeing two features being implemented in this patch. Other than that, it looks pretty good! Comment at: lldb/tools/lldb-vscode/Options.td:20-38 +def port: S<"port">, MetaVarName<"">

[Lldb-commits] [PATCH] D154759: [lldb][NFCI] Change type of UnwindPlan::m_source_name

bulbazord added a comment. In D154759#4487381 , @jasonmolenda wrote: > I guess simplest is we can have all the UnwindPlan creators have a `static > g_unwindplan_name` and save a pointer to that. Each one is unique, don't > need anything fancier than t

[Lldb-commits] [PATCH] D153735: [lldb][TargetGetModuleCallback] Implement Python interface

splhack added inline comments. Comment at: lldb/include/lldb/API/SBDefines.h:129 +typedef SBError (*SBTargetGetModuleCallback)(SBDebugger debugger, + SBModuleSpec &module_spec, clayborg wrote: > If we are putting this

[Lldb-commits] [PATCH] D153734: [lldb][TargetGetModuleCallback] Call get module callback

splhack added a comment. @clayborg Sure, I'll rename the type and function to `Locate` instead of `Get`. typedef SBError (*SBPlatformLocateModuleCallback)( SBDebugger debugger, SBModuleSpec &module_spec, SBFileSpec &module_file_spec, SBFileSpec &symbol_file_spec); This

[Lldb-commits] [PATCH] D154759: [lldb][NFCI] Change type of UnwindPlan::m_source_name

jasonmolenda added a comment. I guess simplest is we can have all the UnwindPlan creators have a `static g_unwindplan_name` and save a pointer to that. Each one is unique, don't need anything fancier than that. There's the risk that someone will create a new UnwindPlan and forget to make it a

[Lldb-commits] [PATCH] D154759: [lldb][NFCI] Change type of UnwindPlan::m_source_name

jasonmolenda added a comment. probably the real correct change is to have constant c-strings in as globals and have pointers to those. Then you're using the same space as a ConstString in each UnwindPlan (a pointer) but creation is cheaper. There's no dynamic aspect to the names when the Unwi

[Lldb-commits] [PATCH] D154759: [lldb][NFCI] Change type of UnwindPlan::m_source_name

jasonmolenda added a comment. (to say it more clearly: I'm fine if you'd like to reduce the places where ConstStrings are being used, but I don't think there's any good reason to remove this use of them. It will increase our memory footprint a bit.) Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [PATCH] D154759: [lldb][NFCI] Change type of UnwindPlan::m_source_name

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. I'm fine with this. It does increase the size of the UnwindPlan object, and there are a couple of them for every function that we see on a stack during a program execution, but I

[Lldb-commits] [lldb] 5f6c558 - Revert "[LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate."

Author: Caroline Tice Date: 2023-07-10T16:24:31-07:00 New Revision: 5f6c55836fb4666f3160400dc273deefdac82e06 URL: https://github.com/llvm/llvm-project/commit/5f6c55836fb4666f3160400dc273deefdac82e06 DIFF: https://github.com/llvm/llvm-project/commit/5f6c55836fb4666f3160400dc273deefdac82e06.diff

[Lldb-commits] [PATCH] D153734: [lldb][TargetGetModuleCallback] Call get module callback

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So the "SetTargetGetModuleCallback" functions in this patch need to pass both a callback _and_ a callback_baton. That way people can register native callbacks that can be used. T

[Lldb-commits] [PATCH] D153735: [lldb][TargetGetModuleCallback] Implement Python interface

clayborg added inline comments. Comment at: lldb/include/lldb/API/SBDefines.h:129 +typedef SBError (*SBTargetGetModuleCallback)(SBDebugger debugger, + SBModuleSpec &module_spec, If we are putting this into SBPlatform,

[Lldb-commits] [PATCH] D154643: [lldb] Prevent crash when completing ambiguous subcommands

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb10b01cca85: [lldb] Prevent crash when completing ambiguous subcommands (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D154643?vs=537829&id=

[Lldb-commits] [lldb] fb10b01 - [lldb] Prevent crash when completing ambiguous subcommands

Author: Jonas Devlieghere Date: 2023-07-10T14:50:40-07:00 New Revision: fb10b01cca85306c8a94826e31e8a4dfb8aff502 URL: https://github.com/llvm/llvm-project/commit/fb10b01cca85306c8a94826e31e8a4dfb8aff502 DIFF: https://github.com/llvm/llvm-project/commit/fb10b01cca85306c8a94826e31e8a4dfb8aff502.d

[Lldb-commits] [PATCH] D153735: [lldb][TargetGetModuleCallback] Implement Python interface

splhack updated this revision to Diff 538835. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153735/new/ https://reviews.llvm.org/D153735 Files: lldb/bindings/python/python-typemaps.swig lldb/bindings/python/pyth

[Lldb-commits] [lldb] c1885d2 - "settings set -g target.load-script-from-symbol-file" shouldn't crash.

Author: Jim Ingham Date: 2023-07-10T14:40:18-07:00 New Revision: c1885d2dfa950d0f78978546f92be15bc6cca474 URL: https://github.com/llvm/llvm-project/commit/c1885d2dfa950d0f78978546f92be15bc6cca474 DIFF: https://github.com/llvm/llvm-project/commit/c1885d2dfa950d0f78978546f92be15bc6cca474.diff LO

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

MaskRay added a comment. In D151683#4486321 , @aaron.ballman wrote: > Aside from the failing precommit CI test case in C, I think this LGTM. I've > added @MaskRay as the code owner for the command line option changes in case > he's got concerns regardi

[Lldb-commits] [PATCH] D154890: [lldb][NFCI] Avoid construction of temporary std::strings in Variable

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154890/new/ https://reviews.llvm.org/D154890 ___

[Lldb-commits] [PATCH] D154643: [lldb] Prevent crash when completing ambiguous subcommands

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks like it might be the place where we also say "`set s` could either be `set` or `show`". But that's actually done elsewhere so this change is okay. We should maybe make sure we h

[Lldb-commits] [PATCH] D154890: [lldb][NFCI] Avoid construction of temporary std::strings in Variable

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A common thing to do is to call `str().c_str()` to get

[Lldb-commits] [PATCH] D154883: [lldb][NFCI] Methods to load scripting resources should take a Stream by reference

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added subscribers: lldb-commits, wangpc. Herald added a project: LLDB. These methods all take a `Stream *` to get feedback about

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

aaron.ballman added a reviewer: MaskRay. aaron.ballman added a comment. Aside from the failing precommit CI test case in C, I think this LGTM. I've added @MaskRay as the code owner for the command line option changes in case he's got concerns regarding the deprecation/removal plans. Repository

[Lldb-commits] [PATCH] D154757: [lldb][NFCI] TestEmulation should take a Stream ref

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e7101a3d958: [lldb][NFCI] TestEmulation should take a Stream ref (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154757/new/ https:/

[Lldb-commits] [lldb] 1e7101a - [lldb][NFCI] TestEmulation should take a Stream ref

Author: Alex Langford Date: 2023-07-10T11:17:25-07:00 New Revision: 1e7101a3d95884c791d566b7b6192fbac55f55e0 URL: https://github.com/llvm/llvm-project/commit/1e7101a3d95884c791d566b7b6192fbac55f55e0 DIFF: https://github.com/llvm/llvm-project/commit/1e7101a3d95884c791d566b7b6192fbac55f55e0.diff

[Lldb-commits] [PATCH] D153734: [lldb][TargetGetModuleCallback] Call get module callback

splhack updated this revision to Diff 538741. splhack added a comment. Fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153734/new/ https://reviews.llvm.org/D153734 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Interpret

[Lldb-commits] [PATCH] D153735: [lldb][TargetGetModuleCallback] Implement Python interface

splhack updated this revision to Diff 538713. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153735/new/ https://reviews.llvm.org/D153735 Files: lldb/bindings/python/python-typemaps.swig lldb/bindings/python/pyth

[Lldb-commits] [PATCH] D153734: [lldb][TargetGetModuleCallback] Call get module callback

splhack updated this revision to Diff 538696. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153734/new/ https://reviews.llvm.org/D153734 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Interpreter/Scr

[Lldb-commits] [PATCH] D153733: [lldb][TargetGetModuleCallback] Update SBFileSpec/SBModuleSpec

splhack updated this revision to Diff 538662. splhack added a comment. fix LLDB_INSTRUMENT_VA for SBModuleSpec constructor too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153733/new/ https://reviews.llvm.org/D153733 Files: lldb/bindings/python

[Lldb-commits] [PATCH] D153733: [lldb][TargetGetModuleCallback] Update SBFileSpec/SBModuleSpec

splhack updated this revision to Diff 538660. splhack added a comment. Fix LLDB_INSTRUMENT_VA args Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153733/new/ https://reviews.llvm.org/D153733 Files: lldb/bindings/python/python-swigsafecast.swig

[Lldb-commits] [PATCH] D153733: [lldb][TargetGetModuleCallback] Update SBFileSpec/SBModuleSpec

splhack updated this revision to Diff 538649. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153733/new/ https://reviews.llvm.org/D153733 Files: lldb/bindings/python/python-swigsafecast.swig lldb/include/lldb/API

[Lldb-commits] [PATCH] D154843: [lldb] Disable TestNamespaceLookup in DWARF 5 + dSYM setting

This revision was automatically updated to reflect the committed changes. Closed by commit rG6890ad3f41c5: [lldb] Disable TestNamespaceLookup in DWARF 5 + dSYM setting (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154843/new/

[Lldb-commits] [lldb] 6890ad3 - [lldb] Disable TestNamespaceLookup in DWARF 5 + dSYM setting

Author: Felipe de Azevedo Piovezan Date: 2023-07-10T10:10:15-04:00 New Revision: 6890ad3f41c51ba9008c26f5b23397d5e0bc2aad URL: https://github.com/llvm/llvm-project/commit/6890ad3f41c51ba9008c26f5b23397d5e0bc2aad DIFF: https://github.com/llvm/llvm-project/commit/6890ad3f41c51ba9008c26f5b23397d5e

[Lldb-commits] [PATCH] D154843: [lldb] Disable TestNamespaceLookup in DWARF 5 + dSYM setting

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The ordering in which functions are presented to the expression evaluator in this test setting triggers a known bug in LLD

[Lldb-commits] [PATCH] D154757: [lldb][NFCI] TestEmulation should take a Stream ref

fdeazeve accepted this revision. fdeazeve added a comment. Thanks for finding those! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154757/new/ https://reviews.llvm.org/D154757 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D154823: [lldb][AArch64] Add test predicate for systems with SME enabled

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. "sme" is just one of many cpuinfo features for SME but it's the only o

[Lldb-commits] [PATCH] D154757: [lldb][NFCI] TestEmulation should take a Stream ref

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM. Always happy to see never-null pointers get updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https