[Lldb-commits] [PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

h-vetinari added inline comments. Comment at: libunwind/src/CMakeLists.txt:28-35 # See add_asm_sources() in compiler-rt for explanation of this workaround. # CMake doesn't work correctly with assembly on AIX. Workaround by compiling # as C files as well. if((APPLE AND CMAKE

[Lldb-commits] [PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

mstorsjo added inline comments. Comment at: libunwind/src/CMakeLists.txt:28-35 # See add_asm_sources() in compiler-rt for explanation of this workaround. # CMake doesn't work correctly with assembly on AIX. Workaround by compiling # as C files as well. if((APPLE AND CMAKE_V

[Lldb-commits] [lldb] c9ee631 - TestStackCoreScriptedProcess.py is timing out, skip it

Author: Jason Molenda Date: 2023-05-25T19:13:16-07:00 New Revision: c9ee63138189368674cd201891577e65bd289ed4 URL: https://github.com/llvm/llvm-project/commit/c9ee63138189368674cd201891577e65bd289ed4 DIFF: https://github.com/llvm/llvm-project/commit/c9ee63138189368674cd201891577e65bd289ed4.diff

[Lldb-commits] [PATCH] D150928: Two bug fixes for loading process save-core created core files, plus perf improvements

jasonmolenda updated this revision to Diff 525910. jasonmolenda added a comment. Updating the patch to incorporate Alex's feedback, and a little further refinement with testing. I am still doing final testing now, and mostly interested in how to create a mach-o corefile that would trigger the f

[Lldb-commits] [PATCH] D151524: [lldb][NFCI] Change type of SBDebugger::m_instance_name

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This doesn't need to be in the ConstString StringPool. There's li

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

JDevlieghere added inline comments. Comment at: lldb/source/Breakpoint/Watchpoint.cpp:127 + +bool Watchpoint::VariableWatchpointDisabler(void *baton, +StoppointCallbackContext *context, mib wrote: > JDevlieghere wrote:

[Lldb-commits] [PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

h-vetinari added inline comments. Comment at: libunwind/src/CMakeLists.txt:28-35 # See add_asm_sources() in compiler-rt for explanation of this workaround. # CMake doesn't work correctly with assembly on AIX. Workaround by compiling # as C files as well. if((APPLE AND CMAKE

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Commands/CommandObjectWatchpoint.cpp:959 ", variable expression='%s').\n", addr, (uint64_t)size, command.GetArgumentAtIndex(0)); if (error.AsCString(nullptr)) ---

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. In D151497#4374495 , @JDevlieghere wrote: > In D151497#4374080 , @bulbazord > wrote: > >> I think it'

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Breakpoint/Watchpoint.cpp:127 + +bool Watchpoint::VariableWatchpointDisabler(void *baton, +StoppointCallbackContext *context, JDev

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

JDevlieghere added inline comments. Comment at: lldb/source/Breakpoint/Watchpoint.cpp:127 + +bool Watchpoint::VariableWatchpointDisabler(void *baton, +StoppointCallbackContext *context, I think this should return an `ll

[Lldb-commits] [PATCH] D151516: [lldb][NFCI] Remove use of ConstString from UnixSignals::SignalCode

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, labath, DavidSpickett. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On llvm.org and all downstream forks that I'm aware of,

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

JDevlieghere added inline comments. Comment at: lldb/source/Expression/UserExpression.cpp:211 +error.SetErrorStringWithFormatv( +"unable to evaluate expression while the process is {0}: the process " +"must be stopped because the expression might requires allo

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

JDevlieghere updated this revision to Diff 525861. JDevlieghere added a comment. Rephrase error message for `UserExpression::Evaluate` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151497/new/ https://reviews.llvm.org/D151497 Files: lldb/source/Expression/UserExpression.cpp lldb/so

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

JDevlieghere added a comment. In D151497#4374080 , @bulbazord wrote: > I think it's good to improve the error messaging but I think we can probably > do better. "Function caller" is specific to the internals of LLDB and isn't > really meaningful for man

[Lldb-commits] [PATCH] D151392: Fix SBValue::FindValue for file static variables

mib accepted this revision. mib added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151392/new/ https://reviews.llvm.org/D151392 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D151399: [lldb] Introduce FileSpec::GetComponents

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1241 +// We want the components in reverse order. +std::reverse(path_parts.begin(), path_parts.end(

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

mib added a subscriber: kastiglione. mib added a comment. In D151497#4374080 , @bulbazord wrote: > I think it's good to improve the error messaging but I think we can probably > do better. "Function caller" is specific to the internals of LLDB and isn't

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c847ac4bd1b: [lldb] Disable variable watchpoints when going out of scope (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151366/new/ https

[Lldb-commits] [lldb] 7c847ac - [lldb] Disable variable watchpoints when going out of scope

Author: Med Ismail Bennani Date: 2023-05-25T15:07:09-07:00 New Revision: 7c847ac4bd1bd8a89c7fbb4581328fa8cb0498f1 URL: https://github.com/llvm/llvm-project/commit/7c847ac4bd1bd8a89c7fbb4581328fa8cb0498f1 DIFF: https://github.com/llvm/llvm-project/commit/7c847ac4bd1bd8a89c7fbb4581328fa8cb0498f1.

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

mib added a comment. In D151366#4372731 , @aprantl wrote: >> @aprantl Do you know if we can detect the end of the scope ? I'm not sure >> it's possible currently ... But even if we could do it, that wouldn't cover >> the following case: > > When setting

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

bulbazord requested changes to this revision. bulbazord added a comment. This revision now requires changes to proceed. I think it's good to improve the error messaging but I think we can probably do better. "Function caller" is specific to the internals of LLDB and isn't really meaningful for m

[Lldb-commits] [PATCH] D151501: [LLDB] Explicitly declare constructor in `PersistentExpressionState`

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Herald added subscribers: Michael137, JDevlieghere. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151501/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D151501: [LLDB] Explicitly declare constructor in `PersistentExpressionState`

laszlokindrat created this revision. laszlokindrat added reviewers: rriddle, bzcheeseman, wallace. Herald added a project: All. laszlokindrat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It seems that when trying to link the lldb library

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, aprantl, bulbazord, mib. Herald added a project: All. JDevlieghere requested review of this revision. When trying to run an expression after a process has existed, you currently are shown the following error message: (l

[Lldb-commits] [lldb] 0e90ac9 - Re-revert "[lldb] Move PassthroughScriptedProcess to `lldb.scripted_process` module"

Author: Med Ismail Bennani Date: 2023-05-25T14:00:11-07:00 New Revision: 0e90ac9c94d716fa78e0c86a6c7f6ff24decf7fe URL: https://github.com/llvm/llvm-project/commit/0e90ac9c94d716fa78e0c86a6c7f6ff24decf7fe DIFF: https://github.com/llvm/llvm-project/commit/0e90ac9c94d716fa78e0c86a6c7f6ff24decf7fe.

[Lldb-commits] [PATCH] D151460: [NFC][Py Reformat] Reformat python files in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rG2238dcc39358: [NFC][Py Reformat] Reformat python files in lldb (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D151460?vs=525647&id=525759#toc

[Lldb-commits] [PATCH] D151399: [lldb] Introduce FileSpec::GetComponents

bulbazord updated this revision to Diff 525757. bulbazord added a comment. Convert return type to `std::vector` Actually fix code so this thing compiles correctly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151399/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D151451: [lldb][nfc] Refactor methods with out parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rG346afb857228: [lldb][nfc] Refactor methods with out parameter (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151451/new/ https://revi

[Lldb-commits] [lldb] 346afb8 - [lldb][nfc] Refactor methods with out parameter

Author: Felipe de Azevedo Piovezan Date: 2023-05-25T13:38:35-04:00 New Revision: 346afb8572280292139c22a00f80afbbfdb509f6 URL: https://github.com/llvm/llvm-project/commit/346afb8572280292139c22a00f80afbbfdb509f6 DIFF: https://github.com/llvm/llvm-project/commit/346afb8572280292139c22a00f80afbbf

[Lldb-commits] [PATCH] D151451: [lldb][nfc] Refactor methods with out parameter

bulbazord accepted this revision. bulbazord added a comment. Thanks for doing this work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151451/new/ https://reviews.llvm.org/D151451 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D151399: [lldb] Introduce FileSpec::GetComponents

bulbazord added inline comments. Comment at: lldb/include/lldb/Utility/FileSpec.h:420 + /// A std::vector of std::strings for each path component. + std::vector GetComponents() const; + JDevlieghere wrote: > bulbazord wrote: > > JDevlieghere wrote: > > > I'm

[Lldb-commits] [PATCH] D151451: [lldb][nfc] Refactor methods with out parameter

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151451/new/ https://reviews.llvm.org/D151451 ___

[Lldb-commits] [PATCH] D151460: [NFC][Py Reformat] Reformat python files in lldb

JDevlieghere added a comment. In D151460#4372779 , @thieta wrote: > In D151460#4372763 , @mib wrote: > >> Can you add this commit hash to the `.git-blame-ignore-revs` file so it >> doesn't show up in the git hist

[Lldb-commits] [PATCH] D151425: [lldb][nfc] Place comment in the right place

This revision was automatically updated to reflect the committed changes. Closed by commit rG52b03b63972a: [lldb][nfc] Place comment in the right place (authored by fdeazeve). Changed prior to commit: https://reviews.llvm.org/D151425?vs=525544&id=525679#toc Repository: rG LLVM Github Monorep

[Lldb-commits] [lldb] 52b03b6 - [lldb][nfc] Place comment in the right place

Author: Felipe de Azevedo Piovezan Date: 2023-05-25T12:53:35-04:00 New Revision: 52b03b63972a75cef8cfa5e1a2b1675a04f3dbe8 URL: https://github.com/llvm/llvm-project/commit/52b03b63972a75cef8cfa5e1a2b1675a04f3dbe8 DIFF: https://github.com/llvm/llvm-project/commit/52b03b63972a75cef8cfa5e1a2b1675a0

[Lldb-commits] [PATCH] D151460: [NFC][Py Reformat] Reformat python files in lldb

thieta added a comment. In D151460#4372763 , @mib wrote: > Can you add this commit hash to the `.git-blame-ignore-revs` file so it > doesn't show up in the git history Yeah that should be done. But has to be done after arc land anyway. CHANGES SINCE L

[Lldb-commits] [PATCH] D151460: [NFC][Py Reformat] Reformat python files in lldb

mib added a comment. Can you add this commit hash to the `.git-blame-ignore-revs` file so it doesn't show up in the git history CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151460/new/ https://reviews.llvm.org/D151460 ___ lldb-commits maili

[Lldb-commits] [PATCH] D151460: [NFC][Py Reformat] Reformat python files in lldb

JDevlieghere added a comment. In D151460#4372711 , @thieta wrote: > Thanks for doing this! Going to assume you ran the tests and it worked :) Yup, no regressions. I'll keep an eye on the bots to make sure that holds true for other configurations too.

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

aprantl added a comment. > @aprantl Do you know if we can detect the end of the scope ? I'm not sure > it's possible currently ... But even if we could do it, that wouldn't cover > the following case: When setting a variable watchpoint, you would have to store the scope the variable is in, and

[Lldb-commits] [PATCH] D151460: [NFC][Py Reformat] Reformat python files in lldb

thieta accepted this revision. thieta added a comment. This revision is now accepted and ready to land. Thanks for doing this! Going to assume you ran the tests and it worked :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151460/new/ https://reviews.llvm.org/D151460 _

[Lldb-commits] [PATCH] D151460: [NFC][Py Reformat] Reformat python files in lldb

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, thieta. Herald added subscribers: pmatos, asb, ormris, mstorsjo, wenlei, arphaman, steven_wu, kbarton, hiraditya, fedor.sergeev, sbc100, nemanjai, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a project

[Lldb-commits] [PATCH] D151425: [lldb][nfc] Place comment in the right place

fdeazeve added inline comments. Comment at: lldb/include/lldb/Utility/RangeMap.h:47 + // Set the start value for the range, and keep the same size void SetRangeBase(BaseType b) { base = b; } JDevlieghere wrote: > I can update it for sure, but note that no

[Lldb-commits] [PATCH] D151425: [lldb][nfc] Place comment in the right place

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo Doxygen comment. Comment at: lldb/include/lldb/Utility/RangeMap.h:47 + // Set the start value for the range, and keep the same size void SetRang

[Lldb-commits] [PATCH] D151451: [lldb][nfc] Refactor methods with out parameter

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently, the method `GetAttributeAddressRanges` takes a DWARFRangeList as a parameter, just to immediately clear it. The

[Lldb-commits] [PATCH] D151425: [lldb][nfc] Place comment in the right place

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This line has been misplaced since it was introduced in 2011 by c26e4454035a4160cffc3c865cf83be194ca38c4. Repository:

[Lldb-commits] [PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

hans added a comment. This looks right to me. (I'm out of office at the moment, but this looks like what I tested in https://github.com/llvm/llvm-project/issues/62719 so it should work.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151344/new/ h

[Lldb-commits] [PATCH] D151268: [lldb][DataFormatter] Add dereference support to libstdcpp std::shared_ptr formatter

Michael137 added a subscriber: compnerd. Michael137 added a comment. Any chance someone with a working aarch64 windows 10 setup could take a look? (@compnerd ?) Or let me know how I might be able to set this up. The place where we seem to crash in `TestVarPath.py` is: # Make sure we don't cra

[Lldb-commits] [PATCH] D151268: [lldb][DataFormatter] Add dereference support to libstdcpp std::shared_ptr formatter

antmo added a comment. Hi Michael, lldb-aarch64-windows bot is broken since yesterday: https://lab.llvm.org/buildbot/#/builders/219/builds/3012 I suspect this is due to this commit. Could you please take a look at this ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151268/new/ https:/