Author: Jonas Devlieghere
Date: 2023-05-14T20:30:29-07:00
New Revision: bf76a6e44723b73940ca81c3b17077225b3c4118
URL:
https://github.com/llvm/llvm-project/commit/bf76a6e44723b73940ca81c3b17077225b3c4118
DIFF:
https://github.com/llvm/llvm-project/commit/bf76a6e44723b73940ca81c3b17077225b3c4118.d
Author: Jonas Devlieghere
Date: 2023-05-14T20:18:47-07:00
New Revision: 3ebb33632a1509450fdbc1fb6a21107a0a513072
URL:
https://github.com/llvm/llvm-project/commit/3ebb33632a1509450fdbc1fb6a21107a0a513072
DIFF:
https://github.com/llvm/llvm-project/commit/3ebb33632a1509450fdbc1fb6a21107a0a513072.d
bolshakov-a added inline comments.
Comment at: clang/lib/AST/ItaniumMangle.cpp:4397
+// argument.
+// As proposed in https://github.com/itanium-cxx-abi/cxx-abi/issues/111.
+auto *SNTTPE = cast(E);
efriedma wrote:
> bolshakov-a wrote:
> > erichkeane wr
bolshakov-a added inline comments.
Comment at: clang/lib/AST/ItaniumMangle.cpp:4579
+ if (CE->hasAPValueResult())
+mangleValueInTemplateArg(ParamType, CE->getResultAsAPValue(), false,
+ /*NeedExactType=*/true);
efriedm
efriedma added inline comments.
Comment at: clang/lib/AST/ItaniumMangle.cpp:4579
+ if (CE->hasAPValueResult())
+mangleValueInTemplateArg(ParamType, CE->getResultAsAPValue(), false,
+ /*NeedExactType=*/true);
I'm not su
sgraenitz added a comment.
This patch adds test coverage for existing functionality. It was ready to land
6 weeks ago. There was plenty of opportunity to raise concerns and discuss
details over the last 2 months of review. I assume the topic is just too niche
to attract a lot of attention.
I a
