[Lldb-commits] [PATCH] D147587: Fix the check in StopInfoBreakpoint for "are we running an expression"

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo naming preference Comment at: lldb/include/lldb/Target/Process.h:287-292 + bool CurrentlyRunningExpression() const { +// Don't return true if we

[Lldb-commits] [PATCH] D147587: Fix the check in StopInfoBreakpoint for "are we running an expression"

jingham created this revision. jingham added reviewers: JDevlieghere, kastiglione, bulbazord, augusto2112. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If you hit a breakpoint while running an express

[Lldb-commits] [lldb] a78997e - Simplify test.

Author: Adrian Prantl Date: 2023-04-04T15:16:01-07:00 New Revision: a78997e0aa89250a193ff036e7c6e71562e03222 URL: https://github.com/llvm/llvm-project/commit/a78997e0aa89250a193ff036e7c6e71562e03222 DIFF: https://github.com/llvm/llvm-project/commit/a78997e0aa89250a193ff036e7c6e71562e03222.diff

[Lldb-commits] [lldb] 5d77344 - Simplify test script

Author: Adrian Prantl Date: 2023-04-04T15:08:57-07:00 New Revision: 5d77344d9d52a623de93563d9fae47cb0634d699 URL: https://github.com/llvm/llvm-project/commit/5d77344d9d52a623de93563d9fae47cb0634d699 DIFF: https://github.com/llvm/llvm-project/commit/5d77344d9d52a623de93563d9fae47cb0634d699.diff

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

wolfgangp added a comment. > @probinson Sounds like Sony's solution also changes the `DW_AT_type` to a > non-canonical form. Do you still have concerns with the direction of this > patch? Would it cause any problems for you downstream? Sorry for the late reply. Looking at the patch I don't thin

[Lldb-commits] [PATCH] D147300: [lldb] Fix build on older FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rGc0df412ad2a5: [lldb] Fix build on older FreeBSD (authored by brooks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147300/new/ https://reviews.llvm.org/D14

[Lldb-commits] [lldb] c0df412 - [lldb] Fix build on older FreeBSD

Author: Brooks Davis Date: 2023-04-04T21:21:45+01:00 New Revision: c0df412ad2a5236a66ff1b608aeddc744b563e79 URL: https://github.com/llvm/llvm-project/commit/c0df412ad2a5236a66ff1b608aeddc744b563e79 DIFF: https://github.com/llvm/llvm-project/commit/c0df412ad2a5236a66ff1b608aeddc744b563e79.diff

[Lldb-commits] [PATCH] D147436: [lldb][ClangExpression] Filter out non-root namespaces in FindNamespace

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. So the new bool flag effectively implements the leading `::` separator in the lookup. Seems reasonable! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

DavidSpickett added a comment. > It is completely bare metal, but the address space is only 16-bit, so would > the entire 64 KB of memory count as a core dump? It's more "world" than "core" but yeah why not. Probably won't need all 64k though, see below... > I can make a test that checks if fa

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd added a comment. In D146965#4240075 , @DavidSpickett wrote: > Two things come to mind: > > - Core files (though it is embedded so is that even a thing?) It is completely bare metal, but the address space is only 16-bit, so would the entire 64 KB

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added a comment. The modified proposal keeps GNUstep support off by default (even if installed). It must be enabled explicitly by passing `-DLLDB_TEST_OBJC_GNUSTEP=On` and it can be disabled easily by passing `-DLLDB_TEST_OBJC_GNUSTEP=Off` to CMake. A custom install location `/path/to

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz updated this revision to Diff 510732. sgraenitz added a comment. Split config in two parts: On/Off and DIR Move standard find library logic into FindGNUstepObjC.cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146058/new/ https://revie