[Lldb-commits] [PATCH] D147009: [lldb] Remove lldbExpression's dependency on ObjectFileJIT

mib added inline comments. Comment at: lldb/include/lldb/Symbol/ObjectFile.h:28 -class ObjectFileJITDelegate { +class ObjectFileDelegate { public: nit: What about nesting this in the `ObjectFile` class and rename it to `Delegate`. I would be better in term of

[Lldb-commits] [PATCH] D147006: [lldb] Fix value printing for a specific case

jgorbe accepted this revision. jgorbe added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147006/new/ https://reviews.llvm.org/D147006

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

dblaikie added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + Michael137 wrote: > dblaikie wrote: > > Michael137 wrote: > > > probinson wrote: > > > > This doesn't become `Foo` ? > > > The name stays as `Foo>` but t

[Lldb-commits] [PATCH] D147007: [lldb] Fix double free in python bindings error handling.

mib added a comment. LGTM! Thanks @jgorbe ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147007/new/ https://reviews.llvm.org/D147007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [PATCH] D147012: [lldb] Support Universal Mach-O binaries with a fat64 header

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, pete, aprantl. Herald added a project: All. JDevlieghere requested review of this revision. Support universal Mach-O binaries with a fat64 header. After D146879 , dsymutil can now gen

[Lldb-commits] [PATCH] D147007: [lldb] Fix double free in python bindings error handling.

jgorbe added a comment. In D147007#4225762 , @JDevlieghere wrote: > LGTM. I think it would be worth adding that information to the top of the > file to prevent similar mistakes in the future. Good idea, thanks. I added a note at the top before committi

[Lldb-commits] [PATCH] D147007: [lldb] Fix double free in python bindings error handling.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a38d3326895: [lldb] Fix double free in python bindings error handling. (authored by jgorbe). Changed prior to commit: https://reviews.llvm.org/D147007?vs=508811&id=508827#toc Repository: rG LLVM Git

[Lldb-commits] [lldb] 4a38d33 - [lldb] Fix double free in python bindings error handling.

Author: Jorge Gorbe Moya Date: 2023-03-27T16:07:36-07:00 New Revision: 4a38d33268959309dd97d9ef423327607bda4104 URL: https://github.com/llvm/llvm-project/commit/4a38d33268959309dd97d9ef423327607bda4104 DIFF: https://github.com/llvm/llvm-project/commit/4a38d33268959309dd97d9ef423327607bda4104.di

[Lldb-commits] [PATCH] D147009: [lldb] Remove lldbExpression's dependency on ObjectFileJIT

bulbazord updated this revision to Diff 508817. bulbazord added a comment. Herald added a subscriber: Michael137. Minor fix to ObjectFileWasm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147009/new/ https://reviews.llvm.org/D147009 Files: lldb/

[Lldb-commits] [PATCH] D147009: [lldb] Remove lldbExpression's dependency on ObjectFileJIT

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, labath, clayborg, mib, jingham. Herald added subscribers: pmatos, asb, sbc100, emaste. Herald added a project: All. bulbazord requested review of this revision. Herald added subscribers: lldb-commits, MaskRay, aheejin. Herald

[Lldb-commits] [PATCH] D147007: [lldb] Fix double free in python bindings error handling.

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM. I think it would be worth adding that information to the top of the file to prevent similar mistakes in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147007/new/

[Lldb-commits] [PATCH] D146977: [lldb-server/linux] Use waitpid(-1) to collect inferior events

yinghuitan added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:376-386 +bool handled = llvm::any_of(m_processes, [&](NativeProcessLinux *process) { + return process->TryHandleWaitStatus(pid, status); +}); +if (!handled) { +

[Lldb-commits] [PATCH] D147007: [lldb] Fix double free in python bindings error handling.

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Thanks for taking care of that! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147007/new/ https://reviews.llvm.org/D147007 __

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

jgorbe added a comment. In D146590#4225500 , @bulbazord wrote: > Yea, after reading the SWIG documentation, this diagnosis looks correct. If > you'd like to fix this feel free to upload a patch and list myself and @mib > as reviewers. Otherwise let me k

[Lldb-commits] [PATCH] D147007: [lldb] Fix double free in python bindings error handling.

jgorbe created this revision. jgorbe added reviewers: bulbazord, mib, labath. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. If we have a `%typemap(freearg)` that frees the argument, we shouldn't free it

[Lldb-commits] [PATCH] D147006: [lldb] Fix value printing for a specific case

kastiglione created this revision. kastiglione added reviewers: aprantl, jingham, jgorbe. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixes printing of spaces in cases where the following are tru

[Lldb-commits] [PATCH] D147001: [lldb] TestInferiorCrashing.py should check for crash reason

bulbazord created this revision. bulbazord added reviewers: labath, rupprecht. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In a now-reverted series of patches, I inadvertently broke the ability for

[Lldb-commits] [lldb] 41b6d58 - Revert "[lldb] Move UnixSignals creation into Platform plugins"

Author: Alex Langford Date: 2023-03-27T13:42:14-07:00 New Revision: 41b6d5863fef94bb3a9d184802c5bb6e2759da15 URL: https://github.com/llvm/llvm-project/commit/41b6d5863fef94bb3a9d184802c5bb6e2759da15 DIFF: https://github.com/llvm/llvm-project/commit/41b6d5863fef94bb3a9d184802c5bb6e2759da15.diff

[Lldb-commits] [lldb] ea157f9 - Revert "[lldb-server] Use Platform plugin corresponding to the host"

Author: Alex Langford Date: 2023-03-27T13:42:14-07:00 New Revision: ea157f9b3912209cdda4d3acc07245624ed68b6f URL: https://github.com/llvm/llvm-project/commit/ea157f9b3912209cdda4d3acc07245624ed68b6f DIFF: https://github.com/llvm/llvm-project/commit/ea157f9b3912209cdda4d3acc07245624ed68b6f.diff

[Lldb-commits] [lldb] 64b3bbc - [lldb] Remove NO_PLUGIN_DEPENDENCIES from lldbTarget

Author: Alex Langford Date: 2023-03-27T13:35:48-07:00 New Revision: 64b3bbc5220615b13d4a003877c773b8745a4d00 URL: https://github.com/llvm/llvm-project/commit/64b3bbc5220615b13d4a003877c773b8745a4d00 DIFF: https://github.com/llvm/llvm-project/commit/64b3bbc5220615b13d4a003877c773b8745a4d00.diff

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

bulbazord added a comment. In D146590#4220388 , @jgorbe wrote: > I found the actual reason for the crash I was talking about. This patch only > addressed the incorrect `OverflowError`, but the crash comes from a double > free (as @rupprecht mentioned) i

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

bulbazord added a comment. I'm not too familiar with MSP430 but the general idea looks fine. Others may have comments about areas I'm less familiar with. One concern I have is that there are no tests. I can understand that it may be difficult to get automated tests running testing the debugging

[Lldb-commits] [PATCH] D144665: Use Resume not PrivateResume when asynchronously continuing after the start at stop

mib added inline comments. Comment at: lldb/test/API/python_api/run_locker/TestRunLocker.py:25 +self.build() +self.runlocker_test(False) + @jingham, you're testing the same thing twice. You probably wanted to set the `stop_at_entry` argument to `

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 marked an inline comment as not done. Michael137 added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + dblaikie wrote: > Michael137 wrote: > > probinson wrote: > > > This doesn't become `Foo` ? > > The nam

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

dblaikie added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + Michael137 wrote: > probinson wrote: > > This doesn't become `Foo` ? > The name stays as `Foo>` but the type of the template parameter > becomes `BarInt

[Lldb-commits] [PATCH] D146783: [lldb] Add ability to hide the root name of a value

kastiglione added a comment. @jgorbe thanks for reporting. I have a fix for the missing space, I will look into the cause of the double space and fix that as well. I'll do this today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146783/new/ https

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

asl added a comment. @JDevlieghere @bulbazord I don't think I know lldb codebase well enough to cover the complete review here. But from MSP430-standpoint things seem to be correct. Will you be able to review or suggest some other reviewers? Thanks! Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [PATCH] D146668: [lldb-server] Use Platform plugin corresponding to the host

bulbazord added a comment. In D146668#4223456 , @labath wrote: > I'm sorry, but I don't think this is a good change (which I guess means the > previous one is not good either, but this one drives the point). I really > don't want lldb-server to depend o

[Lldb-commits] [PATCH] D146977: [lldb-server/linux] Use waitpid(-1) to collect inferior events

labath created this revision. labath added reviewers: DavidSpickett, yinghuitan. Herald added a subscriber: emaste. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. This is a follow-up to D116372 , which had a r

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd created this revision. kuilpd added a reviewer: asl. kuilpd added a project: LLDB. Herald added subscribers: Michael137, JDevlieghere. Herald added a project: All. kuilpd requested review of this revision. Herald added a subscriber: lldb-commits. Add MSP430 to the list of available targets,

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added a comment. In D146058#4223575 , @labath wrote: > What kind of setup is necessary to make that work? If it's not too > complicated, I think we could make something work. Thanks, that'd be awesome! The last official release is from 2020,

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 updated this revision to Diff 508563. Michael137 added a comment. - Fix function docstring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 updated this revision to Diff 508562. Michael137 added a comment. - Refine tests: - Check for type of template parameter - Add test for chained typedefs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

labath added a comment. In D146058#4193594 , @sgraenitz wrote: >> Pavel runs the x86 debian bot and I think the x86 Windows bot may have been >> retired, or at least is offline at the moment >> (https://lab.llvm.org/buildbot/#/builders/83) > > Yes, that

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

labath added a comment. In D146590#4220388 , @jgorbe wrote: > I believe (but I don't have any experience with SWIG typemaps so this is an > educated guess) that the call to `free` in the error path comes from the > `%typemap(freearg)` immediately after

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

labath added a comment. Yes, that is the correct process. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144240/new/ https://reviews.llvm.org/D144240 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D146668: [lldb-server] Use Platform plugin corresponding to the host

labath added a comment. I'm sorry, but I don't think this is a good change (which I guess means the previous one is not good either, but this one drives the point). I really don't want lldb-server to depend on a platform plugins . I have two reasons for that: - lldb-server is always running on