[Lldb-commits] [PATCH] D145181: Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery"

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM (see https://github.com/llvm/llvm-project/issues/60314) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145181/new/ https://revie

[Lldb-commits] [PATCH] D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

JDevlieghere added a comment. Can we do something similar for plugins? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146473/new/ https://reviews.llvm.org/D146473 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146473/new/ https://reviews.llvm.org/D146473 ___

[Lldb-commits] [lldb] c1e4a0d - Follow on to 2c7abc83f605b2d3b1062f28422eeff81278ecd5.

Author: Jim Ingham Date: 2023-03-20T16:49:05-07:00 New Revision: c1e4a0d4dbe9d68113a877764c794407bdd65622 URL: https://github.com/llvm/llvm-project/commit/c1e4a0d4dbe9d68113a877764c794407bdd65622 DIFF: https://github.com/llvm/llvm-project/commit/c1e4a0d4dbe9d68113a877764c794407bdd65622.diff LO

[Lldb-commits] [PATCH] D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

bulbazord added a comment. Note that this won't stop people from performing `#include` with non-Utility files, but this marks the intent that Utility is not supposed to be using anything else in lldb. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

bulbazord created this revision. bulbazord added a reviewer: JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldbUtility is not supposed to depend on anything else in lldb. Let's enforce

[Lldb-commits] [lldb] 2c7abc8 - Reapply 8d024a79ea783ed3fbb5691aeaf186ad3f0a4ae9 w/o the extra bits.

Author: Jim Ingham Date: 2023-03-20T16:11:00-07:00 New Revision: 2c7abc83f605b2d3b1062f28422eeff81278ecd5 URL: https://github.com/llvm/llvm-project/commit/2c7abc83f605b2d3b1062f28422eeff81278ecd5 DIFF: https://github.com/llvm/llvm-project/commit/2c7abc83f605b2d3b1062f28422eeff81278ecd5.diff LO

[Lldb-commits] [lldb] 9b655c2 - Revert "Fix a problem with "watchpoint triggers before" watchpoint handling."

Author: Jim Ingham Date: 2023-03-20T16:05:57-07:00 New Revision: 9b655c2627e31ea62032e175b3a9f2cae8aea653 URL: https://github.com/llvm/llvm-project/commit/9b655c2627e31ea62032e175b3a9f2cae8aea653 DIFF: https://github.com/llvm/llvm-project/commit/9b655c2627e31ea62032e175b3a9f2cae8aea653.diff LO

[Lldb-commits] [lldb] ee23250 - [lldb] Move UnixSignals creation into Platform plugins

Author: Alex Langford Date: 2023-03-20T15:41:06-07:00 New Revision: ee232506b870ce5282cc4da5ca493d41d361feb3 URL: https://github.com/llvm/llvm-project/commit/ee232506b870ce5282cc4da5ca493d41d361feb3 DIFF: https://github.com/llvm/llvm-project/commit/ee232506b870ce5282cc4da5ca493d41d361feb3.diff

[Lldb-commits] [PATCH] D146263: [lldb] Move UnixSignals creation into Platform plugins

This revision was automatically updated to reflect the committed changes. Closed by commit rGee232506b870: [lldb] Move UnixSignals creation into Platform plugins (authored by bulbazord). Changed prior to commit: https://reviews.llvm.org/D146263?vs=505934&id=506757#toc Repository: rG LLVM Git

[Lldb-commits] [PATCH] D146337: Partially fix stepping over watchpoints on "watch triggers before" systems

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d024a79ea78: Fix a problem with "watchpoint triggers before" watchpoint handling. (authored by jingham). Changed prior to commit: https://reviews.llvm.org/D146337?vs=506219&id=506750#toc Repository:

[Lldb-commits] [lldb] 8d024a7 - Fix a problem with "watchpoint triggers before" watchpoint handling.

Author: Jim Ingham Date: 2023-03-20T15:17:15-07:00 New Revision: 8d024a79ea783ed3fbb5691aeaf186ad3f0a4ae9 URL: https://github.com/llvm/llvm-project/commit/8d024a79ea783ed3fbb5691aeaf186ad3f0a4ae9 DIFF: https://github.com/llvm/llvm-project/commit/8d024a79ea783ed3fbb5691aeaf186ad3f0a4ae9.diff LO

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

bulbazord added a comment. I'm supportive of this idea but I would like to find a way to do it without introducing dependencies on plugins in non-plugin code if possible. Comment at: lldb/include/lldb/Core/DumpRegisterValue.h:12 +#include "Plugins/TypeSystem/Clang/TypeSystem

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4053 + // appears once, so we don't have to handle that here. + if (attr_name == "name") { +LLDB_LOGF(log, Do you think that using a `Str

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

JDevlieghere added a subscriber: bulbazord. JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/DumpRegisterValue.h:12 +#include "Plugins/TypeSystem/Clang/TypeSystemClang.h" #include "lldb/lldb-enumerations.h" Core components (not just the C

[Lldb-commits] [PATCH] D145568: [lldb] Add dummy field to RegisterInfo for register flags use later

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ABI/ARM/ABIMacOSX_arm.cpp:57-68 {"r1", nullptr, 4, 0, eEncodingUint, eFormatHex, {ehframe_r1, dwarf_r1, LLDB_REGNUM_GENERIC_ARG2, LLDB_INVALID_REGNUM, Wou

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM modulo comments Comment at: lldb/include/lldb/Target/RegisterFlags.h:21-22 + public: +Field(llvm::StringRef name, unsigned start, unsigned end) +: m_name(name.str()), m_start(start), m_end(end)

[Lldb-commits] [PATCH] D146263: [lldb] Move UnixSignals creation into Platform plugins

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. We're only using the OS part of the triple/ArchSpec so there should be a 1:1 mapping with the platform. I don't see any issue with this. LGTM. Repository: rG LLVM Github Monorep

[Lldb-commits] [lldb] c47da7f - [lldb] Introduce CMake variable LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS

Author: Alex Langford Date: 2023-03-20T10:41:22-07:00 New Revision: c47da7f109468efbe77c27d436fd69fa2b3ad991 URL: https://github.com/llvm/llvm-project/commit/c47da7f109468efbe77c27d436fd69fa2b3ad991 DIFF: https://github.com/llvm/llvm-project/commit/c47da7f109468efbe77c27d436fd69fa2b3ad991.diff

[Lldb-commits] [PATCH] D146335: [lldb] Introduce CMake variable LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS

This revision was automatically updated to reflect the committed changes. Closed by commit rGc47da7f10946: [lldb] Introduce CMake variable LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[Lldb-commits] [lldb] e4f62da - [lldb] Sidestep -Wformat warning by using LLDB_LOG instead of LLDB_LOGF

Author: Jonas Devlieghere Date: 2023-03-20T10:32:02-07:00 New Revision: e4f62da8129d9632d77fd4db5cf8caede0a1e5a6 URL: https://github.com/llvm/llvm-project/commit/e4f62da8129d9632d77fd4db5cf8caede0a1e5a6 DIFF: https://github.com/llvm/llvm-project/commit/e4f62da8129d9632d77fd4db5cf8caede0a1e5a6.d

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 updated this revision to Diff 506588. Michael137 added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Fix cycle in `DIDerivedType` when we deal with forward declarations and complete explicitly via `completeClassData` (e.g., with `-gmodules`) - Add

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

erichkeane added a subscriber: asl. erichkeane added a comment. I've got the 1 concern with the mangling that I REALLY want one of our codegen owners to chime in on, otherwise this LGTM. Comment at: clang/lib/AST/ItaniumMangle.cpp:4397 +// argument. +// As proposed in

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

DavidSpickett added a comment. The big assumption here is that the GDB process lasts longer than the higher level debug session does. I am keeping a map of register name to unique pointer in the GDB process, then giving out raw pointers to the higher level commands. The higher level is destroye

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett added a comment. The shakiest aspect here is probably my use of the scratch type system. It works but I'm not 100% that there isn't a better choice. These are the current steps: - Make the type name. I've prepended `__lldb_` as I saw elsewhere. So register `cpsr` would have a typ

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

This revision was automatically updated to reflect the committed changes. Closed by commit rG0107513fe79d: [lldb] Implement CrashReason using UnixSignals (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146044/new/ https://

[Lldb-commits] [lldb] 0107513 - [lldb] Implement CrashReason using UnixSignals

Author: David Spickett Date: 2023-03-20T11:39:32Z New Revision: 0107513fe79da7670e37c29c0862794a2213a89c URL: https://github.com/llvm/llvm-project/commit/0107513fe79da7670e37c29c0862794a2213a89c DIFF: https://github.com/llvm/llvm-project/commit/0107513fe79da7670e37c29c0862794a2213a89c.diff LOG

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

DavidSpickett added inline comments. Comment at: lldb/include/lldb/Target/UnixSignals.h:127 + struct SignalCode { +ConstString m_description; +SignalCodePrintOption m_print_option; DavidSpickett wrote: > labath wrote: > > I think we should just make stri

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

iridinite added a comment. @kwk Thanks for the links, good to know that there is a debuginfod client in the LLVM project. However, doesn't lldb itself still need to integrate with this, like @fche2 mentioned, for end-users to be able to work with it? (Please correct me if I'm wrong, I am not fa

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140630/new/ https://reviews.llvm.org/D140630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.