[Lldb-commits] [PATCH] D146337: Partially fix stepping over watchpoints on "watch triggers before" systems

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146337/new/ https://reviews.llvm.org/D146337 ___

[Lldb-commits] [PATCH] D146335: [lldb] Introduce CMake variable LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks, this is great. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146335/new/ https://reviews.llvm.org/D146335 ___

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

clayborg added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145624/new/ https://reviews.llvm.org/D145624 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D146337: Partially fix stepping over watchpoints on "watch triggers before" systems

jingham created this revision. jingham added reviewers: jasonmolenda, JDevlieghere. Herald added a subscriber: kristof.beyls. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There were (at least) two pro

[Lldb-commits] [PATCH] D146265: [lldb] Introduce SymbolFile::ParseAllLanguages

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. You could add a test similar to lldb/unittests/SymbolFile/DWARF/XcodeSDKModuleTests.cpp Comment at: lldb/include/lldb/Symbol/SymbolFile.h:154 + /// case this function sho

[Lldb-commits] [PATCH] D146335: [lldb] Introduce CMake variable LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, aprantl, labath. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The goal of this patch is to add the ability for the CMake con

[Lldb-commits] [PATCH] D146320: [lldb] Test direct ivar access in objc++ (NFC)

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Otherwise LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146320/new/ https://reviews.llvm.org/D146320 ___

[Lldb-commits] [PATCH] D146320: [lldb] Test direct ivar access in objc++ (NFC)

aprantl added inline comments. Comment at: lldb/test/API/commands/frame/var/direct-ivar/objcpp/main.mm:6 + void fun() { +// check this + } I would recommend using `printf("check this")` to make 100% sure that there is code on this line. Repository: rG

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

aprantl added a comment. Here is an example of how the Swift Runtime plugin detects both itself and whether ObjC interop is enabled. Basically all I'm asking is to not accidentally break this mechanism. https://github.com/apple/llvm-project/blob/7750ffa35111df6d38a5c73ab7e78ccebc9b43c3/lldb/sour

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

aprantl added a comment. In D146154#4198730 , @sgraenitz wrote: > In D146154#4197454 , @aprantl wrote: > >> One thing I just realized — we need to make sure that we don't accidentally >> create a GNUstep ObjC run

[Lldb-commits] [lldb] b1e9bae - [lldb] Enable TestPublicAPIHeaders.py on Apple Silicon

Author: Alex Langford Date: 2023-03-17T12:43:14-07:00 New Revision: b1e9baea3a2c486dc09b6a098439d1f75548b582 URL: https://github.com/llvm/llvm-project/commit/b1e9baea3a2c486dc09b6a098439d1f75548b582 DIFF: https://github.com/llvm/llvm-project/commit/b1e9baea3a2c486dc09b6a098439d1f75548b582.diff

[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

rsmith added a comment. I have no strong opinions on the merits of this patch in either direction; I think the "sorry"s in the Sema diagnostics for regrettable non-conformance make Clang marginally friendlier, but they do nothing to actually help people who encounter the diagnostic. FWIW, the

[Lldb-commits] [PATCH] D146320: [lldb] Test direct ivar access in objc++ (NFC)

kastiglione created this revision. kastiglione added a reviewer: aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add an Objective-C++ specific test for direct ivar access. This adds to the

[Lldb-commits] [lldb] 8c040d0 - [lldb] Fix d875838e8b45cb0da5070298d0c1a2d1ee78ce7e

Author: Dave Lee Date: 2023-03-17T10:45:46-07:00 New Revision: 8c040d0f4941d3557affda3550428b8712b69c92 URL: https://github.com/llvm/llvm-project/commit/8c040d0f4941d3557affda3550428b8712b69c92 DIFF: https://github.com/llvm/llvm-project/commit/8c040d0f4941d3557affda3550428b8712b69c92.diff LOG:

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Herald added a subscriber: jplehr. Comment at: lldb/source/Plugins/SymbolFile/JSON/SymbolFileJSON.cpp:112 +symtab.AddSymbol(Symbol( +/*symID*/ 0, Mangled(symbol.name), eSymbolTypeCode,

[Lldb-commits] [PATCH] D146230: [lldb][test] Replace use of p with expression in Shell tests (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGd875838e8b45: [lldb][test] Replace use of p with expression in Shell tests (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146

[Lldb-commits] [lldb] d875838 - [lldb][test] Replace use of p with expression in Shell tests (NFC)

Author: Dave Lee Date: 2023-03-17T10:29:24-07:00 New Revision: d875838e8b45cb0da5070298d0c1a2d1ee78ce7e URL: https://github.com/llvm/llvm-project/commit/d875838e8b45cb0da5070298d0c1a2d1ee78ce7e DIFF: https://github.com/llvm/llvm-project/commit/d875838e8b45cb0da5070298d0c1a2d1ee78ce7e.diff LOG:

[Lldb-commits] [lldb] 147b609 - [lldb] Unify WatchpointSP variable names (NFC)

Author: Jonas Devlieghere Date: 2023-03-17T10:09:40-07:00 New Revision: 147b60964064b17163f1788dcd24c366ba3d54b1 URL: https://github.com/llvm/llvm-project/commit/147b60964064b17163f1788dcd24c366ba3d54b1 DIFF: https://github.com/llvm/llvm-project/commit/147b60964064b17163f1788dcd24c366ba3d54b1.d

[Lldb-commits] [PATCH] D146262: [lldb] Set the watchpoint spec for expression watchpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a7642977876: [lldb] Set the watchpoint spec for expression watchpoints (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [lldb] 2a76429 - [lldb] Set the watchpoint spec for expression watchpoints

Author: Jonas Devlieghere Date: 2023-03-17T09:55:57-07:00 New Revision: 2a76429778768ed29404f0396194636e2bc11b90 URL: https://github.com/llvm/llvm-project/commit/2a76429778768ed29404f0396194636e2bc11b90 DIFF: https://github.com/llvm/llvm-project/commit/2a76429778768ed29404f0396194636e2bc11b90.d

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

fche2 added a comment. Closing this might have been premature. I can't find an lldb debuginfod client side support. Is that somehow behind llvm-symbolicator or something like that? Is there documentation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D146221: [CodeView] Add source languages ObjC and ObjC++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef006eb0bc5e: [CodeView] Add source languages ObjC and ObjC++ (authored by sgraenitz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [lldb] ef006eb - [CodeView] Add source languages ObjC and ObjC++

Author: Stefan Gränitz Date: 2023-03-17T17:09:31+01:00 New Revision: ef006eb0bc5e8d069deee7e7d93d7cf5d55fd791 URL: https://github.com/llvm/llvm-project/commit/ef006eb0bc5e8d069deee7e7d93d7cf5d55fd791 DIFF: https://github.com/llvm/llvm-project/commit/ef006eb0bc5e8d069deee7e7d93d7cf5d55fd791.diff

[Lldb-commits] [PATCH] D146221: [CodeView] Add source languages ObjC and ObjC++

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/test/DebugInfo/COFF/objc.ll:4-6 +; ASM: .short 4412# Record kind: S_COMPILE3 +; ASM-NEXT: .long 17

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk abandoned this revision. kwk added a comment. There already is a Debuginfod implementation in LLVM by now. Abandoning revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 _

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk added a comment. Looks like it is already there: https://github.com/llvm/llvm-project/tree/main/llvm/include/llvm/Debuginfod Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 ___

[Lldb-commits] [PATCH] D146221: [CodeView] Add source languages ObjC and ObjC++

sgraenitz added inline comments. Comment at: llvm/test/DebugInfo/COFF/objc.ll:4-6 +; ASM: .short 4412# Record kind: S_COMPILE3 +; ASM-NEXT: .long 17 # Flags and language +; ASM-NEXT: .short 208 # CPUType --

[Lldb-commits] [PATCH] D146221: [CodeView] Add source languages ObjC and ObjC++

sgraenitz updated this revision to Diff 506100. sgraenitz marked 7 inline comments as done. sgraenitz added a comment. Cut down check-lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146221/new/ https://reviews.llvm.org/D146221 Files: lldb/so

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk added a subscriber: phosek. kwk added a comment. @iridinite please see these: - https://discourse.llvm.org/t/http-library-in-llvm/56317/10 - https://discourse.llvm.org/t/rfc-building-llvm-debuginfod/59011 - https://discourse.llvm.org/t/rfc-building-llvm-debuginfod/58994 - https://discourse.ll

[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

aaron.ballman added a comment. In D146041#4198056 , @AryanGodara wrote: > I will try to split this commit, and update on this asap (Sorry for the late > update, I have mid-sem exams going on, I haven't abandoned this issue, still > working on it). No

[Lldb-commits] [PATCH] D146297: [lldb][gnustep][PDB] Parse ObjC base classes and recognize NSObject type

sgraenitz added a comment. In D146297#4202172 , @DavidSpickett wrote: > I don't know anything about Objective C internals, perhaps you can provide > some reference that talks about this? Honestly, I am mostly looking what the DWARF parser does and try

[Lldb-commits] [PATCH] D146221: [CodeView] Add source languages ObjC and ObjC++

DavidSpickett added inline comments. Comment at: llvm/test/DebugInfo/COFF/objc.ll:4-6 +; ASM: .short 4412# Record kind: S_COMPILE3 +; ASM-NEXT: .long 17 # Flags and language +; ASM-NEXT: .short 208 # CPUType --

[Lldb-commits] [PATCH] D146221: [CodeView] Add source languages ObjC and ObjC++

DavidSpickett added inline comments. Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeView.h:142 +/// These values correspond to the CV_CFL_LANG enumeration in the Microsoft +/// Debug Interface Access SDK enum SourceLanguage : uint8_t { sgraenitz wrote: > D

[Lldb-commits] [PATCH] D146221: [CodeView] Add source languages ObjC and ObjC++

sgraenitz added a comment. Maybe I should have noted immediately, that this is mostly following the change for Rust from https://reviews.llvm.org/D115300 Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeView.h:142 +/// These values correspond to the CV_CFL_LANG enumeration

[Lldb-commits] [PATCH] D146297: [lldb][gnustep][PDB] Parse ObjC base classes and recognize NSObject type

DavidSpickett added a comment. I don't know anything about Objective C internals, perhaps you can provide some reference that talks about this? Comment at: lldb/test/Shell/Expr/objc-gnustep-print-pdb.m:44 -// RUN: %lldb -b -o "b objc-gnustep-print-pdb.m:67" -o "run" -o "p pt

[Lldb-commits] [PATCH] D146221: [CodeView] Add source languages ObjC and ObjC++

DavidSpickett added inline comments. Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeView.h:142 +/// These values correspond to the CV_CFL_LANG enumeration in the Microsoft +/// Debug Interface Access SDK enum SourceLanguage : uint8_t { Could put the same l

[Lldb-commits] [lldb] 49f9af1 - [LLDB] Remove some typed pointer code (NFCI)

Author: Nikita Popov Date: 2023-03-17T15:25:58+01:00 New Revision: 49f9af1864d918a0561e455d2ec403f32135c108 URL: https://github.com/llvm/llvm-project/commit/49f9af1864d918a0561e455d2ec403f32135c108 DIFF: https://github.com/llvm/llvm-project/commit/49f9af1864d918a0561e455d2ec403f32135c108.diff

[Lldb-commits] [PATCH] D146297: [lldb][gnustep][PDB] Parse ObjC base classes and recognize NSObject type

sgraenitz created this revision. sgraenitz added reviewers: aleksandr.urakov, rnk, teemperor, DavidSpickett, aprantl, zturner. Herald added a project: All. sgraenitz requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. Herald added a pr

[Lldb-commits] [PATCH] D146286: [lldb][PDB] Rename GetDeclarationForSymbol() -> AddSourceInfoToDecl()

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9987f0ac81a: [lldb][PDB] Rename GetDeclarationForSymbol() -> AddSourceInfoToDecl() (authored by sgraenitz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[Lldb-commits] [lldb] c9987f0 - [lldb][PDB] Rename GetDeclarationForSymbol() -> AddSourceInfoToDecl()

Author: Stefan Gränitz Date: 2023-03-17T14:40:17+01:00 New Revision: c9987f0ac81a3d00be7627022372551bed61e6c1 URL: https://github.com/llvm/llvm-project/commit/c9987f0ac81a3d00be7627022372551bed61e6c1 DIFF: https://github.com/llvm/llvm-project/commit/c9987f0ac81a3d00be7627022372551bed61e6c1.diff

[Lldb-commits] [PATCH] D146286: [lldb][PDB] Rename GetDeclarationForSymbol() -> AddSourceInfoToDecl()

sgraenitz added a comment. Thanks for the quick response! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146286/new/ https://reviews.llvm.org/D146286 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D146293: [lldb][gnustep][PDB] Recognize ObjC classes and start definition only once the complete type is requested

sgraenitz added a comment. In order to run the test yourself locally, you also need to apply D146058 , D146154 and D146221 first (right now they are still in review). Comm

[Lldb-commits] [PATCH] D146293: [lldb][gnustep][PDB] Recognize ObjC classes and start definition only once the complete type is requested

sgraenitz created this revision. sgraenitz added reviewers: aleksandr.urakov, rnk, aprantl, DavidSpickett, omjavaid, zturner, asmith. Herald added a project: All. sgraenitz requested review of this revision. Herald added a project: LLDB. This patch allows the PDB parser to recognize UDT symbols a

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

iridinite added a comment. Hello all, I am quite interested in integrating debuginfod with LLDB; my colleagues and I are currently exploring moving away from GDB to LLDB for general development work, since it appears to outperform GDB in many respects! It appears there has been no activity on

[Lldb-commits] [PATCH] D146286: [lldb][PDB] Rename GetDeclarationForSymbol() -> AddSourceInfoToDecl()

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. Agreed, the original name sounds like a const method. Although I can see why it might have been this way because before optional there was no way to have a null return. So it's return a bool and a ref to the result.

[Lldb-commits] [PATCH] D146286: [lldb][PDB] Rename GetDeclarationForSymbol() -> AddSourceInfoToDecl()

sgraenitz created this revision. sgraenitz added reviewers: aleksandr.urakov, labath, rnk, asmith, zturner. Herald added a project: All. sgraenitz requested review of this revision. Herald added a project: LLDB. The old name of this function was confusing for me, when I started working on the PDB

[Lldb-commits] [PATCH] D146285: [lldb] For native compiles, check signal numbers are correct when adding codes

DavidSpickett created this revision. Herald added subscribers: krytarowski, emaste. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D146222: [lldb] Add compile time checks for signal codes when on the matching platform

DavidSpickett updated this revision to Diff 506029. DavidSpickett marked an inline comment as done. DavidSpickett added a comment. Correct Linux macro definition when not on Linux. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146222/new/ https://r

[Lldb-commits] [PATCH] D146222: [lldb] Add compile time checks for signal codes when on the matching platform

DavidSpickett marked 3 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:14 + +#ifndef SEGV_BNDERR +#define SEGV_BNDERR 3 arichardson wrote: > I guess these are needed to support older v

[Lldb-commits] [PATCH] D146222: [lldb] Add compile time checks for signal codes when on the matching platform

DavidSpickett updated this revision to Diff 506028. DavidSpickett added a comment. Remove SEGV_BNDERR defines from FreeBSD and NetBSD. I cargo culted these from CrashReason but on checking the latest sources, they are not in either. It has been in Linux since kernel 3.19 which was February 2015.

[Lldb-commits] [PATCH] D146045: [LLDB] Show sub type of signals when debugging a core file

DavidSpickett updated this revision to Diff 506025. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146045/new/ https://reviews.llvm.org/D146045 Files: lldb/include/lldb/Target/StopInfo.h lldb/source/Plugins

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

DavidSpickett updated this revision to Diff 506022. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146044/new/ https://reviews.llvm.org/D146044 Files: lldb/include/lldb/Target/UnixSignals.h lldb/source/Plug