[Lldb-commits] [PATCH] D145294: [lldb/API] Introduce SBProcess::ForceScriptedState method

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145294/new/ https://reviews.llvm.org/D145294 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 93a4553 - [lldb] Remove MIPS Linux UnixSignals

Author: Alex Langford Date: 2023-03-13T17:17:47-07:00 New Revision: 93a455375c0fa1dd014a3b4571b22e307d15bbf7 URL: https://github.com/llvm/llvm-project/commit/93a455375c0fa1dd014a3b4571b22e307d15bbf7 DIFF: https://github.com/llvm/llvm-project/commit/93a455375c0fa1dd014a3b4571b22e307d15bbf7.diff

[Lldb-commits] [PATCH] D142260: Actually report an error when `command script add` is passed a non-existent class

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo the else-after-return. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1949-1950 +new StructuredPythonOb

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM if @clayborg is happy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145624/new/ https://reviews.llvm.org/D145624 _

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145295/new/ https://reviews.llvm.org/D145295 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

bulbazord added a comment. No problem from me. Jonas? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145295/new/ https://reviews.llvm.org/D145295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

mib updated this revision to Diff 504877. mib added a comment. Address @bulbazord comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145295/new/ https://reviews.llvm.org/D145295 Files: lldb/examples/python/scripted_process/scripted_process.py lldb/include/lldb/Interpreter/Scri

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

bulbazord updated this revision to Diff 504873. bulbazord added a comment. Address small nits from Greg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145624/new/ https://reviews.llvm.org/D145624 Files: lldb/include/lldb/Target/Memory.h lldb/so

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

bulbazord added inline comments. Comment at: lldb/source/Target/Memory.cpp:245-246 +if (m_invalid_ranges.FindEntryThatContains(cache_line_base_addr)) { + error.SetErrorStringWithFormat("memory read failed for 0x%" PRIx64, + cache_line_

[Lldb-commits] [PATCH] D145294: [lldb/API] Introduce SBProcess::ForceScriptedState method

mib updated this revision to Diff 504871. mib added a comment. Remove `private state` occurrences as @jingham suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145294/new/ https://reviews.llvm.org/D145294 Files: lldb/include/lldb/API/SBProcess.h lldb/include/lldb/Target/Proc

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

bulbazord added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_process.py:166-167 -Returns: -lldb.SBError: An `lldb.SBError` with error code 0. -""" -return lldb.SBError() - -@abstractmethod -def should_st

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bnbarham added inline comments. Comment at: clang/lib/Index/USRGeneration.cpp:1032 + case TemplateArgument::UncommonValue: +// FIXME: Visit value. +break; bolshakov-a wrote: > bnbarham wrote: > > bolshakov-a wrote: > > > bnbarham wrote: > > > > akyrtzi w

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging (NFC)

mib added a comment. ping @JDevlieghere @jingham @labath Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145297/new/ https://reviews.llvm.org/D145297 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [PATCH] D145296: [lldb/Plugin] Add breakpoint setting support to ScriptedProcesses.

mib added a comment. ping @JDevlieghere @jingham Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145296/new/ https://reviews.llvm.org/D145296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added inline comments. Comment at: clang/lib/Index/USRGeneration.cpp:1032 + case TemplateArgument::UncommonValue: +// FIXME: Visit value. +break; bnbarham wrote: > bolshakov-a wrote: > > bnbarham wrote: > > > akyrtzi wrote: > > > > erichkeane

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

mib added a comment. ping @JDevlieghere @bulbazord Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145295/new/ https://reviews.llvm.org/D145295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bnbarham added inline comments. Comment at: clang/lib/Index/USRGeneration.cpp:1032 + case TemplateArgument::UncommonValue: +// FIXME: Visit value. +break; bolshakov-a wrote: > bnbarham wrote: > > akyrtzi wrote: > > > erichkeane wrote: > > > > bolshakov-a

[Lldb-commits] [lldb] 9c972a3 - [lldb] Explicitly import json in TestSymbolFileJSON.py

Author: Jonas Devlieghere Date: 2023-03-13T14:48:05-07:00 New Revision: 9c972a3d82f303714be6d4f1485a0dc6642cd5f3 URL: https://github.com/llvm/llvm-project/commit/9c972a3d82f303714be6d4f1485a0dc6642cd5f3 DIFF: https://github.com/llvm/llvm-project/commit/9c972a3d82f303714be6d4f1485a0dc6642cd5f3.d

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added inline comments. Comment at: clang/lib/Index/USRGeneration.cpp:1032 + case TemplateArgument::UncommonValue: +// FIXME: Visit value. +break; bnbarham wrote: > akyrtzi wrote: > > erichkeane wrote: > > > bolshakov-a wrote: > > > > aaron.ba

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bnbarham added inline comments. Comment at: clang/lib/Index/USRGeneration.cpp:1032 + case TemplateArgument::UncommonValue: +// FIXME: Visit value. +break; akyrtzi wrote: > erichkeane wrote: > > bolshakov-a wrote: > > > aaron.ballman wrote: > > > > Any pa

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

akyrtzi added a subscriber: bnbarham. akyrtzi added inline comments. Comment at: clang/lib/Index/USRGeneration.cpp:1032 + case TemplateArgument::UncommonValue: +// FIXME: Visit value. +break; erichkeane wrote: > bolshakov-a wrote: > > aaron.ballman wrote

[Lldb-commits] [lldb] 0ea18a0 - [lldb] Fix lldb code for renaming of OpenCL AVC types.

Author: Joshua Cranmer Date: 2023-03-13T14:55:01-04:00 New Revision: 0ea18a0d5cbe6d836cae49bfa6ad8d999e6edc61 URL: https://github.com/llvm/llvm-project/commit/0ea18a0d5cbe6d836cae49bfa6ad8d999e6edc61 DIFF: https://github.com/llvm/llvm-project/commit/0ea18a0d5cbe6d836cae49bfa6ad8d999e6edc61.diff

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

erichkeane added inline comments. Comment at: clang/www/cxx_status.html:1067 + Reference type template arguments referring to instantiation-dependent objects and subobjects + (i.e. delcared inside a template but neither type- nor value-dependent) aren't fully

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

erichkeane added subscribers: eli.friedman, gribozavr2, akyrtzi, gribozavr. erichkeane added inline comments. Comment at: clang/include/clang/AST/TemplateBase.h:88 +/// so cannot be dependent. +UncommonValue, + bolshakov-a wrote: > shafik wrote: > > erich

[Lldb-commits] [PATCH] D145955: Refactor ObjectFilePlaceholder for sharing

This revision was automatically updated to reflect the committed changes. Closed by commit rG46c2e4c4f347: Refactor ObjectFilePlaceholder for sharing (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145955/new/ https://reviews

[Lldb-commits] [lldb] 46c2e4c - Refactor ObjectFilePlaceholder for sharing

Author: Jeffrey Tan Date: 2023-03-13T11:09:05-07:00 New Revision: 46c2e4c4f347038179e21e027128f5f2914fb980 URL: https://github.com/llvm/llvm-project/commit/46c2e4c4f347038179e21e027128f5f2914fb980 DIFF: https://github.com/llvm/llvm-project/commit/46c2e4c4f347038179e21e027128f5f2914fb980.diff L

[Lldb-commits] [PATCH] D145964: [lld] Use installed llvm_gtest in standalone builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56464ba865b7: [lld] Use installed llvm_gtest in standalone builds (authored by mgorny). Herald added a project: LLVM. Herald added a subscriber: llvm

[Lldb-commits] [PATCH] D142260: Actually report an error when `command script add` is passed a non-existent class

jingham added a comment. Committed as: 9093f3c39b8fa8ef836c627e1db329cd7349e9bb . I forgot to include the "differential revision" line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

clayborg added inline comments. Comment at: lldb/source/Target/Memory.cpp:133-135 + if (pos != m_L2_cache.end()) { +return pos->second; + } remove braces for single line if statement per llvm coding guidelines Comment at: lldb/source/Targ

[Lldb-commits] [PATCH] D145964: [lld] Use installed llvm_gtest in standalone builds

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145964/new/ https://reviews.llvm.org/D145964 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D145964: [lld] Use installed llvm_gtest in standalone builds

mgorny created this revision. mgorny added a reviewer: tstellar. Herald added a project: All. mgorny requested review of this revision. Use the installed llvm_gtest library instead of rebuilding it locally when standalone builds are used. This change is now required as otherwise the build fails d

[Lldb-commits] [PATCH] D145955: Refactor ObjectFilePlaceholder for sharing

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch ref

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

jasonmolenda added a comment. This gdb_remote_client test looks real nice with this update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145580/new/ https://reviews.llvm.org/D145580 ___ lldb-commits mai

[Lldb-commits] [PATCH] D145377: [LLDB] Show sub type of memory tagging SEGV when reading a core file

DavidSpickett planned changes to this revision. DavidSpickett added a comment. I'm working on merging CrashReason into UnixSignals, so this will either be part of, or on top of that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145377/new/ https:

[Lldb-commits] [PATCH] D145950: [lldb] Remove MipsLinuxSignals

DavidSpickett added a reviewer: labath. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. One less set of signals I need to update to merge CrashReason into UnixSignals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145950/new/

[Lldb-commits] [PATCH] D145950: [lldb] Remove MipsLinuxSignals

DavidSpickett created this revision. Herald added subscribers: atanasyan, jrtc27, arichardson, sdardis. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. Support for Linux MIPS debu

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added a comment. It works, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504681. bolshakov-a added a comment. Update patch with more context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

Endill added a comment. In D140996#4189452 , @bolshakov-a wrote: > Sorry! It's my first time using Phabricator. Maybe, the problem occurs > because I've solved the issue with Arcanist just by means of copy-pasting > patches into "Update Diff" Web GUI f

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

erichkeane added a comment. In D140996#4189452 , @bolshakov-a wrote: > Sorry! It's my first time using Phabricator. Maybe, the problem occurs > because I've solved the issue with Arcanist just by means of copy-pasting > patches into "Update Diff" Web G

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added a comment. Sorry! It's my first time using Phabricator. Maybe, the problem occurs because I've solved the issue with Arcanist just by means of copy-pasting patches into "Update Diff" Web GUI form. Maybe, I should reopen the PR? CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

erichkeane added a comment. Patch seems to be missing all the context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/TestRegistersUnavailable.py:57 +"other:\n" +"1 registers were unavailable."]) The only difference here if you have the x86 backend vs. not, is that

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Prior to this the only check was that we did not print this message when reading registers that should exist. I

[Lldb-commits] [PATCH] D144392: [lldb] Skip signal handlers for ignored signals on lldb-server's side when stepping

kpdev42 added a comment. In D144392#4139001 , @labath wrote: > I'm afraid you're fixing this at the wrong end. This kind of complex thread > control does not belong inside the debug stub. > > IIUC, the problematic sequence of events is: > > 1. lldb sends

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added a comment. Ping. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangHost.cpp:56 + const std::string clang_resource_path = + clang::driver::Driver::GetResourcesPath("bin/lldb", CLANG_RESOURCE_DIR); Should be "${CMAKE_INSTALL_B

[Lldb-commits] [PATCH] D144390: [lldb] Send QPassSignals packet on attach, and at start for remote platforms

kpdev42 added a comment. In D144390#4138869 , @DavidSpickett wrote: > What is the practical impact of the bug you are fixing? > > I guess it is something like if you set signal handling info, then attach to > something, that info is not used. Until you

[Lldb-commits] [lldb] b4854e4 - [lldb][docs] Remove mentions of MIPS64 Linux debug

Author: David Spickett Date: 2023-03-13T12:01:31Z New Revision: b4854e4e86cc934e8d7ba86007edd6e255b11609 URL: https://github.com/llvm/llvm-project/commit/b4854e4e86cc934e8d7ba86007edd6e255b11609 DIFF: https://github.com/llvm/llvm-project/commit/b4854e4e86cc934e8d7ba86007edd6e255b11609.diff LOG

[Lldb-commits] [lldb] 2dc1d48 - [lldb] Use static instead of anonymous namesapce in CrashReason

Author: David Spickett Date: 2023-03-13T11:57:04Z New Revision: 2dc1d48a454fd511e42468e427fde49780f352fc URL: https://github.com/llvm/llvm-project/commit/2dc1d48a454fd511e42468e427fde49780f352fc DIFF: https://github.com/llvm/llvm-project/commit/2dc1d48a454fd511e42468e427fde49780f352fc.diff LOG

[Lldb-commits] [lldb] a372070 - [lldb] Remove MIPS64 specific signal handling for Linux

Author: David Spickett Date: 2023-03-13T11:50:07Z New Revision: a372070389a672274ad288cf8fd748d25569a2b8 URL: https://github.com/llvm/llvm-project/commit/a372070389a672274ad288cf8fd748d25569a2b8 DIFF: https://github.com/llvm/llvm-project/commit/a372070389a672274ad288cf8fd748d25569a2b8.diff LOG

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett added a comment. > If this skip is really needed, then I don't know how many people would > exercise an s390x test even if it was added - I don't personally build with > that target normally. This is now resolved. No skip needed for AArch64, but for whatever reason, it is needed

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett updated this revision to Diff 504583. DavidSpickett added a comment. Add an s390x test for big endian byte ordering. Turns out you can fake AArch64 without the backend, but not s390x. Luckily, s390x is a default backend. So the LE host -> BE target part will be tested widely. BE to

[Lldb-commits] [PATCH] D145550: [LLDB][ObjectFileELF] Correct the return type of RelocOffset64 and RelocAddend64

This revision was automatically updated to reflect the committed changes. Closed by commit rG174a38f9c316: [LLDB][ObjectFileELF] Correct the return type of RelocOffset64 and RelocAddend64 (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D145571: [LLDB][ObjectFileELF] Correct the return type of Reloc{Offset, Addend}32

This revision was automatically updated to reflect the committed changes. Closed by commit rG27705f456a3a: [LLDB][ObjectFileELF] Correct the return type of Reloc{Offset,Addend}32 (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [lldb] 27705f4 - [LLDB][ObjectFileELF] Correct the return type of Reloc{Offset, Addend}32

Author: Weining Lu Date: 2023-03-13T16:23:10+08:00 New Revision: 27705f456a3a03e7c935f7f573c05f742df4f272 URL: https://github.com/llvm/llvm-project/commit/27705f456a3a03e7c935f7f573c05f742df4f272 DIFF: https://github.com/llvm/llvm-project/commit/27705f456a3a03e7c935f7f573c05f742df4f272.diff LO

[Lldb-commits] [PATCH] D145462: [LLDB][ObjectFileELF] Support LoongArch64 in ApplyReloctions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2c93873d191: [LLDB][ObjectFileELF] Support LoongArch64 in ApplyReloctions (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145462/new

[Lldb-commits] [lldb] 174a38f - [LLDB][ObjectFileELF] Correct the return type of RelocOffset64 and RelocAddend64

Author: Weining Lu Date: 2023-03-13T16:23:10+08:00 New Revision: 174a38f9c3167573e060493b94135cf453d27879 URL: https://github.com/llvm/llvm-project/commit/174a38f9c3167573e060493b94135cf453d27879 DIFF: https://github.com/llvm/llvm-project/commit/174a38f9c3167573e060493b94135cf453d27879.diff LO

[Lldb-commits] [lldb] c2c9387 - [LLDB][ObjectFileELF] Support LoongArch64 in ApplyReloctions

Author: Weining Lu Date: 2023-03-13T16:23:09+08:00 New Revision: c2c93873d1912a62685818ec9f4e020ee7a1c616 URL: https://github.com/llvm/llvm-project/commit/c2c93873d1912a62685818ec9f4e020ee7a1c616 DIFF: https://github.com/llvm/llvm-project/commit/c2c93873d1912a62685818ec9f4e020ee7a1c616.diff LO