[Lldb-commits] [lldb] 9aae408 - [NFC] fix typo `funciton` -> `function`

Author: Yuanfang Chen Date: 2023-03-10T18:05:25-08:00 New Revision: 9aae408d551083bbbac96ecc512d45c30358e4b9 URL: https://github.com/llvm/llvm-project/commit/9aae408d551083bbbac96ecc512d45c30358e4b9 DIFF: https://github.com/llvm/llvm-project/commit/9aae408d551083bbbac96ecc512d45c30358e4b9.diff

[Lldb-commits] [lldb] e508545 - [lldb][NFC] Use UnixSignal::CreateForHost in Process

Author: Alex Langford Date: 2023-03-10T16:58:14-08:00 New Revision: e5085457ecc44418fab73de3b535961eac06c7a2 URL: https://github.com/llvm/llvm-project/commit/e5085457ecc44418fab73de3b535961eac06c7a2 DIFF: https://github.com/llvm/llvm-project/commit/e5085457ecc44418fab73de3b535961eac06c7a2.diff

[Lldb-commits] [PATCH] D145832: [lldb][test] Add tests for clang::PreferredNameAttr formatting

Michael137 updated this revision to Diff 504306. Michael137 added a comment. - Update testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145832/new/ https://reviews.llvm.org/D145832 Files: lldb/test/API/lang/cpp/preferred_name/Makefile lld

[Lldb-commits] [PATCH] D145832: [lldb][test] Add tests for clang::PreferredNameAttr formatting

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add some tests to make sure we're formatting structures with preferred names cor

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

royjacobson added a comment. In D140996#4185795 , @bolshakov-a wrote: > @royjacobson, I've added some test cases for using the new NTTP arguments in > clang modules. It uses serialization, in principle. Or more specialized tests > are still needed? No

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added a comment. @royjacobson, I've added some test cases for using the new NTTP arguments in clang modules. It uses serialization, in principle. Or more specialized tests are still needed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504255. bolshakov-a added a comment. Add relnote and update C++ status. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarg

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504254. bolshakov-a added a comment. Fix constness issue in `TemplateArgument` for `ASTContext`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-to

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504253. bolshakov-a added a comment. Add some testcases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.cpp clang/

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504251. bolshakov-a added a comment. Add `ODRHash` calculation for `UncommonValue` (and test it). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-t

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504250. bolshakov-a added a comment. Herald added a subscriber: ChuanqiXu. Add `ODRHash` calculation for UncommonValue (and test it). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tool

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504249. bolshakov-a added a comment. Refactor `TemplateArgument` constructors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/F

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504248. bolshakov-a added a comment. Fix after rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.cpp clang/in

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504247. bolshakov-a added a comment. Fix after rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang/include/clang/AST/PropertiesBase.td Index: clang/include/clang/AST/PropertiesBase

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504242. bolshakov-a added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.cpp clang/include/cla

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added a comment. I have some problems with Arcanist... It tries to open a new PR instead of updating this one. Probably because I've re-cloned my local repository. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://revie

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:3036 if (!std::is_trivially_destructible::value) { - auto DestroyPtr = [](void *V) { static_cast(V)->~T(); }; - AddDeallocation(DestroyPtr, Ptr); + auto DestroyPtr = [](void *V

[Lldb-commits] [PATCH] D145629: When a ValueObjectDynamicValue fails to update, return a not valid ValueObject so the static one is used instead

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1462d14b1e4: Don't produce a dynamic value if there was an error creating it. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145629/ne

[Lldb-commits] [lldb] e1462d1 - Don't produce a dynamic value if there was an error creating it.

Author: Jim Ingham Date: 2023-03-10T10:21:50-08:00 New Revision: e1462d14b1e4be329a95bdd08181b97a7a3ad6e6 URL: https://github.com/llvm/llvm-project/commit/e1462d14b1e4be329a95bdd08181b97a7a3ad6e6 DIFF: https://github.com/llvm/llvm-project/commit/e1462d14b1e4be329a95bdd08181b97a7a3ad6e6.diff LO

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett added a comment. I'm trying to get an s390x test going in the same fashion but figuring it out is tricky. Also, I realise that all this XML substitution with strings is very brittle. I want to replace that with Python's xml.etree but will do that later in another patch. Reposit

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett updated this revision to Diff 504140. DavidSpickett added a comment. Remove need for aarch64 yaml file in tests. Refactor the responders. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145580/new/ https://reviews.llvm.org/D145580 File

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett added a comment. > This all looks good to me. the phab says there's a missing newline at the end > of TestXMLRegisterFlags.py. Fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145580/new/ https://reviews.llvm.org/D145580 __

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett added a comment. The last update changes the format slightly, though for the better I think. (lldb) register read cpsr x0 fpcr fpsr x1 cpsr = 0x60001000 = (N = 0, Z = 1, C = 1, V = 0, TCO = 0, DIT = 0, UAO = 0, PAN = 0, SS = 0, IL = 0, SSBS = 1, BTYPE = 0, D = 0,

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett updated this revision to Diff 504109. DavidSpickett added a comment. - Rebase - Add a test to show the register fields respect the child limit setting. - Make sure alignment is correct both when printed as one line and multiple. - Correct indentation in test file so it's all 4 space

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

DavidSpickett updated this revision to Diff 504107. DavidSpickett added a comment. Correct printf for `unsigned`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145574/new/ https://reviews.llvm.org/D145574 Files: lldb/include/lldb/Target/DynamicR

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

DavidSpickett updated this revision to Diff 504106. DavidSpickett added a comment. Remove use of type attribute on flags. We will recognise it as valid, but do nothing with it as it's not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145574/

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

DavidSpickett updated this revision to Diff 504104. DavidSpickett added a comment. Fix typo, remove `m_type` which is not used by the following patches. We could use it down the road, but we can also just guess that single bit fields are bools and anything else is a number. So we don't lose much.

[Lldb-commits] [PATCH] D145078: [WIP][lldb][DWARFASTParserClang] Support DW_AT_LLVM_preferred_name attribute

Michael137 updated this revision to Diff 504103. Michael137 added a comment. - Update variable names in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145078/new/ https://reviews.llvm.org/D145078 Files: lldb/source/Plugins/SymbolFile/DWARF/D

[Lldb-commits] [PATCH] D145078: [WIP][lldb][DWARFASTParserClang] Support DW_AT_LLVM_preferred_name attribute

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a reviewer: shafik. Herald added a project: All. Michael137 updated this revision to Diff 502692. Michael137 added a comment. Michael137 updated this revision to Diff 502694. Michael137 updated this revision to Dif

[Lldb-commits] [lldb] 60a7188 - [lldb][test] TestInlineNamespaceAlias.py: skip on older compiler versions

Author: Michael Buch Date: 2023-03-10T12:20:58Z New Revision: 60a7188cb086abe172bc46582356f30b3c3e1c4c URL: https://github.com/llvm/llvm-project/commit/60a7188cb086abe172bc46582356f30b3c3e1c4c DIFF: https://github.com/llvm/llvm-project/commit/60a7188cb086abe172bc46582356f30b3c3e1c4c.diff LOG: