[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

2023-02-25 Thread Roy Jacobson via Phabricator via lldb-commits
royjacobson added a comment. There are no AST [de]serialization tests in this PR, right? Would be nice to add some. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 ___

[Lldb-commits] [PATCH] D144182: [lldb][DWARFASTParserClang] Add support for DW_TAG_LLVM_annotation

2023-02-25 Thread Michael Buch via Phabricator via lldb-commits
Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a reviewer: shafik. Herald added a project: All. Michael137 added a comment. Michael137 updated this revision to Diff 498020. Michael137 updated this revision to Diff 498899. Michael137 updated this revisi

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

2023-02-25 Thread Andrey Ali Khan Bolshakov via Phabricator via lldb-commits
bolshakov-a added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:3036 if (!std::is_trivially_destructible::value) { - auto DestroyPtr = [](void *V) { static_cast(V)->~T(); }; - AddDeallocation(DestroyPtr, Ptr); + auto DestroyPtr = [](void *V