[Lldb-commits] [PATCH] D144688: [lldb] Fix watchpoint command function stopping behavior

mib created this revision. mib added a reviewer: bulbazord. mib added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch fixes an issue where we would discard the return v

[Lldb-commits] [PATCH] D144224: [lldb] Extend SWIG SBProcess interface with WriteMemoryAsCString method

jingham added a comment. I see no tests. If there were tests, one of them could be for "" and then you would know whether Pavel was right or not... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144224/new/ https://reviews.llvm.org/D144224 _

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

clayborg added a comment. Sorry for delay, I have been on vacation for the last two weeks. I will be back next Monday and get to this soon. Feel free to ping again next week if I don't get to it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14063

[Lldb-commits] [PATCH] D143695: [lldb] Make repeat commands work for regex commands

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This change didn't immediately make sense to me, which means it's a bit tricky and tricky changes should get comments or they will confuse us later on. Plus, I wasn't sure how it

[Lldb-commits] [PATCH] D144665: Use Resume not PrivateResume when asynchronously continuing after the start at stop

jingham created this revision. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In the auto-continue after we stop at the start point when running the debugger asynchronously, we use PrivateResume to con

[Lldb-commits] [PATCH] D144664: Preserve SBValue's that only have an Error state

jingham created this revision. jingham added reviewers: JDevlieghere, clayborg, labath, jasonmolenda. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. SBValues carry their own errors with them (SBValue::G

[Lldb-commits] [PATCH] D144311: [debugserver] Add one additional sleep before attaching after waiting

This revision was automatically updated to reflect the committed changes. Closed by commit rG97b579d31404: [debugserver] Add one additional sleep before attaching after waiting (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[Lldb-commits] [lldb] 97b579d - [debugserver] Add one additional sleep before attaching after waiting

Author: Alex Langford Date: 2023-02-23T11:22:22-08:00 New Revision: 97b579d3140476cd32d94a6e052f0908e2c21228 URL: https://github.com/llvm/llvm-project/commit/97b579d3140476cd32d94a6e052f0908e2c21228 DIFF: https://github.com/llvm/llvm-project/commit/97b579d3140476cd32d94a6e052f0908e2c21228.diff

[Lldb-commits] [PATCH] D144311: [debugserver] Add one additional sleep before attaching after waiting

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Ah, sorry I missed this one, LGTM. Attaching to a process very early in startup during this transition between dyld's is especially difficult to recover from; letting the process

[Lldb-commits] [lldb] bd56c8d - [lldb] Skip test_stop_reply_contains_thread_pcs on Windows

Author: David Spickett Date: 2023-02-23T16:08:44Z New Revision: bd56c8d5f59a22b6c0ab64328b87d831a0c4468c URL: https://github.com/llvm/llvm-project/commit/bd56c8d5f59a22b6c0ab64328b87d831a0c4468c DIFF: https://github.com/llvm/llvm-project/commit/bd56c8d5f59a22b6c0ab64328b87d831a0c4468c.diff LOG

[Lldb-commits] [lldb] dc2d2ca - [LLDB] Mark test_stop_reply_contains_thread_pcs as an expected failure on Windows

Author: David Spickett Date: 2023-02-23T14:10:07Z New Revision: dc2d2ca0603a5aaaea68515ff7c0605049268778 URL: https://github.com/llvm/llvm-project/commit/dc2d2ca0603a5aaaea68515ff7c0605049268778 DIFF: https://github.com/llvm/llvm-project/commit/dc2d2ca0603a5aaaea68515ff7c0605049268778.diff LOG

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8bd179a1738: Clear read_fd_set if EINTR received (authored by emrekultursay, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144240/new/

[Lldb-commits] [lldb] d8bd179 - Clear read_fd_set if EINTR received

Author: Emre Kultursay Date: 2023-02-23T13:27:19+01:00 New Revision: d8bd179a173876a7a9ee11828b63efffe145356c URL: https://github.com/llvm/llvm-project/commit/d8bd179a173876a7a9ee11828b63efffe145356c DIFF: https://github.com/llvm/llvm-project/commit/d8bd179a173876a7a9ee11828b63efffe145356c.diff