[Lldb-commits] [PATCH] D143698: Cleanedup and added comments

kkcode0 updated this revision to Diff 496347. kkcode0 added a comment. mark some vars used Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h

[Lldb-commits] [PATCH] D143694: [lldb] Hoist code to create StructuredData into DiagnosticEventData (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG125e69015add: [lldb] Hoist code to create StructuredData into DiagnosticEventData (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D14369

[Lldb-commits] [lldb] 125e690 - [lldb] Hoist code to create StructuredData into DiagnosticEventData (NFC)

Author: Jonas Devlieghere Date: 2023-02-09T21:42:25-08:00 New Revision: 125e69015addb656bccaf1c48ea006c9742cda25 URL: https://github.com/llvm/llvm-project/commit/125e69015addb656bccaf1c48ea006c9742cda25 DIFF: https://github.com/llvm/llvm-project/commit/125e69015addb656bccaf1c48ea006c9742cda25.d

[Lldb-commits] [PATCH] D143698: Cleanedup and added comments

kkcode0 updated this revision to Diff 496321. kkcode0 added a comment. Herald added a subscriber: Michael137. rebase all changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/

[Lldb-commits] [PATCH] D143698: Cleanedup and added comments

kkcode0 created this revision. Herald added a project: All. kkcode0 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D143698 Files: lldb/source/Plugins/Process/gdb-remote/GDB

[Lldb-commits] [lldb] 8235253 - [lldb] Remove unused CommandObjectRegexCommand::m_max_matches (NFC)

Author: Dave Lee Date: 2023-02-09T19:35:00-08:00 New Revision: 82352538576a67d746ae2c0ba4ec5453839e70cd URL: https://github.com/llvm/llvm-project/commit/82352538576a67d746ae2c0ba4ec5453839e70cd DIFF: https://github.com/llvm/llvm-project/commit/82352538576a67d746ae2c0ba4ec5453839e70cd.diff LOG:

[Lldb-commits] [PATCH] D143398: [lldb][DWARFASTParserClang] Correctly resolve imported namespaces during expression evaluation

Michael137 added a comment. Will reland once https://reviews.llvm.org/D143458 relands Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143398/new/ https://reviews.llvm.org/D143398 ___ lldb-commits mailing l

[Lldb-commits] [lldb] 181d6e2 - Revert "[lldb][DWARFASTParserClang] Correctly resolve imported namespaces during expression evaluation"

Author: Michael Buch Date: 2023-02-10T03:28:28Z New Revision: 181d6e24ca3c09bfd6ec7c3b20affde3e5ea9b40 URL: https://github.com/llvm/llvm-project/commit/181d6e24ca3c09bfd6ec7c3b20affde3e5ea9b40 DIFF: https://github.com/llvm/llvm-project/commit/181d6e24ca3c09bfd6ec7c3b20affde3e5ea9b40.diff LOG:

[Lldb-commits] [PATCH] D143694: [lldb] Hoist code to create StructuredData into DiagnosticEventData (NFC)

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM with some nitpicks. Comment at: lldb/source/API/SBDebugger.cpp:175 - const DiagnosticEventData *diagnostic_data = - DiagnosticEventData::GetEventDataFromEvent(event.ge

[Lldb-commits] [PATCH] D143398: [lldb][DWARFASTParserClang] Correctly resolve imported namespaces during expression evaluation

Michael137 added a comment. Broke linux buildbot, investigating... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143398/new/ https://reviews.llvm.org/D143398 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D143652: [lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing

Michael137 added a comment. On a release build, for a type instantiated with 50,000 distinct types I get the following results: Benchmark 1: ./lldb-build-release-with-patch/bin/lldb a.out -o "b main" -o "r" -o "p b.sinkWrapper(b.getWrapper())" Time (mean ± σ): 7.594 s ± 0.124 s[U

[Lldb-commits] [PATCH] D143652: [lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing

Michael137 updated this revision to Diff 496300. Michael137 added a comment. - Reduce scope of local var Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143652/new/ https://reviews.llvm.org/D143652 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARF

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord updated this revision to Diff 496299. bulbazord added a comment. Stop exposing unsupported SBReproducer functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142926/new/ https://reviews.llvm.org/D142926 Files: lldb/bindings/CMakeList

[Lldb-commits] [PATCH] D143656: [lldb][Test] Check compiler in data formatter compiler version checks

Michael137 added a comment. Fixes condition introduced in https://reviews.llvm.org/D141828 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143656/new/ https://reviews.llvm.org/D143656 ___ lldb-commits mail

[Lldb-commits] [PATCH] D143656: [lldb][Test] Check compiler in data formatter compiler version checks

This revision was automatically updated to reflect the committed changes. Closed by commit rGad81d019a62d: [lldb][Test] Check compiler in data forammter compiler version checks (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [lldb] ad81d01 - [lldb][Test] Check compiler in data forammter compiler version checks

Author: Michael Buch Date: 2023-02-10T01:37:26Z New Revision: ad81d019a62d33e5d1f232844b83d3e164e4b160 URL: https://github.com/llvm/llvm-project/commit/ad81d019a62d33e5d1f232844b83d3e164e4b160 DIFF: https://github.com/llvm/llvm-project/commit/ad81d019a62d33e5d1f232844b83d3e164e4b160.diff LOG:

[Lldb-commits] [PATCH] D143398: [lldb][DWARFASTParserClang] Correctly resolve imported namespaces during expression evaluation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ba6ec0ba906: [lldb][DWARFASTParserClang] Correctly resolve imported namespaces during… (authored by Michael137). Repository: rG LLVM Github Monor

[Lldb-commits] [lldb] 1ba6ec0 - [lldb][DWARFASTParserClang] Correctly resolve imported namespaces during expression evaluation

Author: Michael Buch Date: 2023-02-10T01:33:52Z New Revision: 1ba6ec0ba906472661506ef7bd2f0bf4efe4657e URL: https://github.com/llvm/llvm-project/commit/1ba6ec0ba906472661506ef7bd2f0bf4efe4657e DIFF: https://github.com/llvm/llvm-project/commit/1ba6ec0ba906472661506ef7bd2f0bf4efe4657e.diff LOG:

[Lldb-commits] [PATCH] D143398: [lldb][DWARFASTParserClang] Correctly resolve imported namespaces during expression evaluation

Michael137 updated this revision to Diff 496293. Michael137 added a comment. - Minor: simplify condition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143398/new/ https://reviews.llvm.org/D143398 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARF

[Lldb-commits] [PATCH] D143695: [lldb] Make repeat commands work for regex commands

kastiglione created this revision. kastiglione added a reviewer: jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix logic for repeat commands, so that regex commands (specificially `bt`) ar

[Lldb-commits] [PATCH] D143694: [lldb] Hoist code to create StructuredData into DiagnosticEventData (NFC)

JDevlieghere created this revision. JDevlieghere added a reviewer: mib. Herald added a project: All. JDevlieghere requested review of this revision. Hoist the code that creates a StructuredData dictionary from a diagnostic event into the DiagnosticEventData. This addresses Ismail's code review fee

[Lldb-commits] [PATCH] D143690: [lldb] Add the ability to provide a message to a progress event update

mib added a comment. Makes sense! LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143690/new/ https://reviews.llvm.org/D143690 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [PATCH] D143690: [lldb] Add the ability to provide a message to a progress event update

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, mib, kastiglione, bulbazord. Herald added a project: All. JDevlieghere requested review of this revision. This patch adds the ability to add a message to a progress event update. Consider the following example as motivati

[Lldb-commits] [PATCH] D143687: [lldb] Add an SB API to get progress events as SBStructuredData

JDevlieghere added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:175-186 + const ProgressEventData *progress_data = + ProgressEventData::GetEventDataFromEvent(event.get()); + if (!progress_data) +return {}; + + auto dictionary = std::make_unique(); + di

[Lldb-commits] [PATCH] D143687: [lldb] Add an SB API to get progress events as SBStructuredData

mib added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:175-186 + const ProgressEventData *progress_data = + ProgressEventData::GetEventDataFromEvent(event.get()); + if (!progress_data) +return {}; + + auto dictionary = std::make_unique(); + dictionary-

[Lldb-commits] [PATCH] D143687: [lldb] Add an SB API to get progress events as SBStructuredData

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, mib, kastiglione, bulbazord. Herald added a project: All. JDevlieghere requested review of this revision. This is a preparatory patch to add an SB API to get the progress data as SBStructuredData. The approach is identica

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/ProcessInfo.h:90 + bool IsScriptedProcess() const; + Can we not ask this from the ScriptedMetadata? Comment at: lldb/source/API/SBAttachInfo.cpp:272 void SBAttachInfo

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

JDevlieghere added a comment. In D142926#4116427 , @clayborg wrote: > Does this mean we could submit a patch that removes all of the > "LLDB_INSTRUMENT*" stuff that is in all of the SB*.cpp files? That would be > great to clean that up if they are not n

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

clayborg added a comment. In D142926#4116417 , @JDevlieghere wrote: > In D142926#4115980 , @clayborg > wrote: > >> In D142926#4115875 , @JDevlieghere >> wrote: >> >>> I

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

JDevlieghere added a comment. In D142926#4115980 , @clayborg wrote: > In D142926#4115875 , @JDevlieghere > wrote: > >> In D142926#4114215 , @bulbazord >> wrote: >> >>> N

[Lldb-commits] [PATCH] D143652: [lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:914-915 + for (auto const &sc : sc_list.SymbolContexts()) { +auto *func = sc.function; +if (func) { + auto func_die = dwarf->GetDIE(func->GetID()); -

[Lldb-commits] [PATCH] D143398: [lldb][DWARFASTParserClang] Correctly resolve imported namespaces during expression evaluation

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3480 + if (auto it = m_die_to_decl_ctx.find(die.GetDIE()); + it != m_die_to_decl_ctx.end(

[Lldb-commits] [lldb] 26e9f23 - [lldb] Add the ability to remove diagnostic callbacks

Author: Jonas Devlieghere Date: 2023-02-09T13:20:51-08:00 New Revision: 26e9f23ada4f7dea37199bca89ce628e2a54b74e URL: https://github.com/llvm/llvm-project/commit/26e9f23ada4f7dea37199bca89ce628e2a54b74e DIFF: https://github.com/llvm/llvm-project/commit/26e9f23ada4f7dea37199bca89ce628e2a54b74e.d

[Lldb-commits] [PATCH] D143548: [lldb] Add the ability to remove diagnostic callbacks

This revision was automatically updated to reflect the committed changes. Closed by commit rG26e9f23ada4f: [lldb] Add the ability to remove diagnostic callbacks (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D142241: Don't use CLANG_LIBS and LINK_COMPONENTS in lldb/tools/lldb-instr/CMakeLists.txt

aheejin added a comment. This broke `-sBUILD_SHARED_LIBS=ON` build: ld.lld: error: undefined symbol: llvm::errs() >>> referenced by Instrument.cpp:162 (/usr/local/google/home/aheejin/llvm-git/lldb/tools/lldb-instr/Instrument.cpp:162) >>> tools/lldb/tools/lldb-instr/CMakeFile

[Lldb-commits] [PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added a comment. > I'd recommend a possible long-term solution would be simplified template > names (so we don't have to worry about encoding this in the `DW_AT_name` > anyway) and a "DW_AT_LLVM_preferred_name" or similar attribute on a type that > refers to the typedef that is the p

[Lldb-commits] [PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

dblaikie added a comment. In D143501#4110302 , @Michael137 wrote: > The alternative would be attaching the preferred name as a new attribute or > an existing attribute like `DW_AT_description`. I'd recommend a possible long-term solution would be simpl

[Lldb-commits] [PATCH] D143652: [lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Nice! Comment at: lldb/test/API/lang/cpp/external_ctor_dtor_lookup/TestExternalCtorDtorLookup.py:2 +""" +Test that we can constructors/destructors +without a linkage name

[Lldb-commits] [lldb] 49470f1 - Remove test case that tries to allocate impossible amounts

Author: Jason Molenda Date: 2023-02-09T10:44:40-08:00 New Revision: 49470f1eacca6aa5ab0f860347aa282a79323161 URL: https://github.com/llvm/llvm-project/commit/49470f1eacca6aa5ab0f860347aa282a79323161 DIFF: https://github.com/llvm/llvm-project/commit/49470f1eacca6aa5ab0f860347aa282a79323161.diff

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

clayborg added a comment. In D142926#4115875 , @JDevlieghere wrote: > In D142926#4114215 , @bulbazord > wrote: > >> Not sure how useful it would be but I recorded the full list of methods get >> added with this

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

JDevlieghere added a comment. In D142926#4114215 , @bulbazord wrote: > Not sure how useful it would be but I recorded the full list of methods get > added with this change. Take a look and let me know if there are any that you > think shouldn't be added

[Lldb-commits] [PATCH] D143623: [lldb] Print an error for unsupported combinations of log options

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG3c565c246635: [lldb] Print an error for unsupported combinations of log options (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to co

[Lldb-commits] [lldb] 3c565c2 - [lldb] Print an error for unsupported combinations of log options

Author: Jonas Devlieghere Date: 2023-02-09T09:58:39-08:00 New Revision: 3c565c246635cace81f01340cd3d1d7386042478 URL: https://github.com/llvm/llvm-project/commit/3c565c246635cace81f01340cd3d1d7386042478 DIFF: https://github.com/llvm/llvm-project/commit/3c565c246635cace81f01340cd3d1d7386042478.d

[Lldb-commits] [PATCH] D143623: [lldb] Print an error for unsupported combinations of log options

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/test/Shell/Log/TestHandlers.test:1-2 +# RUN: %lldb -o 'log enable -h os -f /tmp/foo gdb-remote packets' 2>&1 | FileCheck %s --check-prefix UNSUPPORTED-FILE +# RUN: %lldb -o 'log

[Lldb-commits] [PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/TestDataFormatterLibcxxSharedPtr.py:61 if self.expectedCompilerVersion(['>', '16.0']): +string_type = "std::string"

[Lldb-commits] [PATCH] D143656: [lldb][Test] Check compiler in data forammter compiler version checks

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. **Summary** The compiler version check wouldn't make sense for non-GCC compiler

[Lldb-commits] [PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

kiranchandramohan accepted this revision. kiranchandramohan added a comment. LG. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D141910 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D143652: [lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing

Michael137 updated this revision to Diff 496131. Michael137 added a comment. - Simplify test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143652/new/ https://reviews.llvm.org/D143652 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserCla

[Lldb-commits] [PATCH] D143652: [lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing

Michael137 updated this revision to Diff 496128. Michael137 added a comment. - add `CHECK-NEXT` to test - reword commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143652/new/ https://reviews.llvm.org/D143652 Files: lldb/source/Plugins/SymbolF

[Lldb-commits] [PATCH] D143652: [WIP][lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing

Michael137 updated this revision to Diff 496127. Michael137 added a comment. - clang-format - Minor cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143652/new/ https://reviews.llvm.org/D143652 Files: lldb/source/Plugins/SymbolFile/DWARF/DW

[Lldb-commits] [PATCH] D143652: [WIP][lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing

Michael137 created this revision. Michael137 added reviewers: aprantl, labath, aeubanks. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. **Summary** This patch addres

[Lldb-commits] [PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 updated this revision to Diff 496089. Michael137 added a comment. - Reword commit - Use different debuginfo kind in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143501/new/ https://reviews.llvm.org/D143501 Files: clang/lib/Code

[Lldb-commits] [PATCH] D143564: [LLDB] Add missing newline to "image lookup" output

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a4e9ccb2c6f: [LLDB] Add missing newline to "image lookup" output (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143564/new/ htt

[Lldb-commits] [lldb] 6a4e9cc - [LLDB] Add missing newline to "image lookup" output

Author: David Spickett Date: 2023-02-09T10:44:50Z New Revision: 6a4e9ccb2c6f3340eb01bd374988a55daed2a68d URL: https://github.com/llvm/llvm-project/commit/6a4e9ccb2c6f3340eb01bd374988a55daed2a68d DIFF: https://github.com/llvm/llvm-project/commit/6a4e9ccb2c6f3340eb01bd374988a55daed2a68d.diff LOG

[Lldb-commits] [PATCH] D143215: lldb can know architecture-dependent watchpoint behaviors, instead of depending on the remote stub

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. One minor comment otherwise LGTM. `[LLDB]` tag in the commit title please :) Comment at: lldb/source/Target/Process.cpp:2371 + if (triple.isAArch64() || tripl