[Lldb-commits] [PATCH] D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp

xgupta updated this revision to Diff 491601. xgupta added a comment. fix build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142309/new/ https://reviews.llvm.org/D142309 Files: lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntim

[Lldb-commits] [PATCH] D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp

JDevlieghere added a subscriber: labath. JDevlieghere added a comment. LGTM, but I wonder when we'll be able to get rid of RenderScript completely (CC @labath) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142309/new/ https://reviews.llvm.org/D142

[Lldb-commits] [PATCH] D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp

xgupta added a comment. In D142309#4075616 , @jingham wrote: > I don't think this code is going to compile, is it? You took out the `if > (!buffer) {` but left the RHS `}` so now the scopes are unbalanced. I think > you should just change how the shar

[Lldb-commits] [PATCH] D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp

xgupta updated this revision to Diff 491597. xgupta added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142309/new/ https://reviews.llvm.org/D142309 Files: lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScrip

[Lldb-commits] [PATCH] D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I don't think this code is going to compile, is it? You took out the `if (!buffer) {` but left the RHS `}` so now the scopes are unbalanced. I think you should just change how th

[Lldb-commits] [PATCH] D141605: [lldb] Detach the child process when stepping over a fork

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. In D141605#4073158 , @labath wrote: > Thanks for your response, Jim. > > In D141605#4066649 , @jingham wrot

[Lldb-commits] [PATCH] D141219: Add a .lldbinit file to autoload LLVM/Clang data formatters

jingham added a comment. IMO the correct solution to this problem is for the IDE to give affordances for specifying either absolute or project relative paths to "the debugger init file". Then we don't have to clutter our sources with .lldbinit files in weird places hoping to catch the attentio

[Lldb-commits] [PATCH] D142413: [lldb] Don't create Clang AST nodes in GetCPlusPlusQualifiedName

aeubanks added a comment. there may be an alternate solution involving making some declarations into definitions (at all? earlier?), but I don't have that level of understanding of lldb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142413/new/ ht

[Lldb-commits] [PATCH] D142413: [lldb] Don't create Clang AST nodes in GetCPlusPlusQualifiedName

aeubanks created this revision. Herald added a reviewer: shafik. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Otherwise we may be inserting a decl into a DeclContext that's not fully defined yet. G

[Lldb-commits] [PATCH] D141629: Run address expression argument values through ABI::FixCodeAddress to strip TBI/pointer auth bytes on AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rG484bc2bcc799: Run cmdline address expressions through ABI's FixAddress (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141629/new/

[Lldb-commits] [lldb] 484bc2b - Run cmdline address expressions through ABI's FixAddress

Author: Jason Molenda Date: 2023-01-23T10:44:19-08:00 New Revision: 484bc2bcc7990f4ecaf40f3d806ed870cdbdfd95 URL: https://github.com/llvm/llvm-project/commit/484bc2bcc7990f4ecaf40f3d806ed870cdbdfd95 DIFF: https://github.com/llvm/llvm-project/commit/484bc2bcc7990f4ecaf40f3d806ed870cdbdfd95.diff

[Lldb-commits] [PATCH] D142150: [lldb] Remove timer from SBModule copy ctor

JDevlieghere added a comment. In D142150#4074015 , @aprantl wrote: > What about adding a `trivial` parameter to the macro that has the effect of > skipping it in instrumentation if the instrumentation is the costly signpost > mechanism? The `_VA` macro

[Lldb-commits] [PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

jsjodin accepted this revision. jsjodin added a comment. This revision is now accepted and ready to land. This looks good to me. Have @jdoerfert approve as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D14

[Lldb-commits] [lldb] 9bf0318 - Revert "[lldb] Remove timer from SBModule copy ctor"

Author: Dave Lee Date: 2023-01-23T09:52:11-08:00 New Revision: 9bf03187bd29f42902183e4bdac9b7f2d3008d00 URL: https://github.com/llvm/llvm-project/commit/9bf03187bd29f42902183e4bdac9b7f2d3008d00 DIFF: https://github.com/llvm/llvm-project/commit/9bf03187bd29f42902183e4bdac9b7f2d3008d00.diff LOG:

[Lldb-commits] [PATCH] D142150: [lldb] Remove timer from SBModule copy ctor

kastiglione added a comment. In D142150#4074015 , @aprantl wrote: > What about adding a `trivial` parameter to the macro that has the effect of > skipping it in instrumentation if the instrumentation is the costly signpost > mechanism? sounds good to m

[Lldb-commits] [PATCH] D142150: [lldb] Remove timer from SBModule copy ctor

aprantl added a comment. What about adding a `trivial` parameter to the macro that has the effect of skipping it in instrumentation if the instrumentation is the costly signpost mechanism? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142150/new/

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

labath added a comment. In D138618#4060565 , @clayborg wrote: > ... > Since the user IDs of SymbolFileDWARF plug-ins mean nothing to anyone else, > we can make them what we need them to be so they work for us. I would suggest > to remove the use of DIER

[Lldb-commits] [PATCH] D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/

Michael137 added a subscriber: jingham. Michael137 added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:225 if (valobj_sp) +SyntheticChildrenFrontEnd(*valobj_sp); Update(); Michael137 wrote: > Michael137 wrote: > > this

[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:32 - DIERef(std::optional dwo_num, Section section, + DIERef(std::optional dwo_oso_num, Section section, dw_offset_t die_offset) Where is this constructor being

[Lldb-commits] [PATCH] D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/

Michael137 added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:225 if (valobj_sp) +SyntheticChildrenFrontEnd(*valobj_sp); Update(); Michael137 wrote: > this won't initialise the parent constructor though will it? Just

[Lldb-commits] [PATCH] D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/

Michael137 added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:225 if (valobj_sp) +SyntheticChildrenFrontEnd(*valobj_sp); Update(); this won't initialise the parent constructor though will it? Just creates a temporary

[Lldb-commits] [PATCH] D141605: [lldb] Detach the child process when stepping over a fork

labath added a comment. Thanks for your response, Jim. In D141605#4066649 , @jingham wrote: > The part of handling the fork where we decide we're going to follow the child > and so we need to switch the process PID & TID does have to happen on event >

[Lldb-commits] [lldb] 291a7fc - [LLDB] Fix build error after D142214

Author: Jay Foad Date: 2023-01-23T12:28:06Z New Revision: 291a7fcf70db4d45c24b559fc867d3499b2e1e04 URL: https://github.com/llvm/llvm-project/commit/291a7fcf70db4d45c24b559fc867d3499b2e1e04 DIFF: https://github.com/llvm/llvm-project/commit/291a7fcf70db4d45c24b559fc867d3499b2e1e04.diff LOG: [LLD

[Lldb-commits] [PATCH] D142341: [LLDB][NFC] Fix a null pointer check in LibCxx.cpp

xgupta updated this revision to Diff 491288. xgupta added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142341/new/ https://reviews.llvm.org/D142341 Files: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp lldb/sour

[Lldb-commits] [PATCH] D142341: [LLDB][NFC] Fix a null pointer check in LibCxx.cpp

xgupta added a comment. In D142341#4072810 , @Michael137 wrote: > Looks correct to me, given we seem to allow `valobj_sp` to be null. Though we > seem to be doing it in a lot of other places too around this file. So could > fix those all at once? Yeah

[Lldb-commits] [PATCH] D142341: [LLDB][NFC] Fix a null pointer check in LibCxx.cpp

Michael137 added a comment. Seems reasonable to me. Could you also apply the check to `LibCxxUnorderedMapIteratorSyntheticFrontEnd` which suffers from the same. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142341/new/ https://reviews.llvm.org/D14

[Lldb-commits] [PATCH] D142341: [LLDB][NFC] Fix a null pointer check in LibCxx.cpp

xgupta created this revision. xgupta added a reviewer: DavidSpickett. Herald added a project: All. xgupta requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The issue is that the SyntheticChildrenFrontEnd constructor is being called with the d

[Lldb-commits] [PATCH] D141687: [LLDB] Remove return value from DumpRegisterValue

This revision was automatically updated to reflect the committed changes. Closed by commit rGae361d3d90a8: [LLDB] Remove return value from DumpRegisterValue (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141687/new/ https

[Lldb-commits] [lldb] ae361d3 - [LLDB] Remove return value from DumpRegisterValue

Author: David Spickett Date: 2023-01-23T10:52:20Z New Revision: ae361d3d90a83ede308dd4ee56811966e8a42fe2 URL: https://github.com/llvm/llvm-project/commit/ae361d3d90a83ede308dd4ee56811966e8a42fe2 DIFF: https://github.com/llvm/llvm-project/commit/ae361d3d90a83ede308dd4ee56811966e8a42fe2.diff LOG