[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

2022-12-30 Thread Sam Elliott via Phabricator via lldb-commits
lenary added a comment. In D137838#4018930 , @vitalybuka wrote: > This bot is broken after the patch > https://lab.llvm.org/buildbot/#/builders/236/builds/1480 Thanks for letting me know. I'm back in the office on the 3rd, and it looks like this will

[Lldb-commits] [PATCH] D140759: [LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch

2022-12-30 Thread Lu Weining via Phabricator via lldb-commits
SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM from the LoongArch side. Thanks. Comment at: lldb/unittests/Instruction/LoongArch/TestLoongArchEmulator.cpp:154 + opcode = opcode >> 2; + return opcode << 26 |

[Lldb-commits] [PATCH] D140759: [LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch

2022-12-30 Thread Hui Li via Phabricator via lldb-commits
lh03061238 updated this revision to Diff 485680. lh03061238 added a comment. 1、Modify BCEQZ/BCNEZ instruction opcode and mask 2、Separate BCEQZ and BCNEZ 3、Use "Bits32(inst, 7, 5) + fpr_fcc0_loongarch" to calculate cj CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140759/new/ https://revi

[Lldb-commits] [PATCH] D140759: [LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch

2022-12-30 Thread Hui Li via Phabricator via lldb-commits
lh03061238 added inline comments. Comment at: lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.cpp:42 "bnez rj, offs21"}, + {0xfc00, 0x4800, &EmulateInstructionLoongArch::EmulateBCXXZ, + "bceqz/bcnez cj, offs21"},