[Lldb-commits] [PATCH] D136938: [LLDB] Fix code breakpoints on tagged addresses

jasonmolenda added a comment. Hi David, thanks for the ping sorry for not replying earlier to this. I looked at this a little bit today but want to look at how I solved the same issue a while ago (but never upstreamed, which is my bad, I need to clean those up). (I did solved this in OptionAr

[Lldb-commits] [lldb] 9464bd8 - [lldb] llvm::Optional::value => operator*/operator->

Author: Fangrui Song Date: 2022-12-17T05:01:54Z New Revision: 9464bd8c78d142225957abbf38ed3c2abaa9e180 URL: https://github.com/llvm/llvm-project/commit/9464bd8c78d142225957abbf38ed3c2abaa9e180 DIFF: https://github.com/llvm/llvm-project/commit/9464bd8c78d142225957abbf38ed3c2abaa9e180.diff LOG:

[Lldb-commits] [PATCH] D140249: [lldb] Do not deallocate memory after exec

bulbazord updated this revision to Diff 483692. bulbazord added a comment. Add a comment explaining why we do not dealloc after exec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140249/new/ https://reviews.llvm.org/D140249 Files: lldb/include/l

[Lldb-commits] [PATCH] D140249: [lldb] Do not deallocate memory after exec

bulbazord added inline comments. Comment at: lldb/source/Target/Memory.cpp:337 std::lock_guard guard(m_mutex); - if (m_process.IsAlive()) { + if (m_process.IsAlive() && !did_exec) { PermissionsToBlockMap::iterator pos, end = m_memory_map.end(); jasonmol

[Lldb-commits] [PATCH] D140253: [debugserver] Clear memory allocations after exec

bulbazord created this revision. bulbazord added a reviewer: jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. After an exec, the inferior is a new process and none of these memory regions are still allocated. Clear them out. Re

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#3999154 , @labath wrote: > Thanks for splitting this up. We still need to figure out what to do with the > first patch, but these two are looking very good now. > > At least, in the sense that one can clearly see what

[Lldb-commits] [lldb] 20c213a - [lldb][NFC] Remove unused/unimplemented Type methods

Author: Arthur Eubanks Date: 2022-12-16T15:16:52-08:00 New Revision: 20c213a13dfa19a262b15c4d7a8977f547471b43 URL: https://github.com/llvm/llvm-project/commit/20c213a13dfa19a262b15c4d7a8977f547471b43 DIFF: https://github.com/llvm/llvm-project/commit/20c213a13dfa19a262b15c4d7a8977f547471b43.diff

[Lldb-commits] [PATCH] D140249: [lldb] Do not deallocate memory after exec

jasonmolenda added inline comments. Comment at: lldb/source/Target/Memory.cpp:337 std::lock_guard guard(m_mutex); - if (m_process.IsAlive()) { + if (m_process.IsAlive() && !did_exec) { PermissionsToBlockMap::iterator pos, end = m_memory_map.end(); Shoul

[Lldb-commits] [PATCH] D140249: [lldb] Do not deallocate memory after exec

bulbazord created this revision. bulbazord added reviewers: jasonmolenda, jingham, JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. After an exec has occured, resources used to manage the state of a Process are cleaned up. One su

[Lldb-commits] [lldb] 27249c0 - Temporarily skip test under ASAN

Author: Adrian Prantl Date: 2022-12-16T13:50:21-08:00 New Revision: 27249c06b775c73b7fa9f2d8e48cac1a85169481 URL: https://github.com/llvm/llvm-project/commit/27249c06b775c73b7fa9f2d8e48cac1a85169481 DIFF: https://github.com/llvm/llvm-project/commit/27249c06b775c73b7fa9f2d8e48cac1a85169481.diff

[Lldb-commits] [PATCH] D140056: [lldb] Report clang module build remarks

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c5b97570502: [lldb] Report clang module build remarks (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140056/new/ https://reviews.

[Lldb-commits] [lldb] 9c5b975 - [lldb] Report clang module build remarks

Author: Dave Lee Date: 2022-12-16T13:49:17-08:00 New Revision: 9c5b97570502c5c6648730f75d097910ae2faa22 URL: https://github.com/llvm/llvm-project/commit/9c5b97570502c5c6648730f75d097910ae2faa22 DIFF: https://github.com/llvm/llvm-project/commit/9c5b97570502c5c6648730f75d097910ae2faa22.diff LOG:

[Lldb-commits] [lldb] 320b29e - Fix a syntax error

Author: Adrian Prantl Date: 2022-12-16T13:03:45-08:00 New Revision: 320b29e7ed64c37560c263d4d4eeaa9dad87cb43 URL: https://github.com/llvm/llvm-project/commit/320b29e7ed64c37560c263d4d4eeaa9dad87cb43 DIFF: https://github.com/llvm/llvm-project/commit/320b29e7ed64c37560c263d4d4eeaa9dad87cb43.diff

[Lldb-commits] [PATCH] D140240: [lldb] Prevent false positives with simple template names in SymbolFileDWARF::FindTypes

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2519 +GetTypeForDIE(die)->GetBaseName().AsCString(); +if (name_bracket_index == llvm::StringRef::npos && base_name.contains('<')) + return true;

[Lldb-commits] [PATCH] D140240: [lldb] Prevent false positives with simple template names in SymbolFileDWARF::FindTypes

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The provided test case was crashing because of confusion attempting to find types for `ns::Foo` under -gsimple-template-n

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

avl added a comment. In D138176#4002154 , @JDevlieghere wrote: > I'll add the assert you suggested to this patch. Do you want to commit the > test yourself or can I include it in my commit (I don't want to take credit > for your hard work, but also don

[Lldb-commits] [lldb] daa6305 - [trace] Migrate uses of operator<<(raw_ostream &OS, const Optional &O) to std::optional

Author: Fangrui Song Date: 2022-12-16T19:30:47Z New Revision: daa6305cf7ece2a85aa37e6a880ea6460499 URL: https://github.com/llvm/llvm-project/commit/daa6305cf7ece2a85aa37e6a880ea6460499 DIFF: https://github.com/llvm/llvm-project/commit/daa6305cf7ece2a85aa37e6a880ea6460499.diff LOG:

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

JDevlieghere added a comment. In D138176#4001739 , @avl wrote: > Looks like I have a test case for this problem: That's awesome, thank you for spending time on that! I'll add the assert you suggested to this patch. Do you want to commit the test yourse

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

avl added a comment. Since this patch extends number of cases when uncloned dies are created, it is worth to add following check: void CompileUnit::fixupForwardReferences() { for (const auto &Ref : ForwardDIEReferences) { DIE *RefDie; const CompileUnit *RefUnit; PatchLoca

[Lldb-commits] [PATCH] D140113: [lldb] Force override when adding crashlog command

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Do we want to do this for all the modules in `examples/python` that do something to this effect? e.g. `memory.py` as well. It also might be worth changing some of those messages from err

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

aprantl added a comment. > Well that was my confusion, no there isn't an option. So how does one end up > with a build that doesn't include it. Perhaps a standalone build of lldb, > built with a prebuilt llvm that didn't package libLTO? This is just about adding a dependency between lldb-test-d

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

avl added a comment. Looks like I have a test case for this problem: F25661135: odr-two-units-in-single-file11.test compile units cross reference each other in this test case: CU1: 0x10 type 1 ref to 0x40 CU2: 0x40 type 1 ref to 0x10 CH

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

mib marked 3 inline comments as done. mib added inline comments. Comment at: lldb/source/Plugins/Platform/scripted/ScriptedPlatform.cpp:261 + if (!proc_info_or_error) { +llvm::consumeError(proc_info_or_error.takeError()); +return false; labath wrote: > W

[Lldb-commits] [PATCH] D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

mib added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionGroupPlatform.h:73 bool m_include_platform_option; + OptionGroupPythonClassWithDict m_class_options; }; labath wrote: > labath wrote: > > These nested groups are fairly unusual? Could

[Lldb-commits] [PATCH] D139248: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h:105 +Status error; +Dispatch(method_name, error, args...); + labath wrote: > `std::forward(args)...` maybe

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib added a comment. ping @JDevlieghere CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139250/new/ https://reviews.llvm.org/D139250 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib updated this revision to Diff 483509. mib added a comment. Update comments for `scripted_platform.list_processes` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139250/new/ https://reviews.llvm.org/D139250 Files: lldb/bindings/python/CMakeLists.txt lldb/bindings/python/python-wr

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib added inline comments. Comment at: lldb/bindings/python/python-wrapper.swig:317 +PythonObject lldb_private::LLDBSwigPythonCreateScriptedPlatform( +const char *python_class_name, const char *session_dictionary_name, JDevlieghere wrote: > This looks prett

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib marked 3 inline comments as done. mib added a subscriber: jingham. mib added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31 +def list_processes(self): +""" Get a list of processes that can be ran on the platform. + -

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

fpetrogalli accepted this revision. fpetrogalli added a comment. In D137838#4000959 , @lenary wrote: > [...] I think this is ready to land on Monday? SGTM - thank you again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. The most recent update is all the fixes needed after the builds @MaskRay asked me for. I think this is ready to land on Monday? @thakis there will be GN fallout from this change. I do not intend to update GN in this patchset, but wanted to give you a heads-up. Reposito

[Lldb-commits] [PATCH] D136938: [LLDB] Fix code breakpoints on tagged addresses

DavidSpickett added a comment. Completely forgot about this, ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136938/new/ https://reviews.llvm.org/D136938 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

DavidSpickett added a comment. Well that was my confusion, no there isn't an option. So how does one end up with a build that doesn't include it. Perhaps a standalone build of lldb, built with a prebuilt llvm that didn't package libLTO? Which sounds perfectly legitimate and the test should be s

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

This revision was automatically updated to reflect the committed changes. Closed by commit rGeafe2d4cf17b: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch (authored by lh03061238, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] eafe2d4 - [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

Author: Hui Li Date: 2022-12-16T17:48:37+08:00 New Revision: eafe2d4cf17b7448db5750aff79ee3bb0158f945 URL: https://github.com/llvm/llvm-project/commit/eafe2d4cf17b7448db5750aff79ee3bb0158f945 DIFF: https://github.com/llvm/llvm-project/commit/eafe2d4cf17b7448db5750aff79ee3bb0158f945.diff LOG: [

[Lldb-commits] [PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:469 // Also grab prefixes for each option, these are not fully exposed. -const char *const *Prefixes[DriverID::LastOption] = {nullptr}; -#define PREFIX(NAME, VALUE) static const char

[Lldb-commits] [lldb] 95ec1a6 - [trace] Change /sys/bus const char * variables to const char []

Author: Fangrui Song Date: 2022-12-16T08:07:07Z New Revision: 95ec1a60986c13628c6f608fc0ed1f1fafb1b033 URL: https://github.com/llvm/llvm-project/commit/95ec1a60986c13628c6f608fc0ed1f1fafb1b033 DIFF: https://github.com/llvm/llvm-project/commit/95ec1a60986c13628c6f608fc0ed1f1fafb1b033.diff LOG:

[Lldb-commits] [PATCH] D140056: [lldb] Report clang module build remarks

mib accepted this revision. mib added a comment. Yep, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140056/new/ https://reviews.llvm.org/D140056 ___ lldb-commits mailing list lldb-commits@lists.llv