[Lldb-commits] [PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

kazu created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, ayermolo, sdasgup3, carlosgalvezp, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, r

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan added a comment. The test failure is fixed in https://reviews.llvm.org/D138536 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135798/new/ https://reviews.llvm.org/D135798 ___ lldb-commits maili

[Lldb-commits] [PATCH] D138536: Fix TestVSCode_launch.py test failure

yinghuitan created this revision. yinghuitan added reviewers: clayborg, GeorgeHuyubo, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We changed the output to telemetry category but the test

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

MaskRay added a comment. In D137217#3945366 , @glandium wrote: > Almost there, but not quite: > > [task 2022-11-22T23:55:36.341Z] > /builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1106:6: > error: no matching function for call to o

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

glandium added a comment. Almost there, but not quite: [task 2022-11-22T23:55:36.341Z] /builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1106:6: error: no matching function for call to object of type '(lambda at /builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugi

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added a comment. In D137217#3945136 , @glandium wrote: > Still broken: > > task 2022-11-22T22:09:00.912Z] /usr/lib/llvm-11/bin/clang++ > --sysroot=/builds/worker/fetches/sysroot -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE > -D__STDC_CONSTANT_MACROS -D__

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

clayborg updated this revision to Diff 477314. clayborg added a comment. Remove SBType::IsTypeForcefullyCompleted() for now. Change SBType::IsTypeComplete() to return false for forcefully completed types. I did this only in the public API, not internally since we have the CompilerType::IsForcef

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

glandium added a comment. Still broken: task 2022-11-22T22:09:00.912Z] /usr/lib/llvm-11/bin/clang++ --sysroot=/builds/worker/fetches/sysroot -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/gold -I/builds/worker/fetches/llvm-proje

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf0c16f89124f: Add runToBinaryEntry option for lldb-vscode (authored by yinghuitan). Changed prior to commit: https://re

[Lldb-commits] [lldb] f0c16f8 - Add runToBinaryEntry option for lldb-vscode

Author: Jeffrey Tan Date: 2022-11-22T13:52:45-08:00 New Revision: f0c16f89124f2dc0630162ff9ea23934f5b2b75b URL: https://github.com/llvm/llvm-project/commit/f0c16f89124f2dc0630162ff9ea23934f5b2b75b DIFF: https://github.com/llvm/llvm-project/commit/f0c16f89124f2dc0630162ff9ea23934f5b2b75b.diff L

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added a comment. In D137217#3944952 , @glandium wrote: > This broke the gold plugin: > > [task 2022-11-22T21:03:29.486Z] > /builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1108:19: > error: no matching function for call to

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

glandium added a comment. This broke the gold plugin: [task 2022-11-22T21:03:29.486Z] /builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1108:19: error: no matching function for call to 'localCache' [task 2022-11-22T21:03:29.486Z] Cache = check(localCache("ThinLTO", "T

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

clayborg added a comment. In D138259#3943739 , @labath wrote: > In D138259#3941859 , @clayborg > wrote: > >> In D138259#3941465 , @labath wrote: >> >>> In D138259#3941431

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added a comment. Relanded here to match api changes at https://reviews.llvm.org/D135590 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.

[Lldb-commits] [lldb] 387620a - Reland "[LTO][COFF] Use bitcode file names in lto native object file names."

Author: Zequan Wu Date: 2022-11-22T11:26:18-08:00 New Revision: 387620aa8cea33174b6c1fb80c1af713fee732ac URL: https://github.com/llvm/llvm-project/commit/387620aa8cea33174b6c1fb80c1af713fee732ac DIFF: https://github.com/llvm/llvm-project/commit/387620aa8cea33174b6c1fb80c1af713fee732ac.diff LOG

[Lldb-commits] [lldb] eef5405 - Revert "[LTO][COFF] Use bitcode file names in lto native object file names."

Author: Zequan Wu Date: 2022-11-22T10:55:05-08:00 New Revision: eef5405f74ae208e3e2eb7daacecac923d7338f2 URL: https://github.com/llvm/llvm-project/commit/eef5405f74ae208e3e2eb7daacecac923d7338f2 DIFF: https://github.com/llvm/llvm-project/commit/eef5405f74ae208e3e2eb7daacecac923d7338f2.diff LOG

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

thakis added a comment. This doesn't build: http://45.33.8.238/win/70474/step_4.txt http://45.33.8.238/linux/92146/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Merge executable module's architecture into target's architecture.

This revision was automatically updated to reflect the committed changes. Closed by commit rG24993e749ccd: [LLDB][Minidump] Merge executable module's architecture into target's… (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[Lldb-commits] [lldb] 24993e7 - [LLDB][Minidump] Merge executable module's architecture into target's architecture.

Author: Zequan Wu Date: 2022-11-22T10:23:11-08:00 New Revision: 24993e749ccd0b8f701f5d8cecaaa49cc205aaa2 URL: https://github.com/llvm/llvm-project/commit/24993e749ccd0b8f701f5d8cecaaa49cc205aaa2 DIFF: https://github.com/llvm/llvm-project/commit/24993e749ccd0b8f701f5d8cecaaa49cc205aaa2.diff LOG

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

This revision was automatically updated to reflect the committed changes. Closed by commit rG531ed6d5aa65: [LTO][COFF] Use bitcode file names in lto native object file names. (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D137217?vs=477014&id=477246#toc Repository:

[Lldb-commits] [lldb] 531ed6d - [LTO][COFF] Use bitcode file names in lto native object file names.

Author: Zequan Wu Date: 2022-11-22T10:19:58-08:00 New Revision: 531ed6d5aa65f41c6dfe2e74905d5c6c88fc95a7 URL: https://github.com/llvm/llvm-project/commit/531ed6d5aa65f41c6dfe2e74905d5c6c88fc95a7 DIFF: https://github.com/llvm/llvm-project/commit/531ed6d5aa65f41c6dfe2e74905d5c6c88fc95a7.diff LOG

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_loongarch64.cpp:194 + + uint8_t *dst = const_cast(data_sp->GetBytes()); + ::memcpy(dst, GetGPRBuffer(), GetGPRSize()); I'm not sure const cast is need

[Lldb-commits] [lldb] 60d690b - Add include guards for PlatformQemuUser.h

Author: Pavel Labath Date: 2022-11-22T16:13:29+01:00 New Revision: 60d690b3a956a727ecf2c3dc1d00a74d667a0f5f URL: https://github.com/llvm/llvm-project/commit/60d690b3a956a727ecf2c3dc1d00a74d667a0f5f DIFF: https://github.com/llvm/llvm-project/commit/60d690b3a956a727ecf2c3dc1d00a74d667a0f5f.diff

[Lldb-commits] [lldb] 8effceb - [lldb] rm include/lldb/Host/posix/Fcntl.h

Author: Pavel Labath Date: 2022-11-22T16:13:29+01:00 New Revision: 8effceb570d924675cd4b15e6ca25311598797d1 URL: https://github.com/llvm/llvm-project/commit/8effceb570d924675cd4b15e6ca25311598797d1 DIFF: https://github.com/llvm/llvm-project/commit/8effceb570d924675cd4b15e6ca25311598797d1.diff

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc08d3b08f6d7: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions (authored by pfaffe). Changed prior to commit: https://reviews.llvm.org/D137247?vs=477099&id=477175#toc Repos

[Lldb-commits] [lldb] c08d3b0 - [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

Author: Philip Pfaffe Date: 2022-11-22T14:38:07Z New Revision: c08d3b08f6d71e974537de226c68d4c94c396a46 URL: https://github.com/llvm/llvm-project/commit/c08d3b08f6d71e974537de226c68d4c94c396a46 DIFF: https://github.com/llvm/llvm-project/commit/c08d3b08f6d71e974537de226c68d4c94c396a46.diff LOG:

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

labath added a comment. In D138259#3941859 , @clayborg wrote: > In D138259#3941465 , @labath wrote: > >> In D138259#3941431 , @clayborg >> wrote: >> >>> "a type should be

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Expression/DWARFExpression.cpp:41-44 +#include "llvm/Support/Casting.h" #include "Plugins/SymbolFile/DWARF/DWARFUnit.h" +#include "Plugins/Symb

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Use plugin.object-file.pe-coff.abi as minidump process abi when OS is Windows.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Cool, great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137873/new/ https://reviews.llvm.org/D137873 ___

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

SixWeining added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_loongarch64.cpp:27 +// NT_PRSTATUS and NT_FPREGSET definition +#include + [[ https://llvm.org/docs/CodingStandards.html#include-style | Should be sorted

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

pfaffe updated this revision to Diff 477099. pfaffe marked 2 inline comments as done. pfaffe added a comment. Override new functions in DWOs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137247/new/ https://reviews.llvm.org/D137247 Files: lldb/