[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

clayborg added a comment. In D138259#3942246 , @yinghuitan wrote: > Also, do you have any plan to record this happening in statistics dump so > that our telemetry can report it? I do, that will be a separate patch I will make once this patch is in.

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu updated this revision to Diff 477014. zequanwu added a comment. Update `Twine` argument to `const Twine&`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 Files: clang/lib/CodeGen/BackendUtil.c

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Use plugin.object-file.pe-coff.abi as minidump process abi when OS is Windows.

zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/Breakpad/unwind-via-stack-win-no-memory-info.yaml:74 +header: + Machine: IMAGE_FILE_MACHINE_I386 Characteristics: [ IMAGE_FILE_EXECUTABLE_IMAGE, IMAGE_FILE_LARGE_ADDRESS_AWARE, IMAGE_FILE_DLL ] -

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Use plugin.object-file.pe-coff.abi as minidump process abi when OS is Windows.

zequanwu updated this revision to Diff 477008. zequanwu edited the summary of this revision. zequanwu added a comment. Merge executable module's architecture into target's architecture. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137873/new/ http

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

yinghuitan added a comment. Also, do you have any plan to record this happening in statistics dump so that our telemetry can report it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138259/new/ https://reviews.llvm.org/D138259 ___

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

yinghuitan added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:600 + // no member variables or member functions will be available. + if (GetCompilerType().IsForcefullyCompleted()) { + destination = ""; Is this shown in lldb-vscode? If so, c

[Lldb-commits] [lldb] b3f15cc - Reland "[lldb] Fix SBFileSpec.fullpath"

Author: Dave Lee Date: 2022-11-21T12:45:27-08:00 New Revision: b3f15ccf54cf8094507137d145b38313aa785d61 URL: https://github.com/llvm/llvm-project/commit/b3f15ccf54cf8094507137d145b38313aa785d61 DIFF: https://github.com/llvm/llvm-project/commit/b3f15ccf54cf8094507137d145b38313aa785d61.diff LOG:

[Lldb-commits] [lldb] ba87147 - Revert "[lldb] Fix SBFileSpec.fullpath"

Author: Dave Lee Date: 2022-11-21T12:31:43-08:00 New Revision: ba87147881c8f6592aea0cbdb22d0028e78b30d8 URL: https://github.com/llvm/llvm-project/commit/ba87147881c8f6592aea0cbdb22d0028e78b30d8 DIFF: https://github.com/llvm/llvm-project/commit/ba87147881c8f6592aea0cbdb22d0028e78b30d8.diff LOG:

[Lldb-commits] [PATCH] D138348: [lldb] Fix SBFileSpec.fullpath

This revision was automatically updated to reflect the committed changes. Closed by commit rGa59ed8fa8603: [lldb] Fix SBFileSpec.fullpath (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138348/new/ https://reviews.llvm.org/D

[Lldb-commits] [lldb] a59ed8f - [lldb] Fix SBFileSpec.fullpath

Author: Dave Lee Date: 2022-11-21T12:09:44-08:00 New Revision: a59ed8fa86036efe66efcaddd5cd3e1d17856563 URL: https://github.com/llvm/llvm-project/commit/a59ed8fa86036efe66efcaddd5cd3e1d17856563 DIFF: https://github.com/llvm/llvm-project/commit/a59ed8fa86036efe66efcaddd5cd3e1d17856563.diff LOG:

[Lldb-commits] [lldb] 71b2ff7 - [test] Fix TestSourceManager when the source file is readonly.

Author: Jordan Rupprecht Date: 2022-11-21T11:56:02-08:00 New Revision: 71b2ff79043aea637335b28299e978b678fd83bd URL: https://github.com/llvm/llvm-project/commit/71b2ff79043aea637335b28299e978b678fd83bd DIFF: https://github.com/llvm/llvm-project/commit/71b2ff79043aea637335b28299e978b678fd83bd.di

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

clayborg added a comment. In D138259#3941465 , @labath wrote: > In D138259#3941431 , @clayborg > wrote: > >> "a type should be complete but isn't and you are losing information that >> should have been available

[Lldb-commits] [lldb] 82a46cd - [test] Remove named function arguments from TestSBEnvironment

Author: Jordan Rupprecht Date: 2022-11-21T10:05:41-08:00 New Revision: 82a46cd247c3980f86443a54fbe0a124beee7d26 URL: https://github.com/llvm/llvm-project/commit/82a46cd247c3980f86443a54fbe0a124beee7d26 DIFF: https://github.com/llvm/llvm-project/commit/82a46cd247c3980f86443a54fbe0a124beee7d26.di

[Lldb-commits] [PATCH] D138197: [lldb] Fix bitfield incorrectly printing when field crosses a storage unit

DavidSpickett added a comment. Thanks for working on this. Due to llvm dev and vacation it took me a while to get to this. Comment at: lldb/test/API/commands/expression/expr-bitfield-on-boundary/Makefile:3 + +CXXFLAGS_EXTRAS := -gdwarf-2 + Add a comment here

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b80e8ee1fca: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] 8b80e8e - [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

Author: Arthur Eubanks Date: 2022-11-21T09:30:29-08:00 New Revision: 8b80e8ee1fca660a5ea58cf701c2af8bba0dd89b URL: https://github.com/llvm/llvm-project/commit/8b80e8ee1fca660a5ea58cf701c2af8bba0dd89b DIFF: https://github.com/llvm/llvm-project/commit/8b80e8ee1fca660a5ea58cf701c2af8bba0dd89b.diff

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

labath added a comment. In D138259#3941431 , @clayborg wrote: > "a type should be complete but isn't and you are losing information that > should have been available for you to debug". I agree, but there are still two (or more) ways to communicate that

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

clayborg added a comment. In D138259#3940689 , @labath wrote: > I have a somewhat high level question. Do we actually want > (SB)Type::IsTypeComplete to return true for these kinds of types? > > For clang's benefit, we have to pretend that the AST object

[Lldb-commits] [PATCH] D137900: Make only one function that needs to be implemented when searching for types.

clayborg added a comment. Adrian: so it doesn't seem to make sense to try and get rid of all set accessors because it really complicates the way the TypeQuery is used. We have places where a type query is being create and modified as we parse options from a command line command and we need to c

[Lldb-commits] [PATCH] D138345: [test][lldb-vscode] Un-realpath coreFile test.

This revision was automatically updated to reflect the committed changes. Closed by commit rGae7a3e1c1d3e: [test][lldb-vscode] Un-realpath coreFile test. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138345/new/ https://revi

[Lldb-commits] [lldb] ae7a3e1 - [test][lldb-vscode] Un-realpath coreFile test.

Author: Jordan Rupprecht Date: 2022-11-21T08:32:49-08:00 New Revision: ae7a3e1c1d3ed7125c2436b9fd50512f7548acd7 URL: https://github.com/llvm/llvm-project/commit/ae7a3e1c1d3ed7125c2436b9fd50512f7548acd7 DIFF: https://github.com/llvm/llvm-project/commit/ae7a3e1c1d3ed7125c2436b9fd50512f7548acd7.di

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

labath added a comment. Looks ok, module some inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:2580 +llvm::dyn_cast(symbol_file)) { + symbol_file = &dwo_symbol_file->GetBaseSymbolFile(); +} For other metho

[Lldb-commits] [PATCH] D138430: [lldb/test] Use SBPlatform info for lldbplatformutil.getPlatform()

labath created this revision. labath added a reviewer: JDevlieghere. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. Previously, we just used the platform name. This worked mostly OK, but it required adding special handling for any unusual (and

[Lldb-commits] [lldb] 5b6e67a - [lldb] Enable TestTargetVar on non-darwin

Author: Pavel Labath Date: 2022-11-21T13:26:01+01:00 New Revision: 5b6e67a92b3a28605ac6394d2f657847a09548c0 URL: https://github.com/llvm/llvm-project/commit/5b6e67a92b3a28605ac6394d2f657847a09548c0 DIFF: https://github.com/llvm/llvm-project/commit/5b6e67a92b3a28605ac6394d2f657847a09548c0.diff

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

labath added a comment. I have a somewhat high level question. Do we actually want (SB)Type::IsTypeComplete to return true for these kinds of types? For clang's benefit, we have to pretend that the AST objects are complete (and empty), but we're not similarly restricted in our own representatio

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Use plugin.object-file.pe-coff.abi as minidump process abi when OS is Windows.

labath added a comment. Did you look at the Target::MergeArchitecture function? Is there a suitable place where we could insert a call to that function so that the executable object file environment is automatically propagated to the target? Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Okay, here goes nothing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137983/new/ https://reviews.llvm.org/D137983 ___

[Lldb-commits] [PATCH] D138348: [lldb] Fix SBFileSpec.fullpath

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138348/new/ https://reviews.llvm.org/D138348 ___

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

seehearfeel created this revision. seehearfeel added reviewers: SixWeining, wangleiat, xen0n, xry111, MaskRay, DavidSpickett. Herald added a subscriber: StephenFan. Herald added a project: All. seehearfeel requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: