[Lldb-commits] [lldb] 1fb5c7a - [lldb] Rewrite to assertEqual/assertNotEqual (NFC)

Author: Dave Lee Date: 2022-11-11T17:03:02-08:00 New Revision: 1fb5c7a2f17f10e768160fe23d4a04537c7224c1 URL: https://github.com/llvm/llvm-project/commit/1fb5c7a2f17f10e768160fe23d4a04537c7224c1 DIFF: https://github.com/llvm/llvm-project/commit/1fb5c7a2f17f10e768160fe23d4a04537c7224c1.diff LOG:

[Lldb-commits] [lldb] 5223366 - [lldb] Fix SBFileSpec.fullpath for Windows

Author: Dave Lee Date: 2022-11-11T16:07:38-08:00 New Revision: 5223366416fbde8ac5d53c586c985bffac9cb168 URL: https://github.com/llvm/llvm-project/commit/5223366416fbde8ac5d53c586c985bffac9cb168 DIFF: https://github.com/llvm/llvm-project/commit/5223366416fbde8ac5d53c586c985bffac9cb168.diff LOG:

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG5223366416fb: [lldb] Fix SBFileSpec.fullpath for Windows (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://review

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Set abi environment for windows.

zequanwu created this revision. zequanwu added a reviewer: labath. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If we don't set it, clang will use itanium abi to create record layout which may cause

[Lldb-commits] [PATCH] D137682: Change IRMemoryMap's last-resort magic address to an inaddressable address so it doesn't conflict

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Except that you explicitly want to use the expression parser here so you shouldn't use `p` in the test, this seems fine to me. It would be better to have a less fragile strategy for getting

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione updated this revision to Diff 474866. kastiglione added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 Files: lldb/bindings/interface/SBFileSpec.i lldb/test/API/pyth

[Lldb-commits] [PATCH] D137860: [lldb] Allow flexible importing of in_call_stack

This revision was automatically updated to reflect the committed changes. Closed by commit rG307f395d4ffe: [lldb] Allow flexible importing of in_call_stack (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137860/new/ https://

[Lldb-commits] [lldb] 307f395 - [lldb] Allow flexible importing of in_call_stack

Author: Dave Lee Date: 2022-11-11T14:28:40-08:00 New Revision: 307f395d4ffee839dd0bd88c879539428cc31693 URL: https://github.com/llvm/llvm-project/commit/307f395d4ffee839dd0bd88c879539428cc31693 DIFF: https://github.com/llvm/llvm-project/commit/307f395d4ffee839dd0bd88c879539428cc31693.diff LOG:

[Lldb-commits] [PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aeubanks added a comment. In D137583#3917735 , @dblaikie wrote: > In D137583#3917706 , @aaron.ballman > wrote: > >>> ...we expect template params to be fully qualified when comparing them for >>> simple template

[Lldb-commits] [PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aeubanks updated this revision to Diff 474850. aeubanks added a comment. add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137583/new/ https://reviews.llvm.org/D137583 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp lld

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo a few small nits Comment at: lldb/include/lldb/Symbol/CompilerType.h:60 +} +operator bool() const { return (bool)m_typesystem_sp; } +bool

[Lldb-commits] [PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aeubanks updated this revision to Diff 474848. aeubanks added a comment. use getNameForDiagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137583/new/ https://reviews.llvm.org/D137583 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSystemC

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

aprantl added a comment. Ping @JDevlieghere @labath CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136650/new/ https://reviews.llvm.org/D136650 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [PATCH] D137860: [lldb] Allow flexible importing of in_call_stack

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. I made this change in situ in the version we ship in the LLDB.framework, and this does the right thing! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D137860: [lldb] Allow flexible importing of in_call_stack

kastiglione created this revision. kastiglione added a reviewer: jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Allow `in_call_stack` to be imported in either of the following ways: comm

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

This revision was automatically updated to reflect the committed changes. Closed by commit rGb66da73a05ab: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] b66da73 - [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

Author: Dave Lee Date: 2022-11-11T11:59:36-08:00 New Revision: b66da73a05abe88bbe34bf7ffbe09f6e3d7f1fe0 URL: https://github.com/llvm/llvm-project/commit/b66da73a05abe88bbe34bf7ffbe09f6e3d7f1fe0 DIFF: https://github.com/llvm/llvm-project/commit/b66da73a05abe88bbe34bf7ffbe09f6e3d7f1fe0.diff LOG:

[Lldb-commits] [PATCH] D133395: [lldb] Update regex to be less fragile in TestDataFormatterGenericUnordered

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f121a3f18f7: [lldb] Update regex to be less fragile in TestDataFormatterGenericUnordered (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [lldb] 8f121a3 - [lldb] Update regex to be less fragile in TestDataFormatterGenericUnordered

Author: Dave Lee Date: 2022-11-11T11:42:56-08:00 New Revision: 8f121a3f18f7cc9dac08b7fb43ed7deec6adf583 URL: https://github.com/llvm/llvm-project/commit/8f121a3f18f7cc9dac08b7fb43ed7deec6adf583 DIFF: https://github.com/llvm/llvm-project/commit/8f121a3f18f7cc9dac08b7fb43ed7deec6adf583.diff LOG:

[Lldb-commits] [lldb] 2d2854c - [lldb] [cmake] Fix typo in unittest directory path

Author: Michał Górny Date: 2022-11-11T20:40:37+01:00 New Revision: 2d2854c7d5f9c1723e7ecbe7e8b8f9a2a78941a9 URL: https://github.com/llvm/llvm-project/commit/2d2854c7d5f9c1723e7ecbe7e8b8f9a2a78941a9 DIFF: https://github.com/llvm/llvm-project/commit/2d2854c7d5f9c1723e7ecbe7e8b8f9a2a78941a9.diff

[Lldb-commits] [lldb] d7e1c27 - Revert "[LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`"

Author: Adrian Vogelsgesang Date: 2022-11-11T10:00:58-08:00 New Revision: d7e1c2770fa57fb8df2f09f74d433ac9cf80a595 URL: https://github.com/llvm/llvm-project/commit/d7e1c2770fa57fb8df2f09f74d433ac9cf80a595 DIFF: https://github.com/llvm/llvm-project/commit/d7e1c2770fa57fb8df2f09f74d433ac9cf80a595

[Lldb-commits] [lldb] 558db77 - [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

Author: Adrian Vogelsgesang Date: 2022-11-11T09:37:08-08:00 New Revision: 558db7787005348e2efaabb628ec36f1c461a741 URL: https://github.com/llvm/llvm-project/commit/558db7787005348e2efaabb628ec36f1c461a741 DIFF: https://github.com/llvm/llvm-project/commit/558db7787005348e2efaabb628ec36f1c461a741

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

This revision was automatically updated to reflect the committed changes. Closed by commit rG558db7787005: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle` (authored by avogelsgesang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D136809: [CMake] Make sure all headers are installed into `CLANG_RESOURCE_DIR`

paperchalice added inline comments. Herald added subscribers: Michael137, JDevlieghere. Comment at: clang/lib/Headers/CMakeLists.txt:285 +include(GetClangResourceDir) +get_clang_resource_dir(output_dir PREFIX ${LLVM_BINARY_DIR}/$ SUBDIR include) set(out_files)

[Lldb-commits] [PATCH] D136809: [CMake] Make sure all headers are installed into `CLANG_RESOURCE_DIR`

paperchalice updated this revision to Diff 474715. paperchalice added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add cmake module to handle clang resource dir. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1368