[Lldb-commits] [PATCH] D137312: [LLDB] [LoongArch] Add loongarch64 case in ComputeHostArchitectureSupport()

xen0n accepted this revision. xen0n added a comment. This revision is now accepted and ready to land. Trivially correct. `CONFIG_COMPAT` isn't yet supported by upstream Linux though, but preemptively adding LoongArch here won't do any harm. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D137287: [Test] Fix CHECK typo.

zequanwu updated this revision to Diff 472833. zequanwu added a comment. Herald added subscribers: lldb-commits, nemanjai. Herald added projects: LLDB, clang-tools-extra, Flang. Fix more typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137287/ne

[Lldb-commits] [PATCH] D137312: [LLDB] [LoongArch] Add loongarch64 case in ComputeHostArchitectureSupport()

seehearfeel created this revision. seehearfeel added reviewers: SixWeining, wangleiat, xen0n, xry111, MaskRay, DavidSpickett. Herald added a subscriber: StephenFan. Herald added a project: All. seehearfeel requested review of this revision. Herald added a project: LLDB. Herald added a subscriber:

[Lldb-commits] [PATCH] D137301: PlatformDarwinKernel::GetSupportedArchitectures should report all supported architectures

JDevlieghere added a comment. LGTM Comment at: lldb/source/Target/Target.cpp:1550-1556 + LLDB_LOGF( + log, + "Target::SetArchitecture changing architecture to %s (%s) from %s (%s)", + arch_spec.GetArchitectureName(), + arch_spec.GetTriple().getTriple().c_st

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory (RFC)

JDevlieghere updated this revision to Diff 472812. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135631/new/ https://reviews.llvm.org/D135631 Files: lldb/source/Core/Debugger.cpp lldb/test/Shell/Dia

[Lldb-commits] [PATCH] D137284: Override CalculateFrameVariableError in SymbolFileOnDemand

GeorgeHuyubo updated this revision to Diff 472810. GeorgeHuyubo marked 2 inline comments as done. GeorgeHuyubo added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137284/new/ https://reviews.llvm.org/D137284 Files: l

[Lldb-commits] [PATCH] D137301: PlatformDarwinKernel::GetSupportedArchitectures should report all supported architectures

jasonmolenda added a comment. I should note that `PlatformDarwin::ARMGetSupportedArchitectures` and `PlatformDarwin::x86GetSupportedArchitectures` append the entries to the vector passed in, so calling them in sequence is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D137301: PlatformDarwinKernel::GetSupportedArchitectures should report all supported architectures

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. PlatformDarwi

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

zequanwu abandoned this revision. zequanwu added a comment. It shouldn't reach the code path to complete a class with empty debug info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134066/new/ https://reviews.llvm.org/D134066

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

aeubanks added a comment. Herald added a project: All. the added test `TestVSCode_runInTerminal` consistently fails for me locally with Failed to attach to the target process. Timed out trying to get messages from the runInTerminal launcher I've asked other people and they've also reported co

[Lldb-commits] [PATCH] D137284: Override CalculateFrameVariableError in SymbolFileOnDemand

yinghuitan requested changes to this revision. yinghuitan added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Symbol/SymbolFileOnDemand.h:121 + lldb_private::Status + CalculateFrameVariableError(lldb_private::StackFrame &frame) ov

[Lldb-commits] [PATCH] D136795: [LLDB] Add a `(not loaded) ` prefix to placeholder object filename to indicate they are not loaded.

zequanwu added a comment. Actually just changing the module's file spec make `image dump symtab /tmp/test/linux-x86_64` to fail because the extra string. I still prefer the previous version though `PlaceholderObjectFile` isn't first class plugin as we just checking the plugin name. Repository

[Lldb-commits] [PATCH] D137098: [lldb] Support simplified template names in the manual index

aeubanks added a comment. In D137098#3902140 , @labath wrote: > Why is it that the other indexes don't need an equivalent fix? Could it be > that you just haven't tried those code paths? > > If they do need it, then it'd be good if we could make the fix

[Lldb-commits] [PATCH] D137098: [lldb] Support simplified template names in the manual index

aeubanks updated this revision to Diff 472770. aeubanks added a comment. move retry into SymbolFileDWARF add tests for non-member functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137098/new/ https://reviews.llvm.org/D137098 Files: lldb/so

[Lldb-commits] [PATCH] D126260: [lldb/crashlog] Add support for Application Specific Backtraces & Information

mib updated this revision to Diff 472756. mib added a comment. Update tests following changes in D135547 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126260/new/ https://reviews.llvm.org/D126260 Files: lldb/examples/python/crashlog.py lldb/exampl

[Lldb-commits] [PATCH] D137284: Override CalculateFrameVariableError in SymbolFileOnDemand

kusmour added a comment. It'd be great to put some background in the summary. The issue is introduced when adding Symbol OnDemand feature. We added a wrapper that ignore the error. And this affected the ability to populate the error when we have this feature turned on :D (something like this,

[Lldb-commits] [PATCH] D137284: Override CalculateFrameVariableError in SymbolFileOnDemand

GeorgeHuyubo created this revision. Herald added a project: All. GeorgeHuyubo requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137284 Files: lldb/include/lldb/Symbol/SymbolF

[Lldb-commits] [PATCH] D137191: [lldb] Add information on type systems to statistics dump command

This revision was automatically updated to reflect the committed changes. Closed by commit rG13cd39017de0: [lldb] Add information on type systems to statistics dump command (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137191

[Lldb-commits] [lldb] 13cd390 - [lldb] Add information on type systems to statistics dump command

Author: Alex Langford Date: 2022-11-02T10:45:56-07:00 New Revision: 13cd39017de07a116c8901904fd4cf7aa290a47c URL: https://github.com/llvm/llvm-project/commit/13cd39017de07a116c8901904fd4cf7aa290a47c DIFF: https://github.com/llvm/llvm-project/commit/13cd39017de07a116c8901904fd4cf7aa290a47c.diff

[Lldb-commits] [PATCH] D137272: [lldb][Test] Make TestFrameFormatNameWithArgs.test more compatible across platforms

Michael137 added a comment. Herald added a subscriber: JDevlieghere. Thanks for pointing this out @labath I think this should be enough to get it working on Linux (though unfortunately I don't have a Linux machine handy to test this on) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D137272: [lldb][Test] Make TestFrameFormatNameWithArgs.test more compatible across platforms

Michael137 created this revision. Michael137 added a reviewer: labath. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On Linux the `std::function` behaved differently to that on Darwin. This patch r

[Lldb-commits] [PATCH] D137191: [lldb] Add information on type systems to statistics dump command

bulbazord updated this revision to Diff 472672. bulbazord added a comment. Remove `const &` from argument to `Module::ForEachTypeSystem` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137191/new/ https://reviews.llvm.org/D137191 Files: lldb/include/lldb/Core/Module.h lldb/include/ll

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

DavidSpickett added inline comments. Comment at: lldb/source/Expression/DWARFExpressionList.cpp:93 const DWARFExpression &expr = m_exprs.GetEntryRef(0).data; - return expr.ContainsThreadLocalStorage(); + return expr.ContainsThreadLocalStorage(*m_dwarf_cu); } ---

[Lldb-commits] [lldb] 4b21ecf - [lldb] Update TestDump.test for gnuwin32's 'file' command output

Author: Jonas Devlieghere Date: 2022-11-02T09:33:25-07:00 New Revision: 4b21ecf10c8a0abb977bf11edf939cc708902cd3 URL: https://github.com/llvm/llvm-project/commit/4b21ecf10c8a0abb977bf11edf939cc708902cd3 DIFF: https://github.com/llvm/llvm-project/commit/4b21ecf10c8a0abb977bf11edf939cc708902cd3.d

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

pfaffe added a comment. Yes, you got the context right! Although technically speaking this change isn't limited to wasm, plugins can implement any vendor extension on top of this change. Comment at: lldb/source/Expression/DWARFExpressionList.cpp:93 const DWARFExpression &e

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

labath added a comment. Well... like they say, there's no software engineering problem that can't be solved by adding an extra layer of indirection. In this case, that's "adding an extra layer and leaking it", so I'm wondering if we can drop the second part. I'm going to assume that we want to

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

DavidSpickett added inline comments. Comment at: lldb/unittests/Expression/DWARFExpressionTest.cpp:719 + Type:ET_EXEC + Machine: EM_386 +Sections: I know it's just a test but is there an `EM_WASM` you could use? Maybe lldb doesn't understan

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

DavidSpickett added a comment. I'm missing some context here I think. I assume the use case is that, for example, we don't want to be adding a bunch of WASM specific DWARF operations to the generic operations. If those can live in a WASM (the "vendor") plugin then we know where to look and they

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

labath added a comment. In D137000#3897878 , @jgorbe wrote: > I'm looking at the option of using a non-printable character for the short > flag, and at the same time make `--regex` and `--recognizer-function` > mutually exclusive using option groups. On

Re: [Lldb-commits] [lldb] 3e03873 - [lldb][Test] Fix TestFrameFormatNameWithArgs.test on Windows/Linux

On 01/11/2022 06:59, Michael Buch via lldb-commits wrote: Author: Michael Buch Date: 2022-10-31T22:59:16-07:00 New Revision: 3e03873e363b5aa90e4488da63a6de0648d11aba URL: https://github.com/llvm/llvm-project/commit/3e03873e363b5aa90e4488da63a6de0648d11aba DIFF: https://github.com/llvm/llvm-pr

[Lldb-commits] [PATCH] D137098: [lldb] Support simplified template names in the manual index

labath added a comment. Why is it that the other indexes don't need an equivalent fix? Could it be that you just haven't tried those code paths? If they do need it, then it'd be good if we could make the fix in a single place. Possibly by putting the retry logic at a higher level? In D137098#3

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

pfaffe created this revision. pfaffe added reviewers: labath, DavidSpickett. Herald added a project: All. pfaffe requested review of this revision. Herald added subscribers: lldb-commits, aheejin. Herald added a project: LLDB. Parsing DWARF expressions currently does not support DW_OPs that are ve

[Lldb-commits] [PATCH] D135664: [wasm] Always treat DWARF expression addresses as load addresses

This revision was automatically updated to reflect the committed changes. Closed by commit rGd839f654586a: [wasm] Always treat DWARF expression addresses as load addresses (authored by pfaffe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135664/new

[Lldb-commits] [lldb] d839f65 - [wasm] Always treat DWARF expression addresses as load addresses

Author: Philip Pfaffe Date: 2022-11-02T12:11:53Z New Revision: d839f654586a4f3a84b334fcc2c986343a1d7f98 URL: https://github.com/llvm/llvm-project/commit/d839f654586a4f3a84b334fcc2c986343a1d7f98 DIFF: https://github.com/llvm/llvm-project/commit/d839f654586a4f3a84b334fcc2c986343a1d7f98.diff LOG:

[Lldb-commits] [PATCH] D137191: [lldb] Add information on type systems to statistics dump command

tschuett added inline comments. Comment at: lldb/include/lldb/Core/Module.h:818 + void ForEachTypeSystem(llvm::function_ref const &callback); + Nit: the `const &`is redundant. It is a function reference. CHANGES SINCE LAST ACTION https://reviews.llvm.org/