[Lldb-commits] [PATCH] D136959: clang: Improve errors for DiagnosticInfoResourceLimit

arsenm closed this revision. arsenm added a comment. 0ebd4638af1f71788ca55f521ed8e1ed8cab518d CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136959/new/ https://reviews.llvm.org/D136959 __

Re: [Lldb-commits] [lldb] d765664 - [lldb] Add matching based on Python callbacks for data formatters.

Sent you https://reviews.llvm.org/D137000 for review :) On Wed, Oct 19, 2022 at 2:16 PM Jorge Gorbe Moya wrote: > Hi Jim, > > Thanks for the encouragement! It's unfortunate that you missed the > notifications and couldn't contribute to the code reviews, but I'm glad you > think the code looks fi

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe created this revision. jgorbe added reviewers: jingham, labath. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. This change adds a `--recognizer-function` (`-R`) to `type summary add` and `type syn

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

This revision was automatically updated to reflect the committed changes. Closed by commit rGa842f7405679: [lldb] Support simplified template names (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llv

[Lldb-commits] [lldb] a842f74 - [lldb] Support simplified template names

Author: Arthur Eubanks Date: 2022-10-28T16:15:37-07:00 New Revision: a842f74056793d9ab41411aa343811368164e6a8 URL: https://github.com/llvm/llvm-project/commit/a842f74056793d9ab41411aa343811368164e6a8 DIFF: https://github.com/llvm/llvm-project/commit/a842f74056793d9ab41411aa343811368164e6a8.diff

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan updated this revision to Diff 471676. yinghuitan added a comment. Add failure case testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136697/new/ https://reviews.llvm.org/D136697 Files: lldb/test/API/tools/lldb-vscode/breakpoint/T

[Lldb-commits] [lldb] b3b517d - [lldb] Explicitly open file to write with utf-8 encoding in crashlog.py

Author: Augusto Noronha Date: 2022-10-28T15:04:24-07:00 New Revision: b3b517d572391d9799d1f29bddd66e2bad1acb54 URL: https://github.com/llvm/llvm-project/commit/b3b517d572391d9799d1f29bddd66e2bad1acb54 DIFF: https://github.com/llvm/llvm-project/commit/b3b517d572391d9799d1f29bddd66e2bad1acb54.dif

[Lldb-commits] [PATCH] D136798: [lldb] Explicitly open file to write with utf-8 encoding in crashlog.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3b517d57239: [lldb] Explicitly open file to write with utf-8 encoding in crashlog.py (authored by augusto2112). Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D136798: [lldb] Explicitly open file to write with utf-8 encoding in crashlog.py

mib accepted this revision. mib added a comment. LGTM! Thanks Augusto! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136798/new/ https://reviews.llvm.org/D136798 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D136798: [lldb] Explicitly open file to write with utf-8 encoding in crashlog.py

augusto2112 updated this revision to Diff 471662. augusto2112 added a comment. Added encoding parameter to all "open" calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136798/new/ https://reviews.llvm.org/D136798 Files: lldb/examples/python/cr

[Lldb-commits] [PATCH] D136935: [lldb][CPlusPlus] Introduce CPlusPlusLanguage::MethodName::GetReturnType

hawkinsw added inline comments. Comment at: lldb/unittests/Language/CPlusPlus/CPlusPlusLanguageTest.cpp:85 // Function pointers - {"string (*f(vector&&))(float)", "", "f", "(vector&&)", "", - "f"}, - {"void (*&std::_Any_data::_M_access())()", "std::_Any_dat

[Lldb-commits] [PATCH] D136959: clang: Improve errors for DiagnosticInfoResourceLimit

aeubanks added a comment. see https://reviews.llvm.org/D110665 for how we get line/col from a function. basically, we have a map from function name hashes to source location available in clang if we don't have clang source information for functions available, there's not much more we can do ot

[Lldb-commits] [PATCH] D136934: [lldb][FormatEntity][NFC] Move function argument parsing code into separate functions

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Core/FormatEntity.cpp:1057 + // the arguments list + if (generic && open_paren && generic < open_paren) { +int generic_depth = 1;

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

kastiglione added a comment. > Do you have an repro case that will show this issue? I would need to debug it. @clayborg sorry for the late reply. The repro happened to me while debugging some Swift: func main() { let digits = /\d+/ let match = "abc123".firstMatch(of: digits)

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 471585. aeubanks added a comment. rename variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llvm.org/D134378 Files: lldb/include/lldb/Symbol/CompilerType.h lldb/include/ll

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

hawkinsw added a comment. Mr. Sabolčec, Thank you for the kind response -- I hope my work was helpful! It was lots of fun to dig in to this part of the codebase! Sincerely, Will Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132734/new/ https://r

[Lldb-commits] [PATCH] D136935: [lldb][CPlusPlus] Introduce CPlusPlusLanguage::MethodName::GetReturnType

Michael137 added a comment. In D136935#3892082 , @labath wrote: > The return type handling for function pointers is not correct. If it's hard > to do, then maybe we could skip it (i suspect the original code didn't handle > that either), but I have a fe

[Lldb-commits] [PATCH] D136958: [lldb] Document QSetDetachOnError packet

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM, thanks for adding this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136958/new/ https://reviews.llvm.org/D136958

[Lldb-commits] [PATCH] D128504: debugserver: spawn process in its own process group

aarzilli added a comment. > Do you have commit access to the repository? I do not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128504/new/ https://reviews.llvm.org/D128504 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D128504: debugserver: spawn process in its own process group

jasonmolenda added a comment. Sorry for the delay in replying to this, I'm fine with integrating this change. I won't pretend to understand all the ins & outs of signal delivery to process groups, but the best way to find if there's an issue with this kind of change is to try it out. Do you h

[Lldb-commits] [PATCH] D136959: clang: Improve errors for DiagnosticInfoResourceLimit

arsenm created this revision. arsenm added reviewers: nickdesaulniers, yaxunl, aaron.ballman, qcolombet, aeubanks, olista01, dnovillo, echristo, MaskRay. Herald added subscribers: kosarev, StephenFan, tpr. Herald added a project: All. arsenm requested review of this revision. Herald added a subscr

[Lldb-commits] [PATCH] D136958: [lldb] Document QSetDetachOnError packet

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The packet was introduced in 106d02866d4d54b09c08e6a12915dba58e709294. Repository: rG LLVM Github Monorepo https://re

[Lldb-commits] [PATCH] D136935: [lldb][CPlusPlus] Introduce CPlusPlusLanguage::MethodName::GetReturnType

Michael137 added a comment. In D136935#3892082 , @labath wrote: > The return type handling for function pointers is not correct. If it's hard > to do, then maybe we could skip it (i suspect the original code didn't handle > that either), but I have a fe

[Lldb-commits] [PATCH] D136935: [lldb][CPlusPlus] Introduce CPlusPlusLanguage::MethodName::GetReturnType

labath added a comment. The return type handling for function pointers is not correct. If it's hard to do, then maybe we could skip it (i suspect the original code didn't handle that either), but I have a feeling it might not be that hard, given that we're already able correctly extract the inn

[Lldb-commits] [PATCH] D135664: [wasm] Always treat DWARF expression addresses as load addresses

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135664/new/ https://reviews.llvm.org/D135664

[Lldb-commits] [PATCH] D135664: [wasm] Always treat DWARF expression addresses as load addresses

pfaffe updated this revision to Diff 471543. pfaffe added a comment. Add unittest for DW_OP_addrx as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135664/new/ https://reviews.llvm.org/D135664 Files: lldb/source/Expression/DWARFExpression.c

[Lldb-commits] [PATCH] D128504: debugserver: spawn process in its own process group

aarzilli added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128504/new/ https://reviews.llvm.org/D128504 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D135664: [wasm] Always treat DWARF expression addresses as load addresses

DavidSpickett added inline comments. Comment at: lldb/unittests/Expression/DWARFExpressionTest.cpp:435 + ASSERT_EQ(result.GetValueType(), Value::ValueType::LoadAddress); +} DavidSpickett wrote: > There are two `target && target->GetArchitecture().GetCore() == >

[Lldb-commits] [PATCH] D135664: [wasm] Always treat DWARF expression addresses as load addresses

pfaffe updated this revision to Diff 471486. pfaffe added a comment. Bring back lost changes... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135664/new/ https://reviews.llvm.org/D135664 Files: lldb/source/Expression/DWARFExpression.cpp lldb/u

[Lldb-commits] [PATCH] D135664: [wasm] Always treat DWARF expression addresses as load addresses

pfaffe updated this revision to Diff 471485. pfaffe added a comment. Add comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135664/new/ https://reviews.llvm.org/D135664 Files: lldb/source/Expression/DWARFExpression.cpp Index: lldb/source/

[Lldb-commits] [PATCH] D135664: [wasm] Always treat DWARF expression addresses as load addresses

pfaffe updated this revision to Diff 471484. pfaffe added a comment. Herald added a subscriber: lldb-commits. Full context with arcanist Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135664/new/ https://reviews.llvm.org/D135664 Files: lldb/sourc

[Lldb-commits] [PATCH] D136938: [LLDB] Fix code breakpoints on tagged addresses

DavidSpickett added a comment. If you want to understand the motivation beyond "this should work why doesn't it", here it is. If your ABI mandated signing all function pointers you might store a callback in a struct somewhere. Not knowing what that callback points to you would like to be able

[Lldb-commits] [PATCH] D136938: [LLDB] Fix code breakpoints on tagged addresses

DavidSpickett added a comment. Tests will run only for armv8.3-a hardware so I've tested them with `qemu-system`. Existing tests pass on Armv8 Linux as before. Some of these PAC tests could run on Apple Silicon now that I think about it. That's for another time, needs extra work. Repository:

[Lldb-commits] [PATCH] D136938: [LLDB] Fix code breakpoints on tagged addresses

DavidSpickett updated this revision to Diff 471481. DavidSpickett added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136938/new/ https://reviews.

[Lldb-commits] [PATCH] D136766: [lldb][Docs][NFC] Fix sphinx warnings/errors for LLDB docs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2a812bdc70c6: [lldb][Docs][NFC] Fix sphinx warnings/errors for LLDB docs (authored by Michael137). Repository: rG LLVM

[Lldb-commits] [lldb] 2a812bd - [lldb][Docs][NFC] Fix sphinx warnings/errors for LLDB docs

Author: Michael Buch Date: 2022-10-28T11:31:15+01:00 New Revision: 2a812bdc70c6153f41907db056e348d9b322f01c URL: https://github.com/llvm/llvm-project/commit/2a812bdc70c6153f41907db056e348d9b322f01c DIFF: https://github.com/llvm/llvm-project/commit/2a812bdc70c6153f41907db056e348d9b322f01c.diff

[Lldb-commits] [PATCH] D136938: [LLDB] Fix code breakpoints on tagged addresses

DavidSpickett created this revision. Herald added subscribers: atanasyan, arichardson, sdardis. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This allows you to break on the value of a function p

[Lldb-commits] [PATCH] D136935: [lldb][CPlusPlus] Introuce CPlusPlusLanguage::MethodName::GetReturnType

Michael137 updated this revision to Diff 471474. Michael137 added a comment. - Fix unit-tests - Handle function pointer types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136935/new/ https://reviews.llvm.org/D136935 Files: lldb/source/Plugins/L

[Lldb-commits] [PATCH] D136761: [lldb][CPlusPlus] Implement CPlusPlusLanguage::GetFunctionDisplayName

Michael137 added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:1538 + cstr = inline_info->GetName().GetCString(); +} + Not great that this is copied from `FormatEntity` but didn't see a great way of ma

[Lldb-commits] [PATCH] D136761: [lldb][FormatEntity] Fix closing parenthesis for function.name-with-args frame format

Michael137 updated this revision to Diff 471468. Michael137 added a comment. - Use the C++ language-plugin to format the function name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136761/new/ https://reviews.llvm.org/D136761 Files: lldb/source/

[Lldb-commits] [lldb] bf07c33 - Revert "[clang] Instantiate NTTPs and template default arguments with sugar"

Author: Haojian Wu Date: 2022-10-28T11:56:19+02:00 New Revision: bf07c338bb78c54b8d96fb42a75b168bf1550ad7 URL: https://github.com/llvm/llvm-project/commit/bf07c338bb78c54b8d96fb42a75b168bf1550ad7 DIFF: https://github.com/llvm/llvm-project/commit/bf07c338bb78c54b8d96fb42a75b168bf1550ad7.diff LO

[Lldb-commits] [PATCH] D136935: [lldb][CPlusPlus] Introuce CPlusPlusLanguage::MethodName::GetReturnType

Michael137 created this revision. Michael137 added reviewers: labath, aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a way to extract the return type out of the `CPlusPlusNam

[Lldb-commits] [PATCH] D136934: [lldb][FormatEntity][NFC] Move function argument parsing code into separate functions

Michael137 created this revision. Michael137 added reviewers: labath, aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Hopefully makes the code more readable and allows us to re-use argument p

[Lldb-commits] [PATCH] D136928: [LLDB] Fix help text for "platform settings"

DavidSpickett added a reviewer: clayborg. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. Alternatively, I could look at adding that option. Not sure off the top of my head if configuring an inactive platform would even work. Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D136928: [LLDB] Fix help text for "platform settings"

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This claims to take a platform name argument but doesn't. That was probably the intent in fbb7634934d40548b6505

[Lldb-commits] [PATCH] D136362: [LLDB][RISCV] Add RV64C instruction support for EmulateInstructionRISCV

Emmmer added a comment. I suspect the cause is that g++ tries to instantiate these generic lambdas inside `std::visit`, which consumes N^2 the size memory (or whatever is related?) when there's nested-`std::visit` bool compareInst(const RISCVInst &lhs, const RISCVInst &rhs) { if (lhs.inde

[Lldb-commits] [PATCH] D136795: [LLDB] Add a `(not loaded) ` prefix to placeholder object filename to indicate they are not loaded.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I'm not entirely sold on the string "(not loaded)". Maybe would be ok for the user, but to me it sounds extremely weird, because the main reason we are creating this module is so that we can p

[Lldb-commits] [PATCH] D136362: [LLDB][RISCV] Add RV64C instruction support for EmulateInstructionRISCV

seehearfeel added a subscriber: SixWeining. seehearfeel added a comment. In D136362#3890970 , @DavidSpickett wrote: > Can you give us: > > - the full cmake command you used to configure the project git clone https://github.com/llvm/llvm-project.git

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D134378#3890302 , @aeubanks wrote: > regarding the failure in TestCPPBreakpointLocations.py (added recently in > https://reviews.llvm.org/D135921,

[Lldb-commits] [PATCH] D136362: [LLDB][RISCV] Add RV64C instruction support for EmulateInstructionRISCV

DavidSpickett added a comment. Can you give us: - the full cmake command you used to configure the project - the gcc/g++ version used - the distro used - the architecture (unlikely to matter but I'm assuming Loongson?) - the version of clang++ that did work Could be tripping over a bug in g++. I

[Lldb-commits] [lldb] 1dc3937 - [lldb/qemu] Stub out process info functions

Author: Pavel Labath Date: 2022-10-28T09:17:53+02:00 New Revision: 1dc39378c46643ec9d2544da671aca78e7c6967a URL: https://github.com/llvm/llvm-project/commit/1dc39378c46643ec9d2544da671aca78e7c6967a DIFF: https://github.com/llvm/llvm-project/commit/1dc39378c46643ec9d2544da671aca78e7c6967a.diff

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mstorsjo added a comment. In D136572#3890835 , @mgorny wrote: > In D136572#3889317 , @mstorsjo > wrote: > >> Also for the record, I'd love to get rid of this symlink based setup, if I >> could make cmake produce