[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

mehdi_amini added a comment. From what I saw when you posted the discourse thread initially, I understand you're targeting user-visible features, and mostly from the "toolchain" side of the project. However I find the language here to be potentially confusing for the API surface of the librarie

[Lldb-commits] [PATCH] D136306: [WIP][lldb][CPlusPlus] Add abi_tag support to the CPlusPlusNameParser

Michael137 added a comment. Herald added a subscriber: JDevlieghere. Would really be nice not to have to do this. Especially because it looks like only the LLVM demangler prints out the ABI tags (though other vendors may start doing the same at some point) This is partly educational to see what

[Lldb-commits] [PATCH] D136306: [WIP][lldb][CPlusPlus] Add abi_tag support to the CPlusPlusNameParser

Michael137 created this revision. Michael137 added reviewers: aprantl, labath, jingham. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch teaches the `CPlusPlusNameParser` to parse the demang

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

Michael137 added subscribers: jingham, labath, aprantl. Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2500 +const llvm::StringRef nameRef = name.GetStringRef(); +auto it = nameRef.find('<'); +if (it != llvm::Str

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

rnk added a comment. @Michael137, are you comfortable approving this, or can you reroute to a reviewer who can help us with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llvm.org/D134378 _

[Lldb-commits] [PATCH] D136295: Fix exception description in lldb-vscode

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour, fixathon. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There is a

Re: [Lldb-commits] [lldb] d765664 - [lldb] Add matching based on Python callbacks for data formatters.

Hi Jim, Thanks for the encouragement! It's unfortunate that you missed the notifications and couldn't contribute to the code reviews, but I'm glad you think the code looks fine. Of course I don't mind adding these as a follow-up, it would be a shame if I didn't expose the new feature for CLI user

Re: [Lldb-commits] [lldb] d765664 - [lldb] Add matching based on Python callbacks for data formatters.

Jorge, It's great to see you worked your way through this change! Something in our mail pipeline is dropping all my lldb-commits and review comment notifications. Still haven't figured out who is doing that, so I didn't get a chance to look over the final version. The code looks fine, but nob

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f2423c6fe97: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [lldb] 6f2423c - [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

Author: Augusto Noronha Date: 2022-10-19T13:49:40-07:00 New Revision: 6f2423c6fe97bec77da66d87a7a997917f6b489e URL: https://github.com/llvm/llvm-project/commit/6f2423c6fe97bec77da66d87a7a997917f6b489e DIFF: https://github.com/llvm/llvm-project/commit/6f2423c6fe97bec77da66d87a7a997917f6b489e.dif

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

augusto2112 updated this revision to Diff 469032. augusto2112 added a comment. Updated default stack size of the cu containers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136114/new/ https://reviews.llvm.org/D136114 Files: lldb/source/Plugins/

[Lldb-commits] [PATCH] D135983: [lldb] Fix a -Wdeprecated-declarations warning

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135983/new/ https://reviews.llvm.org/D135983 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D135648: [lldb] Add matching based on Python callbacks for data formatters.

This revision was automatically updated to reflect the committed changes. jgorbe marked 2 inline comments as done. Closed by commit rGd76566417e59: [lldb] Add matching based on Python callbacks for data formatters. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [lldb] d765664 - [lldb] Add matching based on Python callbacks for data formatters.

Author: Jorge Gorbe Moya Date: 2022-10-19T12:53:38-07:00 New Revision: d76566417e592cfac9c710f82575473b1b4a9285 URL: https://github.com/llvm/llvm-project/commit/d76566417e592cfac9c710f82575473b1b4a9285 DIFF: https://github.com/llvm/llvm-project/commit/d76566417e592cfac9c710f82575473b1b4a9285.di

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. LGTM, with two tiny new suggestions. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.h:179 +/// The compile units that an object file contains.

[Lldb-commits] [PATCH] D136011: [lldb] Don't check environment default char signedness when creating clang type for "char"

dblaikie added a comment. In D136011#3862150 , @labath wrote: > In D136011#3860637 , @dblaikie > wrote: > >> I think the place where this will go wrong is in terms of how lldb renders >> `char` values on non-def

[Lldb-commits] [lldb] 1e58e3e - [lldb][trace] Fix some minor bugs in the call tree

Author: Walter Erquinigo Date: 2022-10-19T00:44:48-07:00 New Revision: 1e58e3e1e96096f2d8db759555cf5132c5860519 URL: https://github.com/llvm/llvm-project/commit/1e58e3e1e96096f2d8db759555cf5132c5860519 DIFF: https://github.com/llvm/llvm-project/commit/1e58e3e1e96096f2d8db759555cf5132c5860519.di