[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

2022-10-08 Thread Matheus Izvekov via Phabricator via lldb-commits
mizvekov added inline comments. Comment at: clang/include/clang/AST/Type.h:1836 +// The index of the template parameter this substitution represents. +unsigned Index : 15; + erichkeane wrote: > Is it a problem for this to be a different number of bits use

[Lldb-commits] [PATCH] D135521: [lldb][trace] Add a basic function call dump [1] - Add the command scaffolding

2022-10-08 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 466317. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135521/new/ https://reviews.llvm.org/D135521 Files: lldb/source/Commands/CommandObjectThread.cpp lldb/source/Commands/Opt

[Lldb-commits] [PATCH] D135521: [lldb][trace] Add a basic function call dumpdump [1] - Add the command scaffolding

2022-10-08 Thread walter erquinigo via Phabricator via lldb-commits
wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The command is thread trace dump function-calls and as minimum will require p

[Lldb-commits] [PATCH] D135516: [lldb] [MainLoopPosix] Fix crash upon adding lots of pending callbacks

2022-10-08 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jingham. Herald added a project: All. mgorny requested review of this revision. If lots of pending callbacks are added while the main loop has exited already, the trigger pipe buffer fills in, causing the write to f