[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

2022-09-24 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. I'll have to admit, a quick read through of Target::GetOrAddModule() worries me about adding this mid-function return - the code clearly has a mix of cases where it has found a Module on disk that is new to lldb and is loading it, it has found a module in lldb's gl

[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

2022-09-24 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. I probably misunderstand the situation DynamicLoaderWindows finds itself in, but in DynamicLoaderDarwin we have similar behavior - you run 'lldb binary' and lldb loads all the directly linked dynamic libraries into the target it creates, pre-execution. When execut

[Lldb-commits] [PATCH] D134585: [lldb][COFF] Map symbols without base+complex type as 'Data' type

2022-09-24 Thread Alvin Wong via Phabricator via lldb-commits
alvinhochun created this revision. alvinhochun added reviewers: labath, DavidSpickett, mstorsjo. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Both LLD and GNU ld write global/static variables to t

[Lldb-commits] [PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

2022-09-24 Thread Iain Sandoe via Phabricator via lldb-commits
iains updated this revision to Diff 462657. iains added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rebased and reworked. The version here has now been tested to consume all of the libc++ headers including those in experimental and ext. Repository: rG LL

[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

2022-09-24 Thread Alvin Wong via Phabricator via lldb-commits
alvinhochun added a comment. @mstorsjo Can you please try the test I added and check that it passes with the patch and fails without it? (I don't have a setup to run tests on Windows.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134581/new/ http

[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

2022-09-24 Thread Alvin Wong via Phabricator via lldb-commits
alvinhochun created this revision. alvinhochun added reviewers: labath, mstorsjo, clayborg, jingham. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. LLDB preloads some dependent modules when creating