[Lldb-commits] [PATCH] D132775: [lldb][docs] Fix formatting in fuzzing doc

This revision was automatically updated to reflect the committed changes. Closed by commit rG53f1cc85e3de: [lldb][docs] Fix formatting in fuzzing doc (authored by cassanova). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132775/new/ https://reviews.

[Lldb-commits] [lldb] 53f1cc8 - [lldb][docs] Fix formatting in fuzzing doc

Author: Chelsea Cassanova Date: 2022-08-26T22:15:38-05:00 New Revision: 53f1cc85e3de11ff91eb985332257d63dcf47ddc URL: https://github.com/llvm/llvm-project/commit/53f1cc85e3de11ff91eb985332257d63dcf47ddc DIFF: https://github.com/llvm/llvm-project/commit/53f1cc85e3de11ff91eb985332257d63dcf47ddc.d

[Lldb-commits] [PATCH] D132775: [lldb][docs] Fix formatting in fuzzing doc

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132775/new/ https://reviews.llvm.org/D132775 ___

[Lldb-commits] [PATCH] D132775: [lldb][docs] Fix formatting in fuzzing doc

cassanova created this revision. cassanova added reviewers: JDevlieghere, mib. Herald added a project: All. cassanova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The page for fuzzing LLDB had incorrectly formatted code, this commit fixe

Re: [Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

> On Aug 26, 2022, at 5:08 PM, Adrian Vogelsgesang > wrote: > > Thank you for that hint, Jim! This infrastructure indeed looks very > interesting for my use case. > I will most likely use the HistoryThread class to represent the backtrace of > the logical coroutine threads. > > Is my unders

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 added a comment. @Emmmer, agreed that automated tests for ABI plugins would be a nice thing to have at some point in the future, but it is out of the scope of this initial bring up for RISCV, as tests are missing for all architectures. Also we need `Plugins/Architecture`port for RISCV

[Lldb-commits] [PATCH] D132735: [LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty printer

avogelsgesang updated this revision to Diff 456062. avogelsgesang added a comment. fix offset Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132735/new/ https://reviews.llvm.org/D132735 Files: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp

[Lldb-commits] [PATCH] D132735: [LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty printer

avogelsgesang updated this revision to Diff 456060. avogelsgesang added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132735/new/ https://reviews.llvm.org/D132735 Files: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp

[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

This revision was automatically updated to reflect the committed changes. Closed by commit rG43d7320e7111: [lldb][docs] Add documentation for LLDB fuzzers (authored by cassanova). Changed prior to commit: https://reviews.llvm.org/D132148?vs=453808&id=456058#toc Repository: rG LLVM Github Mon

[Lldb-commits] [lldb] 43d7320 - [lldb][docs] Add documentation for LLDB fuzzers

Author: Chelsea Cassanova Date: 2022-08-26T18:35:21-05:00 New Revision: 43d7320e7111784c613634e73f50c631a1b0b303 URL: https://github.com/llvm/llvm-project/commit/43d7320e7111784c613634e73f50c631a1b0b303 DIFF: https://github.com/llvm/llvm-project/commit/43d7320e7111784c613634e73f50c631a1b0b303.d

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

avogelsgesang updated this revision to Diff 456055. avogelsgesang added a comment. disable tests on gcc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132624/new/ https://reviews.llvm.org/D132624 Files: lldb/source/Plugins/Language/CPlusPlus/Coro

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 marked 2 inline comments as done. kasper81 added a comment. Addressed review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132510/new/ https://reviews.llvm.org/D132510 ___ lldb-commits

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 updated this revision to Diff 455982. kasper81 marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132510/new/ https://reviews.llvm.org/D132510 Files: lldb/source/Plugins/ABI/CMakeLists.txt lldb/source/Plugin

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 updated this revision to Diff 455977. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132510/new/ https://reviews.llvm.org/D132510 Files: lldb/source/Plugins/ABI/CMakeLists.txt lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp lldb/source

[Lldb-commits] [PATCH] D128504: debugserver: spawn process in its own process group

clayborg added a comment. Jason? Are you ok with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128504/new/ https://reviews.llvm.org/D128504 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:75-76 + name.startswith("unordered_multimap<") || + name.startswith("std::__1::unordered_map<") || + name.startswith("std::__1::unordered_multimap

[Lldb-commits] [PATCH] D132578: [lldb] [Core] Use thread for Communication::Write() as well

mgorny updated this revision to Diff 455952. mgorny added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132578/new/ https://reviews.llvm.org/D132578 Files: lldb/include/lldb/Core/Communication.h lldb/source/Core/Communication.cpp lldb/unittests/Core/Communicati

[Lldb-commits] [PATCH] D132283: [lldb] [Core] Reimplement Communication::ReadThread using MainLoop

mgorny updated this revision to Diff 455951. mgorny added a comment. Rebase, move `StopReadThread()` test here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132283/new/ https://reviews.llvm.org/D132283 Files: lldb/include/lldb/Core/Communication.h lldb/source/Core/Communication.cp

[Lldb-commits] [PATCH] D132577: [lldb] [Core] Pass error/status from Communication::ReadThread()

mgorny updated this revision to Diff 455950. mgorny added a comment. Rebase, move `StopReadThread()` test to the other patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132577/new/ https://reviews.llvm.org/D132577 Files: lldb/include/lldb/Core/Communication.h lldb/source/Core/Co

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

Emmmer added a subscriber: labath. Emmmer added a comment. I have to say sorry after reading your update but not giving you feedback. I pulled your patch and found it does not compile, and I have fixed them for you :) In D62732#2306055 , @labath wrote: >

Re: [Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

> On Aug 26, 2022, at 7:05 AM, Adrian Vogelsgesang via Phabricator via > lldb-commits wrote: > > avogelsgesang added a comment. > >> I don't know much about coroutines, but it seems like your goal is to format >> them like a linked list > > actually, my preferred goal would be to show them

[Lldb-commits] [PATCH] D132578: [lldb] [Core] Use thread for Communication::Write() as well

mgorny added a comment. (with the final goal of using `StartReadThread()` inside gdb-remote comms to take care of reading the data for concurrent process plugin instances) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132578/new/ https://reviews.llvm.org/D132578 __

[Lldb-commits] [PATCH] D132578: [lldb] [Core] Use thread for Communication::Write() as well

mgorny added a comment. Well, back when working on the async thread, you've indicated that it's a bad idea to read from one thread while writing from another, so I've basically focused on getting to the point when all reads and writes are guaranteed to happen from a single thread. CHANGES SIN

[Lldb-commits] [PATCH] D132577: [lldb] [Core] Pass error/status from Communication::ReadThread()

mgorny added a comment. Hmm, I see you've updated the tests, so I need to update this patch anyway. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132577/new/ https://reviews.llvm.org/D132577 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

mgorny added a comment. In that case, is there something more I should do about this patch or are you going to take over from here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131160/new/ https://reviews.llvm.org/D131160 ___ lldb-commits m

[Lldb-commits] [PATCH] D132577: [lldb] [Core] Pass error/status from Communication::ReadThread()

mgorny added inline comments. Comment at: lldb/unittests/Core/CommunicationTest.cpp:140 + + // StopReadThread() can hang, so force an external timeout. + std::unique_lock lock{finished_mutex}; labath wrote: > I don't understand what is the purpose of this. Can

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 added a comment. @jasonmolenda. @Emmmer, I've addressed your review feedback. Could you please take another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132510/new/ https://reviews.llvm.org/D132510

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

avogelsgesang added a comment. > I don't know much about coroutines, but it seems like your goal is to format > them like a linked list actually, my preferred goal would be to show them as a logical, user-level thread. Such that you can type thread backtrace cxxcoro:0xb2a0 to get th

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

avogelsgesang added a comment. > I don't know much about coroutines, but it seems like your goal is to format > them like a linked list Yes, and no. Coroutines are a compiler-provided type-erasure mechanism which (among other things) erase the type of the contained promise. One common use case

[Lldb-commits] [PATCH] D132578: [lldb] [Core] Use thread for Communication::Write() as well

labath added a comment. Can you explain where you're heading with this? I can imagine that something like this might be necessary in some cases, but I also don't see anything inherently wrong with concurrent reads and writes to the same connection. CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D132283: [lldb] [Core] Reimplement Communication::ReadThread using MainLoop

labath added inline comments. Comment at: lldb/source/Core/Communication.cpp:427 // Notify the read thread. - m_connection_sp->InterruptRead(); Have you considered putting this code (some version of it) inside `InterruptRead`? Basically replacing the `sele

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

labath added a comment. In D131160#3735372 , @mgorny wrote: > Also I'm wondering about error handling. Should we introduce fallible > constructor for this? I'm not particularly worried about this. I might even make the Pipe constructor non-fallible, as

[Lldb-commits] [PATCH] D132735: [LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty printer

avogelsgesang updated this revision to Diff 455893. avogelsgesang added a comment. Exclude unsupported compilers from test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132735/new/ https://reviews.llvm.org/D132735 Files: lldb/source/Plugins

[Lldb-commits] [PATCH] D132577: [lldb] [Core] Pass error/status from Communication::ReadThread()

labath added inline comments. Comment at: lldb/unittests/Core/CommunicationTest.cpp:140 + + // StopReadThread() can hang, so force an external timeout. + std::unique_lock lock{finished_mutex}; I don't understand what is the purpose of this. Can you elaborate?

[Lldb-commits] [lldb] 59656c0 - [lldb] Make CommunicationTest compatible with windows

Author: Pavel Labath Date: 2022-08-26T15:25:46+02:00 New Revision: 59656c0492224a2da590b913959630107e0a31f4 URL: https://github.com/llvm/llvm-project/commit/59656c0492224a2da590b913959630107e0a31f4 DIFF: https://github.com/llvm/llvm-project/commit/59656c0492224a2da590b913959630107e0a31f4.diff

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

labath added a comment. In D132624#3749263 , @avogelsgesang wrote: >> leads me to believe that the data formatter is creating the synthetic >> children as non pointer objects (e.g. by automatically dereferencing any >> nested pointers), even though the

[Lldb-commits] [PATCH] D132735: [LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty printer

avogelsgesang created this revision. avogelsgesang added reviewers: ChuanqiXu, aprantl, dblaikie, ychen, jryans, JDevlieghere. Herald added a project: All. avogelsgesang requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. With this commit, the

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

tonkosi created this revision. tonkosi added reviewers: werat, Michael137. Herald added a project: All. tonkosi requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This change fixes two issues in ValueObject::GetExpressionPath method: 1. Acces

[Lldb-commits] [lldb] afdfb3a - [lldb] Skip TestCoroutineHandle.py on libstdc++<11

Author: Pavel Labath Date: 2022-08-26T14:04:04+02:00 New Revision: afdfb3ae6b07b546b56b7ef1fbee26b7ad2bcfe7 URL: https://github.com/llvm/llvm-project/commit/afdfb3ae6b07b546b56b7ef1fbee26b7ad2bcfe7 DIFF: https://github.com/llvm/llvm-project/commit/afdfb3ae6b07b546b56b7ef1fbee26b7ad2bcfe7.diff

[Lldb-commits] [lldb] bb26ebb - [lldb] Fix dotest argument order

Author: Felipe de Azevedo Piovezan Date: 2022-08-26T06:52:40-04:00 New Revision: bb26ebb4d18c1877cc6fd17aa803609abeb95096 URL: https://github.com/llvm/llvm-project/commit/bb26ebb4d18c1877cc6fd17aa803609abeb95096 DIFF: https://github.com/llvm/llvm-project/commit/bb26ebb4d18c1877cc6fd17aa803609ab

[Lldb-commits] [PATCH] D132642: [lldb] Fix dotest argument order

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb26ebb4d18c: [lldb] Fix dotest argument order (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D132642: [lldb] Fix dotest argument order

fdeazeve updated this revision to Diff 455859. fdeazeve added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132642/new/ https://reviews.llvm.org/D132642 Files: lldb/test/API/CMakeLists.txt lldb/test/API/lit

[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

bkramer added a comment. This seems to trigger a use after free in `lldb-api :: functionalities/thread/create_after_attach/TestCreateAfterAttach.py` asan log: ==4741==ERROR: AddressSanitizer: heap-use-after-free on address 0x62f00023bf58 at pc 0x563639db88f1 bp 0x7ffd942412f0 sp 0x7ffd942412

[Lldb-commits] [lldb] 5955edf - [lldb][Test] Add missing breakpoint in TestNamespaceLookup.py

Author: Michael Buch Date: 2022-08-26T10:28:28+01:00 New Revision: 5955edf8a453b4b8ff7d5dfff2db3adc27a36bc1 URL: https://github.com/llvm/llvm-project/commit/5955edf8a453b4b8ff7d5dfff2db3adc27a36bc1 DIFF: https://github.com/llvm/llvm-project/commit/5955edf8a453b4b8ff7d5dfff2db3adc27a36bc1.diff

[Lldb-commits] [PATCH] D132709: [lldb][ClangExpression] Fix LLDB_LOG incorrect format specifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b95b50dd69b: [lldb][ClangExpression] Fix LLDB_LOG incorrect format specifier (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132709/

[Lldb-commits] [lldb] 2b95b50 - [lldb][ClangExpression] Fix LLDB_LOG incorrect format specifier

Author: Michael Buch Date: 2022-08-26T10:06:38+01:00 New Revision: 2b95b50dd69b03be793357cbadae70d413b375a5 URL: https://github.com/llvm/llvm-project/commit/2b95b50dd69b03be793357cbadae70d413b375a5 DIFF: https://github.com/llvm/llvm-project/commit/2b95b50dd69b03be793357cbadae70d413b375a5.diff

[Lldb-commits] [PATCH] D128504: debugserver: spawn process in its own process group

aarzilli added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128504/new/ https://reviews.llvm.org/D128504 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org