wallace updated this revision to Diff 445980.
wallace added a comment.
..
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130054/new/
https://reviews.llvm.org/D130054
Files:
lldb/include/lldb/Target/TraceCursor.h
lldb/include/lldb/Target/TraceDu
clayborg added a comment.
Looks good to me. Jim, anything you still want fixed?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130098/new/
https://reviews.llvm.org/D130098
___
lldb-commits mailing list
ll
fixathon marked 3 inline comments as done.
fixathon added a comment.
Replied to comments
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4685
+lldb::tid_t m_thread_id = LLDB_INVALID_THREAD_ID;
+uint32_t m_thread_index = 0;
std::string m_thread_name;
--
fixathon updated this revision to Diff 445966.
fixathon added a comment.
Addressing comments
Updating D130098: [LLDB][NFC][Reliability] Fix uninitialized variables from
Coverity scan # # Enter a
=
This revision was automatically updated to reflect the committed changes.
zequanwu marked 2 inline comments as done.
Closed by commit rGb8cf916b89d4: [LLDB][NativePDB] Add MSInheritanceAttr when
creating pointer type that is a… (authored by zequanwu).
Changed prior to commit:
https://reviews.ll
Author: Zequan Wu
Date: 2022-07-19T15:36:35-07:00
New Revision: b8cf916b89d4502569680b8b4cb284db5b7e8c4d
URL:
https://github.com/llvm/llvm-project/commit/b8cf916b89d4502569680b8b4cb284db5b7e8c4d
DIFF:
https://github.com/llvm/llvm-project/commit/b8cf916b89d4502569680b8b4cb284db5b7e8c4d.diff
LOG
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Thanks!
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:840
+spelling =
+clang::MSInheritanceAttr::Spelling::Keyword_multiple_inheritance
fixathon marked 6 inline comments as done.
fixathon added a comment.
Respond to comments
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4685
+lldb::tid_t m_thread_id = LLDB_INVALID_THREAD_ID;
+uint32_t m_thread_index = 0;
std::string m_thread_name;
--
jingham added inline comments.
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4685
+lldb::tid_t m_thread_id = LLDB_INVALID_THREAD_ID;
+uint32_t m_thread_index = 0;
std::string m_thread_name;
clayborg wrote:
> jingham wrote:
> > Because of t
clayborg added inline comments.
Comment at: lldb/include/lldb/Core/EmulateInstruction.h:182
eInfoTypeNoArgs
- } InfoType;
+ };
fixathon wrote:
> clayborg wrote:
> > This doesn't fall into the un initialized variable case, I would revert
> > this. You ca
fixathon added a comment.
Adding review comments
Comment at: lldb/include/lldb/Core/EmulateInstruction.h:182
eInfoTypeNoArgs
- } InfoType;
+ };
clayborg wrote:
> This doesn't fall into the un initialized variable case, I would revert this.
> You can a
fixathon updated this revision to Diff 445943.
fixathon marked 13 inline comments as done.
fixathon added a comment.
Update the init value in ObjectFilePECOFF.cpp
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130098/new/
https://reviews.llvm.org/D
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
You missed a few comments. It would also be nice to remove the memset from the
ObjectFilePECOFF by adding "= 0;" to all of the struct definitions in
ObjectFilePECOFF.h that would
zequanwu updated this revision to Diff 445942.
zequanwu marked 3 inline comments as done.
zequanwu edited the summary of this revision.
zequanwu added a comment.
Use PointerToMemberRepresentation in pdb to get inheritance attribute.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIO
fixathon updated this revision to Diff 445937.
fixathon added a comment.
Update code based on revew comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130098/new/
https://reviews.llvm.org/D130098
Files:
lldb/include/lldb/Core/EmulateInstruct
clayborg added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.cpp:96
+ return LoadOrGetSection(eSectionTypeDWARFDebugMacro,
+ eSectionTypeDWARFDebugMacro, m_data_debug_macro);
}
Never mind me! Just checke
clayborg added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.cpp:95-96
const DWARFDataExtractor &DWARFContext::getOrLoadMacroData() {
- return LoadOrGetSection(eSectionTypeDWARFDebugMacro, llvm::None,
- m_data_debug_macr
clayborg requested changes to this revision.
clayborg added inline comments.
Comment at: lldb/include/lldb/Core/EmulateInstruction.h:182
eInfoTypeNoArgs
- } InfoType;
+ };
This doesn't fall into the un initialized variable case, I would revert this.
You
jingham added inline comments.
Comment at: lldb/source/Plugins/Language/ObjC/NSDictionary.cpp:140
DataDescriptor_64 *m_data_64 = nullptr;
- lldb::addr_t m_data_ptr;
+ lldb::addr_t m_data_ptr = {};
CompilerType m_pair_type;
jingham wrote:
> Invalid address
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
Thanks for finding these uninitialized variables. That's a valuable exercise.
Couple of comments;
Most of the time you set lldb::addr_t's to 0, they probably should have been
se
fixathon created this revision.
Herald added a project: All.
fixathon requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Improve LLDB reliability by fixing the following "uninitialized variables"
static code inspection warnings from
scan.cove
jj10306 added a comment.
AFAICT this doesn't handle the TSCs we get for CPU change events through the
context switch traces, is that correct?
This will be very useful to have for visualization purposes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/
jj10306 requested changes to this revision.
jj10306 added inline comments.
This revision now requires changes to proceed.
Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp:183
-DecodedThread::TscRange::TscRange(std::map::const_iterator
it,
+DecodedThread::TscRan
DavidSpickett marked an inline comment as done.
DavidSpickett added a comment.
> I am wondering if we should also test memory reads with correct/wrong tags
> for corefiles as well? Do you see any value on doing it or have done it
> already in above test and i skipped it?
You mean "memory read
omjavaid added a comment.
I am wondering if we should also test memory reads with correct/wrong tags for
corefiles as well? Do you see any value on doing it or have done it already in
above test and i skipped it?
Comment at: lldb/test/API/linux/aarch64/mte_core_file/main.c:1
omjavaid accepted this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.
This looks good to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129487/new/
https://reviews.llvm.org/D129487
_
tschuett added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugMacro.h:27
+struct DWARFStrOffsetsInfo {
+ lldb::offset_t cu_offset;
If you would use a class instead of the struct, you could hide the member
variables.
The class var
Author: Jason Molenda
Date: 2022-07-19T01:40:40-07:00
New Revision: 2149455cdc6f5b0d418a715fb3a8a0e4ecccb3aa
URL:
https://github.com/llvm/llvm-project/commit/2149455cdc6f5b0d418a715fb3a8a0e4ecccb3aa
DIFF:
https://github.com/llvm/llvm-project/commit/2149455cdc6f5b0d418a715fb3a8a0e4ecccb3aa.diff
kpdev42 created this revision.
kpdev42 added reviewers: clayborg, davide, k8stone, DavidSpickett.
kpdev42 added a project: LLDB.
Herald added subscribers: Enna1, JDevlieghere, mgorny.
Herald added a project: All.
kpdev42 requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald
29 matches
Mail list logo
