[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

2022-07-17 Thread Matheus Izvekov via Phabricator via lldb-commits
mizvekov updated this revision to Diff 445365. mizvekov marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTe

[Lldb-commits] [lldb] 8b3ed1f - Remove redundant return statements (NFC)

2022-07-17 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2022-07-17T15:37:46-07:00 New Revision: 8b3ed1fa984b07c88f218d0ddc6b3e2c0629a9fa URL: https://github.com/llvm/llvm-project/commit/8b3ed1fa984b07c88f218d0ddc6b3e2c0629a9fa DIFF: https://github.com/llvm/llvm-project/commit/8b3ed1fa984b07c88f218d0ddc6b3e2c0629a9fa.diff L

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

2022-07-17 Thread Matheus Izvekov via Phabricator via lldb-commits
mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/lib/Sema/TypeLocBuilder.cpp:159 - assert(Capacity - Index == TypeLoc::getFullDataSizeForType(T) && + unsigned FDSz = TypeLoc::getFullDataSizeForType(T); + assert(Capacity - Index ==

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

2022-07-17 Thread Matheus Izvekov via Phabricator via lldb-commits
mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 445319. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace

[Lldb-commits] [PATCH] D129962: [LLDB][DataFormatter] Add support for std::__map_const_iterator

2022-07-17 Thread Michael Buch via Phabricator via lldb-commits
Michael137 created this revision. Michael137 added reviewers: aprantl, jingham. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds support for formatting `std::map::const_iterator`. It's

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

2022-07-17 Thread Matheus Izvekov via Phabricator via lldb-commits
mizvekov added a comment. In D112374#3658059 , @kimgr wrote: > Haha. Pun intended? :-) Yes :-) > As you noticed, it's not our tests that care about the AST, it's the tool > itself. IWYU has been around since 2010-11, so there's probably lots of code >

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

2022-07-17 Thread Kim Gräsman via Phabricator via lldb-commits
kimgr added a comment. In D112374#3657640 , @mizvekov wrote: > In D112374#3657472 , @kimgr wrote: > >> I'm coming at this from pretty far away, so there's very likely lots of >> details that I'm overlooking. But

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

2022-07-17 Thread Michael Buch via Phabricator via lldb-commits
Michael137 updated this revision to Diff 445307. Michael137 added a comment. - Remove redundant moves Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 Files: lldb/include/lldb/Expression/Materializer.h