[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

mib added a comment. What happens if you try to call __str__ after your change ? I have no objection with this change, I think rather it will greatly improve manipulating SBTypes in the interpreter ! Just making sure this passes the test suite and doesn't break the previous behavior Repositor

[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

kastiglione created this revision. kastiglione added reviewers: jingham, JDevlieghere, mib. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When using the `script` Python repl, SB objects are printed

[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

wallace created this revision. wallace added a reviewer: jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This improves several things and addresses comments up to the diff [11] in this stack.

[Lldb-commits] [PATCH] D125897: [trace][intelpt] Support system-wide tracing [9] - Collect and return context switch traces

wallace added inline comments. Comment at: lldb/include/lldb/Utility/TraceIntelPTGDBRemotePackets.h:26-28 static const char *kProcFsCpuInfo; static const char *kTraceBuffer; + static const char *kPerfContextSwitchTrace; jj10306 wrote: > nit: these are just

[Lldb-commits] [PATCH] D127378: [lldb] Use assertState in more tests (NFC)

kastiglione added a comment. @JDevlieghere `assertEquals` is the deprecated name, `assertEqual` is the Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127378/new/ https://reviews.llvm.org/D127378 ___ lldb-

[Lldb-commits] [PATCH] D127378: [lldb] Use assertState in more tests (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG47c4c6a7469f: [lldb] Use assertState in more tests (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127378/new/ https://review

[Lldb-commits] [lldb] 47c4c6a - [lldb] Use assertState in more tests (NFC)

Author: Dave Lee Date: 2022-06-09T16:18:07-07:00 New Revision: 47c4c6a7469f3fd3e364a9b3669838686d4f1de6 URL: https://github.com/llvm/llvm-project/commit/47c4c6a7469f3fd3e364a9b3669838686d4f1de6 DIFF: https://github.com/llvm/llvm-project/commit/47c4c6a7469f3fd3e364a9b3669838686d4f1de6.diff LOG:

[Lldb-commits] [PATCH] D127437: [LLDB][Docs] Fix formatting of example code-block

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127437/new/ https://reviews.llvm.org/D127437 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D125850: [trace][intelpt] Support system-wide tracing [8] - Improve the single buffer perf_event configuration

wallace added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTSingleBufferTrace.cpp:186 attr.exclude_kernel = 1; - attr.sample_type = PERF_SAMPLE_TIME; - attr.sample_id_all = 1; jj10306 wrote: > won't we need this in order to get timest

[Lldb-commits] [lldb] 25c8a06 - [lldb] Set COFF module ABI from default triple and make it an option

Author: Alvin Wong Date: 2022-06-09T22:43:33+03:00 New Revision: 25c8a061c5739677d2fc0af29a8cc9520207b923 URL: https://github.com/llvm/llvm-project/commit/25c8a061c5739677d2fc0af29a8cc9520207b923 DIFF: https://github.com/llvm/llvm-project/commit/25c8a061c5739677d2fc0af29a8cc9520207b923.diff LO

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF module ABI from default triple and make it an option

This revision was automatically updated to reflect the committed changes. Closed by commit rG25c8a061c573: [lldb] Set COFF module ABI from default triple and make it an option (authored by alvinhochun, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D127437: [LLDB][Docs] Fix formatting of example code-block

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Tested by building the `docs-lldb-html` target and confirming the code-block ren

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

alvinhochun created this revision. alvinhochun added reviewers: JDevlieghere, labath, mstorsjo. Herald added subscribers: jsji, pengfei. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes an

[Lldb-commits] [PATCH] D125503: [trace][intelpt] Support system-wide tracing [7] - Create a base IntelPTProcessTrace class

wallace added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTCollector.h:73 + /// The target process. NativeProcessProtocol &m_process; /// Threads traced due to "thread tracing" jj10306 wrote: > Could this be moved to be a part of t

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:180 if (!Loc) - return Callback(Loc.takeError()); -if (*Loc) + consumeError(Loc.takeError()); +else if (*Loc)

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu updated this revision to Diff 435625. zequanwu added a comment. Add missing check for Expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125509/new/ https://reviews.llvm.org/D125509 Files: lldb/include/lldb/Expression/DWARFExpressi

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:180 if (!Loc) - return Callback(Loc.takeError()); -if (*Loc) + consumeError(Loc.takeError()); +else if (*Loc) rnk wrote: > Did this change cause the pres

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

alvinhochun updated this revision to Diff 435605. alvinhochun added a comment. Rebased patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127234/new/ https://reviews.llvm.org/D127234 Files: lldb/include/lldb/Interpreter/OptionValueDictionary.h

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF module ABI from default triple and make it an option

alvinhochun updated this revision to Diff 435604. alvinhochun added a comment. Rebased patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127048/new/ https://reviews.llvm.org/D127048 Files: lldb/include/lldb/Core/PluginManager.h lldb/source/C

[Lldb-commits] [lldb] 0bc291a - [lldb] Add a reference to the "On Demand Symbols" docs.

Author: Jonas Devlieghere Date: 2022-06-09T09:14:56-07:00 New Revision: 0bc291ad35a26982c13ea0b5e19890fdbf2674f1 URL: https://github.com/llvm/llvm-project/commit/0bc291ad35a26982c13ea0b5e19890fdbf2674f1 DIFF: https://github.com/llvm/llvm-project/commit/0bc291ad35a26982c13ea0b5e19890fdbf2674f1.d

[Lldb-commits] [PATCH] D127410: [lldb] Add table with custom LLDB asserts

This revision was automatically updated to reflect the committed changes. Closed by commit rG6565580f1b40: [lldb] Add table with custom LLDB asserts to the docs (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [lldb] 6565580 - [lldb] Add table with custom LLDB asserts to the docs

Author: Jonas Devlieghere Date: 2022-06-09T09:14:56-07:00 New Revision: 6565580f1b40edf8d9339fa849f4a1778d8816a9 URL: https://github.com/llvm/llvm-project/commit/6565580f1b40edf8d9339fa849f4a1778d8816a9 DIFF: https://github.com/llvm/llvm-project/commit/6565580f1b40edf8d9339fa849f4a1778d8816a9.d

[Lldb-commits] [lldb] 5a10620 - [lldb] Fix code blocks in docs/use/intel_pt.rst

Author: Jonas Devlieghere Date: 2022-06-09T09:14:56-07:00 New Revision: 5a1062055e44f4b9623800aeaed06dc1e405a9d9 URL: https://github.com/llvm/llvm-project/commit/5a1062055e44f4b9623800aeaed06dc1e405a9d9 DIFF: https://github.com/llvm/llvm-project/commit/5a1062055e44f4b9623800aeaed06dc1e405a9d9.d

[Lldb-commits] [PATCH] D127410: [lldb] Add table with custom LLDB asserts

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Excellent, thanks for doing this, these are really handy asserts! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127410/new/ https://reviews.llvm.org/D127410 ___

[Lldb-commits] [PATCH] D127410: [lldb] Add table with custom LLDB asserts

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a project: All. JDevlieghere requested review of this revision. Add table with custom LLDB asserts to the docs. https://reviews.llvm.org/D127410 Files: lldb/docs/resources/test.rst Index: lldb/docs/reso

[Lldb-commits] [PATCH] D127378: [lldb] Use assertState in more tests (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. In never realized we had both `assertEqual` and `assertEquals`. Great... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127378/new/ h

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

thieta added a comment. FYI: I helped @PatriosTheGreat to commit this after he asked for help in discord. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 ___ l

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

This revision was automatically updated to reflect the committed changes. Closed by commit rGa33983729df6: Pass plugin_name in SBProcess::SaveCore (authored by PatriosTheGreat, committed by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12532

[Lldb-commits] [lldb] a339837 - Pass plugin_name in SBProcess::SaveCore

Author: Levon Date: 2022-06-09T16:29:50+02:00 New Revision: a33983729df641559b639a48d1b65e2de55f6e90 URL: https://github.com/llvm/llvm-project/commit/a33983729df641559b639a48d1b65e2de55f6e90 DIFF: https://github.com/llvm/llvm-project/commit/a33983729df641559b639a48d1b65e2de55f6e90.diff LOG: Pa

[Lldb-commits] [PATCH] D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID

RamNalamothu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48865/new/ https://reviews.llvm.org/D48865 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50304/new/ https://reviews.llvm.org/D50304 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D127001: [trace][intelpt] Support system-wide tracing [16] - Create threads automatically from context switch data in the post-mortem case

jj10306 requested changes to this revision. jj10306 added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTSessionFileParser.cpp:167-170 + // A list of known threads for the given process. When co

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8daf4a707ad: [lldb] Add gnu-debuglink support for Windows PE/COFF (authored by alvinhochun, committed by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D126367?vs=435214&id=435498#toc Re

[Lldb-commits] [lldb] 39c4ac1 - [lldb] Silence a GCC warning about missing returns after a fully covered switch. NFC.

Author: Martin Storsjö Date: 2022-06-09T14:39:33+03:00 New Revision: 39c4ac140d1ee67d152c990f5d16a8df98155cbc URL: https://github.com/llvm/llvm-project/commit/39c4ac140d1ee67d152c990f5d16a8df98155cbc DIFF: https://github.com/llvm/llvm-project/commit/39c4ac140d1ee67d152c990f5d16a8df98155cbc.diff

[Lldb-commits] [lldb] c8daf4a - [lldb] Add gnu-debuglink support for Windows PE/COFF

Author: Alvin Wong Date: 2022-06-09T14:39:33+03:00 New Revision: c8daf4a707ad502b9694461246114bba01af5222 URL: https://github.com/llvm/llvm-project/commit/c8daf4a707ad502b9694461246114bba01af5222 DIFF: https://github.com/llvm/llvm-project/commit/c8daf4a707ad502b9694461246114bba01af5222.diff LO

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

alvinhochun added a comment. Ah I did not realize that GNU ld also has the option to add the same build id for mingw. I am fine with you committing these changes. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126367/new/ https://reviews.ll

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

mstorsjo added a reviewer: omjavaid. mstorsjo added a comment. (I guess this one might need some updates after D127048 is finalized?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127234/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

mstorsjo added a comment. When testing this patch, I ran into crashes in the `SymbolFile/NativePDB/load-pdb.cpp` testcase. To fix it, I had to add a change like this: diff --git a/lldb/source/Plugins/SymbolVendor/PECOFF/SymbolVendorPECOFF.cpp b/lldb/source/Plugins/SymbolVendor/PECOFF/SymbolV

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF module ABI from default triple and make it an option

omjavaid added a comment. >> 1. This rev apparently assumes x86_64 only but what about Arm/AArch64? > > Where do you get that impression? This should all be architecture independent > (or done in the same way for all architectures). Sorry I just brushed over the code and saw x86_64 specifc obj f