[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

jingham created this revision. jingham added reviewers: JDevlieghere, kastiglione. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Sometimes you have a complex set of breakpoints, some enabled and some n

[Lldb-commits] [PATCH] D126507: [lldb/fuzzer] Moving target fuzzer into separate subdirectory

This revision was automatically updated to reflect the committed changes. Closed by commit rG5451c4b4fb54: [lldb/fuzzer] Moving target fuzzer into separate subdirectory (authored by cassanova, committed by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D126507?vs=432414&id=432

[Lldb-commits] [lldb] 5451c4b - [lldb/fuzzer] Moving target fuzzer into separate subdirectory

Author: Chelsea Cassanova Date: 2022-05-26T17:05:14-07:00 New Revision: 5451c4b4fb5448ac256327db4f78c996114ca4ec URL: https://github.com/llvm/llvm-project/commit/5451c4b4fb5448ac256327db4f78c996114ca4ec DIFF: https://github.com/llvm/llvm-project/commit/5451c4b4fb5448ac256327db4f78c996114ca4ec.d

[Lldb-commits] [PATCH] D126507: [lldb/fuzzer] Moving target fuzzer into separate subdirectory

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126507/new/ https://reviews.llvm.org/D126507 __

[Lldb-commits] [PATCH] D126507: [lldb/fuzzer] Moving target fuzzer into separate subdirectory

cassanova created this revision. cassanova added reviewers: mib, JDevlieghere. cassanova added a project: LLDB. Herald added a subscriber: mgorny. Herald added a project: All. cassanova requested review of this revision. Herald added a subscriber: lldb-commits. Moving lldb-target-fuzzer into its o

[Lldb-commits] [PATCH] D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created

This revision was automatically updated to reflect the committed changes. Closed by commit rG134d7f9a4b97: Store a by name list of signals with their actions in the Target (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126259/ne

[Lldb-commits] [lldb] 134d7f9 - Store a by name list of signals with their actions in the Target

Author: Jim Ingham Date: 2022-05-26T14:50:33-07:00 New Revision: 134d7f9a4b97e9035150d970bd9e376043c4577e URL: https://github.com/llvm/llvm-project/commit/134d7f9a4b97e9035150d970bd9e376043c4577e DIFF: https://github.com/llvm/llvm-project/commit/134d7f9a4b97e9035150d970bd9e376043c4577e.diff LO

[Lldb-commits] [PATCH] D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created

jingham added inline comments. Comment at: lldb/source/Commands/CommandObjectProcess.cpp:1477-1479 +bool only_target_values; +bool do_clear; +bool dummy; JDevlieghere wrote: > jingham wrote: > > JDevlieghere wrote: > > > Let's initialize these to the

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Apparently closing a revision requires it to be accepted first. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68671/new/ https://reviews.llvm.org

[Lldb-commits] [lldb] 75acec8 - [lldb] Fix enums-layout test on Windows

Author: Stella Stamenova Date: 2022-05-26T12:16:52-07:00 New Revision: 75acec818e3a419836cf4827eb64faee719becb8 URL: https://github.com/llvm/llvm-project/commit/75acec818e3a419836cf4827eb64faee719becb8 DIFF: https://github.com/llvm/llvm-project/commit/75acec818e3a419836cf4827eb64faee719becb8.di

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

This revision was automatically updated to reflect the committed changes. Closed by commit rG84b9985f5f63: [lldb] Fix broken bad-address-breakpoint test (authored by hawkinsw, committed by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [lldb] 84b9985 - [lldb] Fix broken bad-address-breakpoint test

Author: Will Hawkins Date: 2022-05-26T12:16:11-07:00 New Revision: 84b9985f5f63509c3f99e2ebaa488f0a0ef33d49 URL: https://github.com/llvm/llvm-project/commit/84b9985f5f63509c3f99e2ebaa488f0a0ef33d49 DIFF: https://github.com/llvm/llvm-project/commit/84b9985f5f63509c3f99e2ebaa488f0a0ef33d49.diff

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. A few things to fix but nothing serious. Nice patch! We also need a test for this. I would add a test to lldb/test/API/functionalities/archives/TestBSDArchives.py

[Lldb-commits] [lldb] ea6d0c4 - One further tweak for realpathing filepath to match dyld

Author: Jason Molenda Date: 2022-05-26T11:24:56-07:00 New Revision: ea6d0c4b2a1ec9c12aa5513ddf574f3146cf9025 URL: https://github.com/llvm/llvm-project/commit/ea6d0c4b2a1ec9c12aa5513ddf574f3146cf9025 DIFF: https://github.com/llvm/llvm-project/commit/ea6d0c4b2a1ec9c12aa5513ddf574f3146cf9025.diff

[Lldb-commits] [PATCH] D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Commands/CommandObjectProcess.cpp:1477-1479 +bool only_target_values; +bool do_clear; +bool dummy; jingh

[Lldb-commits] [lldb] 8a46728 - Defer source path remap tilde expansion until source file use

Author: Jason Molenda Date: 2022-05-26T11:12:37-07:00 New Revision: 8a467284d5608522fdf80cb78056d42d28f5ebb5 URL: https://github.com/llvm/llvm-project/commit/8a467284d5608522fdf80cb78056d42d28f5ebb5 DIFF: https://github.com/llvm/llvm-project/commit/8a467284d5608522fdf80cb78056d42d28f5ebb5.diff

[Lldb-commits] [lldb] bd67468 - Check that a FileSpec has a Directory component before using

Author: Jason Molenda Date: 2022-05-26T11:12:37-07:00 New Revision: bd67468645c08a96aec7839c30385956edd88021 URL: https://github.com/llvm/llvm-project/commit/bd67468645c08a96aec7839c30385956edd88021 DIFF: https://github.com/llvm/llvm-project/commit/bd67468645c08a96aec7839c30385956edd88021.diff

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

jingham added a comment. Herald added a project: All. Just for history's sake, this change was committed (738af7a6241c9). I put in the Differential Revision line in the changelog, so I'm not sure why this didn't get marked as closed... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

PRESIDENT810 created this revision. PRESIDENT810 added reviewers: clayborg, jingham, jasonmolenda. Herald added a project: All. PRESIDENT810 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes https://github.com/llvm/llvm-project/iss

[Lldb-commits] [PATCH] D126435: NFC delay tilde expansion on source path remappings until we are opening a source file

jasonmolenda added a comment. Temporarily reverted for an x86_64 debian bot failure. Probably my comparison of the first character of the FileSpec path with '~' in resolve_tilde() is crashing with some code path that hands us an empty/uninitialized FileSpec. Will try again tomorrow after looki

[Lldb-commits] [lldb] 56ac85a - Revert "Defer source path remap tilde expansion until source file use"

Author: Jason Molenda Date: 2022-05-26T00:46:54-07:00 New Revision: 56ac85a20fb98393d033582ee4dc86993843726d URL: https://github.com/llvm/llvm-project/commit/56ac85a20fb98393d033582ee4dc86993843726d DIFF: https://github.com/llvm/llvm-project/commit/56ac85a20fb98393d033582ee4dc86993843726d.diff

[Lldb-commits] [lldb] c274b6e - Defer source path remap tilde expansion until source file use

Author: Jason Molenda Date: 2022-05-26T00:30:12-07:00 New Revision: c274b6e5830ea88d3f55d6dc1d2b99e38cf6595e URL: https://github.com/llvm/llvm-project/commit/c274b6e5830ea88d3f55d6dc1d2b99e38cf6595e DIFF: https://github.com/llvm/llvm-project/commit/c274b6e5830ea88d3f55d6dc1d2b99e38cf6595e.diff

[Lldb-commits] [PATCH] D126435: NFC delay tilde expansion on source path remappings until we are opening a source file

This revision was automatically updated to reflect the committed changes. Closed by commit rGc274b6e5830e: Defer source path remap tilde expansion until source file use (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126435/

[Lldb-commits] [lldb] 8ee35c5 - Update three tests to realpath paths that we compare to dyld paths

Author: Jason Molenda Date: 2022-05-26T00:21:44-07:00 New Revision: 8ee35c5558aa86e3be5f2882f1db030d6281578f URL: https://github.com/llvm/llvm-project/commit/8ee35c5558aa86e3be5f2882f1db030d6281578f DIFF: https://github.com/llvm/llvm-project/commit/8ee35c5558aa86e3be5f2882f1db030d6281578f.diff

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3538413 , @dblaikie wrote: > In D122974#3536342 , @llunak wrote: > >> D124704 adds a unittest that compares >> StringMap::hash() to a known ha