[Lldb-commits] [PATCH] D125850: [trace][intelpt] Support system-wide tracing [7] - Improve the single buffer perf_event configuration

wallace created this revision. wallace added a reviewer: jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We were setting some events to be written in the data buffer of the perf_event, but we do

[Lldb-commits] [PATCH] D125844: [LLDB][NativePDB] Check for missing type info to avoid crash.

zequanwu created this revision. zequanwu added a reviewer: labath. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. NativePDB often assumes that all debug info are available. This is one step to make it

[Lldb-commits] [PATCH] D125503: [trace][intelpt] Support system-wide tracing [7] - Create a base IntelPTProcessTrace class

wallace updated this revision to Diff 430182. wallace added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125503/new/ https://reviews.llvm.org/D125503 Files: lldb/source/Plugins/Process/Linux/IntelPTCollector.cpp lldb/source/

[Lldb-commits] [lldb] 1188faa - [trace][intelpt] Support system-wide tracing [6] - Break IntelPTCollector into smaller files and minor refactor

Author: Walter Erquinigo Date: 2022-05-17T12:46:54-07:00 New Revision: 1188faa7ab4b005e3ee28f30055de2f76e210eb8 URL: https://github.com/llvm/llvm-project/commit/1188faa7ab4b005e3ee28f30055de2f76e210eb8 DIFF: https://github.com/llvm/llvm-project/commit/1188faa7ab4b005e3ee28f30055de2f76e210eb8.di

[Lldb-commits] [PATCH] D125047: [trace][intelpt] Support system-wide tracing [6] - Break IntelPTCollector into smaller files and minor refactor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1188faa7ab4b: [trace][intelpt] Support system-wide tracing [6] - Break IntelPTCollector into… (authored by Walter Erquinigo ). Repo

[Lldb-commits] [lldb] 1637545 - [trace][intelpt] Support system-wide tracing [5] - Disable/enable per-core tracing based on the process state

Author: Walter Erquinigo Date: 2022-05-17T12:46:54-07:00 New Revision: 1637545f689b8c4ef888ca385de75982a6a932e3 URL: https://github.com/llvm/llvm-project/commit/1637545f689b8c4ef888ca385de75982a6a932e3 DIFF: https://github.com/llvm/llvm-project/commit/1637545f689b8c4ef888ca385de75982a6a932e3.di

[Lldb-commits] [lldb] 1f49714 - [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

Author: Walter Erquinigo Date: 2022-05-17T12:46:54-07:00 New Revision: 1f49714d3e19502753fcea7ad8378a194222328f URL: https://github.com/llvm/llvm-project/commit/1f49714d3e19502753fcea7ad8378a194222328f DIFF: https://github.com/llvm/llvm-project/commit/1f49714d3e19502753fcea7ad8378a194222328f.di

[Lldb-commits] [PATCH] D124962: [trace][intelpt] Support system-wide tracing [5] - Disable/enable per-core tracing based on the process state

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1637545f689b: [trace][intelpt] Support system-wide tracing [5] - Disable/enable per-core… (authored by Walter Erquinigo ). Changed

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f49714d3e19: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on… (authored by Walter Erquinigo ). Repo

[Lldb-commits] [PATCH] D124962: [trace][intelpt] Support system-wide tracing [5] - Disable/enable per-core tracing based on the process state

jj10306 accepted this revision. jj10306 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/Linux/IntelPTSingleBufferTrace.cpp:211 +Error IntelPTSingleBufferTrace::SetCollectionState( +TraceCollectionState new_stat

[Lldb-commits] [lldb] 26d83a4 - [NFC][lldb][trace] Use uint64_t when decoding and enconding json

Author: Walter Erquinigo Date: 2022-05-17T11:08:04-07:00 New Revision: 26d83a431ecbc79d227b0f3b92b0fb2166a7c7d7 URL: https://github.com/llvm/llvm-project/commit/26d83a431ecbc79d227b0f3b92b0fb2166a7c7d7 DIFF: https://github.com/llvm/llvm-project/commit/26d83a431ecbc79d227b0f3b92b0fb2166a7c7d7.di

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw added a comment. Just wanted to see if there was anything else I could do to help make this patch acceptable, @JDevlieghere and @jingham . Thanks again for all your help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://r

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

DavidSpickett updated this revision to Diff 430092. DavidSpickett added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Add a release note before I inevitably forget. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[Lldb-commits] [PATCH] D125073: [lldb-vscode] Fix data race in lldb-vscode when running with ThreadSanitizer

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe738c9d1c16: [lldb-vscode] Fix data race in lldb-vscode when running with ThreadSanitizer (authored by Walter Erquinigo ). Herald added a project: LLDB. Herald added a subscriber: lldb-co

[Lldb-commits] [lldb] be738c9 - [lldb-vscode] Fix data race in lldb-vscode when running with ThreadSanitizer

Author: Walter Erquinigo Date: 2022-05-17T09:11:45-07:00 New Revision: be738c9d1c1612f5cb0a84227f5ced2726ae609e URL: https://github.com/llvm/llvm-project/commit/be738c9d1c1612f5cb0a84227f5ced2726ae609e DIFF: https://github.com/llvm/llvm-project/commit/be738c9d1c1612f5cb0a84227f5ced2726ae609e.di

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

DavidSpickett updated this revision to Diff 430088. DavidSpickett added a comment. Move variables closer to usage in DumpRegion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111791/new/ https://reviews.llvm.org/D111791 Files: lldb/source/Comman

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Minor nit but LGTM Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1707 +ConstString name = range_info.GetName(); +ConstString section_name; +

[Lldb-commits] [PATCH] D108228: Fix error handling in the libcxx std::string formatter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7afd257ff8a4: Fix the std::string formatter to report errors in the case where the (authored by jingham). Herald added a project: All. Changed prior

[Lldb-commits] [lldb] 7afd257 - Fix the std::string formatter to report errors in the case where the

Author: Jim Ingham Date: 2022-05-17T08:22:30-07:00 New Revision: 7afd257ff8a45a348767b4432abc6f4f105fc376 URL: https://github.com/llvm/llvm-project/commit/7afd257ff8a45a348767b4432abc6f4f105fc376 DIFF: https://github.com/llvm/llvm-project/commit/7afd257ff8a45a348767b4432abc6f4f105fc376.diff LO

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

DavidSpickett updated this revision to Diff 430055. DavidSpickett added a comment. Figured that the usage was now a bit confusing. Though I'm not sure how to write "either" in symbols, I see {A|B} used in some other tools, I've just stuck with the word "or" for now. Doesn't matter too much, the

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

DavidSpickett updated this revision to Diff 430042. DavidSpickett added a comment. Herald added a project: All. Correct help text. Make a parameter const (uses the previous stacked change). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111791/new/

[Lldb-commits] [PATCH] D125786: [lldb] const a couple of getters on MemoryRegionInfo

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. GetDirtyPageList was being assigned to const & in most places anyway. If you wanted to change the list you'd mak