[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan added a comment. Thanks for the context. Fixed in https://reviews.llvm.org/D124499. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 ___ lldb-commits

[Lldb-commits] [PATCH] D124499: Rename conflict testcase

yinghuitan created this revision. yinghuitan added reviewers: jasonmolenda, clayborg, JDevlieghere, labath, jdoerfert, jingham. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This diff solves the fo

[Lldb-commits] [lldb] a2681c4 - Don't push null ExecutionContext on CommandInterp exectx stack

Author: Jason Molenda Date: 2022-04-26T18:32:18-07:00 New Revision: a2681c43308c5d1748a7ade4df5188972a3dd8aa URL: https://github.com/llvm/llvm-project/commit/a2681c43308c5d1748a7ade4df5188972a3dd8aa DIFF: https://github.com/llvm/llvm-project/commit/a2681c43308c5d1748a7ade4df5188972a3dd8aa.diff

[Lldb-commits] [PATCH] D111209: Don't push null ExecutionContext on CommandInterpreter exectx stack

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGa2681c43308c: Don't push null ExecutionContext on CommandInterp exectx stack (authored by jasonmolenda). Changed prior to

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

jasonmolenda added a comment. Thanks! Yeah, I only noticed because lldb-dotest threw an error when I was trying to run a test case earlier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 __

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan added a comment. @jasonmolenda, thanks, I discovered a bit late that testcases can't have duplicate names; I fixed one case in the patch but missed these two. Will add a follow-up patch. I would be great if we have a linter/script to detect/warn duplications, not sure how hard to add

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

jasonmolenda added a comment. Hi, I noticed that we have two tests with the same name, lldb/test/API/lang/c/shared_lib/TestSharedLib.py lldb/test/API/symbol_ondemand/shared_library/TestSharedLib.py Can you rename your newly added test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D124492: Update CFA to be in terms of $sp instead of $fp when $fp is overwritten in epilogue on AArch64

jasonmolenda created this revision. jasonmolenda added reviewers: jingham, JDevlieghere. jasonmolenda added a project: LLDB. Herald added a subscriber: kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. When we can t

[Lldb-commits] [PATCH] D123954: [lldb] Add setting for max depth of value object printing (NFC)

shafik added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:718 + /// been told. + ChildrenOmissionWarningStatus m_truncation_warning; + /// Whether we reached the maximum child nesting depth and whether the user Why not use in

[Lldb-commits] [lldb] 0ffcec4 - Fix missing import for test

Author: Jeffrey Tan Date: 2022-04-26T16:40:45-07:00 New Revision: 0ffcec418e45210a9c25632e7fe0a3ef0629b652 URL: https://github.com/llvm/llvm-project/commit/0ffcec418e45210a9c25632e7fe0a3ef0629b652 DIFF: https://github.com/llvm/llvm-project/commit/0ffcec418e45210a9c25632e7fe0a3ef0629b652.diff L

[Lldb-commits] [PATCH] D124479: Fix missing import for test

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ffcec418e45: Fix missing import for test (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124479/new/ https://reviews.llvm.org/D1244

[Lldb-commits] [PATCH] D123954: [lldb] Add setting for max depth of value object printing (NFC)

kastiglione updated this revision to Diff 425338. kastiglione added a comment. Herald added a subscriber: lldb-commits. Updated for code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123954/new/ https://reviews.llvm.org/D123954 Files: ll

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan added a comment. Another patch to fix the missing import: https://reviews.llvm.org/D124479 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 ___ lldb-c

[Lldb-commits] [PATCH] D124479: Fix missing import for test

yinghuitan created this revision. yinghuitan added reviewers: clayborg, JDevlieghere, labath, jingham. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The last fix missed an import in one test file ca

[Lldb-commits] [PATCH] D124471: Disable symbol on-demand feature for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGd738d4717f6d: Disable symbol on-demand feature for Windows (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124471/new/ https://revie

[Lldb-commits] [lldb] d738d47 - Disable symbol on-demand feature for Windows

Author: Jeffrey Tan Date: 2022-04-26T13:35:34-07:00 New Revision: d738d4717f6da88494683da62648f91f04f7c8ce URL: https://github.com/llvm/llvm-project/commit/d738d4717f6da88494683da62648f91f04f7c8ce DIFF: https://github.com/llvm/llvm-project/commit/d738d4717f6da88494683da62648f91f04f7c8ce.diff L

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan added a comment. @stella.stamenova, thanks for the heads-up. I am fixing this in https://reviews.llvm.org/D124471. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 _

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

stella.stamenova added a comment. Looks like this broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/18228 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631

[Lldb-commits] [PATCH] D124471: Disable symbol on-demand feature for Windows

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, JDevlieghere, jdoerfert, DavidSpickett. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Symbol on-demand featu

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b81192d462b: Introduce new symbol on-demand for debug info (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [lldb] 7b81192 - Introduce new symbol on-demand for debug info

Author: Jeffrey Tan Date: 2022-04-26T10:42:06-07:00 New Revision: 7b81192d462bbd8031d5c665e29cd6b4c0c6887a URL: https://github.com/llvm/llvm-project/commit/7b81192d462bbd8031d5c665e29cd6b4c0c6887a DIFF: https://github.com/llvm/llvm-project/commit/7b81192d462bbd8031d5c665e29cd6b4c0c6887a.diff L

[Lldb-commits] [PATCH] D124430: [lldb] Remove Python 2 checks from the test suite

clayborg added a comment. Are we removing Python2 support? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124430/new/ https://reviews.llvm.org/D124430 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [PATCH] D124429: [lldb] Remove Python 2 support from the ScriptInterpreter plugin

lanza accepted this revision. lanza added a comment. Yay, thanks Jonas! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124429/new/ https://reviews.llvm.org/D124429 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [PATCH] D124370: [lldb] Fix PR54761

labath planned changes to this revision. labath added a comment. In D124370#3472394 , @clayborg wrote: > So I believe the reason we need to be able to add methods to a class is for > templates. Templates in DWARF are really poorly emitted all in the name

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp:288 + if (lldb::ABISP abi_sp = GetABI()) +addr = abi_sp->FixDataAddress(addr); + omjavaid wrote: > Is this a candidate for FixAnyAddress ? Absolutely. I

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. LGTM. With a minor nit fix about FixAnyAddress vs FixDataAddress if required. Comment at: lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp:288 + if (lldb::ABISP a