[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

2022-04-24 Thread jeffrey tan via Phabricator via lldb-commits
yinghuitan updated this revision to Diff 424808. yinghuitan marked 3 inline comments as done. yinghuitan added a comment. Incorporate feedback and update summary with follow-up todos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https:

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

2022-04-24 Thread jeffrey tan via Phabricator via lldb-commits
yinghuitan marked 8 inline comments as done. yinghuitan added a comment. Thanks for all the feedback. I will address the comments and add @clayborg's follow-up suggestions into summary. Comment at: lldb/source/Symbol/SymbolFileOnDemand.cpp:47 +lldb::LanguageType SymbolFileOnDe

[Lldb-commits] [PATCH] D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class.

2022-04-24 Thread jeffrey tan via Phabricator via lldb-commits
yinghuitan updated this revision to Diff 424794. yinghuitan added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124110/new/ https://reviews.llvm.org/D124110 Files: lldb/include/lldb/Symbol/SymbolFile.h lldb/s