[Lldb-commits] [PATCH] D120792: [lldb] Fix python errors in gdbremote.py

ddcc created this revision. ddcc added reviewers: kastiglione, jingham, JDevlieghere, clayborg. Herald added a project: All. ddcc requested review of this revision. Herald added a project: LLDB. Fix exceptions encountered while debugging gdb protocol Repository: rG LLVM Github Monorepo https:

[Lldb-commits] [PATCH] D120762: [lldb] Avoid data race in IOHandlerProcessSTDIO

JDevlieghere added a comment. In D120762#3352628 , @labath wrote: > These kinds of changes rarely fix a bug -- usually they just change a > (detectable) data race into some nondeterministic runtime behavior. > > That's because, even though e.g. `IsActive

[Lldb-commits] [PATCH] D120762: [lldb] Avoid data race in IOHandlerProcessSTDIO

JDevlieghere updated this revision to Diff 412316. JDevlieghere retitled this revision from "[lldb] Protect control variables in IOHandler with a mutex to avoid a data race" to "[lldb] Avoid data race in IOHandlerProcessSTDIO". JDevlieghere edited the summary of this revision. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

jingham added a comment. Herald added a project: All. Yeah, just a couple little things in the comments. Otherwise this looks good. Comment at: lldb/include/lldb/Core/Address.h:242 +uint32_t addr_byte_size = UINT32_MAX, +bool all_ranges = false) const;

[Lldb-commits] [PATCH] D120594: Improve error messages for command that need a stopped process

jasonmolenda updated this revision to Diff 412288. jasonmolenda added a comment. Herald added a project: All. Integrate Jonas' suggestion, update the disassemble shell test to match the new error messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D113616: [lldb] Hyphenate Objective-C exception breakpoint labels ✍️

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ff290570965: [lldb] Hyphenate Objective-C exception breakpoint labels ✍️ (authored by stephanemoore). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113616/n

[Lldb-commits] [lldb] 0ff2905 - [lldb] Hyphenate Objective-C exception breakpoint labels ✍️

Author: Stephane Moore Date: 2022-03-01T15:02:44-08:00 New Revision: 0ff290570965b920d0fb8495c0e4b43e6e9ccbf0 URL: https://github.com/llvm/llvm-project/commit/0ff290570965b920d0fb8495c0e4b43e6e9ccbf0 DIFF: https://github.com/llvm/llvm-project/commit/0ff290570965b920d0fb8495c0e4b43e6e9ccbf0.diff

[Lldb-commits] [lldb] b901c40 - [PDB] add missing char8_t for 5c9e20d

Author: Zequan Wu Date: 2022-03-01T14:24:21-08:00 New Revision: b901c404a838400983ece83e25583b42737cfaac URL: https://github.com/llvm/llvm-project/commit/b901c404a838400983ece83e25583b42737cfaac DIFF: https://github.com/llvm/llvm-project/commit/b901c404a838400983ece83e25583b42737cfaac.diff LOG

[Lldb-commits] [PATCH] D113616: [lldb] Hyphenate Objective-C exception breakpoint labels ✍️

stephanemoore added a comment. Herald added a project: All. In D113616#3347980 , @clayborg wrote: > Very easy change as VS Code IDE displays these strings and no one references > these by name. I thought so! Thanks for confirming! Repository: rG LLV

[Lldb-commits] [lldb] 5c9e20d - [PDB] Add char8_t type

Author: Zequan Wu Date: 2022-03-01T13:39:51-08:00 New Revision: 5c9e20d7d0a71439a95875ba6067f9c0fc7a4e04 URL: https://github.com/llvm/llvm-project/commit/5c9e20d7d0a71439a95875ba6067f9c0fc7a4e04 DIFF: https://github.com/llvm/llvm-project/commit/5c9e20d7d0a71439a95875ba6067f9c0fc7a4e04.diff LOG

[Lldb-commits] [PATCH] D120690: [PDB] Add char8_t type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c9e20d7d0a7: [PDB] Add char8_t type (authored by zequanwu). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

labath added a comment. In D120718#3352635 , @shafik wrote: > In D120718#3352450 , @JDevlieghere > wrote: > >> I think the better solution here is to get rid of the `using namespace >> llvm;` in the implementati

[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

shafik added a comment. In D120718#3352450 , @JDevlieghere wrote: > I think the better solution here is to get rid of the `using namespace llvm;` > in the implementation file instead. That is a good point. I did a quick look at the file `DataFileCache.

[Lldb-commits] [PATCH] D120766: [lldb] Devirtualize IOHandler::{IsActive, SetIsDone, GetIsDone} (NFC)

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. good good CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120766/new/ https://reviews.llvm.org/D120766 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D120762: [lldb] Protect control variables in IOHandler with a mutex to avoid a data race

labath added a comment. These kinds of changes rarely fix a bug -- usually they just change a (detectable) data race into some nondeterministic runtime behavior. That's because, even though e.g. `IsActive` can compute its result in a race-free manner, there's nothing preventing someone from inv

[Lldb-commits] [PATCH] D120766: [lldb] Devirtualize IOHandler::{IsActive, SetIsDone, GetIsDone} (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, jingham, labath, mib. Herald added a project: All. JDevlieghere requested review of this revision. There are no implementations overriding these methods. https://reviews.llvm.org/D120766 Files: lldb/include/lldb/Core/

[Lldb-commits] [PATCH] D120762: [lldb] Protect control variables in IOHandler with a mutex to avoid a data race

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, jingham, labath. Herald added a subscriber: kristof.beyls. Herald added a project: All. JDevlieghere requested review of this revision. Fixes a data race between the main thread and the process handling thread: WARNING:

[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

JDevlieghere added a comment. Herald added a project: All. I think the better solution here is to get rid of the `using namespace llvm;` in the implementation file instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120718/new/ https://reviews.

[Lldb-commits] [PATCH] D120607: [lldb/test] Re-enable TestEvents.py on Darwin and fix crashes

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120607/new/ https://reviews.llvm.org/D120607 ___

[Lldb-commits] [PATCH] D120755: Fix race condition when launching and attaching.This is a modified version of a previous patch that was reverted: https://reviews.llvm.org/D119797This version only wait

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. I'm assuming this passes all tests locally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120755/new/ https://reviews.llvm.org/D120755 ___

[Lldb-commits] [PATCH] D120755: Fix race condition when launching and attaching.This is a modified version of a previous patch that was reverted: https://reviews.llvm.org/D119797This version only wait

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, jingham, aadsm, wallace. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ...and doesn't play with the async mode when doing normal launch/attach. We d

[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

emrekultursay added a comment. Hi shafik, can you also submit it? I don't have submit permission. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120718/new/ https://reviews.llvm.org/D120718 ___ ll

[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120718/new/ https://reviews.llvm.org/D120718 ___

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

labath added a comment. In D117928#3349234 , @ljmf00 wrote: > Meanwhile, a commit will land Linux stable branches soon to fix this issue: > https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=44cad52cc14ae10062f142ec16ede489bccf4469 >

[Lldb-commits] [PATCH] D120595: [WIP][trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces

labath added inline comments. Comment at: lldb/include/lldb/Utility/TraceIntelPTGDBRemotePackets.h:74 +struct TraceIntelPTGetStateResponse : TraceGetStateResponse { + /// `nullptr` if no tsc conversion rate exists. + llvm::Optional tsc_rate; wallace wrote: > av

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

andrew added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp:128 + +#ifdef NT_ARM_ADDR_MASK + if (m_addr_mask_is_valid) emaste wrote: > This `#define` is coming from our headers? We need to provide this co

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good, I'm sorry this took so long. Jim, do you have anything to add? Comment at: lldb/source/Symbol/Variable.cpp:439-440 +bool Variable::DumpLocations(Stream *s, const

[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

emrekultursay created this revision. emrekultursay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There are two DataExtractors in scope: one from the llvm namespace and one from the lldb_private namespace. Some Microsoft Visual C++ compile

[Lldb-commits] [PATCH] D120593: [Support] Allow the ability to change WithColor's auto detection function

tmatheson added inline comments. Comment at: llvm/include/llvm/Support/WithColor.h:142 + /// Retrieve the default color auto detection function. + static AutoDetectFunctionType defaultAutoDetectFunction(); + This introduces a global constructor call into libSup